[PATCH v13 00/16] drm/xe/hwmon: Update hwmon thermal mailbox

[PATCH v13 00/16] drm/xe/hwmon: Update hwmon thermal mailbox

[Karthik Poosa]

This series adds CRI-specific temperature sensor handling to the Xe
hwmon implementation and fixes couple of hwmon issues.

CRI platforms may report unavailable temperature sensors and support
a variable number of VRAM temperature channels depending on platform
configuration. This series adds the required sensor presence checks and
uses platform-reported thermal configuration data to expose only valid
temperature-related hwmon attributes.

The series also corrects the telemetry group selection used for memory
controller temperature reporting.

v2:
 - Address review comments from Sashiko, Badal and Raag.
 - Enable IEEE 754 temperature decoding for MMIO temperature registers.
  - Split sensor validity check into mailbox vs MMIO handling; add
    is_temp_available() / is_temp_is_visible().
 - Temporarily disable memory controller and PCIe temperatures on CRI.

v3:
  - Detect unavailable temperature sensors: rephrase a debug log.
  - Decode mailbox temperatures as 8-bit sign-magnitude values instead of
    s8.
  - Use VRAM temperature sensor count from thermal config on CRI: address
    review comments from sashiko-bot@kernel.org and Rodrigo.
  - Decode CRI temperature registers as IEEE-754: reject temperatures that
    overflow long on 32-bit systems.

v4:
  - Address review comments and issues report from Rodrigo and
    sashiko-bot@kernel.org.
  - Decode mailbox temperatures as 8-bit sign-magnitude values.
  - Cache sensor availability during registration.
  - Enable memory controller and pcie sensors for CRI.
  - Derive the VRAM channel count from the CRI MSU enable mask.
  - Use CRI-specific package and VRAM temperature registers.
  - Handle the CRI memory controller and pcie sensor offsets as per CRI.

v5:
 - Remove the unintended IGT prefix from the patch titles.

v6:
 - Address issues reported by sashiko-bot@kernel.org.
 - Add VRAM individual channel CRI_VRAM_TEMPERATURE_N register for CRI.

v7:
 - Address review comments from Rodrigo.
    - Use ret instead of count in patch 1.
    - Return true for platforms without temperature sentinels support.
    - Rename has_mbx_temp_sentinel to has_temp_sentinel.
    - Add a info flag for pcie sensor offset.
    - Simplify temperature channels config.

v8:
 - Address review comment from Sashiko.
 - Revert the unconditional validation of temperature readings on
   non-sentinel platforms.
   This avoids creating spurious VRAM temperature channels when the
   corresponding sensors are unavailable.
a
v9:
 - Address review comment from Rodrigo.
 - Use helper for pcie sensor offset instead of info field.

v10:
 - Address review comments from sashiko.

v11:
 - Add https://patchwork.freedesktop.org/series/175943/ part of this
   series as patch 16. (Rodrigo)
 - Resubmit to get CI results as v10 didn't have it.

v12:
 - Address review comments from sashiko.

v13:
 - Address review comments from sashiko on v12.

Karthik Poosa (16):
  drm/xe/hwmon: Fix pcode power limit handling
  drm/xe/hwmon: Decode mailbox temperature as sign-magnitude
  drm/xe/hwmon: Fix thermal sensor data handling
  drm/xe/hwmon: Add helpers to validate thermal sensor readings
  drm/xe/hwmon: Handle unavailable memory controller sensors
  drm/xe/hwmon: Detect unavailable PCIe thermal sensors
  drm/xe/hwmon: Consolidate temperature sensor availability checks
  drm/xe/hwmon: Cache temperature availability to reduce probe time
  drm/xe/hwmon: use CRI-specific package and VRAM temperature registers
  drm/xe/hwmon: Add platform-aware VRAM thermal channel support
  drm/xe/hwmon: Decode CRI temperature registers as IEEE-754
  drm/xe/hwmon: Update memory controller temperature offset for CRI
  drm/xe/hwmon: add PCIe temperature support for CRI
  drm/xe/hwmon: Simplify temperature channels config
  drm/xe: Validate thermal sensor count before reads
  drm/xe/hwmon: Propagate all hardware read errors

 drivers/gpu/drm/xe/regs/xe_pcode_regs.h |   4 +
 drivers/gpu/drm/xe/xe_device_types.h    |   4 +
 drivers/gpu/drm/xe/xe_hwmon.c           | 595 ++++++++++++++++++------
 drivers/gpu/drm/xe/xe_pci.c             |   4 +
 drivers/gpu/drm/xe/xe_pci_types.h       |   2 +
 drivers/gpu/drm/xe/xe_pcode_api.h       |   2 -
 6 files changed, 463 insertions(+), 148 deletions(-)

-- 
2.25.1

[PATCH v13 01/16] drm/xe/hwmon: Fix pcode power limit handling

[Karthik Poosa]

Return early on pcode read failure in xe_hwmon_pcode_rmw_power_limit()
and propagate errors to callers.

Replace boot_power_limit_read with per-channel
read_power_limit_from_pcode[], set on the first successful pcode write,
so reads and writes stay consistent even if the default limit write at
boot fails.

Also return PWR_LIM_EN for power label so card label visibility works.

Fixes: 8aa7306631f0 ("drm/xe/hwmon: Fix xe_hwmon_power_max_write")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---

v2: Check return in xe_hwmon_get_preregistration_info() also. (Sashiko)
v3: Track pcode limit updates per channel. (Sashiko)

 drivers/gpu/drm/xe/xe_hwmon.c | 77 +++++++++++++++++++++--------------
 1 file changed, 47 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 5edeac961ec3..c7f936892512 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -165,8 +165,8 @@ struct xe_hwmon {
 	struct xe_hwmon_energy_info ei[CHANNEL_MAX];
 	/** @fi: Fan info for fanN_input */
 	struct xe_hwmon_fan_info fi[FAN_MAX];
-	/** @boot_power_limit_read: is boot power limits read */
-	bool boot_power_limit_read;
+	/** @read_power_limit_from_pcode: pcode accepted power limits write for the channel */
+	bool read_power_limit_from_pcode[CHANNEL_MAX];
 	/** @pl1_on_boot: power limit PL1 on boot */
 	u32 pl1_on_boot[CHANNEL_MAX];
 	/** @pl2_on_boot: power limit PL2 on boot */
@@ -175,9 +175,9 @@ struct xe_hwmon {
 	struct xe_hwmon_thermal_info temp;
 };
 
-static inline int prepare_power_limit_param2(const struct xe_hwmon *hwmon)
+static inline int prepare_power_limit_param2(const struct xe_hwmon *hwmon, int channel)
 {
-	if (hwmon->boot_power_limit_read) {
+	if (hwmon->read_power_limit_from_pcode[channel]) {
 		if (hwmon->xe->info.platform >= XE_CRESCENTISLAND)
 			return READ_PL_ACCEPTED;
 		else
@@ -198,7 +198,8 @@ static int xe_hwmon_pcode_read_power_limit(const struct xe_hwmon *hwmon, u32 att
 						  (channel == CHANNEL_CARD) ?
 						  READ_PSYSGPU_POWER_LIMIT :
 						  READ_PACKAGE_POWER_LIMIT,
-						  prepare_power_limit_param2(hwmon)), &val0, &val1);
+						  prepare_power_limit_param2(hwmon, channel)),
+			    &val0, &val1);
 
 	if (ret) {
 		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
@@ -213,14 +214,14 @@ static int xe_hwmon_pcode_read_power_limit(const struct xe_hwmon *hwmon, u32 att
 	else if (attr == PL2_HWMON_ATTR)
 		*uval = (val1 & PWR_LIM_EN) ? val1 : 0;
 	else if (attr == hwmon_power_label)
-		*uval = (val0 & PWR_LIM_EN) ? 1 : (val1 & PWR_LIM_EN) ? 1 : 0;
+		*uval = (val0 | val1) & PWR_LIM_EN;
 	else
 		*uval = 0;
 
 	return ret;
 }
 
-static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr, u8 channel,
+static int xe_hwmon_pcode_rmw_power_limit(struct xe_hwmon *hwmon, u32 attr, u8 channel,
 					  u32 clr, u32 set)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
@@ -231,10 +232,13 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
 						  (channel == CHANNEL_CARD) ?
 						  READ_PSYSGPU_POWER_LIMIT :
 						  READ_PACKAGE_POWER_LIMIT,
-						  prepare_power_limit_param2(hwmon)), &val0, &val1);
-	if (ret)
-		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
+						  prepare_power_limit_param2(hwmon, channel)),
+			    &val0, &val1);
+	if (ret) {
+		drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
 			channel, val0, val1, ret);
+		return ret;
+	}
 
 	if (attr == PL1_HWMON_ATTR)
 		val0 = (val0 & ~clr) | set;
@@ -248,10 +252,17 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
 							     WRITE_PSYSGPU_POWER_LIMIT :
 							     WRITE_PACKAGE_POWER_LIMIT, 0),
 							     val0, val1, PCODE_DEFAULT_TIMEOUT_MS);
-	if (ret)
+	if (ret) {
 		drm_dbg(&hwmon->xe->drm, "write failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
 			channel, val0, val1, ret);
-	return ret;
+		return ret;
+	}
+
+	/* Read from pcode once it holds a driver-written limit */
+	if (!hwmon->read_power_limit_from_pcode[channel])
+		hwmon->read_power_limit_from_pcode[channel] = true;
+
+	return 0;
 }
 
 static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg,
@@ -394,7 +405,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
 		if (hwmon->xe->info.has_mbx_power_limits) {
 			drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
 				PWR_ATTR_TO_STR(attr), channel);
-			xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
+			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
+			if (ret)
+				goto unlock;
 			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
 		} else {
 			reg_val = xe_mmio_rmw32(mmio, rapl_limit, PWR_LIM_EN, 0);
@@ -679,15 +692,19 @@ xe_hwmon_power_max_interval_store(struct device *dev, struct device_attribute *a
 
 	mutex_lock(&hwmon->hwmon_lock);
 
-	if (hwmon->xe->info.has_mbx_power_limits)
-		xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
-	else
+	ret = count;
+	if (hwmon->xe->info.has_mbx_power_limits) {
+		ret = xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
+		if (!ret)
+			ret = count;
+	} else {
 		r = xe_mmio_rmw32(mmio, xe_hwmon_get_reg(hwmon, REG_PKG_RAPL_LIMIT, channel),
 				  PWR_LIM_TIME, rxy);
+	}
 
 	mutex_unlock(&hwmon->hwmon_lock);
 
-	return count;
+	return ret;
 }
 
 /* PSYS PL1 */
@@ -1511,22 +1528,22 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 		} else {
 			drm_info(&hwmon->xe->drm, "Using mailbox commands for power limits\n");
 			/* Write default limits to read from pcode from now on. */
-			xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
-						       CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
-						       hwmon->pl1_on_boot[CHANNEL_CARD]);
-			xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
-						       CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
-						       hwmon->pl1_on_boot[CHANNEL_PKG]);
-			xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
-						       CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
-						       hwmon->pl2_on_boot[CHANNEL_CARD]);
-			xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
-						       CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
-						       hwmon->pl2_on_boot[CHANNEL_PKG]);
+			if (xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
+							   CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
+							   hwmon->pl1_on_boot[CHANNEL_CARD]) |
+			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
+							   CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
+							   hwmon->pl1_on_boot[CHANNEL_PKG]) |
+			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
+							   CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
+							   hwmon->pl2_on_boot[CHANNEL_CARD]) |
+			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
+							   CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
+							   hwmon->pl2_on_boot[CHANNEL_PKG]))
+				drm_warn(&hwmon->xe->drm, "Failed to set default power limits\n");
 			hwmon->scl_shift_power = PWR_UNIT;
 			hwmon->scl_shift_energy = ENERGY_UNIT;
 			hwmon->scl_shift_time = TIME_UNIT;
-			hwmon->boot_power_limit_read = true;
 		}
 	} else {
 		drm_info(&hwmon->xe->drm, "Using register for power limits\n");
-- 
2.25.1

[PATCH v13 02/16] drm/xe/hwmon: Decode mailbox temperature as sign-magnitude

[Karthik Poosa]

The mailbox temperature is an 8-bit sign-magnitude value (bit 7 sign,
bits 6:0 magnitude, range -127..127), not two's-complement. Casting the
raw byte to s8 decodes negative readings incorrectly.

Add mbx_temp_decode(), store the raw byte as u8, and use it in
get_mc_temp() and get_pcie_temp() so temperatures are decoded correctly.

Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index c7f936892512..382bf9625a8b 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -104,6 +104,10 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* Mailbox temperature is sign-magnitude: bit 7 sign, bits 6:0 magnitude. */
+#define TEMP_MBX_SIGN		BIT(7)
+#define TEMP_MBX_MAG		GENMASK(6, 0)
+
 /* Maximum characters in hwmon label name */
 #define MAX_LABEL_SIZE		16
 
@@ -139,8 +143,8 @@ struct xe_hwmon_thermal_info {
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
-	/** @value: signed value from each sensor */
-	s8 value[U8_MAX];
+	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
+	u8 value[U8_MAX];
 	/** @vram_label: vram label names */
 	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
 };
@@ -825,6 +829,14 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 	return ret;
 }
 
+/* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
+static int mbx_temp_decode(u8 value)
+{
+	int temp = value & TEMP_MBX_MAG;
+
+	return (value & TEMP_MBX_SIGN) ? -temp : temp;
+}
+
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
@@ -841,7 +853,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 	}
 
 	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
-		average += hwmon->temp.value[i];
+		average += mbx_temp_decode(hwmon->temp.value[i]);
 
 	average /= (hwmon->temp.count - TEMP_INDEX_MCTRL - 1);
 	*val = average * MILLIDEGREE_PER_DEGREE;
@@ -864,7 +876,7 @@ static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
 		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
 
 	data = REG_FIELD_GET(TEMP_MASK, data);
-	*val = (s8)data * MILLIDEGREE_PER_DEGREE;
+	*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
 
 	return 0;
 }
-- 
2.25.1

[PATCH v13 03/16] drm/xe/hwmon: Fix thermal sensor data handling

[Karthik Poosa]

Read all required thermal groups in get_mc_temp() and store them in a
dword-aligned buffer, avoiding unaligned pcode accesses and ensuring
correct memory controller temperature reporting.

Store the pcode thermal data and thermal limit words as little-endian,
so their per-byte views match the hardware layout on big-endian hosts.

Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Fixes: c332fba805d6 ("drm/xe/hwmon: Expose temperature limits")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---
v2: Protect the shared thermal data buffer while fetching and averaging
memory controller temperatures.

 drivers/gpu/drm/xe/xe_hwmon.c | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 382bf9625a8b..1b4efbf4ac99 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -138,13 +138,17 @@ struct xe_hwmon_thermal_info {
 	union {
 		/** @limit: temperatures limits */
 		u8 limit[TEMP_LIMIT_MAX];
-		/** @data: temperature limits in dwords */
-		u32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
+		/** @data: temperature limits as little-endian dwords */
+		__le32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
-	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
-	u8 value[U8_MAX];
+	union {
+		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
+		u8 value[U8_MAX + 1];
+		/** @dword: sensor values as little-endian dwords, u32-aligned for pcode reads */
+		__le32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
+	};
 	/** @vram_label: vram label names */
 	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
 };
@@ -807,16 +811,17 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
 static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
-	u32 config = 0;
+	u32 config = 0, data0 = 0, data1 = 0;
 	int ret;
 
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_LIMITS, 0),
-			    &hwmon->temp.data[0], &hwmon->temp.data[1]);
+			    &data0, &data1);
 	if (ret)
 		return ret;
 
-	drm_dbg(&hwmon->xe->drm, "thermal info read val 0x%x val1 0x%x\n",
-		hwmon->temp.data[0], hwmon->temp.data[1]);
+	drm_dbg(&hwmon->xe->drm, "thermal info read val 0x%x val1 0x%x\n", data0, data1);
+	hwmon->temp.data[0] = cpu_to_le32(data0);
+	hwmon->temp.data[1] = cpu_to_le32(data1);
 
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_CONFIG, 0),
 			    &config, NULL);
@@ -840,16 +845,20 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
-	u32 *dword = (u32 *)hwmon->temp.value;
 	s32 average = 0;
 	int ret, i;
 
-	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
+	guard(mutex)(&hwmon->hwmon_lock);
+
+	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
+		u32 data = 0;
+
 		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
-				    (dword + i), NULL);
+				    &data, NULL);
 		if (ret)
 			return ret;
-		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i, dword[i]);
+		drm_dbg(&hwmon->xe->drm, "thermal data for group %d val 0x%x\n", i, data);
+		hwmon->temp.dword[i] = cpu_to_le32(data);
 	}
 
 	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
-- 
2.25.1

[PATCH v13 04/16] drm/xe/hwmon: Add helpers to validate thermal sensor readings

[Karthik Poosa]

Add mmio_temp_valid() and mbx_temp_valid() to check whether a temperature
sensor reading is valid. An MMIO value of 0xFFFFFFFF or a mailbox value of
0xFF indicates the sensor is unavailable.

Gate these checks behind has_temp_sentinel, enabled on CRI currently.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---
v2:
 - Address review comment from sashiko.
   Reject all-ones MMIO readings, which may indicate the device is off the
   bus. Also reject the 0xff mailbox sentinel on every platform to avoid
   decoding unavailable sensor readings as extreme temperatures.

 drivers/gpu/drm/xe/xe_device_types.h |  2 ++
 drivers/gpu/drm/xe/xe_hwmon.c        | 27 +++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_pci.c          |  2 ++
 drivers/gpu/drm/xe/xe_pci_types.h    |  1 +
 4 files changed, 32 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 4e0e1bc040c1..beb0ceaabb3f 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -227,6 +227,8 @@ struct xe_device {
 		u8 has_sriov:1;
 		/** @info.has_sysctrl: Supports System Controller */
 		u8 has_sysctrl:1;
+		/** @info.has_temp_sentinel: Device has temperature-unavailable sentinels */
+		u8 has_temp_sentinel:1;
 		/** @info.has_usm: Device has unified shared memory support */
 		u8 has_usm:1;
 		/** @info.has_64bit_timestamp: Device supports 64-bit timestamps */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 1b4efbf4ac99..883a0ae1d90e 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -104,6 +104,9 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* Mailbox sentinel reported for an unavailable temperature sensor */
+#define TEMP_MBX_INVALID	0xFF
+
 /* Mailbox temperature is sign-magnitude: bit 7 sign, bits 6:0 magnitude. */
 #define TEMP_MBX_SIGN		BIT(7)
 #define TEMP_MBX_MAG		GENMASK(6, 0)
@@ -834,6 +837,30 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 	return ret;
 }
 
+static inline bool mmio_temp_valid(const struct xe_hwmon *hwmon, u32 value)
+{
+	/*
+	 * On platforms lacking temperature sentinel support, a value of 0 is treated
+	 * as invalid. While 0°C is theoretically possible, it is highly unlikely for
+	 * a discrete GPU in normal environments, making it a reasonable fallback
+	 * indicator for invalid or uninitialized temperature readings.
+	 * All-ones is returned when the device is off the bus, so reject it too.
+	 */
+	if (value == U32_MAX)
+		return false;
+
+	return hwmon->xe->info.has_temp_sentinel || value != 0;
+}
+
+/* Mailbox temperature is sign-magnitude (bit 7 sign, bits 6:0 magnitude). */
+static inline bool mbx_temp_valid(const struct xe_hwmon *hwmon, u8 value)
+{
+	if (value == TEMP_MBX_INVALID)
+		return false;
+
+	return hwmon->xe->info.has_temp_sentinel || value != 0;
+}
+
 /* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
 static int mbx_temp_decode(u8 value)
 {
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index e44b74b9aa27..111d0aa45b10 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -486,6 +486,7 @@ static const struct xe_device_desc cri_desc = {
 	.has_soc_remapper_telem = true,
 	.has_sriov = true,
 	.has_sysctrl = true,
+	.has_temp_sentinel = true,
 	.max_gt_per_tile = 2,
 	MULTI_LRC_MASK,
 	.require_force_probe = true,
@@ -817,6 +818,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.has_sriov = xe_configfs_primary_gt_allowed(to_pci_dev(xe->drm.dev)) &&
 		desc->has_sriov;
 	xe->info.has_sysctrl = desc->has_sysctrl;
+	xe->info.has_temp_sentinel = desc->has_temp_sentinel;
 	xe->info.skip_guc_pc = desc->skip_guc_pc;
 	xe->info.skip_pcode = desc->skip_pcode;
 	xe->info.needs_scratch = desc->needs_scratch;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index 448bbe5ba1d7..15eedac8467a 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -61,6 +61,7 @@ struct xe_device_desc {
 	u8 has_soc_remapper_telem:1;
 	u8 has_sriov:1;
 	u8 has_sysctrl:1;
+	u8 has_temp_sentinel:1;
 	u8 needs_scratch:1;
 	u8 skip_guc_pc:1;
 	u8 skip_pcode:1;
-- 
2.25.1

[PATCH v13 05/16] drm/xe/hwmon: Handle unavailable memory controller sensors

[Karthik Poosa]

Skip memory controller sensors that report invalid readings when
computing the average temperature in get_mc_temp(). Return -ENXIO when
no valid sensor data is available, and allow the helper to be used as
an availability probe by making the output parameter optional.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Fixes: 3a0cb885e111 ("drm/xe/hwmon: Expose memory controller temperature")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 883a0ae1d90e..c91e5138d0ac 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -872,8 +872,8 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
+	int ret, i, count = 0;
 	s32 average = 0;
-	int ret, i;
 
 	guard(mutex)(&hwmon->hwmon_lock);
 
@@ -888,11 +888,23 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 		hwmon->temp.dword[i] = cpu_to_le32(data);
 	}
 
-	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++)
+	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
+		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
+			continue;
 		average += mbx_temp_decode(hwmon->temp.value[i]);
+		count++;
+	}
+
+	if (!count) {
+		drm_dbg(&hwmon->xe->drm, "Memory controller temperature unavailable!\n");
+		return -ENXIO;
+	}
+
+	average /= count;
+
+	if (val)
+		*val = average * MILLIDEGREE_PER_DEGREE;
 
-	average /= (hwmon->temp.count - TEMP_INDEX_MCTRL - 1);
-	*val = average * MILLIDEGREE_PER_DEGREE;
 	return 0;
 }
 
-- 
2.25.1

[PATCH v13 06/16] drm/xe/hwmon: Detect unavailable PCIe thermal sensors

[Karthik Poosa]

Return -ENXIO from get_pcie_temp() when the mailbox reports an invalid
reading, so the PCIe sensor can be treated as unavailable. Guard the val
store so the function can be used purely as an availability probe. No
sysfs visibility changes.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index c91e5138d0ac..b159980c96bd 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -924,7 +924,13 @@ static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
 		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
 
 	data = REG_FIELD_GET(TEMP_MASK, data);
-	*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
+	if (!mbx_temp_valid(hwmon, data)) {
+		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
+		return -ENXIO;
+	}
+
+	if (val)
+		*val = mbx_temp_decode(data) * MILLIDEGREE_PER_DEGREE;
 
 	return 0;
 }
-- 
2.25.1

[PATCH v13 07/16] drm/xe/hwmon: Consolidate temperature sensor availability checks

[Karthik Poosa]

Replace is_vram_ch_available() with a generalized is_temp_available()
that validates PKG, VRAM, per-channel VRAM, memory controller and PCIe
sensors using the new validity helpers. Rename the existing callers to
the new helper.

Use is_temp_available() from xe_hwmon_temp_is_visible() so attributes for
sensors that are not present are not exposed during hwmon registration.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 64 ++++++++++++++++++++++-------------
 1 file changed, 40 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index b159980c96bd..0ad5004a274e 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -1029,19 +1029,39 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
 	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
 }
 
-static inline bool is_vram_ch_available(struct xe_hwmon *hwmon, int channel)
+static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
-	int vram_id = channel - CHANNEL_VRAM_N;
-	struct xe_reg vram_reg;
+	struct xe_reg reg;
+	u32 reg_val;
 
-	vram_reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
-	if (!xe_reg_is_valid(vram_reg) || !xe_mmio_read32(mmio, vram_reg))
-		return false;
+	switch (channel) {
+	case CHANNEL_PKG:
+	case CHANNEL_VRAM:
+	case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
+		reg = xe_hwmon_get_reg(hwmon, REG_TEMP, channel);
+		if (!xe_reg_is_valid(reg))
+			return false;
+
+		reg_val = xe_mmio_read32(mmio, reg);
+		if (!mmio_temp_valid(hwmon, reg_val)) {
+			drm_dbg(&hwmon->xe->drm,
+				"channel %d temperature unavailable, val 0x%x\n", channel, reg_val);
+			return false;
+		}
+
+		if (channel >= CHANNEL_VRAM_N)
+			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
+				"vram_ch_%d", channel - CHANNEL_VRAM_N);
 
-	/* Create label only for available vram channel */
-	sprintf(hwmon->temp.vram_label[vram_id], "vram_ch_%d", vram_id);
-	return true;
+		return true;
+	case CHANNEL_MCTRL:
+		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
+	case CHANNEL_PCIE:
+		return hwmon->temp.count && !get_pcie_temp(hwmon, NULL);
+	default:
+		return false;
+	}
 }
 
 static umode_t
@@ -1051,14 +1071,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_emergency:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN] ? 0444 : 0;
-		case CHANNEL_VRAM:
-			return hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN] ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_vram_ch_available(hwmon, channel) &&
+			return (is_temp_available(hwmon, channel) &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1066,14 +1085,13 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_crit:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT] ? 0444 : 0;
-		case CHANNEL_VRAM:
-			return hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT] ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT]) ? 0444 : 0;
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_vram_ch_available(hwmon, channel) &&
+			return (is_temp_available(hwmon, channel) &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1081,7 +1099,8 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_max:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return hwmon->temp.limit[TEMP_LIMIT_PKG_MAX] ? 0444 : 0;
+			return (is_temp_available(hwmon, channel) &&
+				hwmon->temp.limit[TEMP_LIMIT_PKG_MAX]) ? 0444 : 0;
 		default:
 			return 0;
 		}
@@ -1090,13 +1109,10 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		switch (channel) {
 		case CHANNEL_PKG:
 		case CHANNEL_VRAM:
-			return xe_reg_is_valid(xe_hwmon_get_reg(hwmon, REG_TEMP,
-								channel)) ? 0444 : 0;
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return hwmon->temp.count ? 0444 : 0;
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return is_vram_ch_available(hwmon, channel) ? 0444 : 0;
+			return is_temp_available(hwmon, channel) ? 0444 : 0;
 		default:
 			return 0;
 		}
-- 
2.25.1

[PATCH v13 08/16] drm/xe/hwmon: Cache temperature availability to reduce probe time

[Karthik Poosa]

Avoid probing temperature sensor availability from the hwmon is_visible()
callback. For MCTRL and PCIe channels, that path can trigger repeated
blocking mailbox reads while sysfs attributes are being created, increasing
probe time and making attribute creation sensitive to transient failures.

Probe temperature availability once during preregistration and cache the
result for subsequent visibility checks.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 39 +++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 0ad5004a274e..7c80dca516a1 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -146,6 +146,8 @@ struct xe_hwmon_thermal_info {
 	};
 	/** @count: no of temperature sensors available for the platform */
 	u8 count;
+	/** @available: temperature sensor availability cached at registration */
+	bool available[CHANNEL_MAX];
 	union {
 		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
 		u8 value[U8_MAX + 1];
@@ -1029,7 +1031,7 @@ static void xe_hwmon_get_voltage(struct xe_hwmon *hwmon, int channel, long *valu
 	*value = DIV_ROUND_CLOSEST(REG_FIELD_GET(VOLTAGE_MASK, reg_val) * 2500, SF_VOLTAGE);
 }
 
-static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
+static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
 	struct xe_reg reg;
@@ -1050,10 +1052,6 @@ static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 			return false;
 		}
 
-		if (channel >= CHANNEL_VRAM_N)
-			sprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N],
-				"vram_ch_%d", channel - CHANNEL_VRAM_N);
-
 		return true;
 	case CHANNEL_MCTRL:
 		return hwmon->temp.count && !get_mc_temp(hwmon, NULL);
@@ -1064,6 +1062,22 @@ static bool is_temp_available(struct xe_hwmon *hwmon, int channel)
 	}
 }
 
+static void xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
+{
+	int channel;
+
+	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
+		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
+
+	for (channel = 0; channel < CHANNEL_MAX; channel++) {
+		hwmon->temp.available[channel] = xe_hwmon_temp_probe(hwmon, channel);
+		if (hwmon->temp.available[channel] &&
+		    in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			snprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N], MAX_LABEL_SIZE,
+				 "vram_ch_%d", channel - CHANNEL_VRAM_N);
+	}
+}
+
 static umode_t
 xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 {
@@ -1073,11 +1087,11 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_PKG:
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_SHUTDOWN]) ? 0444 : 0;
 		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_SHUTDOWN]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1087,11 +1101,11 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_PKG:
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_CRIT]) ? 0444 : 0;
 		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_MEM_CRIT]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1099,7 +1113,7 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	case hwmon_temp_max:
 		switch (channel) {
 		case CHANNEL_PKG:
-			return (is_temp_available(hwmon, channel) &&
+			return (hwmon->temp.available[channel] &&
 				hwmon->temp.limit[TEMP_LIMIT_PKG_MAX]) ? 0444 : 0;
 		default:
 			return 0;
@@ -1112,7 +1126,7 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		case CHANNEL_MCTRL:
 		case CHANNEL_PCIE:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
-			return is_temp_available(hwmon, channel) ? 0444 : 0;
+			return hwmon->temp.available[channel] ? 0444 : 0;
 		default:
 			return 0;
 		}
@@ -1654,8 +1668,7 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 		if (xe_hwmon_is_visible(hwmon, hwmon_fan, hwmon_fan_input, channel))
 			xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);
 
-	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
-		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
+	xe_hwmon_init_temp_info(hwmon);
 }
 
 int xe_hwmon_register(struct xe_device *xe)
-- 
2.25.1

[PATCH v13 09/16] drm/xe/hwmon: use CRI-specific package and VRAM temperature registers

[Karthik Poosa]

Crescent Island uses different MMIO offsets for package and VRAM
temperature than Battlemage. Add CRI-specific register definitions
and select them in xe_hwmon_get_reg() for REG_TEMP handling.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pcode_regs.h | 3 +++
 drivers/gpu/drm/xe/xe_hwmon.c           | 9 ++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
index c63b409d7a82..a969661f0c95 100644
--- a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
@@ -28,6 +28,9 @@
 #define BMG_PACKAGE_TEMPERATURE			XE_REG(0x138434)
 
 #define CRI_PACKAGE_ENERGY_STATUS		XE_REG(0x138120)
+#define CRI_PACKAGE_TEMPERATURE			XE_REG(0x138344)
+#define CRI_VRAM_TEMPERATURE			XE_REG(0x138348)
 #define CRI_PLATFORM_ENERGY_STATUS		XE_REG(0x138458)
+#define CRI_VRAM_TEMPERATURE_N(n)		XE_REG(0x138a00 + ((n) * (sizeof(u32))))
 
 #endif /* _XE_PCODE_REGS_H_ */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 7c80dca516a1..99fc87ed0e8b 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -285,7 +285,14 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
 
 	switch (hwmon_reg) {
 	case REG_TEMP:
-		if (xe->info.platform == XE_BATTLEMAGE || xe->info.platform == XE_CRESCENTISLAND) {
+		if (xe->info.platform == XE_CRESCENTISLAND) {
+			if (channel == CHANNEL_PKG)
+				return CRI_PACKAGE_TEMPERATURE;
+			else if (channel == CHANNEL_VRAM)
+				return CRI_VRAM_TEMPERATURE;
+			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+				return CRI_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
+		} else if (xe->info.platform == XE_BATTLEMAGE) {
 			if (channel == CHANNEL_PKG)
 				return BMG_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
-- 
2.25.1

[PATCH v13 10/16] drm/xe/hwmon: Add platform-aware VRAM thermal channel support

[Karthik Poosa]

On CRI, derive the number of available VRAM temperature channels from the
CRI_MSU_VRAM_ENABLE register, where each enabled MSU contributes
VRAM_CHANNELS_PER_MSU channels.
 
Increase the maximum supported VRAM channel count to 80 and use the
derived count to control VRAM sensor enumeration, channel access, and
VRAM label allocation. Add a has_fixed_vram_channels platform flag to
preserve the existing fixed-channel behavior on non-CRI platforms.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pcode_regs.h |   1 +
 drivers/gpu/drm/xe/xe_device_types.h    |   2 +
 drivers/gpu/drm/xe/xe_hwmon.c           | 162 +++++++++++++++++++++---
 drivers/gpu/drm/xe/xe_pci.c             |   2 +
 drivers/gpu/drm/xe/xe_pci_types.h       |   1 +
 5 files changed, 153 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
index a969661f0c95..d9e4847dd68e 100644
--- a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
@@ -28,6 +28,7 @@
 #define BMG_PACKAGE_TEMPERATURE			XE_REG(0x138434)
 
 #define CRI_PACKAGE_ENERGY_STATUS		XE_REG(0x138120)
+#define CRI_MSU_VRAM_ENABLE			XE_REG(0x138340)
 #define CRI_PACKAGE_TEMPERATURE			XE_REG(0x138344)
 #define CRI_VRAM_TEMPERATURE			XE_REG(0x138348)
 #define CRI_PLATFORM_ENERGY_STATUS		XE_REG(0x138458)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index beb0ceaabb3f..161ba2b27f47 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -185,6 +185,8 @@ struct xe_device {
 		u8 has_drm_ras:1;
 		/** @info.has_fan_control: Device supports fan control */
 		u8 has_fan_control:1;
+		/** @info.has_fixed_vram_channels: Device has fixed VRAM temperature channels */
+		u8 has_fixed_vram_channels:1;
 		/** @info.has_flat_ccs: Whether flat CCS metadata is used */
 		u8 has_flat_ccs:1;
 		/** @info.has_gsc_nvm: Device has gsc non-volatile memory */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 99fc87ed0e8b..afcc80e34bfd 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -39,7 +39,11 @@ enum xe_hwmon_reg_operation {
 	REG_READ64,
 };
 
-#define MAX_VRAM_CHANNELS      (16)
+#define MAX_VRAM_CHANNELS	80
+#define FIXED_VRAM_CHANNELS	16
+
+/* Each MSU enable bit maps to one VRAM subsystem of 4 channels. */
+#define VRAM_CHANNELS_PER_MSU	4
 
 enum xe_hwmon_channel {
 	CHANNEL_CARD,
@@ -48,6 +52,7 @@ enum xe_hwmon_channel {
 	CHANNEL_MCTRL,
 	CHANNEL_PCIE,
 	CHANNEL_VRAM_N,
+	/* Compile-time upper bound; actual channel count is hwmon->temp.vram_count */
 	CHANNEL_VRAM_N_MAX = CHANNEL_VRAM_N + MAX_VRAM_CHANNELS - 1,
 	CHANNEL_MAX,
 };
@@ -144,18 +149,22 @@ struct xe_hwmon_thermal_info {
 		/** @data: temperature limits as little-endian dwords */
 		__le32 data[DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32))];
 	};
-	/** @count: no of temperature sensors available for the platform */
+	/** @count: temperature sensors count from READ_THERMAL_CONFIG */
 	u8 count;
+	/** @vram_count: exclusive upper bound for VRAM temperature channel indices */
+	u8 vram_count;
 	/** @available: temperature sensor availability cached at registration */
 	bool available[CHANNEL_MAX];
+	/** @msu_mask: VRAM subsystem enable mask read from MMIO */
+	u32 msu_mask;
 	union {
 		/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
 		u8 value[U8_MAX + 1];
 		/** @dword: sensor values as little-endian dwords, u32-aligned for pcode reads */
 		__le32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
 	};
-	/** @vram_label: vram label names */
-	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
+	/** @vram_label: vram label names, dynamically allocated based on vram_count */
+	char (*vram_label)[MAX_LABEL_SIZE];
 };
 
 /**
@@ -278,6 +287,14 @@ static int xe_hwmon_pcode_rmw_power_limit(struct xe_hwmon *hwmon, u32 attr, u8 c
 	return 0;
 }
 
+static bool xe_hwmon_vram_channel_enabled(const struct xe_hwmon *hwmon, int index)
+{
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
+		return hwmon->temp.msu_mask & BIT(index / VRAM_CHANNELS_PER_MSU);
+
+	return true;
+}
+
 static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg,
 				      int channel)
 {
@@ -290,14 +307,16 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
 				return CRI_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
 				return CRI_VRAM_TEMPERATURE;
-			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count) &&
+				 xe_hwmon_vram_channel_enabled(hwmon, channel - CHANNEL_VRAM_N))
 				return CRI_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
 		} else if (xe->info.platform == XE_BATTLEMAGE) {
 			if (channel == CHANNEL_PKG)
 				return BMG_PACKAGE_TEMPERATURE;
 			else if (channel == CHANNEL_VRAM)
 				return BMG_VRAM_TEMPERATURE;
-			else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+			else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count) &&
+				 xe_hwmon_vram_channel_enabled(hwmon, channel - CHANNEL_VRAM_N))
 				return BMG_VRAM_TEMPERATURE_N(channel - CHANNEL_VRAM_N);
 		} else if (xe->info.platform == XE_DG2) {
 			if (channel == CHANNEL_PKG)
@@ -809,6 +828,70 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL),
 	HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CRIT |
 			   HWMON_P_CAP,
@@ -823,9 +906,31 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
 static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
+	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
 	u32 config = 0, data0 = 0, data1 = 0;
 	int ret;
 
+	/*
+	 * Only CRI reports dynamic VRAM channel state. Fixed-channel platforms
+	 * set the count up front so those sensors stay visible even if the thermal
+	 * mailbox reads below fail.
+	 */
+	if (hwmon->xe->info.has_fixed_vram_channels)
+		hwmon->temp.vram_count = FIXED_VRAM_CHANNELS;
+
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {
+		hwmon->temp.msu_mask = xe_mmio_read32(mmio, CRI_MSU_VRAM_ENABLE);
+		hwmon->temp.vram_count = fls(hwmon->temp.msu_mask) * VRAM_CHANNELS_PER_MSU;
+		drm_dbg(&hwmon->xe->drm, "MSU VRAM enable mask 0x%x, VRAM channel bound %d\n",
+			hwmon->temp.msu_mask, hwmon->temp.vram_count);
+		if (hwmon->temp.vram_count > MAX_VRAM_CHANNELS) {
+			drm_warn(&hwmon->xe->drm,
+				 "VRAM channel bound %d exceeds max %d, clamping\n",
+				 hwmon->temp.vram_count, MAX_VRAM_CHANNELS);
+			hwmon->temp.vram_count = MAX_VRAM_CHANNELS;
+		}
+	}
+
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_LIMITS, 0),
 			    &data0, &data1);
 	if (ret)
@@ -1052,6 +1157,14 @@ static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 		if (!xe_reg_is_valid(reg))
 			return false;
 
+		/*
+		 * On CRI, VRAM channel presence comes from the MSU enable mask
+		 * (applied in xe_hwmon_get_reg()); the temperature register's
+		 * 0xffffffff sentinel is not reliable for VRAM channels.
+		 */
+		if (hwmon->xe->info.platform == XE_CRESCENTISLAND && channel >= CHANNEL_VRAM_N)
+			return true;
+
 		reg_val = xe_mmio_read32(mmio, reg);
 		if (!mmio_temp_valid(hwmon, reg_val)) {
 			drm_dbg(&hwmon->xe->drm,
@@ -1069,20 +1182,31 @@ static bool xe_hwmon_temp_probe(struct xe_hwmon *hwmon, int channel)
 	}
 }
 
-static void xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
+static int xe_hwmon_init_temp_info(struct xe_hwmon *hwmon)
 {
+	struct device *dev = hwmon->xe->drm.dev;
 	int channel;
 
 	if (hwmon->xe->info.has_mbx_thermal_info && xe_hwmon_pcode_read_thermal_info(hwmon))
 		drm_warn(&hwmon->xe->drm, "Thermal mailbox not supported by card firmware\n");
 
+	/* vram_count is known only after reading thermal info above. */
+	if (hwmon->temp.vram_count) {
+		hwmon->temp.vram_label = devm_kcalloc(dev, hwmon->temp.vram_count,
+						      MAX_LABEL_SIZE, GFP_KERNEL);
+		if (!hwmon->temp.vram_label)
+			return -ENOMEM;
+	}
+
 	for (channel = 0; channel < CHANNEL_MAX; channel++) {
 		hwmon->temp.available[channel] = xe_hwmon_temp_probe(hwmon, channel);
-		if (hwmon->temp.available[channel] &&
-		    in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+		if (hwmon->temp.available[channel] && hwmon->temp.vram_label &&
+		    in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count))
 			snprintf(hwmon->temp.vram_label[channel - CHANNEL_VRAM_N], MAX_LABEL_SIZE,
 				 "vram_ch_%d", channel - CHANNEL_VRAM_N);
 	}
+
+	return 0;
 }
 
 static umode_t
@@ -1578,8 +1702,10 @@ static int xe_hwmon_read_label(struct device *dev,
 			*str = "mctrl";
 		else if (channel == CHANNEL_PCIE)
 			*str = "pcie";
-		else if (in_range(channel, CHANNEL_VRAM_N, MAX_VRAM_CHANNELS))
+		else if (in_range(channel, CHANNEL_VRAM_N, hwmon->temp.vram_count))
 			*str = hwmon->temp.vram_label[channel - CHANNEL_VRAM_N];
+		else
+			return -EOPNOTSUPP;
 		return 0;
 	case hwmon_power:
 	case hwmon_energy:
@@ -1607,7 +1733,7 @@ static const struct hwmon_chip_info hwmon_chip_info = {
 	.info = hwmon_info,
 };
 
-static void
+static int
 xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
@@ -1675,7 +1801,7 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
 		if (xe_hwmon_is_visible(hwmon, hwmon_fan, hwmon_fan_input, channel))
 			xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);
 
-	xe_hwmon_init_temp_info(hwmon);
+	return xe_hwmon_init_temp_info(hwmon);
 }
 
 int xe_hwmon_register(struct xe_device *xe)
@@ -1704,7 +1830,9 @@ int xe_hwmon_register(struct xe_device *xe)
 	hwmon->xe = xe;
 	xe->hwmon = hwmon;
 
-	xe_hwmon_get_preregistration_info(hwmon);
+	ret = xe_hwmon_get_preregistration_info(hwmon);
+	if (ret)
+		goto err_null_hwmon;
 
 	drm_dbg(&xe->drm, "Register xe hwmon interface\n");
 
@@ -1714,10 +1842,14 @@ int xe_hwmon_register(struct xe_device *xe)
 								hwmon_groups);
 	if (IS_ERR(hwmon->hwmon_dev)) {
 		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
-		xe->hwmon = NULL;
-		return PTR_ERR(hwmon->hwmon_dev);
+		ret = PTR_ERR(hwmon->hwmon_dev);
+		goto err_null_hwmon;
 	}
 
 	return 0;
+
+err_null_hwmon:
+	xe->hwmon = NULL;
+	return ret;
 }
 MODULE_IMPORT_NS("INTEL_PMT_TELEMETRY");
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 111d0aa45b10..e754668100cf 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -417,6 +417,7 @@ static const struct xe_device_desc bmg_desc = {
 	.dma_mask_size = 46,
 	.has_display = true,
 	.has_fan_control = true,
+	.has_fixed_vram_channels = true,
 	.has_flat_ccs = 1,
 	.has_mbx_power_limits = true,
 	.has_mbx_thermal_info = true,
@@ -798,6 +799,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.has_device_uid = desc->has_device_uid;
 	xe->info.has_drm_ras = desc->has_drm_ras;
 	xe->info.has_fan_control = desc->has_fan_control;
+	xe->info.has_fixed_vram_channels = desc->has_fixed_vram_channels;
 	/* runtime fusing may force flat_ccs to disabled later */
 	xe->info.has_flat_ccs = desc->has_flat_ccs;
 	xe->info.has_mbx_power_limits = desc->has_mbx_power_limits;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index 15eedac8467a..ce0b0f6c5b18 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -43,6 +43,7 @@ struct xe_device_desc {
 	u8 has_device_uid:1;
 	u8 has_drm_ras:1;
 	u8 has_fan_control:1;
+	u8 has_fixed_vram_channels:1;
 	u8 has_flat_ccs:1;
 	u8 has_gsc_nvm:1;
 	u8 has_heci_gscfi:1;
-- 
2.25.1

[PATCH v13 11/16] drm/xe/hwmon: Decode CRI temperature registers as IEEE-754

[Karthik Poosa]

CRI temperature registers encode package and VRAM temperatures as
IEEE-754 floating-point values. Decode these values before exposing
them through hwmon.
 
Use integer-based IEEE-754 decoding since kernel code does not use
floating-point operations and hwmon reports integer temperatures.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
---

v2: Add missing description for parameter 'temperature' in
    xe_hwmon_temperature_decode().

v3: Add missing mmio_temp_valid() check in xe_hwmon_temp_read() for MMIO
    temperature register reads.

 drivers/gpu/drm/xe/xe_hwmon.c | 99 ++++++++++++++++++++++++++++++-----
 1 file changed, 85 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index afcc80e34bfd..dad2397db141 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -1266,6 +1266,70 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 	}
 }
 
+#define IEEE754_SIGN		REG_BIT(31)
+#define IEEE754_EXP_MASK	REG_GENMASK(30, 23)
+#define IEEE754_MANTISSA_MASK	REG_GENMASK(22, 0)
+#define IEEE754_EXP_BIAS	127 /* Exponent bias to obtain the actual exponent */
+#define IEEE754_MANTISSA_BITS	23 /* Mantissa width and implicit leading-1 bit position */
+#define IEEE754_EXP_SPECIAL	0xff /* reserved exponent value encoding infinity or NaN */
+
+/**
+ * xe_hwmon_temperature_decode - Decode an IEEE-754 temperature register value
+ * @reg_val: The raw register value to decode
+ * @temperature: Pointer to store the decoded temperature in millidegrees Celsius.
+ *
+ * IEEE-754 single-precision format:
+ *
+ *  31 30                         23 22                         0
+ * +--+-----------------------------+----------------------------+
+ * | S|          exponent           |          fraction          |
+ * +--+-----------------------------+----------------------------+
+ *
+ * value = (-1)^S * 1.fraction * 2^(exponent - 127)
+ *
+ * Return: 0 on success or an error if @reg_val is non-finite or cannot be
+ * represented in millidegrees Celsius.
+ */
+static int xe_hwmon_temperature_decode(u32 reg_val, long *temperature)
+{
+	u32 exponent = REG_FIELD_GET(IEEE754_EXP_MASK, reg_val);
+	u32 mantissa = REG_FIELD_GET(IEEE754_MANTISSA_MASK, reg_val);
+	s64 value;
+	int shift;
+
+	/* Exponent 0xff encodes infinity or NaN. */
+	if (exponent == IEEE754_EXP_SPECIAL)
+		return -EINVAL;
+
+	/* Subnormal values are smaller than one millidegree Celsius. */
+	if (!exponent) {
+		*temperature = 0;
+		return 0;
+	}
+
+	value = (s64)(mantissa | BIT(IEEE754_MANTISSA_BITS)) * MILLIDEGREE_PER_DEGREE;
+	shift = exponent - (IEEE754_EXP_BIAS + IEEE754_MANTISSA_BITS);
+	if (shift >= 0) {
+		if (shift >= BITS_PER_LONG || value > (LONG_MAX >> shift))
+			return -ERANGE;
+		value <<= shift;
+	} else if (shift > -64) {
+		value >>= -shift;
+	} else {
+		value = 0;
+	}
+
+	/* Ensure the magnitude fits in long, which is 32-bit on some arches. */
+	if (value > LONG_MAX)
+		return -ERANGE;
+
+	if (reg_val & IEEE754_SIGN)
+		value = -value;
+
+	*temperature = value;
+	return 0;
+}
+
 static int
 xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 {
@@ -1275,26 +1339,33 @@ xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 	switch (attr) {
 	case hwmon_temp_input:
 		switch (channel) {
-		case CHANNEL_PKG:
-		case CHANNEL_VRAM:
-			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
-
-			/* HW register value is in degrees Celsius, convert to millidegrees. */
-			*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
-			return 0;
 		case CHANNEL_MCTRL:
 			return get_mc_temp(hwmon, val);
 		case CHANNEL_PCIE:
 			return get_pcie_temp(hwmon, val);
+		case CHANNEL_PKG:
+		case CHANNEL_VRAM:
 		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
 			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
-			/*
-			 * This temperature format is 24 bit [31:8] signed integer and 8 bit
-			 * [7:0] fraction.
-			 */
-			*val = (s32)(REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val)) *
-				(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
-				 MILLIDEGREE_PER_DEGREE;
+			if (!mmio_temp_valid(hwmon, reg_val)) {
+				drm_dbg(&hwmon->xe->drm,
+					"channel %d temperature invalid, val 0x%llx\n",
+					channel, reg_val);
+				return -ENXIO;
+			}
+			if (hwmon->xe->info.platform >= XE_CRESCENTISLAND) {
+				return xe_hwmon_temperature_decode((u32)reg_val, val);
+			} else if (channel >= CHANNEL_VRAM_N) {
+				/*
+				 * This temperature format is 24 bit [31:8] signed integer and 8 bit
+				 * [7:0] fraction for platforms before CRI.
+				 */
+				*val = (s32)REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val) *
+					(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
+					MILLIDEGREE_PER_DEGREE;
+			} else {
+				*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
+			}
 			return 0;
 		default:
 			return -EOPNOTSUPP;
-- 
2.25.1

[PATCH v13 12/16] drm/xe/hwmon: Update memory controller temperature offset for CRI

[Karthik Poosa]

On CRI the memory controller temperatures moved in the READ_THERMAL_DATA
output: they now occupy bytes 16..19 instead of starting at byte 2.

Read and average the CRI memory controller sensors from bytes 16..19,
keeping the existing byte 2..count-1 range for earlier platforms. Only
the group(s) covering the used bytes are fetched.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---

v2: Use the CRI memory temperature mapping only on
    Crescent Island. (sashiko)

 drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index dad2397db141..eef6560569ce 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -109,6 +109,10 @@ enum sensor_attr_power {
 /* Index of memory controller in READ_THERMAL_DATA output */
 #define TEMP_INDEX_MCTRL	2
 
+/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
+#define CRI_TEMP_INDEX_MCTRL	16
+#define CRI_TEMP_MCTRL_COUNT	4
+
 /* Mailbox sentinel reported for an unavailable temperature sensor */
 #define TEMP_MBX_INVALID	0xFF
 
@@ -986,14 +990,22 @@ static int mbx_temp_decode(u8 value)
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
-	int ret, i, count = 0;
+	int ret, i, start, end, count = 0;
 	s32 average = 0;
+	u32 data = 0;
 
 	guard(mutex)(&hwmon->hwmon_lock);
 
-	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
-		u32 data = 0;
+	/* CRI relocated the memory controller temperatures to READ_THERMAL_DATA bytes 16..19. */
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {
+		start = CRI_TEMP_INDEX_MCTRL;
+		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
+	} else {
+		start = TEMP_INDEX_MCTRL;
+		end = hwmon->temp.count - 1;
+	}
 
+	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
 		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
 				    &data, NULL);
 		if (ret)
@@ -1002,7 +1014,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 		hwmon->temp.dword[i] = cpu_to_le32(data);
 	}
 
-	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
+	for (i = start; i < end; i++) {
 		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
 			continue;
 		average += mbx_temp_decode(hwmon->temp.value[i]);
-- 
2.25.1

[PATCH v13 13/16] drm/xe/hwmon: add PCIe temperature support for CRI

[Karthik Poosa]

Add the PCIe temperature sensor offset in READ_THERMAL_DATA for CRI.

Refactor PCIe temperature handling to use platform-specific sensor
indices and derive the mailbox group and byte offset from the sensor
index, eliminating special-case decoding logic.

v2:
 - Remove variables group and byte variables in get_pcie_temp().
 - Change xe_hwmon_pcie_temp_index() to take a const struct xe_hwmon *.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c     | 28 ++++++++++++++++++++--------
 drivers/gpu/drm/xe/xe_pcode_api.h |  2 --
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index eef6560569ce..dfe9719fb3e2 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -106,12 +106,15 @@ enum sensor_attr_power {
 
 #define PWR_ATTR_TO_STR(attr)	(((attr) == hwmon_power_max) ? "PL1" : "PL2")
 
-/* Index of memory controller in READ_THERMAL_DATA output */
+/* Sensor byte indices in READ_THERMAL_DATA output for BMG. */
 #define TEMP_INDEX_MCTRL	2
+#define TEMP_INDEX_PCIE		10
+#define BMG_G21_TEMP_INDEX_PCIE	8
 
-/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
+/* Sensor byte indices in READ_THERMAL_DATA output for CRI. */
 #define CRI_TEMP_INDEX_MCTRL	16
 #define CRI_TEMP_MCTRL_COUNT	4
+#define CRI_TEMP_INDEX_PCIE	20
 
 /* Mailbox sentinel reported for an unavailable temperature sensor */
 #define TEMP_MBX_INVALID	0xFF
@@ -1034,21 +1037,30 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 	return 0;
 }
 
-static int get_pcie_temp(struct xe_hwmon *hwmon, long *val)
+static u8 xe_hwmon_pcie_temp_index(const struct xe_hwmon *hwmon)
+{
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
+		return CRI_TEMP_INDEX_PCIE;
+
+	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
+		return BMG_G21_TEMP_INDEX_PCIE;
+
+	return TEMP_INDEX_PCIE;
+}
+
+static int get_pcie_temp(const struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
 	u32 data = 0;
 	int ret;
 
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA,
-						  PCIE_SENSOR_GROUP_ID), &data, NULL);
+						  xe_hwmon_pcie_temp_index(hwmon) / sizeof(data)),
+						  &data, NULL);
 	if (ret)
 		return ret;
 
-	/* Sensor offset is different for G21 */
-	if (hwmon->xe->info.subplatform != XE_SUBPLATFORM_BATTLEMAGE_G21)
-		data = REG_FIELD_GET(PCIE_SENSOR_MASK, data);
-
+	data >>= (xe_hwmon_pcie_temp_index(hwmon) % sizeof(data)) * BITS_PER_BYTE;
 	data = REG_FIELD_GET(TEMP_MASK, data);
 	if (!mbx_temp_valid(hwmon, data)) {
 		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 94575c476e3d..00c4fc7d0124 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -58,8 +58,6 @@
 #define     READ_THERMAL_LIMITS			0x0
 #define     READ_THERMAL_CONFIG			0x1
 #define     READ_THERMAL_DATA			0x2
-#define       PCIE_SENSOR_GROUP_ID		0x2
-#define       PCIE_SENSOR_MASK			REG_GENMASK(31, 16)
 
 #define   PCODE_LATE_BINDING			0x5C
 #define     GET_CAPABILITY_STATUS		0x0
-- 
2.25.1

[PATCH v13 14/16] drm/xe/hwmon: Simplify temperature channels config

[Karthik Poosa]

Replace the repeated temperature channels list with an indexed config
array. Use range designators for channels sharing the same attributes.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Assisted-by: LLM
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 104 ++++++----------------------------
 1 file changed, 17 insertions(+), 87 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index dfe9719fb3e2..4249faf9fb39 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -812,94 +812,24 @@ static const struct attribute_group *hwmon_groups[] = {
 	NULL
 };
 
+static const u32 hwmon_temp_config[CHANNEL_MAX + 1] = {
+	[CHANNEL_CARD] = HWMON_T_LABEL,
+	[CHANNEL_PKG] = HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT |
+			 HWMON_T_LABEL | HWMON_T_MAX,
+	[CHANNEL_VRAM ... CHANNEL_PCIE] = HWMON_T_CRIT | HWMON_T_EMERGENCY |
+					 HWMON_T_INPUT | HWMON_T_LABEL,
+	[CHANNEL_VRAM_N ... CHANNEL_VRAM_N_MAX] = HWMON_T_CRIT | HWMON_T_EMERGENCY |
+							 HWMON_T_INPUT | HWMON_T_LABEL,
+	[CHANNEL_MAX] = 0, /* hwmon config terminator */
+};
+
+static const struct hwmon_channel_info hwmon_temp_info = {
+	.type = hwmon_temp,
+	.config = hwmon_temp_config,
+};
+
 static const struct hwmon_channel_info * const hwmon_info[] = {
-	HWMON_CHANNEL_INFO(temp,
-			   HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL |
-			   HWMON_T_MAX,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_CRIT | HWMON_T_EMERGENCY | HWMON_T_INPUT | HWMON_T_LABEL),
+	&hwmon_temp_info,
 	HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CRIT |
 			   HWMON_P_CAP,
 			   HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_LABEL | HWMON_P_CAP),
-- 
2.25.1

[PATCH v13 15/16] drm/xe: Validate thermal sensor count before reads

[Karthik Poosa]

Check that READ_THERMAL_CONFIG reports enough thermal entries for the
platform-specific MCTRL range and PCIe sensor index before reading
READ_THERMAL_DATA.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
---

v2:
- Cap the memory controller sensor range at the PCIe sensor index so the
  PCIe temperature is not averaged into the memory controller temperature.

 drivers/gpu/drm/xe/xe_hwmon.c | 44 ++++++++++++++++++++++++-----------
 1 file changed, 30 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 4249faf9fb39..4b9c18230ade 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -920,6 +920,17 @@ static int mbx_temp_decode(u8 value)
 	return (value & TEMP_MBX_SIGN) ? -temp : temp;
 }
 
+static u8 xe_hwmon_pcie_temp_index(const struct xe_hwmon *hwmon)
+{
+	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
+		return CRI_TEMP_INDEX_PCIE;
+
+	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
+		return BMG_G21_TEMP_INDEX_PCIE;
+
+	return TEMP_INDEX_PCIE;
+}
+
 static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
@@ -935,7 +946,14 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
 	} else {
 		start = TEMP_INDEX_MCTRL;
-		end = hwmon->temp.count - 1;
+		end = min_t(int, hwmon->temp.count - 1, xe_hwmon_pcie_temp_index(hwmon));
+	}
+
+	if (end <= start || end > hwmon->temp.count) {
+		drm_warn(&hwmon->xe->drm,
+			 "memory controller range [%d, %d) is invalid for temperature count %d\n",
+			 start, end, hwmon->temp.count);
+		return -ENODATA;
 	}
 
 	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
@@ -967,30 +985,28 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
 	return 0;
 }
 
-static u8 xe_hwmon_pcie_temp_index(const struct xe_hwmon *hwmon)
-{
-	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
-		return CRI_TEMP_INDEX_PCIE;
-
-	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
-		return BMG_G21_TEMP_INDEX_PCIE;
-
-	return TEMP_INDEX_PCIE;
-}
-
 static int get_pcie_temp(const struct xe_hwmon *hwmon, long *val)
 {
 	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
 	u32 data = 0;
+	int index;
 	int ret;
 
+	index = xe_hwmon_pcie_temp_index(hwmon);
+	if (index >= hwmon->temp.count) {
+		drm_warn(&hwmon->xe->drm,
+			 "PCIe temperature index %d out of range for temperature count %d\n",
+			 index, hwmon->temp.count);
+		return -ENODATA;
+	}
+
 	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA,
-						  xe_hwmon_pcie_temp_index(hwmon) / sizeof(data)),
+						  index / sizeof(data)),
 						  &data, NULL);
 	if (ret)
 		return ret;
 
-	data >>= (xe_hwmon_pcie_temp_index(hwmon) % sizeof(data)) * BITS_PER_BYTE;
+	data >>= (index % sizeof(data)) * BITS_PER_BYTE;
 	data = REG_FIELD_GET(TEMP_MASK, data);
 	if (!mbx_temp_valid(hwmon, data)) {
 		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
-- 
2.25.1

[PATCH v13 16/16] drm/xe/hwmon: Propagate all hardware read errors

[Karthik Poosa]

Propagate all failures from pcode and mailbox accesses and fix missed
return-value checks found by Sashiko in
https://patchwork.freedesktop.org/patch/758843/?series=174898&rev=6.

Fixes: 7596d839f622 ("drm/xe/hwmon: Add support to manage power limits though mailbox")
Fixes: 0c5405d3aa4ad ("drm/xe/hwmon: Read energy status from PMT")
Fixes: 25e963a09e059 ("drm/xe/hwmon: Move card reactive critical power under channel card")
Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_hwmon.c | 47 +++++++++++++++++++++--------------
 1 file changed, 29 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 4b9c18230ade..286020d0c6ec 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -390,17 +390,20 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
  * same pattern for sysfs, allow arbitrary PL1 limits to be set but display
  * clamped values when read.
  */
-static void xe_hwmon_power_max_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *value)
+static int xe_hwmon_power_max_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *value)
 {
 	u32 reg_val = 0;
 	struct xe_device *xe = hwmon->xe;
 	struct xe_reg rapl_limit, pkg_power_sku;
 	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
+	int ret = 0;
 
 	mutex_lock(&hwmon->hwmon_lock);
 
 	if (hwmon->xe->info.has_mbx_power_limits) {
-		xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
+		ret = xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
+		if (ret)
+			goto unlock;
 	} else {
 		rapl_limit = xe_hwmon_get_reg(hwmon, REG_PKG_RAPL_LIMIT, channel);
 		pkg_power_sku = xe_hwmon_get_reg(hwmon, REG_PKG_POWER_SKU, channel);
@@ -432,6 +435,7 @@ static void xe_hwmon_power_max_read(struct xe_hwmon *hwmon, u32 attr, int channe
 	}
 unlock:
 	mutex_unlock(&hwmon->hwmon_lock);
+	return ret;
 }
 
 static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channel, long value)
@@ -454,7 +458,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
 			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
 			if (ret)
 				goto unlock;
-			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
+			ret = xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
+			if (ret)
+				goto unlock;
 		} else {
 			reg_val = xe_mmio_rmw32(mmio, rapl_limit, PWR_LIM_EN, 0);
 			reg_val = xe_mmio_read32(mmio, rapl_limit);
@@ -511,15 +517,18 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
 	return ret;
 }
 
-static void xe_hwmon_power_rated_max_read(struct xe_hwmon *hwmon, u32 attr, int channel,
-					  long *value)
+static int xe_hwmon_power_rated_max_read(struct xe_hwmon *hwmon, u32 attr, int channel,
+					 long *value)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
 	u32 reg_val;
+	int ret = 0;
 
 	if (hwmon->xe->info.has_mbx_power_limits) {
 		/* PL1 is rated max if supported. */
-		xe_hwmon_pcode_read_power_limit(hwmon, PL1_HWMON_ATTR, channel, &reg_val);
+		ret = xe_hwmon_pcode_read_power_limit(hwmon, PL1_HWMON_ATTR, channel, &reg_val);
+		if (ret)
+			return ret;
 	} else {
 		/*
 		 * This sysfs file won't be visible if REG_PKG_POWER_SKU is invalid, so valid check
@@ -533,6 +542,7 @@ static void xe_hwmon_power_rated_max_read(struct xe_hwmon *hwmon, u32 attr, int
 
 	reg_val = REG_FIELD_GET(PKG_TDP, reg_val);
 	*value = mul_u64_u32_shr(reg_val, SF_POWER, hwmon->scl_shift_power);
+	return ret;
 }
 
 /*
@@ -555,7 +565,7 @@ static void xe_hwmon_power_rated_max_read(struct xe_hwmon *hwmon, u32 attr, int
  * hwmon->scl_shift_energy of 14 bits we have 57 (63 - 20 + 14) bits before
  * energyN_input overflows. This at 1000 W is an overflow duration of 278 years.
  */
-static void
+static int
 xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);
@@ -566,7 +576,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 	/* Energy is supported only for card and pkg */
 	if (channel > CHANNEL_PKG) {
 		*energy = 0;
-		return;
+		return 0;
 	}
 
 	if (hwmon->xe->info.platform == XE_BATTLEMAGE) {
@@ -578,7 +588,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 		if (ret != sizeof(pmt_val)) {
 			drm_warn(&hwmon->xe->drm, "energy read from pmt failed, ret %d\n", ret);
 			*energy = 0;
-			return;
+			return ret < 0 ? ret : -EIO;
 		}
 
 		if (channel == CHANNEL_PKG)
@@ -595,6 +605,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 
 	*energy = mul_u64_u32_shr(ei->accum_energy, SF_ENERGY,
 				  hwmon->scl_shift_energy);
+	return 0;
 }
 
 static ssize_t
@@ -620,7 +631,8 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
 			drm_err(&hwmon->xe->drm,
 				"power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n",
 				channel, power_attr, reg_val, ret);
-			reg_val = 0;
+			mutex_unlock(&hwmon->hwmon_lock);
+			return ret;
 		}
 	} else {
 		reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_PKG_RAPL_LIMIT,
@@ -1417,7 +1429,8 @@ xe_hwmon_power_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 		}
 	case hwmon_power_crit:
 		if (channel == CHANNEL_CARD) {
-			xe_hwmon_pcode_read_i1(hwmon, &uval);
+			if (xe_hwmon_pcode_read_i1(hwmon, &uval))
+				return 0;
 			return (uval & POWER_SETUP_I1_WATTS) ? 0644 : 0;
 		}
 		break;
@@ -1436,7 +1449,8 @@ xe_hwmon_power_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
 			}
 		}
 		if ((!(uval & PWR_LIM_EN)) && channel == CHANNEL_CARD) {
-			xe_hwmon_pcode_read_i1(hwmon, &uval);
+			if (xe_hwmon_pcode_read_i1(hwmon, &uval))
+				return 0;
 			return (uval & POWER_SETUP_I1_WATTS) ? 0444 : 0;
 		}
 		return (uval) ? 0444 : 0;
@@ -1452,11 +1466,9 @@ xe_hwmon_power_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 	switch (attr) {
 	case hwmon_power_max:
 	case hwmon_power_cap:
-		xe_hwmon_power_max_read(hwmon, attr, channel, val);
-		return 0;
+		return xe_hwmon_power_max_read(hwmon, attr, channel, val);
 	case hwmon_power_rated_max:
-		xe_hwmon_power_rated_max_read(hwmon, attr, channel, val);
-		return 0;
+		return xe_hwmon_power_rated_max_read(hwmon, attr, channel, val);
 	case hwmon_power_crit:
 		return xe_hwmon_power_curr_crit_read(hwmon, channel, val, SF_POWER);
 	default:
@@ -1573,8 +1585,7 @@ xe_hwmon_energy_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
 {
 	switch (attr) {
 	case hwmon_energy_input:
-		xe_hwmon_energy_get(hwmon, channel, val);
-		return 0;
+		return xe_hwmon_energy_get(hwmon, channel, val);
 	default:
 		return -EOPNOTSUPP;
 	}
-- 
2.25.1

Re: [PATCH v13 04/16] drm/xe/hwmon: Add helpers to validate thermal sensor readings

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe/hwmon: mbx_temp_valid() fails to reject 0x80 (-0°C) as invalid
--

commit cc835292455ece8a38adb02fe6e4c345fc3aa89a
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Add helpers to validate thermal sensor readings

This commit adds mmio_temp_valid() and mbx_temp_valid() to validate
temperature sensor readings. It uses the has_temp_sentinel flag to gate
these checks and rejects 0xFF for mailbox and 0xFFFFFFFF for MMIO.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 1b4efbf4ac999..883a0ae1d90e3 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
[ ... ]
> @@ -834,6 +837,30 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
>  	return ret;
>  }
[ ... ]
> +/* Mailbox temperature is sign-magnitude (bit 7 sign, bits 6:0 magnitude). */
> +static inline bool mbx_temp_valid(const struct xe_hwmon *hwmon, u8 value)
> +{
> +	if (value == TEMP_MBX_INVALID)
> +		return false;
> +
> +	return hwmon->xe->info.has_temp_sentinel || value != 0;

[Severity: Low]
Does this raw byte check fail to reject 0x80?

Since 0x80 represents -0 degrees Celsius in the sign-magnitude format (sign
bit 7 is set, magnitude bits 6:0 are zero), it evaluates to true here
because 0x80 is not equal to 0.

> +}
> +
> +/* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
> +static int mbx_temp_decode(u8 value)
> +{
> +	int temp = value & TEMP_MBX_MAG;
> +
> +	return (value & TEMP_MBX_SIGN) ? -temp : temp;

If 0x80 is passed here, it decodes to 0 degrees Celsius.

This means the fallback safety logic in mbx_temp_valid() intended to reject
uninitialized 0 degrees Celsius readings can be bypassed if the hardware
returns 0x80 instead of 0x00. This could fold invalid readings into the
temperature average.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014115806.831459-1-karthik.poosa@intel.com?part=4

✓ CI.KUnit: success for drm/xe/hwmon: Update hwmon thermal mailbox

[Patchwork]

== Series Details ==

Series: drm/xe/hwmon: Update hwmon thermal mailbox
URL   : https://patchwork.freedesktop.org/series/176121/
State : success

== Summary ==

+ trap cleanup EXIT
+ kunitconfigs=('/kernel/drivers/gpu/tests/.kunitconfig' '/kernel/drivers/gpu/drm/xe/.kunitconfig' '/kernel/drivers/gpu/drm/tests/.kunitconfig' '/kernel/drivers/gpu/drm/ttm/tests/.kunitconfig' '/kernel/drivers/dma-buf/.kunitconfig')
+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/tests/.kunitconfig
[12:10:26] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:10:30] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:10:51] Starting KUnit Kernel (1/1)...
[12:10:51] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:10:51] ================= gpu_buddy (14 subtests) ==================
[12:10:51] [PASSED] gpu_test_buddy_alloc_limit
[12:10:51] [PASSED] gpu_test_buddy_alloc_optimistic
[12:10:51] [PASSED] gpu_test_buddy_alloc_pessimistic
[12:10:51] [PASSED] gpu_test_buddy_alloc_pathological
[12:10:51] [PASSED] gpu_test_buddy_alloc_contiguous
[12:10:51] [PASSED] gpu_test_buddy_alloc_clear
[12:10:51] [PASSED] gpu_test_buddy_alloc_range
[12:10:51] [PASSED] gpu_test_buddy_alloc_range_bias
[12:10:52] [PASSED] gpu_test_buddy_fragmentation_performance
[12:10:53] [PASSED] gpu_test_buddy_dirty_tracker_performance
[12:10:53] [PASSED] gpu_test_buddy_alloc_exceeds_max_order
[12:10:53] [PASSED] gpu_test_buddy_offset_aligned_allocation
[12:10:53] [PASSED] gpu_test_buddy_subtree_offset_alignment_stress
[12:10:53] [PASSED] gpu_test_buddy_addr_to_block
[12:10:53] ==================== [PASSED] gpu_buddy ====================
[12:10:53] ============================================================
[12:10:53] Testing complete. Ran 14 tests: passed: 14
[12:10:53] Elapsed time: 26.859s total, 4.319s configuring, 20.623s building, 1.879s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/xe/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[12:10:53] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:10:55] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:11:29] Starting KUnit Kernel (1/1)...
[12:11:29] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:11:29] ================== guc_buf (11 subtests) ===================
[12:11:29] [PASSED] test_smallest
[12:11:29] [PASSED] test_largest
[12:11:29] [PASSED] test_granular
[12:11:29] [PASSED] test_unique
[12:11:29] [PASSED] test_overlap
[12:11:29] [PASSED] test_reusable
[12:11:29] [PASSED] test_too_big
[12:11:29] [PASSED] test_flush
[12:11:29] [PASSED] test_lookup
[12:11:29] [PASSED] test_data
[12:11:29] [PASSED] test_class
[12:11:29] ===================== [PASSED] guc_buf =====================
[12:11:29] =================== guc_dbm (7 subtests) ===================
[12:11:29] [PASSED] test_empty
[12:11:29] [PASSED] test_default
[12:11:29] ======================== test_size  ========================
[12:11:29] [PASSED] 4
[12:11:29] [PASSED] 8
[12:11:29] [PASSED] 32
[12:11:29] [PASSED] 256
[12:11:29] ==================== [PASSED] test_size ====================
[12:11:29] ======================= test_reuse  ========================
[12:11:29] [PASSED] 4
[12:11:29] [PASSED] 8
[12:11:29] [PASSED] 32
[12:11:29] [PASSED] 256
[12:11:29] =================== [PASSED] test_reuse ====================
[12:11:29] =================== test_range_overlap  ====================
[12:11:29] [PASSED] 4
[12:11:29] [PASSED] 8
[12:11:29] [PASSED] 32
[12:11:29] [PASSED] 256
[12:11:29] =============== [PASSED] test_range_overlap ================
[12:11:29] =================== test_range_compact  ====================
[12:11:29] [PASSED] 4
[12:11:29] [PASSED] 8
[12:11:29] [PASSED] 32
[12:11:29] [PASSED] 256
[12:11:29] =============== [PASSED] test_range_compact ================
[12:11:29] ==================== test_range_spare  =====================
[12:11:29] [PASSED] 4
[12:11:29] [PASSED] 8
[12:11:29] [PASSED] 32
[12:11:29] [PASSED] 256
[12:11:29] ================ [PASSED] test_range_spare =================
[12:11:29] ===================== [PASSED] guc_dbm =====================
[12:11:29] =================== guc_idm (6 subtests) ===================
[12:11:29] [PASSED] bad_init
[12:11:29] [PASSED] no_init
[12:11:29] [PASSED] init_fini
[12:11:29] [PASSED] check_used
[12:11:29] [PASSED] check_quota
[12:11:29] [PASSED] check_all
[12:11:29] ===================== [PASSED] guc_idm =====================
[12:11:29] ============== guc_klv_helpers (13 subtests) ===============
[12:11:29] [PASSED] test_count
[12:11:29] [PASSED] test_encode_u32
[12:11:29] [PASSED] test_encode_u64
[12:11:29] [PASSED] test_encode_string
[12:11:29] [PASSED] test_encode_object_raw
[12:11:29] [PASSED] test_encode_object_klv
[12:11:29] [PASSED] test_encode_object_nested
[12:11:29] [PASSED] test_encode_object_basic
[12:11:29] ===================== test_decode_u16  =====================
[12:11:29] [PASSED] empty
[12:11:29] [PASSED] valid
[12:11:29] [PASSED] max
[12:11:29] [PASSED] big
[12:11:29] [PASSED] long
[12:11:29] ================= [PASSED] test_decode_u16 =================
[12:11:29] ===================== test_decode_u32  =====================
[12:11:29] [PASSED] empty
[12:11:29] [PASSED] valid
[12:11:29] [PASSED] max
[12:11:29] [PASSED] long
[12:11:29] ================= [PASSED] test_decode_u32 =================
[12:11:29] ===================== test_decode_u64  =====================
[12:11:29] [PASSED] empty
[12:11:29] [PASSED] short
[12:11:29] [PASSED] valid
[12:11:29] [PASSED] max
[12:11:29] [PASSED] long
[12:11:29] ================= [PASSED] test_decode_u64 =================
[12:11:29] ===================== test_decode_str  =====================
[12:11:29] [PASSED] empty
[12:11:29] [PASSED] one
[12:11:29] [PASSED] one_trash
[12:11:29] [PASSED] two
[12:11:29] [PASSED] two_trash
[12:11:29] [PASSED] three
[12:11:29] [PASSED] dword
[12:11:29] [PASSED] four
[12:11:29] [PASSED] five
[12:11:29] [PASSED] six
[12:11:29] [PASSED] seven
[12:11:29] [PASSED] qword
[12:11:29] ================= [PASSED] test_decode_str =================
[12:11:29] [PASSED] test_print
[12:11:29] ================= [PASSED] guc_klv_helpers =================
[12:11:29] =================== xe_log (4 subtests) ====================
[12:11:29] [PASSED] demo_cper
[12:11:29] [PASSED] demo_dmesg
[12:11:29] ======================= test_dmesg  ========================
[12:11:29] [PASSED] test_fatal
[12:11:29] [PASSED] test_fatal_tile
[12:11:29] [PASSED] test_fatal_gt
[12:11:29] [PASSED] test_fatal_comp
[12:11:29] [PASSED] test_fatal_comp_tile
[12:11:29] [PASSED] test_fatal_comp_gt
[12:11:29] [PASSED] test_fatal_all
[12:11:29] [PASSED] test_recoverable
[12:11:29] [PASSED] test_recoverable_tile
[12:11:29] [PASSED] test_recoverable_gt
[12:11:29] [PASSED] test_recoverable_comp
[12:11:29] [PASSED] test_recoverable_comp_tile
[12:11:29] [PASSED] test_recoverable_comp_gt
[12:11:29] [PASSED] test_recoverable_all
[12:11:29] [PASSED] test_info
[12:11:29] [PASSED] test_info_tile
[12:11:29] [PASSED] test_info_gt
[12:11:29] [PASSED] test_info_err
[12:11:29] [PASSED] test_info_comp
[12:11:29] [PASSED] test_info_comp_tile
[12:11:29] [PASSED] test_info_comp_gt
[12:11:29] [PASSED] test_info_all
[12:11:29] [PASSED] test_hw_fatal
[12:11:29] [PASSED] test_hw_recoverable
[12:11:29] [PASSED] test_hw_corrected
[12:11:29] [PASSED] test_hw_informational
[12:11:29] =================== [PASSED] test_dmesg ====================
[12:11:29] ====================== test_invalid  =======================
[12:11:29] [SKIPPED] no-component no-location no-warn (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] reserved location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] unknown location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] nonzero-device-id location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] invalid-tile-id location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] invalid-gt-id location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] unknown component class (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] unknown system component (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] unknown hardware component (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] [SKIPPED] unknown component and location (requires CONFIG_DRM_XE_DEBUG)
[12:11:29] ================== [SKIPPED] test_invalid ==================
[12:11:29] ===================== [PASSED] xe_log ======================
[12:11:29] ================== no_relay (3 subtests) ===================
[12:11:29] [PASSED] xe_drops_guc2pf_if_not_ready
[12:11:29] [PASSED] xe_drops_guc2vf_if_not_ready
[12:11:29] [PASSED] xe_rejects_send_if_not_ready
[12:11:29] ==================== [PASSED] no_relay =====================
[12:11:29] ================== pf_relay (14 subtests) ==================
[12:11:29] [PASSED] pf_rejects_guc2pf_too_short
[12:11:29] [PASSED] pf_rejects_guc2pf_too_long
[12:11:29] [PASSED] pf_rejects_guc2pf_no_payload
[12:11:29] [PASSED] pf_fails_no_payload
[12:11:29] [PASSED] pf_fails_bad_origin
[12:11:29] [PASSED] pf_fails_bad_type
[12:11:29] [PASSED] pf_txn_reports_error
[12:11:29] [PASSED] pf_txn_sends_pf2guc
[12:11:29] [PASSED] pf_sends_pf2guc
[12:11:29] [SKIPPED] pf_loopback_nop (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:11:30] [SKIPPED] pf_loopback_echo (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:11:30] [SKIPPED] pf_loopback_fail (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:11:30] [SKIPPED] pf_loopback_busy (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:11:30] [SKIPPED] pf_loopback_retry (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:11:30] ==================== [PASSED] pf_relay =====================
[12:11:30] ================== vf_relay (3 subtests) ===================
[12:11:30] [PASSED] vf_rejects_guc2vf_too_short
[12:11:30] [PASSED] vf_rejects_guc2vf_too_long
[12:11:30] [PASSED] vf_rejects_guc2vf_no_payload
[12:11:30] ==================== [PASSED] vf_relay =====================
[12:11:30] ================ pf_gt_config (9 subtests) =================
[12:11:30] [PASSED] fair_contexts_1vf
[12:11:30] [PASSED] fair_doorbells_1vf
[12:11:30] [PASSED] fair_ggtt_1vf
[12:11:30] ====================== fair_vram_1vf  ======================
[12:11:30] [PASSED] 3.50 GiB
[12:11:30] [PASSED] 11.5 GiB
[12:11:30] [PASSED] 15.5 GiB
[12:11:30] [PASSED] 31.5 GiB
[12:11:30] [PASSED] 63.5 GiB
[12:11:30] [PASSED] 1.91 GiB
[12:11:30] ================== [PASSED] fair_vram_1vf ==================
[12:11:30] ================ fair_vram_1vf_admin_only  =================
[12:11:30] [PASSED] 3.50 GiB
[12:11:30] [PASSED] 11.5 GiB
[12:11:30] [PASSED] 15.5 GiB
[12:11:30] [PASSED] 31.5 GiB
[12:11:30] [PASSED] 63.5 GiB
[12:11:30] [PASSED] 1.91 GiB
[12:11:30] ============ [PASSED] fair_vram_1vf_admin_only =============
[12:11:30] ====================== fair_contexts  ======================
[12:11:30] [PASSED] 1 VF
[12:11:30] [PASSED] 2 VFs
[12:11:30] [PASSED] 3 VFs
[12:11:30] [PASSED] 4 VFs
[12:11:30] [PASSED] 5 VFs
[12:11:30] [PASSED] 6 VFs
[12:11:30] [PASSED] 7 VFs
[12:11:30] [PASSED] 8 VFs
[12:11:30] [PASSED] 9 VFs
[12:11:30] [PASSED] 10 VFs
[12:11:30] [PASSED] 11 VFs
[12:11:30] [PASSED] 12 VFs
[12:11:30] [PASSED] 13 VFs
[12:11:30] [PASSED] 14 VFs
[12:11:30] [PASSED] 15 VFs
[12:11:30] [PASSED] 16 VFs
[12:11:30] [PASSED] 17 VFs
[12:11:30] [PASSED] 18 VFs
[12:11:30] [PASSED] 19 VFs
[12:11:30] [PASSED] 20 VFs
[12:11:30] [PASSED] 21 VFs
[12:11:30] [PASSED] 22 VFs
[12:11:30] [PASSED] 23 VFs
[12:11:30] [PASSED] 24 VFs
[12:11:30] [PASSED] 25 VFs
[12:11:30] [PASSED] 26 VFs
[12:11:30] [PASSED] 27 VFs
[12:11:30] [PASSED] 28 VFs
[12:11:30] [PASSED] 29 VFs
[12:11:30] [PASSED] 30 VFs
[12:11:30] [PASSED] 31 VFs
[12:11:30] [PASSED] 32 VFs
[12:11:30] [PASSED] 33 VFs
[12:11:30] [PASSED] 34 VFs
[12:11:30] [PASSED] 35 VFs
[12:11:30] [PASSED] 36 VFs
[12:11:30] [PASSED] 37 VFs
[12:11:30] [PASSED] 38 VFs
[12:11:30] [PASSED] 39 VFs
[12:11:30] [PASSED] 40 VFs
[12:11:30] [PASSED] 41 VFs
[12:11:30] [PASSED] 42 VFs
[12:11:30] [PASSED] 43 VFs
[12:11:30] [PASSED] 44 VFs
[12:11:30] [PASSED] 45 VFs
[12:11:30] [PASSED] 46 VFs
[12:11:30] [PASSED] 47 VFs
[12:11:30] [PASSED] 48 VFs
[12:11:30] [PASSED] 49 VFs
[12:11:30] [PASSED] 50 VFs
[12:11:30] [PASSED] 51 VFs
[12:11:30] [PASSED] 52 VFs
[12:11:30] [PASSED] 53 VFs
[12:11:30] [PASSED] 54 VFs
[12:11:30] [PASSED] 55 VFs
[12:11:30] [PASSED] 56 VFs
[12:11:30] [PASSED] 57 VFs
[12:11:30] [PASSED] 58 VFs
[12:11:30] [PASSED] 59 VFs
[12:11:30] [PASSED] 60 VFs
[12:11:30] [PASSED] 61 VFs
[12:11:30] [PASSED] 62 VFs
[12:11:30] [PASSED] 63 VFs
[12:11:30] ================== [PASSED] fair_contexts ==================
[12:11:30] ===================== fair_doorbells  ======================
[12:11:30] [PASSED] 1 VF
[12:11:30] [PASSED] 2 VFs
[12:11:30] [PASSED] 3 VFs
[12:11:30] [PASSED] 4 VFs
[12:11:30] [PASSED] 5 VFs
[12:11:30] [PASSED] 6 VFs
[12:11:30] [PASSED] 7 VFs
[12:11:30] [PASSED] 8 VFs
[12:11:30] [PASSED] 9 VFs
[12:11:30] [PASSED] 10 VFs
[12:11:30] [PASSED] 11 VFs
[12:11:30] [PASSED] 12 VFs
[12:11:30] [PASSED] 13 VFs
[12:11:30] [PASSED] 14 VFs
[12:11:30] [PASSED] 15 VFs
[12:11:30] [PASSED] 16 VFs
[12:11:30] [PASSED] 17 VFs
[12:11:30] [PASSED] 18 VFs
[12:11:30] [PASSED] 19 VFs
[12:11:30] [PASSED] 20 VFs
[12:11:30] [PASSED] 21 VFs
[12:11:30] [PASSED] 22 VFs
[12:11:30] [PASSED] 23 VFs
[12:11:30] [PASSED] 24 VFs
[12:11:30] [PASSED] 25 VFs
[12:11:30] [PASSED] 26 VFs
[12:11:30] [PASSED] 27 VFs
[12:11:30] [PASSED] 28 VFs
[12:11:30] [PASSED] 29 VFs
[12:11:30] [PASSED] 30 VFs
[12:11:30] [PASSED] 31 VFs
[12:11:30] [PASSED] 32 VFs
[12:11:30] [PASSED] 33 VFs
[12:11:30] [PASSED] 34 VFs
[12:11:30] [PASSED] 35 VFs
[12:11:30] [PASSED] 36 VFs
[12:11:30] [PASSED] 37 VFs
[12:11:30] [PASSED] 38 VFs
[12:11:30] [PASSED] 39 VFs
[12:11:30] [PASSED] 40 VFs
[12:11:30] [PASSED] 41 VFs
[12:11:30] [PASSED] 42 VFs
[12:11:30] [PASSED] 43 VFs
[12:11:30] [PASSED] 44 VFs
[12:11:30] [PASSED] 45 VFs
[12:11:30] [PASSED] 46 VFs
[12:11:30] [PASSED] 47 VFs
[12:11:30] [PASSED] 48 VFs
[12:11:30] [PASSED] 49 VFs
[12:11:30] [PASSED] 50 VFs
[12:11:30] [PASSED] 51 VFs
[12:11:30] [PASSED] 52 VFs
[12:11:30] [PASSED] 53 VFs
[12:11:30] [PASSED] 54 VFs
[12:11:30] [PASSED] 55 VFs
[12:11:30] [PASSED] 56 VFs
[12:11:30] [PASSED] 57 VFs
[12:11:30] [PASSED] 58 VFs
[12:11:30] [PASSED] 59 VFs
[12:11:30] [PASSED] 60 VFs
[12:11:30] [PASSED] 61 VFs
[12:11:30] [PASSED] 62 VFs
[12:11:30] [PASSED] 63 VFs
[12:11:30] ================= [PASSED] fair_doorbells ==================
[12:11:30] ======================== fair_ggtt  ========================
[12:11:30] [PASSED] 1 VF
[12:11:30] [PASSED] 2 VFs
[12:11:30] [PASSED] 3 VFs
[12:11:30] [PASSED] 4 VFs
[12:11:30] [PASSED] 5 VFs
[12:11:30] [PASSED] 6 VFs
[12:11:30] [PASSED] 7 VFs
[12:11:30] [PASSED] 8 VFs
[12:11:30] [PASSED] 9 VFs
[12:11:30] [PASSED] 10 VFs
[12:11:30] [PASSED] 11 VFs
[12:11:30] [PASSED] 12 VFs
[12:11:30] [PASSED] 13 VFs
[12:11:30] [PASSED] 14 VFs
[12:11:30] [PASSED] 15 VFs
[12:11:30] [PASSED] 16 VFs
[12:11:30] [PASSED] 17 VFs
[12:11:30] [PASSED] 18 VFs
[12:11:30] [PASSED] 19 VFs
[12:11:30] [PASSED] 20 VFs
[12:11:30] [PASSED] 21 VFs
[12:11:30] [PASSED] 22 VFs
[12:11:30] [PASSED] 23 VFs
[12:11:30] [PASSED] 24 VFs
[12:11:30] [PASSED] 25 VFs
[12:11:30] [PASSED] 26 VFs
[12:11:30] [PASSED] 27 VFs
[12:11:30] [PASSED] 28 VFs
[12:11:30] [PASSED] 29 VFs
[12:11:30] [PASSED] 30 VFs
[12:11:30] [PASSED] 31 VFs
[12:11:30] [PASSED] 32 VFs
[12:11:30] [PASSED] 33 VFs
[12:11:30] [PASSED] 34 VFs
[12:11:30] [PASSED] 35 VFs
[12:11:30] [PASSED] 36 VFs
[12:11:30] [PASSED] 37 VFs
[12:11:30] [PASSED] 38 VFs
[12:11:30] [PASSED] 39 VFs
[12:11:30] [PASSED] 40 VFs
[12:11:30] [PASSED] 41 VFs
[12:11:30] [PASSED] 42 VFs
[12:11:30] [PASSED] 43 VFs
[12:11:30] [PASSED] 44 VFs
[12:11:30] [PASSED] 45 VFs
[12:11:30] [PASSED] 46 VFs
[12:11:30] [PASSED] 47 VFs
[12:11:30] [PASSED] 48 VFs
[12:11:30] [PASSED] 49 VFs
[12:11:30] [PASSED] 50 VFs
[12:11:30] [PASSED] 51 VFs
[12:11:30] [PASSED] 52 VFs
[12:11:30] [PASSED] 53 VFs
[12:11:30] [PASSED] 54 VFs
[12:11:30] [PASSED] 55 VFs
[12:11:30] [PASSED] 56 VFs
[12:11:30] [PASSED] 57 VFs
[12:11:30] [PASSED] 58 VFs
[12:11:30] [PASSED] 59 VFs
[12:11:30] [PASSED] 60 VFs
[12:11:30] [PASSED] 61 VFs
[12:11:30] [PASSED] 62 VFs
[12:11:30] [PASSED] 63 VFs
[12:11:30] ==================== [PASSED] fair_ggtt ====================
[12:11:30] ======================== fair_vram  ========================
[12:11:30] [PASSED] 1 VF
[12:11:30] [PASSED] 2 VFs
[12:11:30] [PASSED] 3 VFs
[12:11:30] [PASSED] 4 VFs
[12:11:30] [PASSED] 5 VFs
[12:11:30] [PASSED] 6 VFs
[12:11:30] [PASSED] 7 VFs
[12:11:30] [PASSED] 8 VFs
[12:11:30] [PASSED] 9 VFs
[12:11:30] [PASSED] 10 VFs
[12:11:30] [PASSED] 11 VFs
[12:11:30] [PASSED] 12 VFs
[12:11:30] [PASSED] 13 VFs
[12:11:30] [PASSED] 14 VFs
[12:11:30] [PASSED] 15 VFs
[12:11:30] [PASSED] 16 VFs
[12:11:30] [PASSED] 17 VFs
[12:11:30] [PASSED] 18 VFs
[12:11:30] [PASSED] 19 VFs
[12:11:30] [PASSED] 20 VFs
[12:11:30] [PASSED] 21 VFs
[12:11:30] [PASSED] 22 VFs
[12:11:30] [PASSED] 23 VFs
[12:11:30] [PASSED] 24 VFs
[12:11:30] [PASSED] 25 VFs
[12:11:30] [PASSED] 26 VFs
[12:11:30] [PASSED] 27 VFs
[12:11:30] [PASSED] 28 VFs
[12:11:30] [PASSED] 29 VFs
[12:11:30] [PASSED] 30 VFs
[12:11:30] [PASSED] 31 VFs
[12:11:30] [PASSED] 32 VFs
[12:11:30] [PASSED] 33 VFs
[12:11:30] [PASSED] 34 VFs
[12:11:30] [PASSED] 35 VFs
[12:11:30] [PASSED] 36 VFs
[12:11:30] [PASSED] 37 VFs
[12:11:30] [PASSED] 38 VFs
[12:11:30] [PASSED] 39 VFs
[12:11:30] [PASSED] 40 VFs
[12:11:30] [PASSED] 41 VFs
[12:11:30] [PASSED] 42 VFs
[12:11:30] [PASSED] 43 VFs
[12:11:30] [PASSED] 44 VFs
[12:11:30] [PASSED] 45 VFs
[12:11:30] [PASSED] 46 VFs
[12:11:30] [PASSED] 47 VFs
[12:11:30] [PASSED] 48 VFs
[12:11:30] [PASSED] 49 VFs
[12:11:30] [PASSED] 50 VFs
[12:11:30] [PASSED] 51 VFs
[12:11:30] [PASSED] 52 VFs
[12:11:30] [PASSED] 53 VFs
[12:11:30] [PASSED] 54 VFs
[12:11:30] [PASSED] 55 VFs
[12:11:30] [PASSED] 56 VFs
[12:11:30] [PASSED] 57 VFs
[12:11:30] [PASSED] 58 VFs
[12:11:30] [PASSED] 59 VFs
[12:11:30] [PASSED] 60 VFs
[12:11:30] [PASSED] 61 VFs
[12:11:30] [PASSED] 62 VFs
[12:11:30] [PASSED] 63 VFs
[12:11:30] ==================== [PASSED] fair_vram ====================
[12:11:30] ================== [PASSED] pf_gt_config ===================
[12:11:30] ===================== lmtt (1 subtest) =====================
[12:11:30] ======================== test_ops  =========================
[12:11:30] [PASSED] 2-level
[12:11:30] [PASSED] multi-level
[12:11:30] ==================== [PASSED] test_ops =====================
[12:11:30] ====================== [PASSED] lmtt =======================
[12:11:30] ================= sriov_packet (1 subtest) =================
[12:11:30] [PASSED] test_descriptor_init
[12:11:30] ================== [PASSED] sriov_packet ===================
[12:11:30] ================= pf_service (11 subtests) =================
[12:11:30] [PASSED] pf_negotiate_any
[12:11:30] [PASSED] pf_negotiate_base_match
[12:11:30] [PASSED] pf_negotiate_base_newer
[12:11:30] [PASSED] pf_negotiate_base_next
[12:11:30] [SKIPPED] pf_negotiate_base_older (no older minor)
[12:11:30] [PASSED] pf_negotiate_base_prev
[12:11:30] [PASSED] pf_negotiate_latest_match
[12:11:30] [PASSED] pf_negotiate_latest_newer
[12:11:30] [PASSED] pf_negotiate_latest_next
[12:11:30] [SKIPPED] pf_negotiate_latest_older (no older minor)
[12:11:30] [SKIPPED] pf_negotiate_latest_prev (no prev major)
[12:11:30] =================== [PASSED] pf_service ====================
[12:11:30] ================= xe_guc_g2g (2 subtests) ==================
[12:11:30] ============== xe_live_guc_g2g_kunit_default  ==============
[12:11:30] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[12:11:30] ============== xe_live_guc_g2g_kunit_allmem  ===============
[12:11:30] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[12:11:30] =================== [SKIPPED] xe_guc_g2g ===================
[12:11:30] =================== xe_mocs (2 subtests) ===================
[12:11:30] ================ xe_live_mocs_kernel_kunit  ================
[12:11:30] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[12:11:30] ================ xe_live_mocs_reset_kunit  =================
[12:11:30] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[12:11:30] ==================== [SKIPPED] xe_mocs =====================
[12:11:30] ================= xe_migrate (2 subtests) ==================
[12:11:30] ================= xe_migrate_sanity_kunit  =================
[12:11:30] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[12:11:30] ================== xe_validate_ccs_kunit  ==================
[12:11:30] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[12:11:30] =================== [SKIPPED] xe_migrate ===================
[12:11:30] ================== xe_dma_buf (1 subtest) ==================
[12:11:30] ==================== xe_dma_buf_kunit  =====================
[12:11:30] ================ [SKIPPED] xe_dma_buf_kunit ================
[12:11:30] =================== [SKIPPED] xe_dma_buf ===================
[12:11:30] ================= xe_bo_shrink (1 subtest) =================
[12:11:30] =================== xe_bo_shrink_kunit  ====================
[12:11:30] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[12:11:30] ================== [SKIPPED] xe_bo_shrink ==================
[12:11:30] ==================== xe_bo (2 subtests) ====================
[12:11:30] ================== xe_ccs_migrate_kunit  ===================
[12:11:30] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[12:11:30] ==================== xe_bo_evict_kunit  ====================
[12:11:30] =============== [SKIPPED] xe_bo_evict_kunit ================
[12:11:30] ===================== [SKIPPED] xe_bo ======================
[12:11:30] =================== xe_any (9 subtests) ====================
[12:11:30] [PASSED] test_to_xe
[12:11:30] [PASSED] test_to_dev
[12:11:30] [PASSED] test_to_pdev
[12:11:30] [PASSED] test_to_drm
[12:11:30] [PASSED] test_if_pdev
[12:11:30] [PASSED] test_if_xe
[12:11:30] [PASSED] test_if_tile
[12:11:30] [PASSED] test_if_gt
[12:11:30] [PASSED] test_to_id
[12:11:30] ===================== [PASSED] xe_any ======================
[12:11:30] ==================== args (13 subtests) ====================
[12:11:30] [PASSED] count_args_test
[12:11:30] [PASSED] call_args_example
[12:11:30] [PASSED] call_args_test
[12:11:30] [PASSED] drop_first_arg_example
[12:11:30] [PASSED] drop_first_arg_test
[12:11:30] [PASSED] first_arg_example
[12:11:30] [PASSED] first_arg_test
[12:11:30] [PASSED] last_arg_example
[12:11:30] [PASSED] last_arg_test
[12:11:30] [PASSED] pick_arg_example
[12:11:30] [PASSED] if_args_example
[12:11:30] [PASSED] if_args_test
[12:11:30] [PASSED] sep_comma_example
[12:11:30] ====================== [PASSED] args =======================
[12:11:30] =================== xe_pci (3 subtests) ====================
[12:11:30] ==================== check_graphics_ip  ====================
[12:11:30] [PASSED] 12.00 Xe_LP
[12:11:30] [PASSED] 12.10 Xe_LP+
[12:11:30] [PASSED] 12.55 Xe_HPG
[12:11:30] [PASSED] 12.60 Xe_HPC
[12:11:30] [PASSED] 12.70 Xe_LPG
[12:11:30] [PASSED] 12.71 Xe_LPG
[12:11:30] [PASSED] 12.74 Xe_LPG+
[12:11:30] [PASSED] 20.01 Xe2_HPG
[12:11:30] [PASSED] 20.02 Xe2_HPG
[12:11:30] [PASSED] 20.04 Xe2_LPG
[12:11:30] [PASSED] 30.00 Xe3_LPG
[12:11:30] [PASSED] 30.01 Xe3_LPG
[12:11:30] [PASSED] 30.03 Xe3_LPG
[12:11:30] [PASSED] 30.04 Xe3_LPG
[12:11:30] [PASSED] 30.05 Xe3_LPG
[12:11:30] [PASSED] 35.10 Xe3p_LPG
[12:11:30] [PASSED] 35.11 Xe3p_XPC
[12:11:30] ================ [PASSED] check_graphics_ip ================
[12:11:30] ===================== check_media_ip  ======================
[12:11:30] [PASSED] 12.00 Xe_M
[12:11:30] [PASSED] 12.55 Xe_HPM
[12:11:30] [PASSED] 13.00 Xe_LPM+
[12:11:30] [PASSED] 13.01 Xe2_HPM
[12:11:30] [PASSED] 20.00 Xe2_LPM
[12:11:30] [PASSED] 30.00 Xe3_LPM
[12:11:30] [PASSED] 30.02 Xe3_LPM
[12:11:30] [PASSED] 35.00 Xe3p_LPM
[12:11:30] [PASSED] 35.03 Xe3p_HPM
[12:11:30] ================= [PASSED] check_media_ip ==================
[12:11:30] =================== check_platform_desc  ===================
[12:11:30] [PASSED] 0x9A60 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A68 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A70 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A40 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A49 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A59 (TIGERLAKE)
[12:11:30] [PASSED] 0x9A78 (TIGERLAKE)
[12:11:30] [PASSED] 0x9AC0 (TIGERLAKE)
[12:11:30] [PASSED] 0x9AC9 (TIGERLAKE)
[12:11:30] [PASSED] 0x9AD9 (TIGERLAKE)
[12:11:30] [PASSED] 0x9AF8 (TIGERLAKE)
[12:11:30] [PASSED] 0x4C80 (ROCKETLAKE)
[12:11:30] [PASSED] 0x4C8A (ROCKETLAKE)
[12:11:30] [PASSED] 0x4C8B (ROCKETLAKE)
[12:11:30] [PASSED] 0x4C8C (ROCKETLAKE)
[12:11:30] [PASSED] 0x4C90 (ROCKETLAKE)
[12:11:30] [PASSED] 0x4C9A (ROCKETLAKE)
[12:11:30] [PASSED] 0x4680 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4682 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4688 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x468A (ALDERLAKE_S)
[12:11:30] [PASSED] 0x468B (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4690 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4692 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4693 (ALDERLAKE_S)
[12:11:30] [PASSED] 0x46A0 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46A1 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46A2 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46A3 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46A6 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46A8 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46AA (ALDERLAKE_P)
[12:11:30] [PASSED] 0x462A (ALDERLAKE_P)
[12:11:30] [PASSED] 0x4626 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x4628 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46B0 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46B1 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46B2 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46B3 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46C0 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46C1 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46C2 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46C3 (ALDERLAKE_P)
[12:11:30] [PASSED] 0x46D0 (ALDERLAKE_N)
[12:11:30] [PASSED] 0x46D1 (ALDERLAKE_N)
[12:11:30] [PASSED] 0x46D2 (ALDERLAKE_N)
[12:11:30] [PASSED] 0x46D3 (ALDERLAKE_N)
[12:11:30] [PASSED] 0x46D4 (ALDERLAKE_N)
[12:11:30] [PASSED] 0xA721 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7A1 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7A9 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7AC (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7AD (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA720 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7A0 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7A8 (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7AA (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA7AB (ALDERLAKE_P)
[12:11:30] [PASSED] 0xA780 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA781 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA782 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA783 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA788 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA789 (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA78A (ALDERLAKE_S)
[12:11:30] [PASSED] 0xA78B (ALDERLAKE_S)
[12:11:30] [PASSED] 0x4905 (DG1)
[12:11:30] [PASSED] 0x4906 (DG1)
[12:11:30] [PASSED] 0x4907 (DG1)
[12:11:30] [PASSED] 0x4908 (DG1)
[12:11:30] [PASSED] 0x4909 (DG1)
[12:11:30] [PASSED] 0x56C0 (DG2)
[12:11:30] [PASSED] 0x56C2 (DG2)
[12:11:30] [PASSED] 0x56C1 (DG2)
[12:11:30] [PASSED] 0x7D51 (METEORLAKE)
[12:11:30] [PASSED] 0x7DD1 (METEORLAKE)
[12:11:30] [PASSED] 0x7D41 (METEORLAKE)
[12:11:30] [PASSED] 0x7D67 (METEORLAKE)
[12:11:30] [PASSED] 0xB640 (METEORLAKE)
[12:11:30] [PASSED] 0x56A0 (DG2)
[12:11:30] [PASSED] 0x56A1 (DG2)
[12:11:30] [PASSED] 0x56A2 (DG2)
[12:11:30] [PASSED] 0x56BE (DG2)
[12:11:30] [PASSED] 0x56BF (DG2)
[12:11:30] [PASSED] 0x5690 (DG2)
[12:11:30] [PASSED] 0x5691 (DG2)
[12:11:30] [PASSED] 0x5692 (DG2)
[12:11:30] [PASSED] 0x56A5 (DG2)
[12:11:30] [PASSED] 0x56A6 (DG2)
[12:11:30] [PASSED] 0x56B0 (DG2)
[12:11:30] [PASSED] 0x56B1 (DG2)
[12:11:30] [PASSED] 0x56BA (DG2)
[12:11:30] [PASSED] 0x56BB (DG2)
[12:11:30] [PASSED] 0x56BC (DG2)
[12:11:30] [PASSED] 0x56BD (DG2)
[12:11:30] [PASSED] 0x5693 (DG2)
[12:11:30] [PASSED] 0x5694 (DG2)
[12:11:30] [PASSED] 0x5695 (DG2)
[12:11:30] [PASSED] 0x56A3 (DG2)
[12:11:30] [PASSED] 0x56A4 (DG2)
[12:11:30] [PASSED] 0x56B2 (DG2)
[12:11:30] [PASSED] 0x56B3 (DG2)
[12:11:30] [PASSED] 0x5696 (DG2)
[12:11:30] [PASSED] 0x5697 (DG2)
[12:11:30] [PASSED] 0xB69 (PVC)
[12:11:30] [PASSED] 0xB6E (PVC)
[12:11:30] [PASSED] 0xBD4 (PVC)
[12:11:30] [PASSED] 0xBD5 (PVC)
[12:11:30] [PASSED] 0xBD6 (PVC)
[12:11:30] [PASSED] 0xBD7 (PVC)
[12:11:30] [PASSED] 0xBD8 (PVC)
[12:11:30] [PASSED] 0xBD9 (PVC)
[12:11:30] [PASSED] 0xBDA (PVC)
[12:11:30] [PASSED] 0xBDB (PVC)
[12:11:30] [PASSED] 0xBE0 (PVC)
[12:11:30] [PASSED] 0xBE1 (PVC)
[12:11:30] [PASSED] 0xBE5 (PVC)
[12:11:30] [PASSED] 0x7D40 (METEORLAKE)
[12:11:30] [PASSED] 0x7D45 (METEORLAKE)
[12:11:30] [PASSED] 0x7D55 (METEORLAKE)
[12:11:30] [PASSED] 0x7D60 (METEORLAKE)
[12:11:30] [PASSED] 0x7DD5 (METEORLAKE)
[12:11:30] [PASSED] 0x6420 (LUNARLAKE)
[12:11:30] [PASSED] 0x64A0 (LUNARLAKE)
[12:11:30] [PASSED] 0x64B0 (LUNARLAKE)
[12:11:30] [PASSED] 0xE202 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE209 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE20B (BATTLEMAGE)
[12:11:30] [PASSED] 0xE20C (BATTLEMAGE)
[12:11:30] [PASSED] 0xE20D (BATTLEMAGE)
[12:11:30] [PASSED] 0xE210 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE211 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE212 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE216 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE220 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE221 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE222 (BATTLEMAGE)
[12:11:30] [PASSED] 0xE223 (BATTLEMAGE)
[12:11:30] [PASSED] 0xB080 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB081 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB082 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB083 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB084 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB085 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB086 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB087 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB08F (PANTHERLAKE)
[12:11:30] [PASSED] 0xB090 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB0A0 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB0A1 (PANTHERLAKE)
[12:11:30] [PASSED] 0xB0B0 (PANTHERLAKE)
[12:11:30] [PASSED] 0xFD80 (PANTHERLAKE)
[12:11:30] [PASSED] 0xFD81 (PANTHERLAKE)
[12:11:30] [PASSED] 0xD740 (NOVALAKE_S)
[12:11:30] [PASSED] 0xD741 (NOVALAKE_S)
[12:11:30] [PASSED] 0xD742 (NOVALAKE_S)
[12:11:30] [PASSED] 0xD743 (NOVALAKE_S)
[12:11:30] [PASSED] 0xD745 (NOVALAKE_S)
[12:11:30] [PASSED] 0xD74A (NOVALAKE_S)
[12:11:30] [PASSED] 0xD74B (NOVALAKE_S)
[12:11:30] [PASSED] 0x674C (CRESCENTISLAND)
[12:11:30] [PASSED] 0x674D (CRESCENTISLAND)
[12:11:30] [PASSED] 0x674E (CRESCENTISLAND)
[12:11:30] [PASSED] 0x674F (CRESCENTISLAND)
[12:11:30] [PASSED] 0x6750 (CRESCENTISLAND)
[12:11:30] [PASSED] 0x6751 (CRESCENTISLAND)
[12:11:30] [PASSED] 0xD750 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD751 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD752 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD753 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD754 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD755 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD756 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD757 (NOVALAKE_P)
[12:11:30] [PASSED] 0xD75F (NOVALAKE_P)
[12:11:30] =============== [PASSED] check_platform_desc ===============
[12:11:30] ===================== [PASSED] xe_pci ======================
[12:11:30] ============= xe_rtp_tables_test (5 subtests) ==============
[12:11:30] ================== xe_rtp_table_gt_test  ===================
[12:11:30] [PASSED] gt_was/14011060649
[12:11:30] [PASSED] gt_was/14011059788
[12:11:30] [PASSED] gt_was/14015795083
[12:11:30] [PASSED] gt_was/16021867713
[12:11:30] [PASSED] gt_was/14019449301
[12:11:30] [PASSED] gt_was/16028005424
[12:11:30] [PASSED] gt_was/14026578760
[12:11:30] [PASSED] gt_was/1409420604
[12:11:30] [PASSED] gt_was/1408615072
[12:11:30] [PASSED] gt_was/22010523718
[12:11:30] [PASSED] gt_was/14011006942
[12:11:30] [PASSED] gt_was/14014830051
[12:11:30] [PASSED] gt_was/18018781329
[12:11:30] [PASSED] gt_was/1509235366
[12:11:30] [PASSED] gt_was/18018781329
[12:11:30] [PASSED] gt_was/16016694945
[12:11:30] [PASSED] gt_was/14018575942
[12:11:30] [PASSED] gt_was/22016670082
[12:11:30] [PASSED] gt_was/22016670082
[12:11:30] [PASSED] gt_was/14017421178
[12:11:30] [PASSED] gt_was/16025250150
[12:11:30] [PASSED] gt_was/14021871409
[12:11:30] [PASSED] gt_was/16021865536
[12:11:30] [PASSED] gt_was/14021486841
[12:11:30] [PASSED] gt_was/14025160223
[12:11:30] [PASSED] gt_was/14026144927, 16029437861, 14026127056
[12:11:30] [PASSED] gt_was/14025635424
[12:11:30] [PASSED] gt_was/16028005424
[12:11:30] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:11:30] ================== xe_rtp_table_gt_test  ===================
[12:11:30] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable
[12:11:30] [PASSED] gt_tunings/Tuning: 32B Access Enable
[12:11:30] [PASSED] gt_tunings/Tuning: L3 cache
[12:11:30] [PASSED] gt_tunings/Tuning: L3 cache - media
[12:11:30] [PASSED] gt_tunings/Tuning: Compression Overfetch
[12:11:30] [PASSED] gt_tunings/Tuning: Compression Overfetch - media
[12:11:30] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3
[12:11:30] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media
[12:11:30] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only
[12:11:30] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media
[12:11:30] [PASSED] gt_tunings/Tuning: Stateless compression control
[12:11:30] [PASSED] gt_tunings/Tuning: Stateless compression control - media
[12:11:30] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache
[12:11:30] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media
[12:11:30] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB
[12:11:30] [PASSED] gt_tunings/Tuning: Force All Non-Compressible Memory Reads to be 256B Overfetches
[12:11:30] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:11:30] ================== xe_rtp_table_oob_test  ==================
[12:11:30] [PASSED] oob_was/1607983814
[12:11:30] [PASSED] oob_was/16010904313
[12:11:30] [PASSED] oob_was/18022495364
[12:11:30] [PASSED] oob_was/22012773006
[12:11:30] [PASSED] oob_was/14014475959
[12:11:30] [PASSED] oob_was/22011391025
[12:11:30] [PASSED] oob_was/22012727170
[12:11:30] [PASSED] oob_was/22012727685
[12:11:30] [PASSED] oob_was/22016596838
[12:11:30] [PASSED] oob_was/18020744125
[12:11:30] [PASSED] oob_was/1409600907
[12:11:30] [PASSED] oob_was/22014953428
[12:11:30] [PASSED] oob_was/16017236439
[12:11:30] [PASSED] oob_was/14019821291
[12:11:30] [PASSED] oob_was/14015076503
[12:11:30] [PASSED] oob_was/22016122933
[12:11:30] [PASSED] oob_was/14018913170
[12:11:30] [PASSED] oob_was/14018094691
[12:11:30] [PASSED] oob_was/18024947630
[12:11:30] [PASSED] oob_was/16022287689
[12:11:30] [PASSED] oob_was/13011645652
[12:11:30] [PASSED] oob_was/14022293748
[12:11:30] [PASSED] oob_was/22019794406
[12:11:30] [PASSED] oob_was/22019338487
[12:11:30] [PASSED] oob_was/16023588340
[12:11:30] [PASSED] oob_was/14019789679
[12:11:30] [PASSED] oob_was/14022866841
[12:11:30] [PASSED] oob_was/16021333562
[12:11:30] [PASSED] oob_was/14016712196
[12:11:30] [PASSED] oob_was/14015568240
[12:11:30] [PASSED] oob_was/18013179988
[12:11:30] [PASSED] oob_was/1508761755
[12:11:30] [PASSED] oob_was/16023105232
[12:11:30] [PASSED] oob_was/16026508708
[12:11:30] [PASSED] oob_was/14020001231
[12:11:30] [PASSED] oob_was/16023683509
[12:11:30] [PASSED] oob_was/14025515070
[12:11:30] [PASSED] oob_was/15015404425_disable
[12:11:30] [PASSED] oob_was/16026007364
[12:11:30] [PASSED] oob_was/14020316580
[12:11:30] [PASSED] oob_was/14025883347
[12:11:30] [PASSED] oob_was/16029380221
[12:11:30] [PASSED] oob_was/22022079272
[12:11:30] [PASSED] oob_was/16029897822
[12:11:30] [PASSED] oob_was/14027054324
[12:11:30] [PASSED] oob_was/14025941587
[12:11:30] [PASSED] oob_was/16030224309
[12:11:30] ============== [PASSED] xe_rtp_table_oob_test ==============
[12:11:30] ================ xe_rtp_table_dev_oob_test  ================
[12:11:30] [PASSED] device_oob_was/22010954014
[12:11:30] [PASSED] device_oob_was/15015404425
[12:11:30] [PASSED] device_oob_was/22019338487_display
[12:11:30] [PASSED] device_oob_was/14022085890
[12:11:30] [PASSED] device_oob_was/14026539277
[12:11:30] [PASSED] device_oob_was/14026633728
[12:11:30] [PASSED] device_oob_was/14026746987
[12:11:30] [PASSED] device_oob_was/14026779378
[12:11:30] ============ [PASSED] xe_rtp_table_dev_oob_test ============
[12:11:30] ========== xe_rtp_table_missing_upper_bound_test  ==========
[12:11:30] [PASSED] register_whitelist/WaAllowPMDepthAndInvocationCountAccessFromUMD, 1408556865
[12:11:30] [PASSED] register_whitelist/1508744258, 14012131227, 1808121037
[12:11:30] [PASSED] register_whitelist/1806527549
[12:11:30] [PASSED] register_whitelist/allow_read_ctx_timestamp
[12:11:30] [PASSED] register_whitelist/allow_read_queue_timestamp
[12:11:30] [PASSED] register_whitelist/16014440446
[12:11:30] [PASSED] register_whitelist/16017236439
[12:11:30] [PASSED] register_whitelist/16020183090
[12:11:30] [PASSED] register_whitelist/14024997852
[12:11:30] [PASSED] register_whitelist/14024997852
[12:11:30] ====== [PASSED] xe_rtp_table_missing_upper_bound_test ======
[12:11:30] =============== [PASSED] xe_rtp_tables_test ================
[12:11:30] =================== xe_rtp (3 subtests) ====================
[12:11:30] =================== xe_rtp_rules_tests  ====================
[12:11:30] [PASSED] no
[12:11:30] [PASSED] yes
[12:11:30] [PASSED] no-and-no
[12:11:30] [PASSED] no-and-yes
[12:11:30] [PASSED] yes-and-no
[12:11:30] [PASSED] yes-and-yes
[12:11:30] [PASSED] no-or-no
[12:11:30] [PASSED] no-or-yes
[12:11:30] [PASSED] yes-or-no
[12:11:30] [PASSED] yes-or-yes
[12:11:30] [PASSED] no-yes-or-yes-no
[12:11:30] [PASSED] no-yes-or-yes-yes
[12:11:30] [PASSED] yes-yes-or-no-yes
[12:11:30] [PASSED] yes-yes-or-yes-yes
[12:11:30] [PASSED] no-no-or-yes-or-no
[12:11:30] [PASSED] or
[12:11:30] [PASSED] or-yes
[12:11:30] [PASSED] or-no
[12:11:30] [PASSED] yes-or
[12:11:30] [PASSED] no-or
[12:11:30] [PASSED] no-or-or-yes
[12:11:30] [PASSED] yes-or-or-no
[12:11:30] [PASSED] no-or-or-no
[12:11:30] [PASSED] missing-context-engine-class
[12:11:30] [PASSED] missing-context-engine-class-or-yes
[12:11:30] [PASSED] missing-context-engine-class-or-or-yes
[12:11:30] =============== [PASSED] xe_rtp_rules_tests ================
[12:11:30] =============== xe_rtp_process_to_sr_tests  ================
[12:11:30] [PASSED] coalesce-same-reg
[12:11:30] [PASSED] coalesce-same-reg-literal-and-func
[12:11:30] [PASSED] no-match-no-add
[12:11:30] [PASSED] two-regs-two-entries
[12:11:30] [PASSED] clr-one-set-other
[12:11:30] [PASSED] set-field
[12:11:30] [PASSED] conflict-duplicate
[12:11:30] [PASSED] conflict-not-disjoint
[12:11:30] [PASSED] conflict-not-disjoint-literal-and-func
[12:11:30] [PASSED] conflict-reg-type
[12:11:30] [PASSED] bad-mcr-reg-forced-to-regular
[12:11:30] [PASSED] bad-regular-reg-forced-to-mcr
[12:11:30] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[12:11:30] ================== xe_rtp_process_tests  ===================
[12:11:30] [PASSED] active1
[12:11:30] [PASSED] active2
[12:11:30] [PASSED] active-inactive
[12:11:30] [PASSED] inactive-active
[12:11:30] [PASSED] inactive-active-inactive
[12:11:30] [PASSED] inactive-inactive-inactive
[12:11:30] ============== [PASSED] xe_rtp_process_tests ===============
[12:11:30] ===================== [PASSED] xe_rtp ======================
[12:11:30] ==================== xe_wa (1 subtest) =====================
[12:11:30] ======================== xe_wa_gt  =========================
[12:11:30] [PASSED] TIGERLAKE B0
[12:11:30] [PASSED] DG1 A0
[12:11:30] [PASSED] DG1 B0
[12:11:30] [PASSED] ALDERLAKE_S A0
[12:11:30] [PASSED] ALDERLAKE_S B0
[12:11:30] [PASSED] ALDERLAKE_S C0
[12:11:30] [PASSED] ALDERLAKE_S D0
[12:11:30] [PASSED] ALDERLAKE_P A0
[12:11:30] [PASSED] ALDERLAKE_P B0
[12:11:30] [PASSED] ALDERLAKE_P C0
[12:11:30] [PASSED] ALDERLAKE_S RPLS D0
[12:11:30] [PASSED] ALDERLAKE_P RPLU E0
[12:11:30] [PASSED] DG2 G10 C0
[12:11:30] [PASSED] DG2 G11 B1
[12:11:30] [PASSED] DG2 G12 A1
[12:11:30] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:11:30] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:11:30] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[12:11:30] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[12:11:30] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[12:11:30] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[12:11:30] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[12:11:30] ==================== [PASSED] xe_wa_gt =====================
[12:11:30] ====================== [PASSED] xe_wa ======================
[12:11:30] ============================================================
[12:11:30] Testing complete. Ran 821 tests: passed: 793, skipped: 28
[12:11:30] Elapsed time: 37.048s total, 1.849s configuring, 34.481s building, 0.710s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[12:11:30] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:11:32] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:11:57] Starting KUnit Kernel (1/1)...
[12:11:57] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:11:57] ============ drm_test_pick_cmdline (2 subtests) ============
[12:11:57] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[12:11:57] =============== drm_test_pick_cmdline_named  ===============
[12:11:57] [PASSED] NTSC
[12:11:57] [PASSED] NTSC-J
[12:11:57] [PASSED] PAL
[12:11:57] [PASSED] PAL-M
[12:11:57] =========== [PASSED] drm_test_pick_cmdline_named ===========
[12:11:57] ============== [PASSED] drm_test_pick_cmdline ==============
[12:11:57] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[12:11:57] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[12:11:57] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[12:11:57] =========== drm_validate_clone_mode (2 subtests) ===========
[12:11:57] ============== drm_test_check_in_clone_mode  ===============
[12:11:57] [PASSED] in_clone_mode
[12:11:57] [PASSED] not_in_clone_mode
[12:11:57] ========== [PASSED] drm_test_check_in_clone_mode ===========
[12:11:57] =============== drm_test_check_valid_clones  ===============
[12:11:57] [PASSED] not_in_clone_mode
[12:11:57] [PASSED] valid_clone
[12:11:57] [PASSED] invalid_clone
[12:11:57] =========== [PASSED] drm_test_check_valid_clones ===========
[12:11:57] ============= [PASSED] drm_validate_clone_mode =============
[12:11:57] ============= drm_validate_modeset (1 subtest) =============
[12:11:57] [PASSED] drm_test_check_connector_changed_modeset
[12:11:57] ============== [PASSED] drm_validate_modeset ===============
[12:11:57] ====== drm_test_bridge_get_current_state (1 subtest) =======
[12:11:57] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[12:11:57] ======== [PASSED] drm_test_bridge_get_current_state ========
[12:11:57] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[12:11:57] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[12:11:57] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[12:11:57] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts
[12:11:57] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[12:11:57] ============== drm_bridge_alloc (2 subtests) ===============
[12:11:57] [PASSED] drm_test_drm_bridge_alloc_basic
[12:11:57] [PASSED] drm_test_drm_bridge_alloc_get_put
[12:11:57] ================ [PASSED] drm_bridge_alloc =================
[12:11:57] ============= drm_bridge_bus_fmt (5 subtests) ==============
[12:11:57] [PASSED] drm_test_bridge_rgb_yuv_rgb
[12:11:57] [PASSED] drm_test_bridge_must_convert_to_yuv444
[12:11:57] [PASSED] drm_test_bridge_hdmi_auto_rgb
[12:11:57] [PASSED] drm_test_bridge_auto_first
[12:11:57] [PASSED] drm_test_bridge_rgb_yuv_no_path
[12:11:57] =============== [PASSED] drm_bridge_bus_fmt ================
[12:11:57] ============= drm_cmdline_parser (40 subtests) =============
[12:11:57] [PASSED] drm_test_cmdline_force_d_only
[12:11:57] [PASSED] drm_test_cmdline_force_D_only_dvi
[12:11:57] [PASSED] drm_test_cmdline_force_D_only_hdmi
[12:11:57] [PASSED] drm_test_cmdline_force_D_only_not_digital
[12:11:57] [PASSED] drm_test_cmdline_force_e_only
[12:11:57] [PASSED] drm_test_cmdline_res
[12:11:57] [PASSED] drm_test_cmdline_res_vesa
[12:11:57] [PASSED] drm_test_cmdline_res_vesa_rblank
[12:11:57] [PASSED] drm_test_cmdline_res_rblank
[12:11:57] [PASSED] drm_test_cmdline_res_bpp
[12:11:57] [PASSED] drm_test_cmdline_res_refresh
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[12:11:57] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[12:11:57] [PASSED] drm_test_cmdline_res_margins_force_on
[12:11:57] [PASSED] drm_test_cmdline_res_vesa_margins
[12:11:57] [PASSED] drm_test_cmdline_name
[12:11:57] [PASSED] drm_test_cmdline_name_bpp
[12:11:57] [PASSED] drm_test_cmdline_name_option
[12:11:57] [PASSED] drm_test_cmdline_name_bpp_option
[12:11:57] [PASSED] drm_test_cmdline_rotate_0
[12:11:57] [PASSED] drm_test_cmdline_rotate_90
[12:11:57] [PASSED] drm_test_cmdline_rotate_180
[12:11:57] [PASSED] drm_test_cmdline_rotate_270
[12:11:57] [PASSED] drm_test_cmdline_hmirror
[12:11:57] [PASSED] drm_test_cmdline_vmirror
[12:11:57] [PASSED] drm_test_cmdline_margin_options
[12:11:57] [PASSED] drm_test_cmdline_multiple_options
[12:11:57] [PASSED] drm_test_cmdline_bpp_extra_and_option
[12:11:57] [PASSED] drm_test_cmdline_extra_and_option
[12:11:57] [PASSED] drm_test_cmdline_freestanding_options
[12:11:57] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[12:11:57] [PASSED] drm_test_cmdline_panel_orientation
[12:11:57] ================ drm_test_cmdline_invalid  =================
[12:11:57] [PASSED] margin_only
[12:11:57] [PASSED] interlace_only
[12:11:57] [PASSED] res_missing_x
[12:11:57] [PASSED] res_missing_y
[12:11:57] [PASSED] res_bad_y
[12:11:57] [PASSED] res_missing_y_bpp
[12:11:57] [PASSED] res_bad_bpp
[12:11:57] [PASSED] res_bad_refresh
[12:11:57] [PASSED] res_bpp_refresh_force_on_off
[12:11:57] [PASSED] res_invalid_mode
[12:11:57] [PASSED] res_bpp_wrong_place_mode
[12:11:57] [PASSED] name_bpp_refresh
[12:11:57] [PASSED] name_refresh
[12:11:57] [PASSED] name_refresh_wrong_mode
[12:11:57] [PASSED] name_refresh_invalid_mode
[12:11:57] [PASSED] rotate_multiple
[12:11:57] [PASSED] rotate_invalid_val
[12:11:57] [PASSED] rotate_truncated
[12:11:57] [PASSED] invalid_option
[12:11:57] [PASSED] invalid_tv_option
[12:11:57] [PASSED] truncated_tv_option
[12:11:57] ============ [PASSED] drm_test_cmdline_invalid =============
[12:11:57] =============== drm_test_cmdline_tv_options  ===============
[12:11:57] [PASSED] NTSC
[12:11:57] [PASSED] NTSC_443
[12:11:57] [PASSED] NTSC_J
[12:11:57] [PASSED] PAL
[12:11:57] [PASSED] PAL_M
[12:11:57] [PASSED] PAL_N
[12:11:57] [PASSED] SECAM
[12:11:57] [PASSED] MONO_525
[12:11:57] [PASSED] MONO_625
[12:11:57] =========== [PASSED] drm_test_cmdline_tv_options ===========
[12:11:57] =============== [PASSED] drm_cmdline_parser ================
[12:11:57] ========== drmm_connector_hdmi_init (20 subtests) ==========
[12:11:57] [PASSED] drm_test_connector_hdmi_init_valid
[12:11:57] [PASSED] drm_test_connector_hdmi_init_bpc_8
[12:11:57] [PASSED] drm_test_connector_hdmi_init_bpc_10
[12:11:57] [PASSED] drm_test_connector_hdmi_init_bpc_12
[12:11:57] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[12:11:57] [PASSED] drm_test_connector_hdmi_init_bpc_null
[12:11:57] [PASSED] drm_test_connector_hdmi_init_formats_empty
[12:11:57] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[12:11:57] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[12:11:57] [PASSED] supported_formats=0x9 yuv420_allowed=1
[12:11:57] [PASSED] supported_formats=0x9 yuv420_allowed=0
[12:11:57] [PASSED] supported_formats=0x5 yuv420_allowed=1
[12:11:57] [PASSED] supported_formats=0x5 yuv420_allowed=0
[12:11:57] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[12:11:57] [PASSED] drm_test_connector_hdmi_init_null_ddc
[12:11:57] [PASSED] drm_test_connector_hdmi_init_null_product
[12:11:57] [PASSED] drm_test_connector_hdmi_init_null_vendor
[12:11:57] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[12:11:57] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[12:11:57] [PASSED] drm_test_connector_hdmi_init_product_valid
[12:11:57] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[12:11:57] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[12:11:57] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[12:11:57] ========= drm_test_connector_hdmi_init_type_valid  =========
[12:11:57] [PASSED] HDMI-A
[12:11:57] [PASSED] HDMI-B
[12:11:57] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[12:11:57] ======== drm_test_connector_hdmi_init_type_invalid  ========
[12:11:57] [PASSED] Unknown
[12:11:57] [PASSED] VGA
[12:11:57] [PASSED] DVI-I
[12:11:57] [PASSED] DVI-D
[12:11:57] [PASSED] DVI-A
[12:11:57] [PASSED] Composite
[12:11:57] [PASSED] SVIDEO
[12:11:57] [PASSED] LVDS
[12:11:57] [PASSED] Component
[12:11:57] [PASSED] DIN
[12:11:57] [PASSED] DP
[12:11:57] [PASSED] TV
[12:11:57] [PASSED] eDP
[12:11:57] [PASSED] Virtual
[12:11:57] [PASSED] DSI
[12:11:57] [PASSED] DPI
[12:11:57] [PASSED] Writeback
[12:11:57] [PASSED] SPI
[12:11:57] [PASSED] USB
[12:11:57] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[12:11:57] ============ [PASSED] drmm_connector_hdmi_init =============
[12:11:57] ============= drmm_connector_init (3 subtests) =============
[12:11:57] [PASSED] drm_test_drmm_connector_init
[12:11:57] [PASSED] drm_test_drmm_connector_init_null_ddc
[12:11:57] ========= drm_test_drmm_connector_init_type_valid  =========
[12:11:57] [PASSED] Unknown
[12:11:57] [PASSED] VGA
[12:11:57] [PASSED] DVI-I
[12:11:57] [PASSED] DVI-D
[12:11:57] [PASSED] DVI-A
[12:11:57] [PASSED] Composite
[12:11:57] [PASSED] SVIDEO
[12:11:57] [PASSED] LVDS
[12:11:57] [PASSED] Component
[12:11:57] [PASSED] DIN
[12:11:57] [PASSED] DP
[12:11:57] [PASSED] HDMI-A
[12:11:57] [PASSED] HDMI-B
[12:11:57] [PASSED] TV
[12:11:57] [PASSED] eDP
[12:11:57] [PASSED] Virtual
[12:11:57] [PASSED] DSI
[12:11:57] [PASSED] DPI
[12:11:57] [PASSED] Writeback
[12:11:57] [PASSED] SPI
[12:11:57] [PASSED] USB
[12:11:57] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[12:11:57] =============== [PASSED] drmm_connector_init ===============
[12:11:57] ========= drm_connector_dynamic_init (6 subtests) ==========
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_init
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_init_properties
[12:11:57] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[12:11:57] [PASSED] Unknown
[12:11:57] [PASSED] VGA
[12:11:57] [PASSED] DVI-I
[12:11:57] [PASSED] DVI-D
[12:11:57] [PASSED] DVI-A
[12:11:57] [PASSED] Composite
[12:11:57] [PASSED] SVIDEO
[12:11:57] [PASSED] LVDS
[12:11:57] [PASSED] Component
[12:11:57] [PASSED] DIN
[12:11:57] [PASSED] DP
[12:11:57] [PASSED] HDMI-A
[12:11:57] [PASSED] HDMI-B
[12:11:57] [PASSED] TV
[12:11:57] [PASSED] eDP
[12:11:57] [PASSED] Virtual
[12:11:57] [PASSED] DSI
[12:11:57] [PASSED] DPI
[12:11:57] [PASSED] Writeback
[12:11:57] [PASSED] SPI
[12:11:57] [PASSED] USB
[12:11:57] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[12:11:57] ======== drm_test_drm_connector_dynamic_init_name  =========
[12:11:57] [PASSED] Unknown
[12:11:57] [PASSED] VGA
[12:11:57] [PASSED] DVI-I
[12:11:57] [PASSED] DVI-D
[12:11:57] [PASSED] DVI-A
[12:11:57] [PASSED] Composite
[12:11:57] [PASSED] SVIDEO
[12:11:57] [PASSED] LVDS
[12:11:57] [PASSED] Component
[12:11:57] [PASSED] DIN
[12:11:57] [PASSED] DP
[12:11:57] [PASSED] HDMI-A
[12:11:57] [PASSED] HDMI-B
[12:11:57] [PASSED] TV
[12:11:57] [PASSED] eDP
[12:11:57] [PASSED] Virtual
[12:11:57] [PASSED] DSI
[12:11:57] [PASSED] DPI
[12:11:57] [PASSED] Writeback
[12:11:57] [PASSED] SPI
[12:11:57] [PASSED] USB
[12:11:57] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[12:11:57] =========== [PASSED] drm_connector_dynamic_init ============
[12:11:57] ==== drm_connector_dynamic_register_early (4 subtests) =====
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[12:11:57] ====== [PASSED] drm_connector_dynamic_register_early =======
[12:11:57] ======= drm_connector_dynamic_register (7 subtests) ========
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[12:11:57] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[12:11:57] ========= [PASSED] drm_connector_dynamic_register ==========
[12:11:57] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[12:11:57] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[12:11:57] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[12:11:57] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[12:11:57] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[12:11:57] ========== drm_test_get_tv_mode_from_name_valid  ===========
[12:11:57] [PASSED] NTSC
[12:11:57] [PASSED] NTSC-443
[12:11:57] [PASSED] NTSC-J
[12:11:57] [PASSED] PAL
[12:11:57] [PASSED] PAL-M
[12:11:57] [PASSED] PAL-N
[12:11:57] [PASSED] SECAM
[12:11:57] [PASSED] Mono
[12:11:57] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[12:11:57] [PASSED] drm_test_get_tv_mode_from_name_truncated
[12:11:57] ============ [PASSED] drm_get_tv_mode_from_name ============
[12:11:57] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[12:11:57] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[12:11:57] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[12:11:57] [PASSED] VIC 96
[12:11:57] [PASSED] VIC 97
[12:11:57] [PASSED] VIC 101
[12:11:57] [PASSED] VIC 102
[12:11:57] [PASSED] VIC 106
[12:11:57] [PASSED] VIC 107
[12:11:57] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[12:11:57] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[12:11:57] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[12:11:57] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[12:11:57] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[12:11:57] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[12:11:57] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[12:11:57] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[12:11:57] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[12:11:57] [PASSED] Automatic
[12:11:57] [PASSED] Full
[12:11:57] [PASSED] Limited 16:235
[12:11:57] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[12:11:57] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[12:11:57] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[12:11:57] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[12:11:57] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[12:11:57] [PASSED] RGB
[12:11:57] [PASSED] YUV 4:2:0
[12:11:57] [PASSED] YUV 4:2:2
[12:11:57] [PASSED] YUV 4:4:4
[12:11:57] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[12:11:57] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[12:11:57] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[12:11:57] ============= drm_damage_helper (21 subtests) ==============
[12:11:57] [PASSED] drm_test_damage_iter_no_damage
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_src_moved
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_not_visible
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[12:11:57] [PASSED] drm_test_damage_iter_no_damage_no_fb
[12:11:57] [PASSED] drm_test_damage_iter_simple_damage
[12:11:57] [PASSED] drm_test_damage_iter_single_damage
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_outside_src
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_src_moved
[12:11:57] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[12:11:57] [PASSED] drm_test_damage_iter_damage
[12:11:57] [PASSED] drm_test_damage_iter_damage_one_intersect
[12:11:57] [PASSED] drm_test_damage_iter_damage_one_outside
[12:11:57] [PASSED] drm_test_damage_iter_damage_src_moved
[12:11:57] [PASSED] drm_test_damage_iter_damage_not_visible
[12:11:57] ================ [PASSED] drm_damage_helper ================
[12:11:57] ============== drm_dp_mst_helper (3 subtests) ==============
[12:11:57] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[12:11:57] [PASSED] Clock 154000 BPP 30 DSC disabled
[12:11:57] [PASSED] Clock 234000 BPP 30 DSC disabled
[12:11:57] [PASSED] Clock 297000 BPP 24 DSC disabled
[12:11:57] [PASSED] Clock 332880 BPP 24 DSC enabled
[12:11:57] [PASSED] Clock 324540 BPP 24 DSC enabled
[12:11:57] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[12:11:57] ============== drm_test_dp_mst_calc_pbn_div  ===============
[12:11:57] [PASSED] Link rate 2000000 lane count 4
[12:11:57] [PASSED] Link rate 2000000 lane count 2
[12:11:57] [PASSED] Link rate 2000000 lane count 1
[12:11:57] [PASSED] Link rate 1350000 lane count 4
[12:11:57] [PASSED] Link rate 1350000 lane count 2
[12:11:57] [PASSED] Link rate 1350000 lane count 1
[12:11:57] [PASSED] Link rate 1000000 lane count 4
[12:11:57] [PASSED] Link rate 1000000 lane count 2
[12:11:57] [PASSED] Link rate 1000000 lane count 1
[12:11:57] [PASSED] Link rate 810000 lane count 4
[12:11:57] [PASSED] Link rate 810000 lane count 2
[12:11:57] [PASSED] Link rate 810000 lane count 1
[12:11:57] [PASSED] Link rate 540000 lane count 4
[12:11:57] [PASSED] Link rate 540000 lane count 2
[12:11:57] [PASSED] Link rate 540000 lane count 1
[12:11:57] [PASSED] Link rate 270000 lane count 4
[12:11:57] [PASSED] Link rate 270000 lane count 2
[12:11:57] [PASSED] Link rate 270000 lane count 1
[12:11:57] [PASSED] Link rate 162000 lane count 4
[12:11:57] [PASSED] Link rate 162000 lane count 2
[12:11:57] [PASSED] Link rate 162000 lane count 1
[12:11:57] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[12:11:57] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[12:11:57] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[12:11:57] [PASSED] DP_POWER_UP_PHY with port number
[12:11:57] [PASSED] DP_POWER_DOWN_PHY with port number
[12:11:57] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[12:11:57] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[12:11:57] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[12:11:57] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[12:11:57] [PASSED] DP_QUERY_PAYLOAD with port number
[12:11:57] [PASSED] DP_QUERY_PAYLOAD with VCPI
[12:11:57] [PASSED] DP_REMOTE_DPCD_READ with port number
[12:11:57] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[12:11:57] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[12:11:57] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[12:11:57] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[12:11:57] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[12:11:57] [PASSED] DP_REMOTE_I2C_READ with port number
[12:11:57] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[12:11:57] [PASSED] DP_REMOTE_I2C_READ with transactions array
[12:11:57] [PASSED] DP_REMOTE_I2C_WRITE with port number
[12:11:57] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[12:11:57] [PASSED] DP_REMOTE_I2C_WRITE with data array
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[12:11:57] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[12:11:57] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[12:11:57] ================ [PASSED] drm_dp_mst_helper ================
[12:11:57] ================== drm_exec (7 subtests) ===================
[12:11:57] [PASSED] sanitycheck
[12:11:57] [PASSED] test_lock
[12:11:57] [PASSED] test_lock_unlock
[12:11:57] [PASSED] test_duplicates
[12:11:57] [PASSED] test_prepare
[12:11:57] [PASSED] test_prepare_array
[12:11:57] [PASSED] test_multiple_loops
[12:11:57] ==================== [PASSED] drm_exec =====================
[12:11:57] =========== drm_format_helper_test (17 subtests) ===========
[12:11:57] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[12:11:57] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[12:11:57] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[12:11:57] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[12:11:57] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[12:11:57] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[12:11:57] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[12:11:57] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[12:11:57] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[12:11:57] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[12:11:57] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[12:11:57] ============== drm_test_fb_xrgb8888_to_mono  ===============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[12:11:57] ==================== drm_test_fb_swab  =====================
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ================ [PASSED] drm_test_fb_swab =================
[12:11:57] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[12:11:57] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[12:11:57] [PASSED] single_pixel_source_buffer
[12:11:57] [PASSED] single_pixel_clip_rectangle
[12:11:57] [PASSED] well_known_colors
[12:11:57] [PASSED] destination_pitch
[12:11:57] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[12:11:57] ================= drm_test_fb_clip_offset  =================
[12:11:57] [PASSED] pass through
[12:11:57] [PASSED] horizontal offset
[12:11:57] [PASSED] vertical offset
[12:11:57] [PASSED] horizontal and vertical offset
[12:11:57] [PASSED] horizontal offset (custom pitch)
[12:11:57] [PASSED] vertical offset (custom pitch)
[12:11:57] [PASSED] horizontal and vertical offset (custom pitch)
[12:11:57] ============= [PASSED] drm_test_fb_clip_offset =============
[12:11:57] =================== drm_test_fb_memcpy  ====================
[12:11:57] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[12:11:57] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[12:11:57] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[12:11:57] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[12:11:57] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[12:11:57] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[12:11:57] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[12:11:57] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[12:11:57] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[12:11:57] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[12:11:57] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[12:11:57] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[12:11:57] =============== [PASSED] drm_test_fb_memcpy ================
[12:11:57] ============= [PASSED] drm_format_helper_test ==============
[12:11:57] ================= drm_format (18 subtests) =================
[12:11:57] [PASSED] drm_test_format_block_width_invalid
[12:11:57] [PASSED] drm_test_format_block_width_one_plane
[12:11:57] [PASSED] drm_test_format_block_width_two_plane
[12:11:57] [PASSED] drm_test_format_block_width_three_plane
[12:11:57] [PASSED] drm_test_format_block_width_tiled
[12:11:57] [PASSED] drm_test_format_block_height_invalid
[12:11:57] [PASSED] drm_test_format_block_height_one_plane
[12:11:57] [PASSED] drm_test_format_block_height_two_plane
[12:11:57] [PASSED] drm_test_format_block_height_three_plane
[12:11:57] [PASSED] drm_test_format_block_height_tiled
[12:11:57] [PASSED] drm_test_format_min_pitch_invalid
[12:11:57] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[12:11:57] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[12:11:57] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[12:11:57] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[12:11:57] [PASSED] drm_test_format_min_pitch_two_plane
[12:11:57] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[12:11:57] [PASSED] drm_test_format_min_pitch_tiled
[12:11:57] =================== [PASSED] drm_format ====================
[12:11:57] ============== drm_framebuffer (10 subtests) ===============
[12:11:57] ========== drm_test_framebuffer_check_src_coords  ==========
[12:11:57] [PASSED] Success: source fits into fb
[12:11:57] [PASSED] Fail: overflowing fb with x-axis coordinate
[12:11:57] [PASSED] Fail: overflowing fb with y-axis coordinate
[12:11:57] [PASSED] Fail: overflowing fb with source width
[12:11:57] [PASSED] Fail: overflowing fb with source height
[12:11:57] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[12:11:57] [PASSED] drm_test_framebuffer_cleanup
[12:11:57] =============== drm_test_framebuffer_create  ===============
[12:11:57] [PASSED] ABGR8888 normal sizes
[12:11:57] [PASSED] ABGR8888 max sizes
[12:11:57] [PASSED] ABGR8888 pitch greater than min required
[12:11:57] [PASSED] ABGR8888 pitch less than min required
[12:11:57] [PASSED] ABGR8888 Invalid width
[12:11:57] [PASSED] ABGR8888 Invalid buffer handle
[12:11:57] [PASSED] No pixel format
[12:11:57] [PASSED] ABGR8888 Width 0
[12:11:57] [PASSED] ABGR8888 Height 0
[12:11:57] [PASSED] ABGR8888 Out of bound height * pitch combination
[12:11:57] [PASSED] ABGR8888 Large buffer offset
[12:11:57] [PASSED] ABGR8888 Buffer offset for inexistent plane
[12:11:57] [PASSED] ABGR8888 Invalid flag
[12:11:57] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[12:11:57] [PASSED] ABGR8888 Valid buffer modifier
[12:11:57] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[12:11:57] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] NV12 Normal sizes
[12:11:57] [PASSED] NV12 Max sizes
[12:11:57] [PASSED] NV12 Invalid pitch
[12:11:57] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[12:11:57] [PASSED] NV12 different  modifier per-plane
[12:11:57] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[12:11:57] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] NV12 Modifier for inexistent plane
[12:11:57] [PASSED] NV12 Handle for inexistent plane
[12:11:57] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[12:11:57] [PASSED] YVU420 Normal sizes
[12:11:57] [PASSED] YVU420 Max sizes
[12:11:57] [PASSED] YVU420 Invalid pitch
[12:11:57] [PASSED] YVU420 Different pitches
[12:11:57] [PASSED] YVU420 Different buffer offsets/pitches
[12:11:57] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[12:11:57] [PASSED] YVU420 Valid modifier
[12:11:57] [PASSED] YVU420 Different modifiers per plane
[12:11:57] [PASSED] YVU420 Modifier for inexistent plane
[12:11:57] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[12:11:57] [PASSED] X0L2 Normal sizes
[12:11:57] [PASSED] X0L2 Max sizes
[12:11:57] [PASSED] X0L2 Invalid pitch
[12:11:57] [PASSED] X0L2 Pitch greater than minimum required
[12:11:57] [PASSED] X0L2 Handle for inexistent plane
[12:11:57] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[12:11:57] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[12:11:57] [PASSED] X0L2 Valid modifier
[12:11:57] [PASSED] X0L2 Modifier for inexistent plane
[12:11:57] =========== [PASSED] drm_test_framebuffer_create ===========
[12:11:57] [PASSED] drm_test_framebuffer_free
[12:11:57] [PASSED] drm_test_framebuffer_init
[12:11:57] [PASSED] drm_test_framebuffer_init_bad_format
[12:11:57] [PASSED] drm_test_framebuffer_init_dev_mismatch
[12:11:57] [PASSED] drm_test_framebuffer_lookup
[12:11:57] [PASSED] drm_test_framebuffer_lookup_inexistent
[12:11:57] [PASSED] drm_test_framebuffer_modifiers_not_supported
[12:11:57] ================= [PASSED] drm_framebuffer =================
[12:11:57] ================ drm_gem_shmem (8 subtests) ================
[12:11:57] [PASSED] drm_gem_shmem_test_obj_create
[12:11:57] [PASSED] drm_gem_shmem_test_obj_create_private
[12:11:57] [PASSED] drm_gem_shmem_test_pin_pages
[12:11:57] [PASSED] drm_gem_shmem_test_vmap
[12:11:57] [PASSED] drm_gem_shmem_test_get_sg_table
[12:11:57] [PASSED] drm_gem_shmem_test_get_pages_sgt
[12:11:57] [PASSED] drm_gem_shmem_test_madvise
[12:11:57] [PASSED] drm_gem_shmem_test_purge
[12:11:57] ================== [PASSED] drm_gem_shmem ==================
[12:11:57] === drm_atomic_helper_connector_hdmi_check (29 subtests) ===
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[12:11:57] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[12:11:57] [PASSED] Automatic
[12:11:57] [PASSED] Full
[12:11:57] [PASSED] Limited 16:235
[12:11:57] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[12:11:57] [PASSED] drm_test_check_disable_connector
[12:11:57] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[12:11:57] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[12:11:57] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[12:11:57] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[12:11:57] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[12:11:57] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[12:11:57] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[12:11:57] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[12:11:57] [PASSED] drm_test_check_output_bpc_dvi
[12:11:57] [PASSED] drm_test_check_output_bpc_format_vic_1
[12:11:57] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[12:11:57] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[12:11:57] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[12:11:57] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[12:11:57] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[12:11:57] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[12:11:57] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[12:11:57] ============ drm_test_check_hdmi_color_format  =============
[12:11:57] [PASSED] AUTO -> RGB
[12:11:57] [PASSED] YCBCR422 -> YUV422
[12:11:57] [PASSED] YCBCR420 -> YUV420
[12:11:57] [PASSED] YCBCR444 -> YUV444
[12:11:57] [PASSED] RGB -> RGB
[12:11:57] ======== [PASSED] drm_test_check_hdmi_color_format =========
[12:11:57] ======== drm_test_check_hdmi_color_format_420_only  ========
[12:11:57] [PASSED] RGB should fail
[12:11:57] [PASSED] YUV444 should fail
[12:11:57] [PASSED] YUV422 should fail
[12:11:57] [PASSED] YUV420 should work
[12:11:57] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ====
[12:11:57] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[12:11:57] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[12:11:57] [PASSED] drm_test_check_broadcast_rgb_value
[12:11:57] [PASSED] drm_test_check_bpc_8_value
[12:11:57] [PASSED] drm_test_check_bpc_10_value
[12:11:57] [PASSED] drm_test_check_bpc_12_value
[12:11:57] [PASSED] drm_test_check_format_value
[12:11:57] [PASSED] drm_test_check_tmds_char_value
[12:11:57] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[12:11:57] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) =
[12:11:57] [PASSED] drm_test_check_mode_valid
[12:11:57] [PASSED] drm_test_check_mode_valid_reject
[12:11:57] [PASSED] drm_test_check_mode_valid_reject_rate
[12:11:57] [PASSED] drm_test_check_mode_valid_reject_max_clock
[12:11:57] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock
[12:11:57] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector
[12:11:57] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb
[12:11:57] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[12:11:57] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[12:11:57] [PASSED] drm_test_check_infoframes
[12:11:57] [PASSED] drm_test_check_reject_avi_infoframe
[12:11:57] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[12:11:57] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[12:11:57] [PASSED] drm_test_check_reject_audio_infoframe
[12:11:57] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[12:11:57] ================= drm_managed (2 subtests) =================
[12:11:57] [PASSED] drm_test_managed_release_action
[12:11:57] [PASSED] drm_test_managed_run_action
[12:11:57] =================== [PASSED] drm_managed ===================
[12:11:57] =================== drm_mm (6 subtests) ====================
[12:11:57] [PASSED] drm_test_mm_init
[12:11:57] [PASSED] drm_test_mm_debug
[12:11:57] [PASSED] drm_test_mm_align32
[12:11:57] [PASSED] drm_test_mm_align64
[12:11:57] [PASSED] drm_test_mm_lowest
[12:11:57] [PASSED] drm_test_mm_highest
[12:11:57] ===================== [PASSED] drm_mm ======================
[12:11:57] ============= drm_modes_analog_tv (5 subtests) =============
[12:11:57] [PASSED] drm_test_modes_analog_tv_mono_576i
[12:11:57] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[12:11:57] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[12:11:57] [PASSED] drm_test_modes_analog_tv_pal_576i
[12:11:57] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[12:11:57] =============== [PASSED] drm_modes_analog_tv ===============
[12:11:57] ============== drm_panic_helper (3 subtests) ===============
[12:11:57] ============= drm_test_panic_screen_user_map  ==============
[12:11:57] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:57] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:57] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:57] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:57] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:57] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:57] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:57] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:58] ========= [PASSED] drm_test_panic_screen_user_map ==========
[12:11:58] ============= drm_test_panic_screen_user_page  =============
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:58] ========= [PASSED] drm_test_panic_screen_user_page =========
[12:11:58] ========== drm_test_panic_screen_user_set_pixel  ===========
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:58] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[12:11:58] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[12:11:58] ====== [PASSED] drm_test_panic_screen_user_set_pixel =======
[12:11:58] ================ [PASSED] drm_panic_helper =================
[12:11:58] ============== drm_plane_helper (2 subtests) ===============
[12:11:58] =============== drm_test_check_plane_state  ================
[12:11:58] [PASSED] clipping_simple
[12:11:58] [PASSED] clipping_rotate_reflect
[12:11:58] [PASSED] positioning_simple
[12:11:58] [PASSED] upscaling
[12:11:58] [PASSED] downscaling
[12:11:58] [PASSED] rounding1
[12:11:58] [PASSED] rounding2
[12:11:58] [PASSED] rounding3
[12:11:58] [PASSED] rounding4
[12:11:58] =========== [PASSED] drm_test_check_plane_state ============
[12:11:58] =========== drm_test_check_invalid_plane_state  ============
[12:11:58] [PASSED] positioning_invalid
[12:11:58] [PASSED] upscaling_invalid
[12:11:58] [PASSED] downscaling_invalid
[12:11:58] ======= [PASSED] drm_test_check_invalid_plane_state ========
[12:11:58] ================ [PASSED] drm_plane_helper =================
[12:11:58] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[12:11:58] ====== drm_test_connector_helper_tv_get_modes_check  =======
[12:11:58] [PASSED] None
[12:11:58] [PASSED] PAL
[12:11:58] [PASSED] NTSC
[12:11:58] [PASSED] Both, NTSC Default
[12:11:58] [PASSED] Both, PAL Default
[12:11:58] [PASSED] Both, NTSC Default, with PAL on command-line
[12:11:58] [PASSED] Both, PAL Default, with NTSC on command-line
[12:11:58] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[12:11:58] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[12:11:58] ================== drm_rect (9 subtests) ===================
[12:11:58] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[12:11:58] [PASSED] drm_test_rect_clip_scaled_not_clipped
[12:11:58] [PASSED] drm_test_rect_clip_scaled_clipped
[12:11:58] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[12:11:58] ================= drm_test_rect_intersect  =================
[12:11:58] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[12:11:58] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[12:11:58] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[12:11:58] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[12:11:58] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[12:11:58] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[12:11:58] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[12:11:58] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[12:11:58] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[12:11:58] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[12:11:58] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[12:11:58] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[12:11:58] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[12:11:58] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[12:11:58] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[12:11:58] ============= [PASSED] drm_test_rect_intersect =============
[12:11:58] ================ drm_test_rect_calc_hscale  ================
[12:11:58] [PASSED] normal use
[12:11:58] [PASSED] out of max range
[12:11:58] [PASSED] out of min range
[12:11:58] [PASSED] zero dst
[12:11:58] [PASSED] negative src
[12:11:58] [PASSED] negative dst
[12:11:58] ============ [PASSED] drm_test_rect_calc_hscale ============
[12:11:58] ================ drm_test_rect_calc_vscale  ================
[12:11:58] [PASSED] normal use
[12:11:58] [PASSED] out of max range
[12:11:58] [PASSED] out of min range
[12:11:58] [PASSED] zero dst
[12:11:58] [PASSED] negative src
[12:11:58] [PASSED] negative dst
[12:11:58] ============ [PASSED] drm_test_rect_calc_vscale ============
[12:11:58] ================== drm_test_rect_rotate  ===================
[12:11:58] [PASSED] reflect-x
[12:11:58] [PASSED] reflect-y
[12:11:58] [PASSED] rotate-0
[12:11:58] [PASSED] rotate-90
[12:11:58] [PASSED] rotate-180
[12:11:58] [PASSED] rotate-270
[12:11:58] ============== [PASSED] drm_test_rect_rotate ===============
[12:11:58] ================ drm_test_rect_rotate_inv  =================
[12:11:58] [PASSED] reflect-x
[12:11:58] [PASSED] reflect-y
[12:11:58] [PASSED] rotate-0
[12:11:58] [PASSED] rotate-90
[12:11:58] [PASSED] rotate-180
[12:11:58] [PASSED] rotate-270
[12:11:58] ============ [PASSED] drm_test_rect_rotate_inv =============
[12:11:58] ==================== [PASSED] drm_rect =====================
[12:11:58] ============ drm_sysfb_modeset_test (1 subtest) ============
[12:11:58] ============ drm_test_sysfb_build_fourcc_list  =============
[12:11:58] [PASSED] no native formats
[12:11:58] [PASSED] XRGB8888 as native format
[12:11:58] [PASSED] remove duplicates
[12:11:58] [PASSED] convert alpha formats
[12:11:58] [PASSED] random formats
[12:11:58] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[12:11:58] ============= [PASSED] drm_sysfb_modeset_test ==============
[12:11:58] ================== drm_fixp (2 subtests) ===================
[12:11:58] [PASSED] drm_test_int2fixp
[12:11:58] [PASSED] drm_test_sm2fixp
[12:11:58] ==================== [PASSED] drm_fixp =====================
[12:11:58] ============================================================
[12:11:58] Testing complete. Ran 667 tests: passed: 667
[12:11:58] Elapsed time: 27.656s total, 1.858s configuring, 25.381s building, 0.412s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[12:11:58] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:12:00] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:12:10] Starting KUnit Kernel (1/1)...
[12:12:10] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:12:10] ================= ttm_device (5 subtests) ==================
[12:12:10] [PASSED] ttm_device_init_basic
[12:12:10] [PASSED] ttm_device_init_multiple
[12:12:10] [PASSED] ttm_device_fini_basic
[12:12:10] [PASSED] ttm_device_init_no_vma_man
[12:12:10] ================== ttm_device_init_pools  ==================
[12:12:10] [PASSED] No DMA allocations, no DMA32 required
[12:12:10] [PASSED] DMA allocations, DMA32 required
[12:12:10] [PASSED] No DMA allocations, DMA32 required
[12:12:10] [PASSED] DMA allocations, no DMA32 required
[12:12:10] ============== [PASSED] ttm_device_init_pools ==============
[12:12:10] =================== [PASSED] ttm_device ====================
[12:12:10] ================== ttm_pool (8 subtests) ===================
[12:12:10] ================== ttm_pool_alloc_basic  ===================
[12:12:10] [PASSED] One page
[12:12:10] [PASSED] More than one page
[12:12:10] [PASSED] Above the allocation limit
[12:12:10] [PASSED] One page, with coherent DMA mappings enabled
[12:12:10] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:12:10] ============== [PASSED] ttm_pool_alloc_basic ===============
[12:12:10] ============== ttm_pool_alloc_basic_dma_addr  ==============
[12:12:10] [PASSED] One page
[12:12:10] [PASSED] More than one page
[12:12:10] [PASSED] Above the allocation limit
[12:12:10] [PASSED] One page, with coherent DMA mappings enabled
[12:12:10] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:12:10] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[12:12:10] [PASSED] ttm_pool_alloc_order_caching_match
[12:12:10] [PASSED] ttm_pool_alloc_caching_mismatch
[12:12:10] [PASSED] ttm_pool_alloc_order_mismatch
[12:12:10] [PASSED] ttm_pool_free_dma_alloc
[12:12:10] [PASSED] ttm_pool_free_no_dma_alloc
[12:12:10] [PASSED] ttm_pool_fini_basic
[12:12:10] ==================== [PASSED] ttm_pool =====================
[12:12:10] ================ ttm_resource (8 subtests) =================
[12:12:10] ================= ttm_resource_init_basic  =================
[12:12:10] [PASSED] Init resource in TTM_PL_SYSTEM
[12:12:10] [PASSED] Init resource in TTM_PL_VRAM
[12:12:10] [PASSED] Init resource in a private placement
[12:12:10] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[12:12:10] ============= [PASSED] ttm_resource_init_basic =============
[12:12:10] [PASSED] ttm_resource_init_pinned
[12:12:10] [PASSED] ttm_resource_fini_basic
[12:12:10] [PASSED] ttm_resource_manager_init_basic
[12:12:10] [PASSED] ttm_resource_manager_usage_basic
[12:12:10] [PASSED] ttm_resource_manager_set_used_basic
[12:12:10] [PASSED] ttm_sys_man_alloc_basic
[12:12:10] [PASSED] ttm_sys_man_free_basic
[12:12:10] ================== [PASSED] ttm_resource ===================
[12:12:10] =================== ttm_tt (15 subtests) ===================
[12:12:10] ==================== ttm_tt_init_basic  ====================
[12:12:10] [PASSED] Page-aligned size
[12:12:10] [PASSED] Extra pages requested
[12:12:10] ================ [PASSED] ttm_tt_init_basic ================
[12:12:10] [PASSED] ttm_tt_init_misaligned
[12:12:10] [PASSED] ttm_tt_fini_basic
[12:12:10] [PASSED] ttm_tt_fini_sg
[12:12:10] [PASSED] ttm_tt_fini_shmem
[12:12:10] [PASSED] ttm_tt_create_basic
[12:12:10] [PASSED] ttm_tt_create_invalid_bo_type
[12:12:10] [PASSED] ttm_tt_create_ttm_exists
[12:12:10] [PASSED] ttm_tt_create_failed
[12:12:10] [PASSED] ttm_tt_destroy_basic
[12:12:10] [PASSED] ttm_tt_populate_null_ttm
[12:12:10] [PASSED] ttm_tt_populate_populated_ttm
[12:12:10] [PASSED] ttm_tt_unpopulate_basic
[12:12:10] [PASSED] ttm_tt_unpopulate_empty_ttm
[12:12:10] [PASSED] ttm_tt_swapin_basic
[12:12:10] ===================== [PASSED] ttm_tt ======================
[12:12:10] =================== ttm_bo (14 subtests) ===================
[12:12:10] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[12:12:10] [PASSED] Cannot be interrupted and sleeps
[12:12:10] [PASSED] Cannot be interrupted, locks straight away
[12:12:10] [PASSED] Can be interrupted, sleeps
[12:12:10] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[12:12:10] [PASSED] ttm_bo_reserve_locked_no_sleep
[12:12:10] [PASSED] ttm_bo_reserve_no_wait_ticket
[12:12:10] [PASSED] ttm_bo_reserve_double_resv
[12:12:10] [PASSED] ttm_bo_reserve_interrupted
[12:12:10] [PASSED] ttm_bo_reserve_deadlock
[12:12:10] [PASSED] ttm_bo_unreserve_basic
[12:12:10] [PASSED] ttm_bo_unreserve_pinned
[12:12:10] [PASSED] ttm_bo_unreserve_bulk
[12:12:10] [PASSED] ttm_bo_fini_basic
[12:12:10] [PASSED] ttm_bo_fini_shared_resv
[12:12:10] [PASSED] ttm_bo_pin_basic
[12:12:10] [PASSED] ttm_bo_pin_unpin_resource
[12:12:10] [PASSED] ttm_bo_multiple_pin_one_unpin
[12:12:10] ===================== [PASSED] ttm_bo ======================
[12:12:10] ============== ttm_bo_validate (22 subtests) ===============
[12:12:10] ============== ttm_bo_init_reserved_sys_man  ===============
[12:12:10] [PASSED] Buffer object for userspace
[12:12:10] [PASSED] Kernel buffer object
[12:12:10] [PASSED] Shared buffer object
[12:12:10] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[12:12:10] ============== ttm_bo_init_reserved_mock_man  ==============
[12:12:10] [PASSED] Buffer object for userspace
[12:12:10] [PASSED] Kernel buffer object
[12:12:10] [PASSED] Shared buffer object
[12:12:10] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[12:12:10] [PASSED] ttm_bo_init_reserved_resv
[12:12:10] ================== ttm_bo_validate_basic  ==================
[12:12:10] [PASSED] Buffer object for userspace
[12:12:10] [PASSED] Kernel buffer object
[12:12:10] [PASSED] Shared buffer object
[12:12:10] ============== [PASSED] ttm_bo_validate_basic ==============
[12:12:10] [PASSED] ttm_bo_validate_invalid_placement
[12:12:10] ============= ttm_bo_validate_same_placement  ==============
[12:12:10] [PASSED] System manager
[12:12:10] [PASSED] VRAM manager
[12:12:10] ========= [PASSED] ttm_bo_validate_same_placement ==========
[12:12:10] [PASSED] ttm_bo_validate_failed_alloc
[12:12:10] [PASSED] ttm_bo_validate_pinned
[12:12:10] [PASSED] ttm_bo_validate_busy_placement
[12:12:10] ================ ttm_bo_validate_multihop  =================
[12:12:10] [PASSED] Buffer object for userspace
[12:12:10] [PASSED] Kernel buffer object
[12:12:10] [PASSED] Shared buffer object
[12:12:10] ============ [PASSED] ttm_bo_validate_multihop =============
[12:12:10] ========== ttm_bo_validate_no_placement_signaled  ==========
[12:12:10] [PASSED] Buffer object in system domain, no page vector
[12:12:10] [PASSED] Buffer object in system domain with an existing page vector
[12:12:10] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[12:12:10] ======== ttm_bo_validate_no_placement_not_signaled  ========
[12:12:10] [PASSED] Buffer object for userspace
[12:12:10] [PASSED] Kernel buffer object
[12:12:10] [PASSED] Shared buffer object
[12:12:10] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[12:12:10] [PASSED] ttm_bo_validate_move_fence_signaled
[12:12:10] ========= ttm_bo_validate_move_fence_not_signaled  =========
[12:12:10] [PASSED] Waits for GPU
[12:12:10] [PASSED] Tries to lock straight away
[12:12:10] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[12:12:10] [PASSED] ttm_bo_validate_swapout
[12:12:10] [PASSED] ttm_bo_validate_happy_evict
[12:12:10] [PASSED] ttm_bo_validate_all_pinned_evict
[12:12:10] [PASSED] ttm_bo_validate_allowed_only_evict
[12:12:10] [PASSED] ttm_bo_validate_deleted_evict
[12:12:10] [PASSED] ttm_bo_validate_busy_domain_evict
[12:12:10] [PASSED] ttm_bo_validate_evict_gutting
[12:12:10] [PASSED] ttm_bo_validate_recrusive_evict
[12:12:10] ================= [PASSED] ttm_bo_validate =================
[12:12:10] ============================================================
[12:12:10] Testing complete. Ran 102 tests: passed: 102
[12:12:10] Elapsed time: 12.392s total, 1.898s configuring, 10.279s building, 0.182s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/dma-buf/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/dma-buf/.kunitconfig
[12:12:10] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:12:12] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:12:21] Starting KUnit Kernel (1/1)...
[12:12:21] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:12:21] =============== dma-buf-fence (12 subtests) ================
[12:12:21] [PASSED] test_sanitycheck
[12:12:21] [PASSED] test_signaling
[12:12:21] [PASSED] test_add_callback
[12:12:21] [PASSED] test_late_add_callback
[12:12:21] [PASSED] test_rm_callback
[12:12:21] [PASSED] test_late_rm_callback
[12:12:21] [PASSED] test_status
[12:12:21] [PASSED] test_error
[12:12:21] [PASSED] test_wait
[12:12:21] [PASSED] test_wait_timeout
[12:12:21] [PASSED] test_stub
[12:12:21] [SKIPPED] test_race_signal_callback (requires at least 2 CPUs)
[12:12:21] ================== [PASSED] dma-buf-fence ==================
[12:12:21] ============ dma-buf-fence-chain (11 subtests) =============
[12:12:21] [PASSED] test_sanitycheck
[12:12:21] [PASSED] test_find_seqno
[12:12:21] [PASSED] test_find_signaled
[12:12:21] [PASSED] test_find_out_of_order
[12:12:26] [PASSED] test_find_gap
[12:12:26] [PASSED] test_find_race
[12:12:26] [PASSED] test_signal_forward
[12:12:26] [PASSED] test_signal_backward
[12:12:26] [PASSED] test_wait_forward
[12:12:26] [PASSED] test_wait_backward
[12:12:26] [PASSED] test_wait_random
[12:12:26] =============== [PASSED] dma-buf-fence-chain ===============
[12:12:26] ============ dma-buf-fence-unwrap (10 subtests) ============
[12:12:26] [PASSED] test_sanitycheck
[12:12:26] [PASSED] test_unwrap_array
[12:12:26] [PASSED] test_unwrap_chain
[12:12:26] [PASSED] test_unwrap_chain_array
[12:12:26] [PASSED] test_unwrap_merge
[12:12:26] [PASSED] test_unwrap_merge_duplicate
[12:12:26] [PASSED] test_unwrap_merge_seqno
[12:12:26] [PASSED] test_unwrap_merge_order
[12:12:26] [PASSED] test_unwrap_merge_complex
[12:12:26] [PASSED] test_unwrap_merge_complex_seqno
[12:12:26] ============== [PASSED] dma-buf-fence-unwrap ===============
[12:12:26] ================ dma-buf-resv (5 subtests) =================
[12:12:26] [PASSED] test_sanitycheck
[12:12:26] ===================== test_signaling  ======================
[12:12:26] [PASSED] kernel
[12:12:26] [PASSED] write
[12:12:26] [PASSED] read
[12:12:26] [PASSED] bookkeep
[12:12:26] ================= [PASSED] test_signaling ==================
[12:12:26] ====================== test_for_each  ======================
[12:12:26] [PASSED] kernel
[12:12:26] [PASSED] write
[12:12:26] [PASSED] read
[12:12:26] [PASSED] bookkeep
[12:12:26] ================== [PASSED] test_for_each ==================
[12:12:26] ================= test_for_each_unlocked  ==================
[12:12:26] [PASSED] kernel
[12:12:26] [PASSED] write
[12:12:26] [PASSED] read
[12:12:26] [PASSED] bookkeep
[12:12:26] ============= [PASSED] test_for_each_unlocked ==============
[12:12:26] ===================== test_get_fences  =====================
[12:12:26] [PASSED] kernel
[12:12:26] [PASSED] write
[12:12:26] [PASSED] read
[12:12:26] [PASSED] bookkeep
[12:12:26] ================= [PASSED] test_get_fences =================
[12:12:26] ================== [PASSED] dma-buf-resv ===================
[12:12:26] ============================================================
[12:12:26] Testing complete. Ran 50 tests: passed: 49, skipped: 1
[12:12:26] Elapsed time: 15.858s total, 1.857s configuring, 8.730s building, 5.262s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

Re: [PATCH v13 03/16] drm/xe/hwmon: Fix thermal sensor data handling

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: Subsystem API Violation - Driver uses private custom mutex instead of hwmon_lock()
--

commit 5b607ffd1e7d970e08aa24f25b6f029c27e76b6d
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Fix thermal sensor data handling

This commit reads required thermal groups in get_mc_temp() and stores them
in a dword-aligned buffer, avoiding unaligned pcode accesses. It also stores
the pcode thermal data and thermal limit words as little-endian.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 382bf9625a8bd..1b4efbf4ac999 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
[ ... ]
> @@ -840,16 +845,20 @@ static int mbx_temp_decode(u8 value)
>  static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> -	u32 *dword = (u32 *)hwmon->temp.value;
>  	s32 average = 0;
>  	int ret, i;
>  
> -	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
> +	guard(mutex)(&hwmon->hwmon_lock);

[Severity: Low]
Does this violate the hardware monitoring subsystem locking requirements?

The hwmon subsystem documentation states that drivers implementing locking
required for interrupt handling or for attributes registered by any other
means must use the hwmon_lock() and hwmon_unlock() APIs.

Can we use the hwmon subsystem's locking API here instead of the
driver-specific hwmon_lock mutex?

> +
> +	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014115806.831459-1-karthik.poosa@intel.com?part=3

Re: [PATCH v13 04/16] drm/xe/hwmon: Add helpers to validate thermal sensor readings

[Poosa, Karthik]

On 14-10-2026 17:41, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] drm/xe/hwmon: mbx_temp_valid() fails to reject 0x80 (-0°C) as invalid
> --
>
> commit cc835292455ece8a38adb02fe6e4c345fc3aa89a
> Author: Karthik Poosa <karthik.poosa@intel.com>
>
> drm/xe/hwmon: Add helpers to validate thermal sensor readings
>
> This commit adds mmio_temp_valid() and mbx_temp_valid() to validate
> temperature sensor readings. It uses the has_temp_sentinel flag to gate
> these checks and rejects 0xFF for mailbox and 0xFFFFFFFF for MMIO.
>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index 1b4efbf4ac999..883a0ae1d90e3 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> [ ... ]
>> @@ -834,6 +837,30 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
>>   	return ret;
>>   }
> [ ... ]
>> +/* Mailbox temperature is sign-magnitude (bit 7 sign, bits 6:0 magnitude). */
>> +static inline bool mbx_temp_valid(const struct xe_hwmon *hwmon, u8 value)
>> +{
>> +	if (value == TEMP_MBX_INVALID)
>> +		return false;
>> +
>> +	return hwmon->xe->info.has_temp_sentinel || value != 0;
> [Severity: Low]
> Does this raw byte check fail to reject 0x80?
>
> Since 0x80 represents -0 degrees Celsius in the sign-magnitude format (sign
> bit 7 is set, magnitude bits 6:0 are zero), it evaluates to true here
> because 0x80 is not equal to 0.
hardware will not send 0x80, so this case is not expected in practice.
>
>> +}
>> +
>> +/* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
>> +static int mbx_temp_decode(u8 value)
>> +{
>> +	int temp = value & TEMP_MBX_MAG;
>> +
>> +	return (value & TEMP_MBX_SIGN) ? -temp : temp;
> If 0x80 is passed here, it decodes to 0 degrees Celsius.
>
> This means the fallback safety logic in mbx_temp_valid() intended to reject
> uninitialized 0 degrees Celsius readings can be bypassed if the hardware
> returns 0x80 instead of 0x00. This could fold invalid readings into the
> temperature average.
>
>> +}
same as above

Re: [PATCH v13 03/16] drm/xe/hwmon: Fix thermal sensor data handling

[Poosa, Karthik]

On 14-10-2026 17:46, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] hwmon: Subsystem API Violation - Driver uses private custom mutex instead of hwmon_lock()
> --
>
> commit 5b607ffd1e7d970e08aa24f25b6f029c27e76b6d
> Author: Karthik Poosa <karthik.poosa@intel.com>
>
> drm/xe/hwmon: Fix thermal sensor data handling
>
> This commit reads required thermal groups in get_mc_temp() and stores them
> in a dword-aligned buffer, avoiding unaligned pcode accesses. It also stores
> the pcode thermal data and thermal limit words as little-endian.
>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index 382bf9625a8bd..1b4efbf4ac999 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> [ ... ]
>> @@ -840,16 +845,20 @@ static int mbx_temp_decode(u8 value)
>>   static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>>   {
>>   	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
>> -	u32 *dword = (u32 *)hwmon->temp.value;
>>   	s32 average = 0;
>>   	int ret, i;
>>   
>> -	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
>> +	guard(mutex)(&hwmon->hwmon_lock);
> [Severity: Low]
> Does this violate the hardware monitoring subsystem locking requirements?
>
> The hwmon subsystem documentation states that drivers implementing locking
> required for interrupt handling or for attributes registered by any other
> means must use the hwmon_lock() and hwmon_unlock() APIs.
>
> Can we use the hwmon subsystem's locking API here instead of the
> driver-specific hwmon_lock mutex?

The mutex here protects driver-internal concurrent accesses and does not 
provide synchronization required by the hwmon core callbacks.

Therefore, I don't believe this falls under the case requiring 
hwmon_lock() / hwmon_unlock().

@rodrigo, can you share your comment on this.

>> +
>> +	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {

Re: [PATCH v13 01/16] drm/xe/hwmon: Fix pcode power limit handling

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 05:27:51PM +0530, Karthik Poosa wrote:
> Return early on pcode read failure in xe_hwmon_pcode_rmw_power_limit()
> and propagate errors to callers.
> 
> Replace boot_power_limit_read with per-channel
> read_power_limit_from_pcode[], set on the first successful pcode write,
> so reads and writes stay consistent even if the default limit write at
> boot fails.
> 
> Also return PWR_LIM_EN for power label so card label visibility works.
> 
> Fixes: 8aa7306631f0 ("drm/xe/hwmon: Fix xe_hwmon_power_max_write")
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
> 
> v2: Check return in xe_hwmon_get_preregistration_info() also. (Sashiko)
> v3: Track pcode limit updates per channel. (Sashiko)
> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 77 +++++++++++++++++++++--------------
>  1 file changed, 47 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 5edeac961ec3..c7f936892512 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -165,8 +165,8 @@ struct xe_hwmon {
>  	struct xe_hwmon_energy_info ei[CHANNEL_MAX];
>  	/** @fi: Fan info for fanN_input */
>  	struct xe_hwmon_fan_info fi[FAN_MAX];
> -	/** @boot_power_limit_read: is boot power limits read */
> -	bool boot_power_limit_read;
> +	/** @read_power_limit_from_pcode: pcode accepted power limits write for the channel */
> +	bool read_power_limit_from_pcode[CHANNEL_MAX];
>  	/** @pl1_on_boot: power limit PL1 on boot */
>  	u32 pl1_on_boot[CHANNEL_MAX];
>  	/** @pl2_on_boot: power limit PL2 on boot */
> @@ -175,9 +175,9 @@ struct xe_hwmon {
>  	struct xe_hwmon_thermal_info temp;
>  };
>  
> -static inline int prepare_power_limit_param2(const struct xe_hwmon *hwmon)
> +static inline int prepare_power_limit_param2(const struct xe_hwmon *hwmon, int channel)
>  {
> -	if (hwmon->boot_power_limit_read) {
> +	if (hwmon->read_power_limit_from_pcode[channel]) {
>  		if (hwmon->xe->info.platform >= XE_CRESCENTISLAND)
>  			return READ_PL_ACCEPTED;
>  		else
> @@ -198,7 +198,8 @@ static int xe_hwmon_pcode_read_power_limit(const struct xe_hwmon *hwmon, u32 att
>  						  (channel == CHANNEL_CARD) ?
>  						  READ_PSYSGPU_POWER_LIMIT :
>  						  READ_PACKAGE_POWER_LIMIT,
> -						  prepare_power_limit_param2(hwmon)), &val0, &val1);
> +						  prepare_power_limit_param2(hwmon, channel)),
> +			    &val0, &val1);
>  
>  	if (ret) {
>  		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
> @@ -213,14 +214,14 @@ static int xe_hwmon_pcode_read_power_limit(const struct xe_hwmon *hwmon, u32 att
>  	else if (attr == PL2_HWMON_ATTR)
>  		*uval = (val1 & PWR_LIM_EN) ? val1 : 0;
>  	else if (attr == hwmon_power_label)
> -		*uval = (val0 & PWR_LIM_EN) ? 1 : (val1 & PWR_LIM_EN) ? 1 : 0;
> +		*uval = (val0 | val1) & PWR_LIM_EN;
>  	else
>  		*uval = 0;
>  
>  	return ret;
>  }
>  
> -static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr, u8 channel,
> +static int xe_hwmon_pcode_rmw_power_limit(struct xe_hwmon *hwmon, u32 attr, u8 channel,
>  					  u32 clr, u32 set)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> @@ -231,10 +232,13 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
>  						  (channel == CHANNEL_CARD) ?
>  						  READ_PSYSGPU_POWER_LIMIT :
>  						  READ_PACKAGE_POWER_LIMIT,
> -						  prepare_power_limit_param2(hwmon)), &val0, &val1);
> -	if (ret)
> -		drm_dbg(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
> +						  prepare_power_limit_param2(hwmon, channel)),
> +			    &val0, &val1);
> +	if (ret) {
> +		drm_err(&hwmon->xe->drm, "read failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
>  			channel, val0, val1, ret);
> +		return ret;
> +	}
>  
>  	if (attr == PL1_HWMON_ATTR)
>  		val0 = (val0 & ~clr) | set;
> @@ -248,10 +252,17 @@ static int xe_hwmon_pcode_rmw_power_limit(const struct xe_hwmon *hwmon, u32 attr
>  							     WRITE_PSYSGPU_POWER_LIMIT :
>  							     WRITE_PACKAGE_POWER_LIMIT, 0),
>  							     val0, val1, PCODE_DEFAULT_TIMEOUT_MS);
> -	if (ret)
> +	if (ret) {
>  		drm_dbg(&hwmon->xe->drm, "write failed ch %d val0 0x%08x, val1 0x%08x, ret %d\n",
>  			channel, val0, val1, ret);
> -	return ret;
> +		return ret;
> +	}
> +
> +	/* Read from pcode once it holds a driver-written limit */
> +	if (!hwmon->read_power_limit_from_pcode[channel])
> +		hwmon->read_power_limit_from_pcode[channel] = true;
> +
> +	return 0;
>  }
>  
>  static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg,
> @@ -394,7 +405,9 @@ static int xe_hwmon_power_max_write(struct xe_hwmon *hwmon, u32 attr, int channe
>  		if (hwmon->xe->info.has_mbx_power_limits) {
>  			drm_dbg(&hwmon->xe->drm, "disabling %s on channel %d\n",
>  				PWR_ATTR_TO_STR(attr), channel);
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
> +			ret = xe_hwmon_pcode_rmw_power_limit(hwmon, attr, channel, PWR_LIM_EN, 0);
> +			if (ret)
> +				goto unlock;
>  			xe_hwmon_pcode_read_power_limit(hwmon, attr, channel, &reg_val);
>  		} else {
>  			reg_val = xe_mmio_rmw32(mmio, rapl_limit, PWR_LIM_EN, 0);
> @@ -679,15 +692,19 @@ xe_hwmon_power_max_interval_store(struct device *dev, struct device_attribute *a
>  
>  	mutex_lock(&hwmon->hwmon_lock);
>  
> -	if (hwmon->xe->info.has_mbx_power_limits)
> -		xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
> -	else
> +	ret = count;
> +	if (hwmon->xe->info.has_mbx_power_limits) {
> +		ret = xe_hwmon_pcode_rmw_power_limit(hwmon, power_attr, channel, PWR_LIM_TIME, rxy);
> +		if (!ret)
> +			ret = count;
> +	} else {
>  		r = xe_mmio_rmw32(mmio, xe_hwmon_get_reg(hwmon, REG_PKG_RAPL_LIMIT, channel),
>  				  PWR_LIM_TIME, rxy);
> +	}
>  
>  	mutex_unlock(&hwmon->hwmon_lock);
>  
> -	return count;
> +	return ret;
>  }
>  
>  /* PSYS PL1 */
> @@ -1511,22 +1528,22 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon)
>  		} else {
>  			drm_info(&hwmon->xe->drm, "Using mailbox commands for power limits\n");
>  			/* Write default limits to read from pcode from now on. */
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
> -						       CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
> -						       hwmon->pl1_on_boot[CHANNEL_CARD]);
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
> -						       CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
> -						       hwmon->pl1_on_boot[CHANNEL_PKG]);
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
> -						       CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
> -						       hwmon->pl2_on_boot[CHANNEL_CARD]);
> -			xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
> -						       CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
> -						       hwmon->pl2_on_boot[CHANNEL_PKG]);
> +			if (xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
> +							   CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
> +							   hwmon->pl1_on_boot[CHANNEL_CARD]) |
> +			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL1_HWMON_ATTR,
> +							   CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
> +							   hwmon->pl1_on_boot[CHANNEL_PKG]) |
> +			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
> +							   CHANNEL_CARD, PWR_LIM | PWR_LIM_TIME,
> +							   hwmon->pl2_on_boot[CHANNEL_CARD]) |
> +			    xe_hwmon_pcode_rmw_power_limit(hwmon, PL2_HWMON_ATTR,
> +							   CHANNEL_PKG, PWR_LIM | PWR_LIM_TIME,
> +							   hwmon->pl2_on_boot[CHANNEL_PKG]))
> +				drm_warn(&hwmon->xe->drm, "Failed to set default power limits\n");

this is wrong and ugly, please move this to a function where you can combine
the returns and handle it only once...j

>  			hwmon->scl_shift_power = PWR_UNIT;
>  			hwmon->scl_shift_energy = ENERGY_UNIT;
>  			hwmon->scl_shift_time = TIME_UNIT;
> -			hwmon->boot_power_limit_read = true;
>  		}
>  	} else {
>  		drm_info(&hwmon->xe->drm, "Using register for power limits\n");
> -- 
> 2.25.1
> 

Re: [PATCH v13 03/16] drm/xe/hwmon: Fix thermal sensor data handling

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 07:12:07PM +0530, Poosa, Karthik wrote:
> 
> On 14-10-2026 17:46, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] hwmon: Subsystem API Violation - Driver uses private custom mutex instead of hwmon_lock()
> > --
> > 
> > commit 5b607ffd1e7d970e08aa24f25b6f029c27e76b6d
> > Author: Karthik Poosa <karthik.poosa@intel.com>
> > 
> > drm/xe/hwmon: Fix thermal sensor data handling
> > 
> > This commit reads required thermal groups in get_mc_temp() and stores them
> > in a dword-aligned buffer, avoiding unaligned pcode accesses. It also stores
> > the pcode thermal data and thermal limit words as little-endian.
> > 
> > > diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> > > index 382bf9625a8bd..1b4efbf4ac999 100644
> > > --- a/drivers/gpu/drm/xe/xe_hwmon.c
> > > +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> > [ ... ]
> > > @@ -840,16 +845,20 @@ static int mbx_temp_decode(u8 value)
> > >   static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
> > >   {
> > >   	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> > > -	u32 *dword = (u32 *)hwmon->temp.value;
> > >   	s32 average = 0;
> > >   	int ret, i;
> > > -	for (i = 0; i < DIV_ROUND_UP(TEMP_LIMIT_MAX, sizeof(u32)); i++) {
> > > +	guard(mutex)(&hwmon->hwmon_lock);
> > [Severity: Low]
> > Does this violate the hardware monitoring subsystem locking requirements?
> > 
> > The hwmon subsystem documentation states that drivers implementing locking
> > required for interrupt handling or for attributes registered by any other
> > means must use the hwmon_lock() and hwmon_unlock() APIs.
> > 
> > Can we use the hwmon subsystem's locking API here instead of the
> > driver-specific hwmon_lock mutex?
> 
> The mutex here protects driver-internal concurrent accesses and does not
> provide synchronization required by the hwmon core callbacks.
> 
> Therefore, I don't believe this falls under the case requiring hwmon_lock()
> / hwmon_unlock().
> 
> @rodrigo, can you share your comment on this.

that's right. we need to protect our data, nor take care of any synchronization...

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> > > +
> > > +	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {

Re: [PATCH v13 04/16] drm/xe/hwmon: Add helpers to validate thermal sensor readings

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 06:47:01PM +0530, Poosa, Karthik wrote:
> 
> On 14-10-2026 17:41, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] drm/xe/hwmon: mbx_temp_valid() fails to reject 0x80 (-0°C) as invalid
> > --
> > 
> > commit cc835292455ece8a38adb02fe6e4c345fc3aa89a
> > Author: Karthik Poosa <karthik.poosa@intel.com>
> > 
> > drm/xe/hwmon: Add helpers to validate thermal sensor readings
> > 
> > This commit adds mmio_temp_valid() and mbx_temp_valid() to validate
> > temperature sensor readings. It uses the has_temp_sentinel flag to gate
> > these checks and rejects 0xFF for mailbox and 0xFFFFFFFF for MMIO.
> > 
> > > diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> > > index 1b4efbf4ac999..883a0ae1d90e3 100644
> > > --- a/drivers/gpu/drm/xe/xe_hwmon.c
> > > +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> > [ ... ]
> > > @@ -834,6 +837,30 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
> > >   	return ret;
> > >   }
> > [ ... ]
> > > +/* Mailbox temperature is sign-magnitude (bit 7 sign, bits 6:0 magnitude). */
> > > +static inline bool mbx_temp_valid(const struct xe_hwmon *hwmon, u8 value)
> > > +{
> > > +	if (value == TEMP_MBX_INVALID)
> > > +		return false;
> > > +
> > > +	return hwmon->xe->info.has_temp_sentinel || value != 0;
> > [Severity: Low]
> > Does this raw byte check fail to reject 0x80?
> > 
> > Since 0x80 represents -0 degrees Celsius in the sign-magnitude format (sign
> > bit 7 is set, magnitude bits 6:0 are zero), it evaluates to true here
> > because 0x80 is not equal to 0.
> hardware will not send 0x80, so this case is not expected in practice.
> > 
> > > +}
> > > +
> > > +/* Decode an 8-bit sign-magnitude mailbox temperature to degrees Celsius. */
> > > +static int mbx_temp_decode(u8 value)
> > > +{
> > > +	int temp = value & TEMP_MBX_MAG;
> > > +
> > > +	return (value & TEMP_MBX_SIGN) ? -temp : temp;
> > If 0x80 is passed here, it decodes to 0 degrees Celsius.
> > 
> > This means the fallback safety logic in mbx_temp_valid() intended to reject
> > uninitialized 0 degrees Celsius readings can be bypassed if the hardware
> > returns 0x80 instead of 0x00. This could fold invalid readings into the
> > temperature average.
> > 
> > > +}
> same as above


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 

Re: [PATCH v13 12/16] drm/xe/hwmon: Update memory controller temperature offset for CRI

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 05:28:02PM +0530, Karthik Poosa wrote:
> On CRI the memory controller temperatures moved in the READ_THERMAL_DATA
> output: they now occupy bytes 16..19 instead of starting at byte 2.
> 
> Read and average the CRI memory controller sensors from bytes 16..19,
> keeping the existing byte 2..count-1 range for earlier platforms. Only
> the group(s) covering the used bytes are fetched.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
> 
> v2: Use the CRI memory temperature mapping only on
>     Crescent Island. (sashiko)
> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index dad2397db141..eef6560569ce 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -109,6 +109,10 @@ enum sensor_attr_power {
>  /* Index of memory controller in READ_THERMAL_DATA output */
>  #define TEMP_INDEX_MCTRL	2
>  
> +/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
> +#define CRI_TEMP_INDEX_MCTRL	16
> +#define CRI_TEMP_MCTRL_COUNT	4
> +
>  /* Mailbox sentinel reported for an unavailable temperature sensor */
>  #define TEMP_MBX_INVALID	0xFF
>  
> @@ -986,14 +990,22 @@ static int mbx_temp_decode(u8 value)
>  static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> -	int ret, i, count = 0;
> +	int ret, i, start, end, count = 0;
>  	s32 average = 0;
> +	u32 data = 0;
>  
>  	guard(mutex)(&hwmon->hwmon_lock);
>  
> -	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
> -		u32 data = 0;
> +	/* CRI relocated the memory controller temperatures to READ_THERMAL_DATA bytes 16..19. */
> +	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {

we need to be consistent... we either use >= cri everywhere or we use ==... 

> +		start = CRI_TEMP_INDEX_MCTRL;
> +		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
> +	} else {
> +		start = TEMP_INDEX_MCTRL;
> +		end = hwmon->temp.count - 1;
> +	}
>  
> +	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
>  		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
>  				    &data, NULL);
>  		if (ret)
> @@ -1002,7 +1014,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  		hwmon->temp.dword[i] = cpu_to_le32(data);
>  	}
>  
> -	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
> +	for (i = start; i < end; i++) {
>  		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
>  			continue;
>  		average += mbx_temp_decode(hwmon->temp.value[i]);
> -- 
> 2.25.1
> 

Re: [PATCH v13 15/16] drm/xe: Validate thermal sensor count before reads

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 05:28:05PM +0530, Karthik Poosa wrote:
> Check that READ_THERMAL_CONFIG reports enough thermal entries for the
> platform-specific MCTRL range and PCIe sensor index before reading
> READ_THERMAL_DATA.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
> 
> v2:
> - Cap the memory controller sensor range at the PCIe sensor index so the
>   PCIe temperature is not averaged into the memory controller temperature.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 44 ++++++++++++++++++++++++-----------
>  1 file changed, 30 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 4249faf9fb39..4b9c18230ade 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -920,6 +920,17 @@ static int mbx_temp_decode(u8 value)
>  	return (value & TEMP_MBX_SIGN) ? -temp : temp;
>  }
>  
> +static u8 xe_hwmon_pcie_temp_index(const struct xe_hwmon *hwmon)
> +{
> +	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
> +		return CRI_TEMP_INDEX_PCIE;
> +
> +	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
> +		return BMG_G21_TEMP_INDEX_PCIE;
> +
> +	return TEMP_INDEX_PCIE;
> +}
> +
>  static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> @@ -935,7 +946,14 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
>  	} else {
>  		start = TEMP_INDEX_MCTRL;
> -		end = hwmon->temp.count - 1;
> +		end = min_t(int, hwmon->temp.count - 1, xe_hwmon_pcie_temp_index(hwmon));
> +	}
> +
> +	if (end <= start || end > hwmon->temp.count) {
> +		drm_warn(&hwmon->xe->drm,
> +			 "memory controller range [%d, %d) is invalid for temperature count %d\n",
> +			 start, end, hwmon->temp.count);
> +		return -ENODATA;
>  	}
>  
>  	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
> @@ -967,30 +985,28 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>  	return 0;
>  }
>  
> -static u8 xe_hwmon_pcie_temp_index(const struct xe_hwmon *hwmon)
> -{
> -	if (hwmon->xe->info.platform == XE_CRESCENTISLAND)
> -		return CRI_TEMP_INDEX_PCIE;
> -
> -	if (hwmon->xe->info.subplatform == XE_SUBPLATFORM_BATTLEMAGE_G21)
> -		return BMG_G21_TEMP_INDEX_PCIE;
> -
> -	return TEMP_INDEX_PCIE;
> -}
> -
>  static int get_pcie_temp(const struct xe_hwmon *hwmon, long *val)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
>  	u32 data = 0;
> +	int index;
>  	int ret;
>  
> +	index = xe_hwmon_pcie_temp_index(hwmon);
> +	if (index >= hwmon->temp.count) {
> +		drm_warn(&hwmon->xe->drm,
> +			 "PCIe temperature index %d out of range for temperature count %d\n",
> +			 index, hwmon->temp.count);
> +		return -ENODATA;
> +	}
> +
>  	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA,
> -						  xe_hwmon_pcie_temp_index(hwmon) / sizeof(data)),
> +						  index / sizeof(data)),
>  						  &data, NULL);
>  	if (ret)
>  		return ret;
>  
> -	data >>= (xe_hwmon_pcie_temp_index(hwmon) % sizeof(data)) * BITS_PER_BYTE;
> +	data >>= (index % sizeof(data)) * BITS_PER_BYTE;
>  	data = REG_FIELD_GET(TEMP_MASK, data);
>  	if (!mbx_temp_valid(hwmon, data)) {
>  		drm_dbg(&hwmon->xe->drm, "PCIe temperature not available\n");
> -- 
> 2.25.1
> 

Re: [PATCH v13 11/16] drm/xe/hwmon: Decode CRI temperature registers as IEEE-754

[Rodrigo Vivi]

On Wed, Oct 14, 2026 at 05:28:01PM +0530, Karthik Poosa wrote:
> CRI temperature registers encode package and VRAM temperatures as
> IEEE-754 floating-point values. Decode these values before exposing
> them through hwmon.
>  
> Use integer-based IEEE-754 decoding since kernel code does not use
> floating-point operations and hwmon reports integer temperatures.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Assisted-by: LLM
> ---
> 
> v2: Add missing description for parameter 'temperature' in
>     xe_hwmon_temperature_decode().
> 
> v3: Add missing mmio_temp_valid() check in xe_hwmon_temp_read() for MMIO
>     temperature register reads.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 99 ++++++++++++++++++++++++++++++-----
>  1 file changed, 85 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index afcc80e34bfd..dad2397db141 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -1266,6 +1266,70 @@ xe_hwmon_temp_is_visible(struct xe_hwmon *hwmon, u32 attr, int channel)
>  	}
>  }
>  
> +#define IEEE754_SIGN		REG_BIT(31)
> +#define IEEE754_EXP_MASK	REG_GENMASK(30, 23)
> +#define IEEE754_MANTISSA_MASK	REG_GENMASK(22, 0)
> +#define IEEE754_EXP_BIAS	127 /* Exponent bias to obtain the actual exponent */
> +#define IEEE754_MANTISSA_BITS	23 /* Mantissa width and implicit leading-1 bit position */
> +#define IEEE754_EXP_SPECIAL	0xff /* reserved exponent value encoding infinity or NaN */
> +
> +/**
> + * xe_hwmon_temperature_decode - Decode an IEEE-754 temperature register value
> + * @reg_val: The raw register value to decode
> + * @temperature: Pointer to store the decoded temperature in millidegrees Celsius.
> + *
> + * IEEE-754 single-precision format:
> + *
> + *  31 30                         23 22                         0
> + * +--+-----------------------------+----------------------------+
> + * | S|          exponent           |          fraction          |
> + * +--+-----------------------------+----------------------------+
> + *
> + * value = (-1)^S * 1.fraction * 2^(exponent - 127)
> + *
> + * Return: 0 on success or an error if @reg_val is non-finite or cannot be
> + * represented in millidegrees Celsius.
> + */
> +static int xe_hwmon_temperature_decode(u32 reg_val, long *temperature)
> +{
> +	u32 exponent = REG_FIELD_GET(IEEE754_EXP_MASK, reg_val);
> +	u32 mantissa = REG_FIELD_GET(IEEE754_MANTISSA_MASK, reg_val);
> +	s64 value;
> +	int shift;
> +
> +	/* Exponent 0xff encodes infinity or NaN. */
> +	if (exponent == IEEE754_EXP_SPECIAL)
> +		return -EINVAL;
> +
> +	/* Subnormal values are smaller than one millidegree Celsius. */
> +	if (!exponent) {
> +		*temperature = 0;
> +		return 0;
> +	}
> +
> +	value = (s64)(mantissa | BIT(IEEE754_MANTISSA_BITS)) * MILLIDEGREE_PER_DEGREE;
> +	shift = exponent - (IEEE754_EXP_BIAS + IEEE754_MANTISSA_BITS);
> +	if (shift >= 0) {
> +		if (shift >= BITS_PER_LONG || value > (LONG_MAX >> shift))
> +			return -ERANGE;
> +		value <<= shift;
> +	} else if (shift > -64) {
> +		value >>= -shift;
> +	} else {
> +		value = 0;
> +	}
> +
> +	/* Ensure the magnitude fits in long, which is 32-bit on some arches. */
> +	if (value > LONG_MAX)
> +		return -ERANGE;
> +
> +	if (reg_val & IEEE754_SIGN)
> +		value = -value;
> +
> +	*temperature = value;
> +	return 0;
> +}
> +
>  static int
>  xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
>  {
> @@ -1275,26 +1339,33 @@ xe_hwmon_temp_read(struct xe_hwmon *hwmon, u32 attr, int channel, long *val)
>  	switch (attr) {
>  	case hwmon_temp_input:
>  		switch (channel) {
> -		case CHANNEL_PKG:
> -		case CHANNEL_VRAM:
> -			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
> -
> -			/* HW register value is in degrees Celsius, convert to millidegrees. */
> -			*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
> -			return 0;
>  		case CHANNEL_MCTRL:
>  			return get_mc_temp(hwmon, val);
>  		case CHANNEL_PCIE:
>  			return get_pcie_temp(hwmon, val);
> +		case CHANNEL_PKG:
> +		case CHANNEL_VRAM:
>  		case CHANNEL_VRAM_N...CHANNEL_VRAM_N_MAX:
>  			reg_val = xe_mmio_read32(mmio, xe_hwmon_get_reg(hwmon, REG_TEMP, channel));
> -			/*
> -			 * This temperature format is 24 bit [31:8] signed integer and 8 bit
> -			 * [7:0] fraction.
> -			 */
> -			*val = (s32)(REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val)) *
> -				(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
> -				 MILLIDEGREE_PER_DEGREE;
> +			if (!mmio_temp_valid(hwmon, reg_val)) {
> +				drm_dbg(&hwmon->xe->drm,
> +					"channel %d temperature invalid, val 0x%llx\n",
> +					channel, reg_val);
> +				return -ENXIO;
> +			}
> +			if (hwmon->xe->info.platform >= XE_CRESCENTISLAND) {
> +				return xe_hwmon_temperature_decode((u32)reg_val, val);
> +			} else if (channel >= CHANNEL_VRAM_N) {
> +				/*
> +				 * This temperature format is 24 bit [31:8] signed integer and 8 bit
> +				 * [7:0] fraction for platforms before CRI.
> +				 */
> +				*val = (s32)REG_FIELD_GET(TEMP_MASK_VRAM_N, reg_val) *
> +					(REG_FIELD_GET(TEMP_SIGN_MASK, reg_val) ? -1 : 1) *
> +					MILLIDEGREE_PER_DEGREE;
> +			} else {
> +				*val = REG_FIELD_GET(TEMP_MASK, reg_val) * MILLIDEGREE_PER_DEGREE;
> +			}
>  			return 0;
>  		default:
>  			return -EOPNOTSUPP;
> -- 
> 2.25.1
> 

✓ Xe.CI.BAT: success for drm/xe/hwmon: Update hwmon thermal mailbox

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3816 bytes --]

== Series Details ==

Series: drm/xe/hwmon: Update hwmon thermal mailbox
URL   : https://patchwork.freedesktop.org/series/176121/
State : success

== Summary ==

CI Bug Log - changes from xe-5946-c06d7623a198463e9aa2d09a3c33d96fe66ea662_BAT -> xe-pw-176121v1_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (14 -> 14)
------------------------------

  Additional (1): bat-ptl-vm 
  Missing    (1): bat-nvls-2 

Known issues
------------

  Here are the changes found in xe-pw-176121v1_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@xe_evict@evict-beng-small-cm:
    - bat-ptl-vm:         NOTRUN -> [SKIP][1] ([Intel XE#5764]) +11 other tests skip
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_evict@evict-beng-small-cm.html

  * igt@xe_exec_balancer@no-exec-cm-virtual-basic:
    - bat-ptl-vm:         NOTRUN -> [SKIP][2] ([Intel XE#7482]) +17 other tests skip
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_exec_balancer@no-exec-cm-virtual-basic.html

  * igt@xe_exec_multi_queue@many-queues-preempt-mode-close-fd:
    - bat-ptl-vm:         NOTRUN -> [SKIP][3] ([Intel XE#8364]) +13 other tests skip
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_exec_multi_queue@many-queues-preempt-mode-close-fd.html

  * igt@xe_live_ktest@xe_bo@xe_bo_evict_kunit:
    - bat-ptl-vm:         NOTRUN -> [SKIP][4] ([Intel XE#5775]) +2 other tests skip
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_live_ktest@xe_bo@xe_bo_evict_kunit.html

  * igt@xe_mmap@vram:
    - bat-ptl-vm:         NOTRUN -> [SKIP][5] ([Intel XE#5776])
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_mmap@vram.html

  * igt@xe_pat@pat-index-xehpc:
    - bat-ptl-vm:         NOTRUN -> [SKIP][6] ([Intel XE#5777] / [Intel XE#7590])
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_pat@pat-index-xehpc.html

  * igt@xe_pat@pat-index-xelp:
    - bat-ptl-vm:         NOTRUN -> [SKIP][7] ([Intel XE#5771] / [Intel XE#7590])
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_pat@pat-index-xelp.html

  * igt@xe_pat@pat-index-xelpg:
    - bat-ptl-vm:         NOTRUN -> [SKIP][8] ([Intel XE#5780] / [Intel XE#7590])
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/bat-ptl-vm/igt@xe_pat@pat-index-xelpg.html

  
  [Intel XE#5764]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5764
  [Intel XE#5771]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5771
  [Intel XE#5775]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5775
  [Intel XE#5776]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5776
  [Intel XE#5777]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5777
  [Intel XE#5780]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5780
  [Intel XE#7482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7482
  [Intel XE#7590]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7590
  [Intel XE#8364]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8364


Build changes
-------------

  * IGT: IGT_9145 -> IGT_9146
  * Linux: xe-5946-c06d7623a198463e9aa2d09a3c33d96fe66ea662 -> xe-pw-176121v1

  IGT_9145: 05c13a14f7f8bcda7bff83b8aa033c3c47a4b1fb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  IGT_9146: 9e6040664f13f0767bb4d1028b422b7ee00425dc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-5946-c06d7623a198463e9aa2d09a3c33d96fe66ea662: c06d7623a198463e9aa2d09a3c33d96fe66ea662
  xe-pw-176121v1: 176121v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-176121v1/index.html

[-- Attachment #2: Type: text/html, Size: 4708 bytes --]

Re: [PATCH v13 12/16] drm/xe/hwmon: Update memory controller temperature offset for CRI

[Poosa, Karthik]

On 14-10-2026 23:22, Rodrigo Vivi wrote:
> On Wed, Oct 14, 2026 at 05:28:02PM +0530, Karthik Poosa wrote:
>> On CRI the memory controller temperatures moved in the READ_THERMAL_DATA
>> output: they now occupy bytes 16..19 instead of starting at byte 2.
>>
>> Read and average the CRI memory controller sensors from bytes 16..19,
>> keeping the existing byte 2..count-1 range for earlier platforms. Only
>> the group(s) covering the used bytes are fetched.
>>
>> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
>> ---
>>
>> v2: Use the CRI memory temperature mapping only on
>>      Crescent Island. (sashiko)
>>
>>   drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>> index dad2397db141..eef6560569ce 100644
>> --- a/drivers/gpu/drm/xe/xe_hwmon.c
>> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
>> @@ -109,6 +109,10 @@ enum sensor_attr_power {
>>   /* Index of memory controller in READ_THERMAL_DATA output */
>>   #define TEMP_INDEX_MCTRL	2
>>   
>> +/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
>> +#define CRI_TEMP_INDEX_MCTRL	16
>> +#define CRI_TEMP_MCTRL_COUNT	4
>> +
>>   /* Mailbox sentinel reported for an unavailable temperature sensor */
>>   #define TEMP_MBX_INVALID	0xFF
>>   
>> @@ -986,14 +990,22 @@ static int mbx_temp_decode(u8 value)
>>   static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>>   {
>>   	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
>> -	int ret, i, count = 0;
>> +	int ret, i, start, end, count = 0;
>>   	s32 average = 0;
>> +	u32 data = 0;
>>   
>>   	guard(mutex)(&hwmon->hwmon_lock);
>>   
>> -	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
>> -		u32 data = 0;
>> +	/* CRI relocated the memory controller temperatures to READ_THERMAL_DATA bytes 16..19. */
>> +	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {
> we need to be consistent... we either use >= cri everywhere or we use ==...

I used == explicitly here, as sensor mapping can change based on the 
platform configuration.

where as MMIO definitions and mailbox definitions are expected to be 
same in future platforms.

if those can change, I shall make all places == XE_CRESCENTISLAND

>
>> +		start = CRI_TEMP_INDEX_MCTRL;
>> +		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
>> +	} else {
>> +		start = TEMP_INDEX_MCTRL;
>> +		end = hwmon->temp.count - 1;
>> +	}
>>   
>> +	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
>>   		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
>>   				    &data, NULL);
>>   		if (ret)
>> @@ -1002,7 +1014,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
>>   		hwmon->temp.dword[i] = cpu_to_le32(data);
>>   	}
>>   
>> -	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
>> +	for (i = start; i < end; i++) {
>>   		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
>>   			continue;
>>   		average += mbx_temp_decode(hwmon->temp.value[i]);
>> -- 
>> 2.25.1
>>

Re: [PATCH v13 12/16] drm/xe/hwmon: Update memory controller temperature offset for CRI

[Rodrigo Vivi]

On Thu, Oct 15, 2026 at 01:03:36AM +0530, Poosa, Karthik wrote:
> 
> On 14-10-2026 23:22, Rodrigo Vivi wrote:
> > On Wed, Oct 14, 2026 at 05:28:02PM +0530, Karthik Poosa wrote:
> > > On CRI the memory controller temperatures moved in the READ_THERMAL_DATA
> > > output: they now occupy bytes 16..19 instead of starting at byte 2.
> > > 
> > > Read and average the CRI memory controller sensors from bytes 16..19,
> > > keeping the existing byte 2..count-1 range for earlier platforms. Only
> > > the group(s) covering the used bytes are fetched.
> > > 
> > > Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> > > ---
> > > 
> > > v2: Use the CRI memory temperature mapping only on
> > >      Crescent Island. (sashiko)
> > > 
> > >   drivers/gpu/drm/xe/xe_hwmon.c | 20 ++++++++++++++++----
> > >   1 file changed, 16 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> > > index dad2397db141..eef6560569ce 100644
> > > --- a/drivers/gpu/drm/xe/xe_hwmon.c
> > > +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> > > @@ -109,6 +109,10 @@ enum sensor_attr_power {
> > >   /* Index of memory controller in READ_THERMAL_DATA output */
> > >   #define TEMP_INDEX_MCTRL	2
> > > +/* On CRI the memory controller temperatures are READ_THERMAL_DATA bytes 16..19. */
> > > +#define CRI_TEMP_INDEX_MCTRL	16
> > > +#define CRI_TEMP_MCTRL_COUNT	4
> > > +
> > >   /* Mailbox sentinel reported for an unavailable temperature sensor */
> > >   #define TEMP_MBX_INVALID	0xFF
> > > @@ -986,14 +990,22 @@ static int mbx_temp_decode(u8 value)
> > >   static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
> > >   {
> > >   	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> > > -	int ret, i, count = 0;
> > > +	int ret, i, start, end, count = 0;
> > >   	s32 average = 0;
> > > +	u32 data = 0;
> > >   	guard(mutex)(&hwmon->hwmon_lock);
> > > -	for (i = 0; i < DIV_ROUND_UP(hwmon->temp.count, sizeof(u32)); i++) {
> > > -		u32 data = 0;
> > > +	/* CRI relocated the memory controller temperatures to READ_THERMAL_DATA bytes 16..19. */
> > > +	if (hwmon->xe->info.platform == XE_CRESCENTISLAND) {
> > we need to be consistent... we either use >= cri everywhere or we use ==...
> 
> I used == explicitly here, as sensor mapping can change based on the
> platform configuration.
> 
> where as MMIO definitions and mailbox definitions are expected to be same in
> future platforms.

I'm afraid we cannot assure that. I just want us to be consistent,
that's all.

> 
> if those can change, I shall make all places == XE_CRESCENTISLAND

probably better.
with that:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and keep anywhere that is modified

> 
> > 
> > > +		start = CRI_TEMP_INDEX_MCTRL;
> > > +		end = CRI_TEMP_INDEX_MCTRL + CRI_TEMP_MCTRL_COUNT;
> > > +	} else {
> > > +		start = TEMP_INDEX_MCTRL;
> > > +		end = hwmon->temp.count - 1;
> > > +	}
> > > +	for (i = start / sizeof(u32); i < DIV_ROUND_UP(end, sizeof(u32)); i++) {
> > >   		ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_DATA, i),
> > >   				    &data, NULL);
> > >   		if (ret)
> > > @@ -1002,7 +1014,7 @@ static int get_mc_temp(struct xe_hwmon *hwmon, long *val)
> > >   		hwmon->temp.dword[i] = cpu_to_le32(data);
> > >   	}
> > > -	for (i = TEMP_INDEX_MCTRL; i < hwmon->temp.count - 1; i++) {
> > > +	for (i = start; i < end; i++) {
> > >   		if (!mbx_temp_valid(hwmon, hwmon->temp.value[i]))
> > >   			continue;
> > >   		average += mbx_temp_decode(hwmon->temp.value[i]);
> > > -- 
> > > 2.25.1
> > >