[PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space

[PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space

[Mehmet Fide]

From: Mehmet Fide <mehmet.fide@screeningeagle.com>

Since commit 53b406369e9d ("DFU: Check the number of arguments and
argument string strictly") the NAND backend takes an entry as
"<name> part <dev> <part>", three arguments. The default dfu_alt_info
of colibri_vf still uses the older "part 0,1" form, two arguments, so
its first entry already fails with -EINVAL and "dfu 0 nand 0" returns
at once, before the gadget starts.

Separate the device and the partition number with a space. The
partitions stay the same: vf-bcb, u-boot and ubi.

Fixes: 53b406369e9d ("DFU: Check the number of arguments and argument string strictly")
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---

Notes:
    Tested on a Colibri VF50 with the ehci-vf series [1] applied, which
    the gadget on usb0 needs to start at all: after "env default -f
    dfu_alt_info", "dfu 0 nand 0 list" shows vf-bcb, u-boot and ubi, and
    "dfu 0 nand 0" enumerates on a host and stops at Ctrl-C. With the old
    value the list fails at once.
    
    [1] https://lore.kernel.org/u-boot/20261023111559.4081795-1-mehmet.fide@gmail.com/

 include/configs/colibri_vf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/colibri_vf.h b/include/configs/colibri_vf.h
index 60f31389fd4..060e0ac3fe2 100644
--- a/include/configs/colibri_vf.h
+++ b/include/configs/colibri_vf.h
@@ -45,7 +45,7 @@
 #undef BOOTENV_RUN_NET_USB_START
 #define BOOTENV_RUN_NET_USB_START ""
 
-#define DFU_ALT_NAND_INFO "vf-bcb part 0,1;u-boot part 0,2;ubi part 0,4"
+#define DFU_ALT_NAND_INFO "vf-bcb part 0 1;u-boot part 0 2;ubi part 0 4"
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	BOOTENV \

base-commit: f97bb5c1ad78e95856917b92c7270c82d4b11e21
-- 
2.55.0

Re: [PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space

[Francesco Dolcini]

On Sat, Oct 24, 2026 at 01:34:59PM +0200, Mehmet Fide wrote:
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
> 
> Since commit 53b406369e9d ("DFU: Check the number of arguments and
> argument string strictly") the NAND backend takes an entry as
> "<name> part <dev> <part>", three arguments. The default dfu_alt_info
> of colibri_vf still uses the older "part 0,1" form, two arguments, so
> its first entry already fails with -EINVAL and "dfu 0 nand 0" returns
> at once, before the gadget starts.
> 
> Separate the device and the partition number with a space. The
> partitions stay the same: vf-bcb, u-boot and ubi.
> 
> Fixes: 53b406369e9d ("DFU: Check the number of arguments and argument string strictly")
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Re: [PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space

[Mattijs Korpershoek]

Hi Mehmet,

Thank you for the patch.

On Sat, Oct 24, 2026 at 13:34, Mehmet Fide <mehmet.fide@gmail.com> wrote:

> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
> Since commit 53b406369e9d ("DFU: Check the number of arguments and
> argument string strictly") the NAND backend takes an entry as
> "<name> part <dev> <part>", three arguments. The default dfu_alt_info
> of colibri_vf still uses the older "part 0,1" form, two arguments, so
> its first entry already fails with -EINVAL and "dfu 0 nand 0" returns
> at once, before the gadget starts.
>
> Separate the device and the partition number with a space. The
> partitions stay the same: vf-bcb, u-boot and ubi.
>
> Fixes: 53b406369e9d ("DFU: Check the number of arguments and argument string strictly")
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>