Re: [PATCH 01/14] Hexagon: add v85 CPU model

[Anton Johansson via qemu development <qemu-devel@nongnu.org>]

On 19/10/26, Brian Cain wrote:
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
>  docs/system/hexagon/emulation.rst | 2 +-
>  target/hexagon/cpu-qom.h          | 4 ++++
>  linux-user/hexagon/elfload.c      | 4 ++++
>  target/hexagon/cpu.c              | 2 ++
>  4 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/system/hexagon/emulation.rst b/docs/system/hexagon/emulation.rst
> index 12385311aa4..fb57c77ae90 100644
> --- a/docs/system/hexagon/emulation.rst
> +++ b/docs/system/hexagon/emulation.rst
> @@ -6,7 +6,7 @@ Hexagon CPU architecture support
>  ================================
>  
>  QEMU's TCG emulation includes support for v65, v66, v67, v68, v69, v71, v73,
> -v75, v77, v79, v81.
> +v75, v77, v79, v81, v83, v85.
>  It also has support for the following architecture extensions:
>  
>  - HVX (Hexagon Vector eXtensions)
> diff --git a/target/hexagon/cpu-qom.h b/target/hexagon/cpu-qom.h
> index 2bfa4d5d0fc..d4c8413ded3 100644
> --- a/target/hexagon/cpu-qom.h
> +++ b/target/hexagon/cpu-qom.h
> @@ -28,6 +28,8 @@ typedef enum {
>      HEX_VER_V75 = 0x75,
>      HEX_VER_V79 = 0x79,
>      HEX_VER_V81 = 0x81,
> +    HEX_VER_V83 = 0x83,
> +    HEX_VER_V85 = 0x85,
>      HEX_VER_ANY = 0xff,
>  } HexagonVersion;

I think you missed adding HEX_VER_V85 to get_elf_hwcap(), currently it
would take the default case and return 0.

Otherwise,

Reviewed-by: Anton Johansson <anjo@rev.ng>