From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] MyFirstContribution: move "how to send v2" after discussing reviews
Date: Wed, 21 Oct 2026 10:49:55 +0200 [thread overview]
Message-ID: <ath8s3kEQoQwK_lo@pks.im> (raw)
In-Reply-To: <20261020232242.2217109-2-gitster@pobox.com>
On Tue, Oct 20, 2026 at 04:22:41PM -0700, Junio C Hamano wrote:
> The MyFirstContribution document tells readers how to send v1, how
> to send v2, and then how to respond to reviews, in that order.
>
> It is unclear how much blame can be placed on this text, but senior
> community members find themselves more and more frequently having to
> tell new contributors not to send updated iterations of their patches
> before having any review discussion on the current iteration.
>
> As a small first step to rectify the situation, move the description
> of how to send v2 so that it appears after we have told readers to
> expect and respond to reviews on their first iteration. This step
> contains no text changes. Only the ordering changes, which are
> friendly to 'git diff --color-moved', are included here.
Yup. And that command shows that it's a trivial move indeed.
Patrick
next prev parent reply other threads:[~2026-10-21 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 20:43 [PATCH] MyFirstContribution: move preparation of v2 after review discussion Junio C Hamano
2026-10-20 14:33 ` Patrick Steinhardt
2026-10-20 16:32 ` Junio C Hamano
2026-10-20 23:22 ` [PATCH v2 0/2] MyFirstContribution: discuss then reroll Junio C Hamano
2026-10-20 23:22 ` [PATCH v2 1/2] MyFirstContribution: move "how to send v2" after discussing reviews Junio C Hamano
2026-10-21 8:49 ` Patrick Steinhardt [this message]
2026-10-20 23:22 ` [PATCH v2 2/2] MyFirstContribution: clarify that "reviewing" is a discussion Junio C Hamano
2026-10-21 8:49 ` Patrick Steinhardt
2026-10-21 16:22 ` Junio C Hamano
2026-10-22 11:24 ` Patrick Steinhardt
2026-10-22 21:14 ` [PATCH v4 0/2] MyFirstContribution: discuss then reroll Junio C Hamano
2026-10-22 21:14 ` [PATCH v4 1/2] MyFirstContribution: move "how to send v2" after discussing reviews Junio C Hamano
2026-10-22 21:14 ` [PATCH v4 2/2] MyFirstContribution: clarify that "reviewing" is a discussion Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ath8s3kEQoQwK_lo@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.