Re: [PATCH v2 2/2] MyFirstContribution: clarify that "reviewing" is a discussion

[Patrick Steinhardt <ps@pks.im>]

On Wed, Oct 21, 2026 at 09:22:03AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> >>  [[reviewing]]
> >>  === Responding to Reviews
> >>  
> >> -After a few days, you will hopefully receive a reply to your patchset with some
> >> -comments. Woohoo! Now you can get back to work.
> >> -
> >> -It's good manners to reply to each comment in the mailing list discussion
> >> -instead of letting the next version of your patch be your only response. Tell
> >> -the reviewer whether you plan to make the suggested change, keep the original,
> >> -or pursue a different approach.
> >
> > This is a sentence we lose in the rewrite, but I'd say that it may be
> > useful information to retain.
> 
> Hmph, "communicate your plan" certainly is half lost.  An early
> section ("now-what") advises to communicate "I'll do it differently,
> disregard this iteration" to avoid wasting reviewers' time, and the
> rewritten "reviewing" section somewhat hints to communicate other
> kind of plans with "your reasoning" in
> 
>     Do not start coding, much less send the next version of your patch,
>     until you have finished discussing the current round of reviews with
>     your reviewers.  This saves time for both you and your reviewers.
>     They can respond to your reasoning before you spend time preparing a
>     version they might reject, and they will not have to inspect your
>     'v2' to check if you addressed their concerns.
> 
> but it would be better to be more explicit how "your reasoning"
> should be presented, I guess.  How about inserting "so that both
> sides know what to expect in the next round" to clarify what "finish
> discussing" entails?
> 
>     Do not start coding, let alone send the next version of your
>     patch, until you have finished discussing the current one so
>     both sides know what to expect.  This saves time for everyone.
>     Reviewers can respond to your explanation before you spend time
>     preparing a patch they might reject, and they will not have to
>     inspect 'v2' only to find their concerns unaddressed.

Yeah, I think that's good enough. Thanks!

Patrick