From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Lee Jones <lee@kernel.org>,
Rillian Grant <rillian.grant@gmail.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ruslan Koreev <koreev.r@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes
Date: Wed, 21 Oct 2026 09:38:39 +0300 [thread overview]
Message-ID: <athd74yu2qng04Tc@ashevche-desk.local> (raw)
In-Reply-To: <atdOUv937j63NKAL@kekkonen.localdomain>
On Tue, Oct 20, 2026 at 02:19:46PM +0300, Sakari Ailus wrote:
> On Tue, Oct 20, 2026 at 11:45:06AM +0100, Lee Jones wrote:
...
> > Andy, et al.,
> >
> > I don't usually allow data from other registration mechanisms to be
> > passed through another (MFD data via OF for instance).
> >
> > Is this okay?
Seconding Sakari's answer, this doesn't sound like the best approach.
> In this case the ipu-bridge needs to provide the information to the lm3643
> driver via software nodes, as it already does for a number of other
> devices. There's no point in putting the information to the LED driver.
>
> Presumably the ACPI device node already exists so this should be
> straightforward. What's also missing from the sensor then is the flash-leds
> property, the lens-focus handling serves as an example.
+1 to all the above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-21 6:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 19:09 [PATCH v3 0/4] leds: flash: LM3643 dual LED flash driver Rillian Grant
2026-10-11 19:09 ` [PATCH v3 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-10-11 19:14 ` sashiko-bot
2026-10-12 9:51 ` Krzysztof Kozlowski
2026-10-11 19:09 ` [PATCH v3 2/4] leds: flash: Add support for the " Rillian Grant
2026-10-11 19:20 ` sashiko-bot
2026-10-13 9:31 ` Rillian Grant
2026-10-11 19:09 ` [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-10-11 19:20 ` sashiko-bot
2026-10-13 9:38 ` Rillian Grant
2026-10-20 10:37 ` Lee Jones
2026-10-20 10:45 ` Lee Jones
2026-10-20 11:19 ` Sakari Ailus
2026-10-21 6:38 ` Andy Shevchenko [this message]
2026-10-11 19:09 ` [PATCH v3 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-10-11 19:15 ` sashiko-bot
2026-10-20 10:54 ` Lee Jones
2026-10-21 14:40 ` Ruslan Koreev
2026-11-04 17:24 ` Rillian Grant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=athd74yu2qng04Tc@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=koreev.r@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rillian.grant@gmail.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.