All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Matt Hunter <m@lfurio.us>
Cc: git@vger.kernel.org, Harald Nordgren <haraldnordgren@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] init: show absolute path of (re)initialized repository
Date: Fri, 23 Oct 2026 08:26:46 +0200	[thread overview]
Message-ID: <atr-Juww5KZN-ugM@pks.im> (raw)
In-Reply-To: <20261022120749.3567828-1-m@lfurio.us>

On Thu, Oct 22, 2026 at 08:06:32AM -0400, Matt Hunter wrote:
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f27167..fbf8a0e41dad 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -1000,4 +1000,10 @@ test_expect_success 'init honors GIT_OBJECT_DIRECTORY' '
>  	test_path_is_dir custom-odb/info
>  '
>  
> +test_expect_success 'init shows absolute path to gitdir' '
> +	expect="$(pwd)/init-path" &&

I don't think this extra variable buys us anything, so I'd just drop it.

> +	git init init-path >actual &&
> +	test_grep "$expect" actual
> +'

I would have tested for the whole message, which is short enough to be
reasonable, I'd say.

Other than those nits I'm happy, thanks!

Patrick

  reply	other threads:[~2026-10-23  6:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  5:38 [PATCH] init: show absolute path of (re)initialized repository Matt Hunter
2026-10-20  6:55 ` Patrick Steinhardt
2026-10-20  9:13   ` Matt Hunter
2026-10-20 12:14     ` Patrick Steinhardt
2026-10-20 12:37   ` Harald Nordgren
2026-10-20 14:37     ` Patrick Steinhardt
2026-10-20 15:32       ` Harald Nordgren
2026-10-20 16:29       ` Junio C Hamano
2026-10-22 12:06 ` [PATCH v2] " Matt Hunter
2026-10-23  6:26   ` Patrick Steinhardt [this message]
2026-10-23 12:21     ` Matt Hunter
2026-10-26  7:01       ` Patrick Steinhardt
2026-10-28  5:16 ` [PATCH v3] " Matt Hunter
2026-10-28  7:03   ` Patrick Steinhardt
2026-10-28 15:59     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atr-Juww5KZN-ugM@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=m@lfurio.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.