From: Oliver Upton <oupton@kernel.org>
To: Leonardo Bras <leo.bras@arm.com>
Cc: kvmarm@lists.linux.dev, Marc Zyngier <maz@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Wei-Lin Chang <weilin.chang@arm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Fuad Tabba <fuad.tabba@linux.dev>
Subject: Re: [PATCH v2 18/28] KVM: arm64: nv: Emulate CMOs via writable-clean translations as NOPs
Date: Wed, 4 Nov 2026 10:04:14 -0800 [thread overview]
Message-ID: <autzno1eEpw4X-0I@kernel.org> (raw)
In-Reply-To: <autrOLZWT-s4Ailc@LeoBrasDK>
On Wed, Nov 04, 2026 at 05:28:24PM +0000, Leonardo Bras wrote:
> > The writable-clean state is nonexistent when VTCR_EL2.HD=0 in the direct
> > permission model. So we have no way to construct a translation in the
> > stage-2 that satisfies our requirements.
>
> Since other vcpus will have VTCR_EL2.HD=0, couldn't we enable it just for
> the sake of processing this CMO?
>
> I guess it would need to either decode the instruction or single-step this
> vcpu just to make sure it does not write to the same page we just did mark
> WC.
>
> >
> > The other way to do this would likely involve halting all vCPUs in the
> > VM and attempting to single-step which has a near 100% chance of blowing
> > up in our face.
>
> Sorry, why all vCPUs?
>
> I know for all vCPUs it would be terrible for performance, what else
> do you mean by "blowing up in our face"?
In order to make this work, you need to guarantee that there's no
concurrent updates to either the instruction itself of the stage-1
translation.
The operations would be, approximately:
- Take a stage-2 permission fault on the cache maintenance instruction.
Walk the guest's stage-2 and find a translation in writable-clean
state.
- Pause the VM, re-enter the guest and single-step the instruction. If
we take the debug exception then the guest must've changed the
instruction. Go back to base state.
- If we take another stage-2 permission fault for a cache maintenance
instruction, temporarily promote the translation to RW in the shadow
stage-2 and re-enter with single-step enabled.
- Take the debug exception, invalidate the shadow stage-2 translation,
disarm single-step, restart the VM.
The transient RW mappings seems ripe for pretty nasty bugs.
Thanks,
Oliver
next prev parent reply other threads:[~2026-11-04 18:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 20:55 [PATCH v2 00/28] KVM: arm64: nv: Implement FEAT_HAFDBS, FEAT_HAFT Oliver Upton
2026-10-23 20:55 ` [PATCH v2 01/28] KVM: arm64: nv: Introduce struct for stage-2 walk step Oliver Upton
2026-10-23 20:55 ` [PATCH v2 02/28] KVM: arm64: nv: Consolidate computation of stage-2 permissions Oliver Upton
2026-10-23 20:55 ` [PATCH v2 03/28] KVM: arm64: nv: Get rid of kvm_s2_trans*() accessors Oliver Upton
2026-10-23 20:55 ` [PATCH v2 04/28] KVM: arm64: nv: Only shadow writable-dirty guest descs as writable Oliver Upton
2026-10-23 21:25 ` sashiko-bot
2026-10-24 6:26 ` Oliver Upton
2026-11-02 17:27 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 05/28] KVM: arm64: nv: Pass an access descriptor for stage-2 walks Oliver Upton
2026-11-02 17:41 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 06/28] KVM: arm64: nv: Use a helper for stage-2 descriptor updates Oliver Upton
2026-11-02 17:51 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 07/28] KVM: arm64: nv: Set dirty state at stage-2 Oliver Upton
2026-11-02 18:14 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 08/28] KVM: arm64: nv: Treat DBM as writable " Oliver Upton
2026-10-23 20:55 ` [PATCH v2 09/28] KVM: arm64: Compute S1 permissions as part of s1_walk() Oliver Upton
2026-10-23 20:55 ` [PATCH v2 10/28] KVM: arm64: Plumb through access descriptor for stage-1 Oliver Upton
2026-10-23 21:06 ` sashiko-bot
2026-11-03 17:37 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 11/28] KVM: arm64: Use a struct for stage-1 walk context Oliver Upton
2026-10-23 20:55 ` [PATCH v2 12/28] KVM: arm64: Create helper for stage-1 descriptor updates Oliver Upton
2026-10-23 20:55 ` [PATCH v2 13/28] KVM: arm64: Set dirty state at stage-1 Oliver Upton
2026-10-23 20:55 ` [PATCH v2 14/28] KVM: arm64: nv: Respect HA when computing translated TCR Oliver Upton
2026-11-03 17:58 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 15/28] KVM: arm64: nv: Respect HD " Oliver Upton
2026-11-03 18:08 ` Leonardo Bras
2026-10-23 20:55 ` [PATCH v2 16/28] KVM: arm64: Grant write permission when DBM is set at S1 Oliver Upton
2026-10-23 20:55 ` [PATCH v2 17/28] KVM: arm64: Don't update descriptors for "non-arch" access Oliver Upton
2026-10-23 20:56 ` [PATCH v2 18/28] KVM: arm64: nv: Emulate CMOs via writable-clean translations as NOPs Oliver Upton
2026-11-04 15:03 ` Leonardo Bras
2026-11-04 17:22 ` Oliver Upton
2026-11-04 17:28 ` Leonardo Bras
2026-11-04 18:04 ` Oliver Upton [this message]
2026-11-04 18:27 ` Leonardo Bras
2026-11-04 18:28 ` Leonardo Bras
2026-11-04 18:32 ` Leonardo Bras
2026-10-23 20:56 ` [PATCH v2 19/28] arm64: Add command line switch to disable FEAT_S2FWB Oliver Upton
2026-11-04 15:58 ` Leonardo Bras
2026-10-23 20:56 ` [PATCH v2 20/28] KVM: arm64: Reject non-coherent DMA when using forced writeback Oliver Upton
2026-10-23 21:16 ` sashiko-bot
2026-11-04 16:19 ` Leonardo Bras
2026-10-23 20:56 ` [PATCH v2 21/28] KVM: arm64: nv: Expose FEAT_HAFDBS Oliver Upton
2026-11-04 16:56 ` Leonardo Bras
2026-10-23 20:56 ` [PATCH v2 22/28] KVM: arm64: Set Access flag on table descriptors at stage-1 Oliver Upton
2026-10-23 21:22 ` sashiko-bot
2026-10-24 6:24 ` Oliver Upton
2026-10-23 20:56 ` [PATCH v2 23/28] KVM: arm64: nv: Set access flag on table descriptors at stage-2 Oliver Upton
2026-10-23 20:56 ` [PATCH v2 24/28] KVM: arm64: nv: Expose FEAT_HAFT Oliver Upton
2026-10-23 20:56 ` [PATCH v2 25/28] KVM: arm64: selftests: Only test AF behavior for emulated AT insns Oliver Upton
2026-10-23 20:56 ` [PATCH v2 26/28] KVM: arm64: selftests: Test AT emulation for FEAT_HAFT Oliver Upton
2026-10-23 20:56 ` [PATCH v2 27/28] KVM: arm64: Add tracepoints for S1 page table walk Oliver Upton
2026-11-04 17:09 ` Leonardo Bras
2026-10-23 20:56 ` [PATCH v2 28/28] KVM: arm64: Add tracepoints for S2 " Oliver Upton
2026-11-04 17:10 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=autzno1eEpw4X-0I@kernel.org \
--to=oupton@kernel.org \
--cc=fuad.tabba@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=leo.bras@arm.com \
--cc=maz@kernel.org \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=weilin.chang@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.