All of lore.kernel.org
 help / color / mirror / Atom feed
* x-remote-object breaks QOM introspection
@ 2026-11-17 14:58 Markus Armbruster
  2026-11-18 15:27 ` Jag Raman
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2026-11-17 14:58 UTC (permalink / raw)
  To: Elena Ufimtseva, Jagannathan Raman
  Cc: qemu-devel, Paolo Bonzini, Daniel P. Berrangé,
	Philippe Mathieu-Daudé, Zhao Liu

Watch this:

    $ qemu-system-x86_64 -S -nodefaults -display none -qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 90, "minor": 1, "major": 11}, "package": "v11.2.0-rc0-3-g38171f59ccb-dirty"}, "capabilities": ["oob"]}}
    {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}}
    {"return": {}}
    {"execute": "qom-list-properties", "arguments": {"typename": "x-remote-object"}}
--> qemu-system-x86_64: (null) is not a PCI device
    {"return": [{"name": "type", "type": "string", "qapi-type": "str"}, {"name": "devid", "type": "string", "qapi-type": "str"}, {"name": "fd", "type": "string", "qapi-type": "str"}]}

The error message is suspicious.  Origin:

    static void remote_object_machine_done(Notifier *notifier, void *data)
    {
        RemoteObject *o = container_of(notifier, RemoteObject, machine_done);
        DeviceState *dev = NULL;
        QIOChannel *ioc = NULL;
        Coroutine *co = NULL;
        RemoteCommDev *comdev = NULL;
        Error *err = NULL;

        dev = qdev_find_recursive(sysbus_get_default(), o->devid);
        if (!dev || !object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
            error_report("%s is not a PCI device", o->devid);
            return;
        }

o->devid is null, dev is null.

Glibc's %s shows null pointer as "(null)".  There are libcs that simply
crash.

Stack backtrace:

    #0  remote_object_machine_done (notifier=0x5555587d17e8, data=0x0)
        at ../hw/remote/remote-obj.c:93
    #1  0x000055555578700e in qemu_add_machine_init_done_notifier
        (notify=0x5555587d17e8) at ../hw/core/machine.c:1721
    #2  0x00005555556f26dd in remote_object_init (obj=0x5555587d17c0)
        at ../hw/remote/remote-obj.c:149
    #3  0x0000555555cbda2d in object_init_with_type
        (obj=0x5555587d17c0, ti=0x5555577c02d0) at ../qom/object.c:430
    #4  0x0000555555cbde2c in object_initialize_with_type
        (obj=0x5555587d17c0, size=136, type=0x5555577c02d0) at ../qom/object.c:512
    #5  0x0000555555cbe6fa in object_new_with_type (type=0x5555577c02d0)
        at ../qom/object.c:710
    #6  0x0000555555cbe784 in object_new
        (typename=0x555558356a10 "x-remote-object") at ../qom/object.c:726
    #7  0x0000555555e2d6be in qmp_qom_list_properties
        (typename=0x555558356a10 "x-remote-object", errp=0x7fffffffd888)
        at ../qom/qom-qmp-cmds.c:290
    [...]

I believe using qemu_add_machine_init_done_notifier() is wrong here.
Could we use UserCreatableClass method complete()?

Aside: we should probably check all uses of
qemu_add_machine_init_done_notifier().


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-20  8:53 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 14:58 x-remote-object breaks QOM introspection Markus Armbruster
2026-11-18 15:27 ` Jag Raman
2026-11-19  6:07   ` Markus Armbruster
2026-11-19 16:13     ` Jag Raman
2026-11-19 16:25       ` Daniel P. Berrangé
2026-11-20  5:21         ` Markus Armbruster
2026-11-20  8:53           ` Daniel P. Berrangé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.