From: Mike Rapoport <rppt@kernel.org>
To: Thorsten Blum <blum@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init()
Date: Wed, 11 Nov 2026 19:31:49 +0200 [thread overview]
Message-ID: <avSmhSbrBUBqPLxK@kernel.org> (raw)
In-Reply-To: <20261111133635.75044-3-blum@kernel.org>
On Wed, Nov 11, 2026 at 02:36:34PM +0100, Thorsten Blum wrote:
> Since commit 35c3151a98a6 ("x86/mm: Consolidate initmem_init()") removed
> arch/x86/mm/numa_32.c, highstart_pfn and highend_pfn are only used in
> initmem_init().
>
> Declare both variables locally and remove their unused extern
> declaration. Use min() to initialize highstart_pfn.
>
> No functional change.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> arch/x86/include/asm/highmem.h | 3 ---
> arch/x86/mm/init_32.c | 8 +++-----
> 2 files changed, 3 insertions(+), 8 deletions(-)
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-11-11 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 13:36 [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init() Thorsten Blum
2026-11-11 13:36 ` [PATCH 2/2] x86/mm: Convert printk(KERN_*) to pr_*() in initmem_init() Thorsten Blum
2026-11-11 17:34 ` Mike Rapoport
2026-11-11 18:06 ` Thorsten Blum
2026-11-11 17:31 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avSmhSbrBUBqPLxK@kernel.org \
--to=rppt@kernel.org \
--cc=blum@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.