All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Thorsten Blum <blum@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/mm: Convert printk(KERN_*) to pr_*() in initmem_init()
Date: Wed, 11 Nov 2026 19:34:19 +0200	[thread overview]
Message-ID: <avSnG2SVpeyKDAXt@kernel.org> (raw)
In-Reply-To: <20261111133635.75044-4-blum@kernel.org>

On Wed, Nov 11, 2026 at 02:36:35PM +0100, Thorsten Blum wrote:
> Convert printk(KERN_*) to pr_notice() and pr_info(), use %lu for the
> unsigned long arguments, and add spaces around the shift operators.

Heh, there are about 90 printk(KERN_*) in arch/x86/mm and way more in
arch/x86. 

Maybe change them in a scripted sweep?
 
> No functional change.
> 
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
>  arch/x86/mm/init_32.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index 9b0a3dd02da0..a799f4cff63f 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -616,8 +616,7 @@ void __init initmem_init(void)
>  	unsigned long highstart_pfn = min(max_pfn, max_low_pfn);
>  	unsigned long highend_pfn = max_pfn;
>  
> -	printk(KERN_NOTICE "%ldMB HIGHMEM available.\n",
> -		pages_to_mb(highend_pfn - highstart_pfn));
> +	pr_notice("%luMB HIGHMEM available.\n", pages_to_mb(highend_pfn - highstart_pfn));
>  	high_memory = (void *) __va(highstart_pfn * PAGE_SIZE - 1) + 1;
>  #else
>  	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE - 1) + 1;
> @@ -627,12 +626,10 @@ void __init initmem_init(void)
>  
>  	__vmalloc_start_set = true;
>  
> -	printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
> -			pages_to_mb(max_low_pfn));
> +	pr_notice("%luMB LOWMEM available.\n", pages_to_mb(max_low_pfn));
>  
> -	printk(KERN_INFO "  mapped low ram: 0 - %08lx\n",
> -		 max_pfn_mapped<<PAGE_SHIFT);
> -	printk(KERN_INFO "  low ram: 0 - %08lx\n", max_low_pfn<<PAGE_SHIFT);
> +	pr_info("  mapped low ram: 0 - %08lx\n", max_pfn_mapped << PAGE_SHIFT);
> +	pr_info("  low ram: 0 - %08lx\n", max_low_pfn << PAGE_SHIFT);
>  }
>  
>  /*

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2026-11-11 17:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 13:36 [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init() Thorsten Blum
2026-11-11 13:36 ` [PATCH 2/2] x86/mm: Convert printk(KERN_*) to pr_*() in initmem_init() Thorsten Blum
2026-11-11 17:34   ` Mike Rapoport [this message]
2026-11-11 18:06     ` Thorsten Blum
2026-11-11 17:31 ` [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init() Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avSnG2SVpeyKDAXt@kernel.org \
    --to=rppt@kernel.org \
    --cc=blum@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.