From: Thorsten Blum <blum@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/mm: Convert printk(KERN_*) to pr_*() in initmem_init()
Date: Wed, 11 Nov 2026 19:06:16 +0100 [thread overview]
Message-ID: <avSumM_r99FQuaS2@kernel.org> (raw)
In-Reply-To: <avSnG2SVpeyKDAXt@kernel.org>
On Wed, Nov 11, 2026 at 07:34:19PM +0200, Mike Rapoport wrote:
> On Wed, Nov 11, 2026 at 02:36:35PM +0100, Thorsten Blum wrote:
> > Convert printk(KERN_*) to pr_notice() and pr_info(), use %lu for the
> > unsigned long arguments, and add spaces around the shift operators.
>
> Heh, there are about 90 printk(KERN_*) in arch/x86/mm and way more in
> arch/x86.
>
> Maybe change them in a scripted sweep?
I prefer to convert them when I'm already touching the code rather than
in a broader sweep. The %ld to %lu and the spacing changes modify these
lines anyway, which would trigger multiple checkpatch warnings about the
leftover printk(KERN_*) calls.
next prev parent reply other threads:[~2026-11-11 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 13:36 [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init() Thorsten Blum
2026-11-11 13:36 ` [PATCH 2/2] x86/mm: Convert printk(KERN_*) to pr_*() in initmem_init() Thorsten Blum
2026-11-11 17:34 ` Mike Rapoport
2026-11-11 18:06 ` Thorsten Blum [this message]
2026-11-11 17:31 ` [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init() Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avSumM_r99FQuaS2@kernel.org \
--to=blum@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.