* [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state
@ 2026-11-16 10:30 ` Maxime Ripard
0 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Janne Grunau, Sasha Finkelstein, asahi,
Christian König, Alex Deucher, amd-gfx, sashiko-bot,
Liviu Dudau, Russell King, Dave Airlie, Jocelyn Falempe,
Alim Akhtar, Inki Dae, Krzysztof Kozlowski, Kyungmin Park,
Peter Griffin, Seung-Woo Kim, linux-samsung-soc, Alison Wang,
Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi, Dexuan Cui,
Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam, Frank Li,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx,
Paul Cercueil, linux-mips, Anitha Chrisanthus, Paul Kocialkowski,
Huacai Chen, Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu,
Xi Ruoyao, AngeloGioacchino Del Regno, Chun-Kuang Hu,
Matthias Brugger, Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang,
Marijn Suijten, Rob Clark, Sean Paul, freedreno, linux-arm-msm,
Danilo Krummrich, nouveau, Tomi Valkeinen, Gerd Hoffmann,
spice-devel, virtualization, Geert Uytterhoeven, Kieran Bingham,
Laurent Pinchart, Magnus Damm, Tomi Valkeinen, linux-renesas-soc,
Biju Das, Marcus Folkesson, David Lechner, Iker Pedrosa,
Baolin Wang, Chunyan Zhang, Orson Zhai, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Chen-Yu Tsai, Samuel Holland, linux-sunxi,
Mikko Perttunen, Thierry Reding, linux-tegra, Jyri Sarha,
Alexey Brodkin, Hans de Goede, Kamlesh Gurudasani, Alex Lanzano,
LiangCheng Wang, Chia-I Wu, Dmitry Osipenko, Gurchetan Singh,
Broadcom internal kernel review list, Zack Rusin,
Oleksandr Andrushchenko, Michal Simek
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles. However, the two roles need different
behaviors, notably for objects like drm_private_obj that must persist
across suspend/resume and are excluded from drm_mode_config_reset()
by design.
Previous series introduced drm_mode_config_create_initial_state() to
handle only the initial state creation at probe time, including
drm_private_obj. Unlike drm_mode_config_reset(), it returns an error
code, allowing drivers to properly handle allocation failures.
This series switches all drivers calling drm_mode_config_reset() at
probe time to drm_mode_config_create_initial_state(). The conversion
was done using a Coccinelle semantic patch.
This is part, and the final piece, of a larger transition to remove the
overloaded reset semantics from the KMS subsystem, following similar
series for planes, CRTCs, connectors, and bridges.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Changes in v2:
- Fix some sashiko issues
- Link to v1: https://lore.kernel.org/r/20261105-drm-no-more-config-reset-v1-0-763560c2cc3f@kernel.org
---
Maxime Ripard (64):
drm/adp: Switch to drm_mode_config_create_initial_state
drm/amdgpu: Switch to drm_mode_config_create_initial_state
drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
drm/hdlcd: Switch to drm_mode_config_create_initial_state
drm/armada: Switch to drm_mode_config_create_initial_state
drm/ast: Switch to drm_mode_config_create_initial_state
drm/exynos: Switch to drm_mode_config_create_initial_state
drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
drm/hyperv: Switch to drm_mode_config_create_initial_state
drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
drm/ingenic: Move the private object creation before the reset
drm/ingenic: Switch to drm_mode_config_create_initial_state
drm/kmb: Switch to drm_mode_config_create_initial_state
drm/logicvc: Switch to drm_mode_config_create_initial_state
drm/loongson: Switch to drm_mode_config_create_initial_state
drm/mediatek: Switch to drm_mode_config_create_initial_state
drm/mgag200: Switch to drm_mode_config_create_initial_state
drm/msm: Switch to drm_mode_config_create_initial_state
drm/nouveau: Switch to drm_mode_config_create_initial_state
drm/omap: Switch to drm_mode_config_create_initial_state
drm/qxl: Destroy the monitors object on the modeset init error path
drm/qxl: Switch to drm_mode_config_create_initial_state
drm/rcar-du: Switch to drm_mode_config_create_initial_state
drm/rz-du: Switch to drm_mode_config_create_initial_state
drm/shmobile: Switch to drm_mode_config_create_initial_state
drm/st7571: Switch to drm_mode_config_create_initial_state
drm/st7586: Switch to drm_mode_config_create_initial_state
drm/st7735r: Switch to drm_mode_config_create_initial_state
drm/st7920: Switch to drm_mode_config_create_initial_state
drm/sprd: Switch to drm_mode_config_create_initial_state
drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
drm/stm: Switch to drm_mode_config_create_initial_state
drm/sun4i: Switch to drm_mode_config_create_initial_state
drm/tegra: Switch to drm_mode_config_create_initial_state
drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
drm/tidss: Switch to drm_mode_config_create_initial_state
drm/tilcdc: Switch to drm_mode_config_create_initial_state
drm/arcpgu: Switch to drm_mode_config_create_initial_state
drm/bochs: Switch to drm_mode_config_create_initial_state
drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
drm/gm12u320: Switch to drm_mode_config_create_initial_state
drm/hx8357d: Switch to drm_mode_config_create_initial_state
drm/ili9163: Switch to drm_mode_config_create_initial_state
drm/ili9225: Switch to drm_mode_config_create_initial_state
drm/ili9341: Switch to drm_mode_config_create_initial_state
drm/ili9486: Switch to drm_mode_config_create_initial_state
drm/mi0283qt: Switch to drm_mode_config_create_initial_state
drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
drm/pixpaper: Switch to drm_mode_config_create_initial_state
drm/repaper: Switch to drm_mode_config_create_initial_state
drm/sharp-memory: Switch to drm_mode_config_create_initial_state
drm/udl: Switch to drm_mode_config_create_initial_state
drm/vboxvideo: Switch to drm_mode_config_create_initial_state
drm/verisilicon: Switch to drm_mode_config_create_initial_state
drm/virtio: Switch to drm_mode_config_create_initial_state
drm/vmwgfx: Switch to drm_mode_config_create_initial_state
drm/xen: Switch to drm_mode_config_create_initial_state
drm/xlnx: Switch to drm_mode_config_create_initial_state
drivers/gpu/drm/adp/adp_drv.c | 4 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 +++-
.../amdgpu_dm/tests/amdgpu_dm_connector_test.c | 3 ++-
.../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 4 +++-
drivers/gpu/drm/arm/hdlcd_drv.c | 9 +++++----
drivers/gpu/drm/armada/armada_drv.c | 4 +++-
drivers/gpu/drm/ast/ast_mode.c | 4 +++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +++-
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 +++-
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 7 ++++---
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 +---
drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++-
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 22 +++++++++++++---------
drivers/gpu/drm/kmb/kmb_drv.c | 3 +--
drivers/gpu/drm/logicvc/logicvc_mode.c | 4 +++-
drivers/gpu/drm/loongson/lsdc_drv.c | 4 +++-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++++++-
drivers/gpu/drm/mgag200/mgag200_g200.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh5.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200er.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200ev.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200se.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200wb.c | 4 +++-
drivers/gpu/drm/msm/msm_kms.c | 4 +++-
drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++-
drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++-
drivers/gpu/drm/qxl/qxl_display.c | 11 +++++++++--
drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +++-
drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 4 +++-
drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 4 +++-
drivers/gpu/drm/sitronix/st7571.c | 4 +++-
drivers/gpu/drm/sitronix/st7586.c | 4 +++-
drivers/gpu/drm/sitronix/st7735r.c | 4 +++-
drivers/gpu/drm/sitronix/st7920.c | 4 +---
drivers/gpu/drm/sprd/sprd_drm.c | 6 ++++--
drivers/gpu/drm/sti/sti_drv.c | 10 ++++------
drivers/gpu/drm/stm/drv.c | 6 +++++-
drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +++-
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 6 +++---
drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 2 +-
drivers/gpu/drm/tegra/drm.c | 4 +++-
drivers/gpu/drm/tests/drm_atomic_commit_test.c | 3 ++-
drivers/gpu/drm/tests/drm_atomic_test.c | 4 +++-
drivers/gpu/drm/tests/drm_bridge_test.c | 12 +++++++++---
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 ++-
drivers/gpu/drm/tidss/tidss_drv.c | 6 +++++-
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +++-
drivers/gpu/drm/tiny/arcpgu.c | 4 +++-
drivers/gpu/drm/tiny/bochs.c | 4 +---
drivers/gpu/drm/tiny/cirrus-qemu.c | 4 +++-
drivers/gpu/drm/tiny/gm12u320.c | 4 +++-
drivers/gpu/drm/tiny/hx8357d.c | 4 +++-
drivers/gpu/drm/tiny/ili9163.c | 4 +++-
drivers/gpu/drm/tiny/ili9225.c | 4 +++-
drivers/gpu/drm/tiny/ili9341.c | 4 +++-
drivers/gpu/drm/tiny/ili9486.c | 4 +++-
drivers/gpu/drm/tiny/mi0283qt.c | 4 +++-
drivers/gpu/drm/tiny/panel-mipi-dbi.c | 4 +++-
drivers/gpu/drm/tiny/pixpaper.c | 4 +++-
drivers/gpu/drm/tiny/repaper.c | 4 +++-
drivers/gpu/drm/tiny/sharp-memory.c | 4 +++-
drivers/gpu/drm/udl/udl_modeset.c | 4 +++-
drivers/gpu/drm/vboxvideo/vbox_mode.c | 5 ++++-
drivers/gpu/drm/verisilicon/vs_drm.c | 4 +++-
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +++++++++++++-
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 ---
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 ---
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 ---
drivers/gpu/drm/xen/xen_drm_front_kms.c | 4 +++-
drivers/gpu/drm/xlnx/zynqmp_kms.c | 6 ++++--
74 files changed, 243 insertions(+), 115 deletions(-)
---
base-commit: a8670a2ab1a81dc3fc30093e47c23b83244ca4d0
change-id: 20260712-drm-no-more-config-reset-1ea89f56693d
Best regards,
--
Maxime Ripard <mripard@kernel.org>
^ permalink raw reply [flat|nested] 87+ messages in thread* [PATCH v2 01/64] drm/adp: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Janne Grunau, Sasha Finkelstein, asahi
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Janne Grunau <j@jannau.net>
Cc: Sasha Finkelstein <k@chaosmail.tech>
Cc: asahi@lists.linux.dev
---
drivers/gpu/drm/adp/adp_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c
index fdf0e6316175..795e8a5d3b13 100644
--- a/drivers/gpu/drm/adp/adp_drv.c
+++ b/drivers/gpu/drm/adp/adp_drv.c
@@ -448,13 +448,11 @@ static int adp_setup_mode_config(struct adp_drv_private *adp)
if (ret < 0) {
drm_err(drm, "failed to initialize vblank");
return ret;
}
- drm_mode_config_reset(drm);
-
- return 0;
+ return drm_mode_config_create_initial_state(drm);
}
static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *adp)
{
struct device *dev = &pdev->dev;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 02/64] drm/amdgpu: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
(?)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Christian König, Alex Deucher,
amd-gfx
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 +++-
.../gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c | 3 ++-
.../gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 4 +++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
index 5c7e2172a372..1f8b531eb946 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
@@ -359,11 +359,13 @@ static int amdgpu_vkms_output_init(struct drm_device *dev, struct
if (ret) {
DRM_ERROR("Failed to attach connector to encoder\n");
goto err_attach;
}
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ goto err_attach;
return 0;
err_attach:
drm_encoder_cleanup(encoder);
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
index 254797fa76a6..b8e1fa2378aa 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
@@ -9963,11 +9963,12 @@ dm_test_force_ctx_alloc(struct kunit *test, const struct drm_connector_funcs *fu
drmm_encoder_init(ctx->drm, encoder, NULL,
DRM_MODE_ENCODER_TMDS, NULL), 0);
encoder->crtc = crtc;
ctx->aconnector->base.encoder = encoder;
- drm_mode_config_reset(ctx->drm);
+ KUNIT_ASSERT_EQ(test,
+ drm_mode_config_create_initial_state(ctx->drm), 0);
drm_modeset_acquire_init(&ctx->acquire_ctx, 0);
ctx->drm->mode_config.acquire_ctx = &ctx->acquire_ctx;
KUNIT_ASSERT_EQ(test,
kunit_add_action_or_reset(test, dm_test_force_drop_locks, ctx), 0);
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c
index 8c3e32f40a96..c9fa8308d254 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c
@@ -3791,11 +3791,13 @@ dm_mst_test_alloc_dsc_link_ctx(struct kunit *test, int total_avail_slots)
KUNIT_ASSERT_NOT_NULL(test, ctx->aconnector);
KUNIT_ASSERT_EQ(test,
drmm_connector_init(ctx->drm, &ctx->aconnector->base,
&dm_mst_test_dsc_link_conn_funcs,
DRM_MODE_CONNECTOR_DisplayPort, NULL), 0);
- drm_mode_config_reset(ctx->drm);
+
+ KUNIT_ASSERT_EQ(test,
+ drm_mode_config_create_initial_state(ctx->drm), 0);
KUNIT_ASSERT_EQ(test,
drm_dp_mst_topology_mgr_init(&ctx->aconnector->mst_mgr, ctx->drm,
&ctx->aconnector->dm_dp_aux.aux, 16, 4,
ctx->aconnector->base.base.id), 0);
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 03/64] drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
2026-11-16 10:30 ` Maxime Ripard
` (2 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 18:10 ` Liviu Dudau
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
The hdlcd_probe() error paths for pm_runtime_set_active() and
drm_vblank_init() fall through to the err_pm_active label, which calls
drm_atomic_helper_shutdown().
However, both calls happen before drm_mode_config_reset(), so the CRTC
state is still NULL at that point. drm_atomic_helper_shutdown() will
then go through drm_atomic_helper_disable_all() and
drm_atomic_get_crtc_state() to drm_atomic_helper_crtc_duplicate_state(),
which trips its WARN_ON(!crtc->state) and returns an error.
Move drm_atomic_helper_shutdown() to the err_register label, the only
error path where drm_mode_config_reset() has run and thus where
shutting the device down makes sense. This also brings the error path
closer to hdlcd_remove(), which calls drm_atomic_helper_shutdown()
while runtime PM is still enabled.
The pm_runtime_set_active() error path now jumps directly to
err_unload: runtime PM hasn't been enabled at that point, so calling
pm_runtime_disable() there wasn't needed either.
It will also be needed when drm_mode_config_reset() gets replaced by
drm_mode_config_create_initial_state(), whose state allocation can
fail.
Fixes: d664b851eb2bc ("drm/arm/hdlcd: Reject atomic commits that disable only the plane")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-199498@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/arm/hdlcd_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index 340b1bb38bf9..f2bf9a61979d 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -297,11 +297,11 @@ static int hdlcd_probe(struct platform_device *pdev)
goto err_unload;
}
ret = pm_runtime_set_active(dev);
if (ret)
- goto err_pm_active;
+ goto err_unload;
pm_runtime_enable(dev);
ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
if (ret < 0) {
@@ -333,14 +333,13 @@ static int hdlcd_probe(struct platform_device *pdev)
return 0;
err_register:
drm_kms_helper_poll_fini(drm);
+ drm_atomic_helper_shutdown(drm);
err_vblank:
pm_runtime_disable(drm->dev);
-err_pm_active:
- drm_atomic_helper_shutdown(drm);
err_unload:
hdlcd_irq_uninstall(hdlcd);
of_reserved_mem_device_release(drm->dev);
err_free:
dev_set_drvdata(dev, NULL);
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 03/64] drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
2026-11-16 10:30 ` [PATCH v2 03/64] drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path Maxime Ripard
@ 2026-11-16 18:10 ` Liviu Dudau
0 siblings, 0 replies; 87+ messages in thread
From: Liviu Dudau @ 2026-11-16 18:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, sashiko-bot
On Mon, Nov 16, 2026 at 11:30:19AM +0100, Maxime Ripard wrote:
> The hdlcd_probe() error paths for pm_runtime_set_active() and
> drm_vblank_init() fall through to the err_pm_active label, which calls
> drm_atomic_helper_shutdown().
>
> However, both calls happen before drm_mode_config_reset(), so the CRTC
> state is still NULL at that point. drm_atomic_helper_shutdown() will
> then go through drm_atomic_helper_disable_all() and
> drm_atomic_get_crtc_state() to drm_atomic_helper_crtc_duplicate_state(),
> which trips its WARN_ON(!crtc->state) and returns an error.
>
> Move drm_atomic_helper_shutdown() to the err_register label, the only
> error path where drm_mode_config_reset() has run and thus where
> shutting the device down makes sense. This also brings the error path
> closer to hdlcd_remove(), which calls drm_atomic_helper_shutdown()
> while runtime PM is still enabled.
>
> The pm_runtime_set_active() error path now jumps directly to
> err_unload: runtime PM hasn't been enabled at that point, so calling
> pm_runtime_disable() there wasn't needed either.
>
> It will also be needed when drm_mode_config_reset() gets replaced by
> drm_mode_config_create_initial_state(), whose state allocation can
> fail.
>
> Fixes: d664b851eb2bc ("drm/arm/hdlcd: Reject atomic commits that disable only the plane")
> Reported-by: sashiko-bot@kernel.org
> Link: https://lore.kernel.org/r/sashiko-outbox-199498@kernel.org
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Something seems to have broken down in your setup as I've only been
Cc-ed on patch 04/64, discovered this one during a search.
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index 340b1bb38bf9..f2bf9a61979d 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -297,11 +297,11 @@ static int hdlcd_probe(struct platform_device *pdev)
> goto err_unload;
> }
>
> ret = pm_runtime_set_active(dev);
> if (ret)
> - goto err_pm_active;
> + goto err_unload;
>
> pm_runtime_enable(dev);
>
> ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
> if (ret < 0) {
> @@ -333,14 +333,13 @@ static int hdlcd_probe(struct platform_device *pdev)
>
> return 0;
>
> err_register:
> drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
> err_vblank:
> pm_runtime_disable(drm->dev);
> -err_pm_active:
> - drm_atomic_helper_shutdown(drm);
> err_unload:
> hdlcd_irq_uninstall(hdlcd);
> of_reserved_mem_device_release(drm->dev);
> err_free:
> dev_set_drvdata(dev, NULL);
>
> --
> 2.56.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 04/64] drm/hdlcd: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (3 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Liviu Dudau
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Liviu Dudau <liviu.dudau@arm.com>
---
drivers/gpu/drm/arm/hdlcd_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index f2bf9a61979d..8c48549abf11 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -316,11 +316,13 @@ static int hdlcd_probe(struct platform_device *pdev)
if (hdlcd_read(hdlcd, HDLCD_REG_COMMAND)) {
hdlcd_write(hdlcd, HDLCD_REG_COMMAND, 0);
aperture_remove_all_conflicting_devices(hdlcd_driver.name);
}
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_vblank;
drm_kms_helper_poll_init(drm);
#ifdef CONFIG_DEBUG_FS
drm_debugfs_add_files(drm, hdlcd_debugfs_list, ARRAY_SIZE(hdlcd_debugfs_list));
#endif
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 05/64] drm/armada: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (4 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Russell King
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Russell King <linux@armlinux.org.uk>
---
drivers/gpu/drm/armada/armada_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index cae25ad66c74..5c19923c85b0 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -124,11 +124,13 @@ static int armada_drm_bind(struct device *dev)
ret = drm_vblank_init(&priv->drm, priv->drm.mode_config.num_crtc);
if (ret)
goto err_comp;
- drm_mode_config_reset(&priv->drm);
+ ret = drm_mode_config_create_initial_state(&priv->drm);
+ if (ret)
+ goto err_comp;
drm_kms_helper_poll_init(&priv->drm);
ret = drm_dev_register(&priv->drm, 0);
if (ret)
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 06/64] drm/ast: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (5 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Jocelyn Falempe
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jocelyn Falempe <jfalempe@redhat.com>
---
drivers/gpu/drm/ast/ast_mode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 08db132acae8..efecc1193887 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1071,10 +1071,12 @@ int ast_mode_config_init(struct ast_device *ast)
break;
}
if (ret)
return ret;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drmm_kms_helper_poll_init(dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 07/64] drm/exynos: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (6 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alim Akhtar, Inki Dae,
Krzysztof Kozlowski, Kyungmin Park, Peter Griffin, Seung-Woo Kim,
linux-samsung-soc
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 9ee30086879f..712e5ac86f50 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -275,11 +275,13 @@ static int exynos_drm_bind(struct device *dev)
ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
if (ret)
goto err_unbind_all;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_unbind_all;
/* init kms poll for handling hpd */
drm_kms_helper_poll_init(drm);
/* register the DRM device */
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 08/64] drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (7 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alison Wang, Stefan Agner
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alison Wang <alison.wang@nxp.com>
Cc: Stefan Agner <stefan@agner.ch>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
index 5b47000738e4..9c2189661d8a 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
@@ -40,11 +40,13 @@ int fsl_dcu_drm_modeset_init(struct fsl_dcu_drm_device *fsl_dev)
ret = fsl_dcu_create_outputs(fsl_dev);
if (ret)
goto err;
- drm_mode_config_reset(fsl_dev->drm);
+ ret = drm_mode_config_create_initial_state(fsl_dev->drm);
+ if (ret)
+ goto err;
drm_kms_helper_poll_init(fsl_dev->drm);
return 0;
err:
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 09/64] drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
2026-11-16 10:30 ` Maxime Ripard
` (8 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
The error path of hibmc_load() calls hibmc_unload(), which only calls
drm_atomic_helper_shutdown().
However, all the failures handled there (hibmc_kms_init(),
drm_vblank_init() and hibmc_msi_init()) happen before
drm_mode_config_reset() has run, so the CRTC state is still NULL at
that point. drm_atomic_helper_shutdown() will then go through
drm_atomic_helper_disable_all() and drm_atomic_get_crtc_state() to
drm_atomic_helper_crtc_duplicate_state(), which trips its
WARN_ON(!crtc->state) and returns an error.
Since the device hasn't been registered and no atomic commit ever ran
when hibmc_load() fails, there's nothing to shut down in the first
place. Remove that call.
hibmc_unload() is still called by hibmc_pci_probe() and
hibmc_pci_remove(), where the initial state has been created.
It will also be needed when drm_mode_config_reset() gets replaced by
drm_mode_config_create_initial_state(), whose state allocation can
fail.
Fixes: b11bc1ae46587 ("drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-199610@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 602930964e93..272a8ab6427a 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -417,11 +417,10 @@ static int hibmc_load(struct drm_device *dev)
drmm_kms_helper_poll_init(dev);
return 0;
err:
- hibmc_unload(dev);
drm_err(dev, "failed to initialize drm driver: %d\n", ret);
return ret;
}
static int hibmc_pci_probe(struct pci_dev *pdev,
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 10/64] drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (9 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Tian Tao, Xinwei Kong, Yongbang Shi
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yongbang Shi <shiyongbang@huawei.com>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 272a8ab6427a..029a2e13b98b 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -409,12 +409,14 @@ static int hibmc_load(struct drm_device *dev)
if (ret) {
drm_err(dev, "hibmc msi init failed, ret:%d\n", ret);
goto err;
}
- /* reset all the states of crtc/plane/encoder/connector */
- drm_mode_config_reset(dev);
+ /* Create all the states of crtc/plane/encoder/connector */
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ goto err;
drmm_kms_helper_poll_init(dev);
return 0;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 11/64] drm/hyperv: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (10 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-17 13:07 ` Hamza Mahfooz
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dexuan Cui, Long Li, Saurabh Sengar,
linux-hyperv
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Long Li <longli@microsoft.com>
Cc: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org
---
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 759952f4ff19..73938303e663 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -500,9 +500,7 @@ int hv_drm_mode_config_init(struct hv_drm_device *hv)
ret = drm_vblank_init(dev, 1);
if (ret)
return ret;
- drm_mode_config_reset(dev);
-
- return 0;
+ return drm_mode_config_create_initial_state(dev);
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 11/64] drm/hyperv: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 11/64] drm/hyperv: " Maxime Ripard
@ 2026-11-17 13:07 ` Hamza Mahfooz
0 siblings, 0 replies; 87+ messages in thread
From: Hamza Mahfooz @ 2026-11-17 13:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, Dexuan Cui, Long Li, Saurabh Sengar, linux-hyperv
On Mon, Nov 16, 2026 at 11:30:27AM +0100, Maxime Ripard wrote:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
>
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
>
> Switch to drm_mode_config_create_initial_state().
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Acked-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
> ---
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: Long Li <longli@microsoft.com>
> Cc: Saurabh Sengar <ssengar@linux.microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 759952f4ff19..73938303e663 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -500,9 +500,7 @@ int hv_drm_mode_config_init(struct hv_drm_device *hv)
>
> ret = drm_vblank_init(dev, 1);
> if (ret)
> return ret;
>
> - drm_mode_config_reset(dev);
> -
> - return 0;
> + return drm_mode_config_create_initial_state(dev);
> }
>
> --
> 2.56.1
>
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 12/64] drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (11 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 11:40 ` Philipp Zabel
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Fabio Estevam, Frank Li,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: imx@lists.linux.dev
---
drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
index 51a0ec043248..b7b6ae8f9578 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
@@ -242,11 +242,13 @@ static int imx_drm_bind(struct device *dev)
/* Now try and bind all our sub-components */
ret = component_bind_all(dev, drm);
if (ret)
goto err_kms;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_poll_fini;
/*
* All components are now initialised, so setup the fb helper.
* The fb helper takes copies of key hardware information, so the
* crtcs/connectors/encoders must not change after this point.
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 12/64] drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 12/64] drm/imx/ipuv3: " Maxime Ripard
@ 2026-11-16 11:40 ` Philipp Zabel
0 siblings, 0 replies; 87+ messages in thread
From: Philipp Zabel @ 2026-11-16 11:40 UTC (permalink / raw)
To: Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: dri-devel, Fabio Estevam, Frank Li, Pengutronix Kernel Team,
Sascha Hauer, imx
On Mo, 2026-11-16 at 11:30 +0100, Maxime Ripard wrote:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
>
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
>
> Switch to drm_mode_config_create_initial_state().
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: imx@lists.linux.dev
> ---
> drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
> index 51a0ec043248..b7b6ae8f9578 100644
> --- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
> @@ -242,11 +242,13 @@ static int imx_drm_bind(struct device *dev)
> /* Now try and bind all our sub-components */
> ret = component_bind_all(dev, drm);
> if (ret)
> goto err_kms;
>
> - drm_mode_config_reset(drm);
> + ret = drm_mode_config_create_initial_state(drm);
> + if (ret)
> + goto err_poll_fini;
This is ok because drm_kms_helper_poll_fini() just returns when
drm_kms_helper_poll_init() hasn't been called yet.
Still, I think it would be clearer to add a err_mode_config goto target
between drm_kms_helper_poll_fini() and component_unbind_all().
> /*
> * All components are now initialised, so setup the fb helper.
> * The fb helper takes copies of key hardware information, so the
> * crtcs/connectors/encoders must not change after this point.
Either way,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 13/64] drm/ingenic: Move the private object creation before the reset
2026-11-16 10:30 ` Maxime Ripard
` (12 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
ingenic_drm_bind() calls drm_atomic_private_obj_init() late in the
bind sequence, without checking its return value.
drm_atomic_private_obj_init() registers the object on the
drm->mode_config.privobj_list and then allocates its initial state
through the atomic_create_state hook. If that allocation fails, it
returns an error but leaves the object registered with a NULL state.
Since the return value isn't checked, the probe would continue and
the first atomic commit would then crash in
drm_atomic_get_private_obj_state() -> ingenic_drm_duplicate_state(),
which does a kmemdup() of that NULL state.
Check the drm_atomic_private_obj_init() return value, and move it and
its drmm cleanup action before drm_mode_config_reset().
This will also be needed when drm_mode_config_reset() gets replaced
by drm_mode_config_create_initial_state(), which creates the initial
state of the drm_private_obj instances registered so far: the private
object will already have its state by then, so
drm_mode_config_create_initial_state() will skip it.
Fixes: 8e46b1ebf3704 ("drm/ingenic: Switch private_obj initialization to atomic_create_state")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-199703@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 625ec76cf04d..6acb7d2f25b9 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -1352,10 +1352,20 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
if (ret) {
dev_err(dev, "Failed calling drm_vblank_init()\n");
goto err_drvdata;
}
+ ret = drm_atomic_private_obj_init(drm, &priv->private_obj,
+ &ingenic_drm_private_state_funcs);
+ if (ret)
+ goto err_drvdata;
+
+ ret = drmm_add_action_or_reset(drm, ingenic_drm_atomic_private_obj_fini,
+ &priv->private_obj);
+ if (ret)
+ goto err_drvdata;
+
drm_mode_config_reset(drm);
ret = clk_prepare_enable(priv->pix_clk);
if (ret) {
dev_err(dev, "Unable to start pixel clock\n");
@@ -1399,18 +1409,10 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
if (ret) {
dev_err(dev, "Unable to register clock notifier\n");
goto err_devclk_disable;
}
- drm_atomic_private_obj_init(drm, &priv->private_obj,
- &ingenic_drm_private_state_funcs);
-
- ret = drmm_add_action_or_reset(drm, ingenic_drm_atomic_private_obj_fini,
- &priv->private_obj);
- if (ret)
- goto err_clk_notifier_unregister;
-
ret = drm_dev_register(drm, 0);
if (ret) {
dev_err(dev, "Failed to register DRM driver\n");
goto err_clk_notifier_unregister;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 14/64] drm/ingenic: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (13 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Paul Cercueil, linux-mips
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Acked-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: linux-mips@vger.kernel.org
---
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 6acb7d2f25b9..c73eeb95dd3d 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -1362,11 +1362,13 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
ret = drmm_add_action_or_reset(drm, ingenic_drm_atomic_private_obj_fini,
&priv->private_obj);
if (ret)
goto err_drvdata;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_drvdata;
ret = clk_prepare_enable(priv->pix_clk);
if (ret) {
dev_err(dev, "Unable to start pixel clock\n");
goto err_drvdata;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 15/64] drm/kmb: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (14 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Anitha Chrisanthus
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
---
drivers/gpu/drm/kmb/kmb_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 7c2eb1152fc2..fc8ab5124bd6 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -196,12 +196,11 @@ static int kmb_setup_mode_config(struct drm_device *drm)
drm_err(drm, "failed to initialize vblank\n");
pm_runtime_disable(drm->dev);
return ret;
}
- drm_mode_config_reset(drm);
- return 0;
+ return drm_mode_config_create_initial_state(drm);
}
static irqreturn_t handle_lcd_irq(struct drm_device *dev)
{
unsigned long status, val, val1;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 16/64] drm/logicvc: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (15 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Paul Kocialkowski
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Paul Kocialkowski <paulk@sys-base.io>
---
drivers/gpu/drm/logicvc/logicvc_mode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_mode.c b/drivers/gpu/drm/logicvc/logicvc_mode.c
index 3cf04b70bd27..15503f96743f 100644
--- a/drivers/gpu/drm/logicvc/logicvc_mode.c
+++ b/drivers/gpu/drm/logicvc/logicvc_mode.c
@@ -59,11 +59,13 @@ int logicvc_mode_init(struct logicvc_drm *logicvc)
mode_config->min_height = 1;
mode_config->max_height = 2048;
mode_config->preferred_depth = preferred_depth;
mode_config->funcs = &logicvc_mode_config_funcs;
- drm_mode_config_reset(drm_dev);
+ ret = drm_mode_config_create_initial_state(drm_dev);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(drm_dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 17/64] drm/loongson: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (16 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 10:53 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Huacai Chen, Icenowy Zheng, Jianmin Lv,
Mingcong Bai, Qianhai Wu, Xi Ruoyao
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Mingcong Bai <jeffbai@aosc.io>
Cc: Qianhai Wu <wuqianhai@loongson.cn>
Cc: Xi Ruoyao <xry111@xry111.site>
---
drivers/gpu/drm/loongson/lsdc_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c
index 5a13df31eb90..fbb2658acce4 100644
--- a/drivers/gpu/drm/loongson/lsdc_drv.c
+++ b/drivers/gpu/drm/loongson/lsdc_drv.c
@@ -245,11 +245,13 @@ lsdc_create_device(struct pci_dev *pdev,
ret = lsdc_modeset_init(ldev, descp->num_of_crtc, descp->funcs,
loongson_vblank);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(ddev);
+ ret = drm_mode_config_create_initial_state(ddev);
+ if (ret)
+ return ERR_PTR(ret);
return ldev;
}
/* For multiple GPU driver instance co-exixt in the system */
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 17/64] drm/loongson: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 17/64] drm/loongson: " Maxime Ripard
@ 2026-11-16 10:53 ` sashiko-bot
0 siblings, 0 replies; 87+ messages in thread
From: sashiko-bot @ 2026-11-16 10:53 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/loongson: skipped CRTC and encoder hardware reset in
lsdc_create_device()
--
commit 8beeb01686f101cdce0b7603e2b5e7c72cefba29
Author: Maxime Ripard <mripard@kernel.org>
drm/loongson: Switch to drm_mode_config_create_initial_state
This commit replaces drm_mode_config_reset() with
drm_mode_config_create_initial_state() during device creation in
lsdc_create_device().
> diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c
> index 5a13df31eb902..fbb2658acce40 100644
> --- a/drivers/gpu/drm/loongson/lsdc_drv.c
> +++ b/drivers/gpu/drm/loongson/lsdc_drv.c
> @@ -247,7 +247,9 @@ lsdc_create_device(struct pci_dev *pdev,
> if (ret)
> return ERR_PTR(ret);
>
> - drm_mode_config_reset(ddev);
> + ret = drm_mode_config_create_initial_state(ddev);
> + if (ret)
> + return ERR_PTR(ret);
>
> return ldev;
> }
[Severity: High]
Does replacing drm_mode_config_reset() with
drm_mode_config_create_initial_state() skip hardware initialization that
this driver relies on during probe?
Unlike drm_mode_config_reset(), drm_mode_config_create_initial_state() does
not call crtc->helper_private->hw_reset() or encoder->funcs->reset():
drivers/gpu/drm/loongson/lsdc_output_7a2000.c:ls7a2000_hdmi0_encoder_reset() {
...
val = PHY_CLOCK_POL | PHY_CLOCK_EN | PHY_DATA_EN;
lsdc_wreg32(ldev, LSDC_CRTC0_DVO_CONF_REG, val);
/* using software gpio emulated i2c */
val = lsdc_rreg32(ldev, LSDC_HDMI0_INTF_CTRL_REG);
val &= ~HW_I2C_EN;
lsdc_wreg32(ldev, LSDC_HDMI0_INTF_CTRL_REG, val);
/* help the hdmi phy to get out of reset state */
lsdc_wreg32(ldev, LSDC_HDMI0_PHY_CTRL_REG, HDMI_PHY_RESET_N);
...
}
On both LS7A1000 and LS7A2000, the encoder reset callbacks are the only
places in the driver that program LSDC_CRTC0_DVO_CONF_REG and
LSDC_CRTC1_DVO_CONF_REG. On LS7A2000, skipping encoder reset also leaves
the HDMI PHY in reset and HW_I2C_EN set, breaking software GPIO I2C for
connector detection and EDID reads before an atomic enable runs. In
addition, skipping lsdc_crtc_hw_reset() leaves LSDC_CRTC0_CFG_REG and
LSDC_CRTC1_CFG_REG with firmware settings across read-modify-write modeset
updates instead of initializing them to CFG_RESET_N | LSDC_PF_XRGB8888.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=17
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 18/64] drm/mediatek: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (17 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, AngeloGioacchino Del Regno,
Chun-Kuang Hu, Matthias Brugger, Philipp Zabel
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index a8bf0690756a..33246645e5f4 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -577,14 +577,20 @@ static int mtk_drm_kms_init(struct drm_device *drm)
ret = drm_vblank_init(drm, MAX_CRTC);
if (ret < 0)
goto err_component_unbind;
drm_kms_helper_poll_init(drm);
- drm_mode_config_reset(drm);
+
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_fini_poll;
return 0;
+err_fini_poll:
+ drm_kms_helper_poll_fini(drm);
+
err_component_unbind:
for (i = 0; i < private->data->mmsys_dev_num; i++)
component_unbind_all(private->all_drm_private[i]->dev, drm);
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 19/64] drm/mgag200: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (18 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Jocelyn Falempe
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jocelyn Falempe <jfalempe@redhat.com>
---
drivers/gpu/drm/mgag200/mgag200_g200.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200eh5.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200er.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200ev.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200se.c | 4 +++-
drivers/gpu/drm/mgag200/mgag200_g200wb.c | 4 +++-
9 files changed, 27 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200.c b/drivers/gpu/drm/mgag200/mgag200_g200.c
index 9e6b4618fadd..d4788cdf64d7 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200.c
@@ -399,10 +399,12 @@ struct mga_device *mgag200_g200_device_create(struct pci_dev *pdev, const struct
ret = mgag200_g200_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200eh.c b/drivers/gpu/drm/mgag200/mgag200_g200eh.c
index e64bfeafbefc..b6ef287c05da 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200eh.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200eh.c
@@ -271,10 +271,12 @@ struct mga_device *mgag200_g200eh_device_create(struct pci_dev *pdev, const stru
ret = mgag200_g200eh_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200eh3.c b/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
index 183b7676ea6a..973770ee941a 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
@@ -176,10 +176,12 @@ struct mga_device *mgag200_g200eh3_device_create(struct pci_dev *pdev,
ret = mgag200_g200eh3_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200eh5.c b/drivers/gpu/drm/mgag200/mgag200_g200eh5.c
index dc375c055b0e..0241244bd3f5 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200eh5.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200eh5.c
@@ -196,10 +196,12 @@ struct mga_device *mgag200_g200eh5_device_create(struct pci_dev *pdev,
ret = mgag200_g200eh5_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200er.c b/drivers/gpu/drm/mgag200/mgag200_g200er.c
index 205678a57bfe..df83857b9634 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200er.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200er.c
@@ -304,10 +304,12 @@ struct mga_device *mgag200_g200er_device_create(struct pci_dev *pdev, const stru
ret = mgag200_g200er_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200ev.c b/drivers/gpu/drm/mgag200/mgag200_g200ev.c
index d60693ac0749..82ee58b3faab 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200ev.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200ev.c
@@ -309,10 +309,12 @@ struct mga_device *mgag200_g200ev_device_create(struct pci_dev *pdev, const stru
ret = mgag200_g200ev_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200ew3.c b/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
index 9c14d0eb66bc..19c6a65e8621 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
@@ -194,10 +194,12 @@ struct mga_device *mgag200_g200ew3_device_create(struct pci_dev *pdev,
ret = mgag200_g200ew3_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200se.c b/drivers/gpu/drm/mgag200/mgag200_g200se.c
index 349ec36f6d49..937bceb8309f 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200se.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200se.c
@@ -516,10 +516,12 @@ struct mga_device *mgag200_g200se_device_create(struct pci_dev *pdev, const stru
ret = mgag200_g200se_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200wb.c b/drivers/gpu/drm/mgag200/mgag200_g200wb.c
index f65d4238422f..92e4cd9ef50e 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200wb.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200wb.c
@@ -318,10 +318,12 @@ struct mga_device *mgag200_g200wb_device_create(struct pci_dev *pdev, const stru
ret = mgag200_g200wb_pipeline_init(mdev);
if (ret)
return ERR_PTR(ret);
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ERR_PTR(ret);
drm_kms_helper_poll_init(dev);
return mdev;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 20/64] drm/msm: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (19 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Abhinav Kumar, Dmitry Baryshkov,
Jessica Zhang, Marijn Suijten, Rob Clark, Sean Paul, freedreno,
linux-arm-msm
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>
Cc: Dmitry Baryshkov <lumag@kernel.org>
Cc: Jessica Zhang <jesszhan0024@gmail.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>
Cc: Sean Paul <sean@poorly.run>
Cc: freedreno@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org
---
drivers/gpu/drm/msm/msm_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c
index e5d0ea629448..9592fa28c85b 100644
--- a/drivers/gpu/drm/msm/msm_kms.c
+++ b/drivers/gpu/drm/msm/msm_kms.c
@@ -329,11 +329,13 @@ int msm_drm_kms_init(struct device *dev, const struct drm_driver *drv)
if (ret < 0) {
DRM_DEV_ERROR(dev, "failed to install IRQ handler\n");
goto err_msm_uninit;
}
- drm_mode_config_reset(ddev);
+ ret = drm_mode_config_create_initial_state(ddev);
+ if (ret)
+ goto err_msm_uninit;
return 0;
err_msm_uninit:
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 21/64] drm/nouveau: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Danilo Krummrich, nouveau
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index d71dcfc6ee66..da07acea6a41 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -708,11 +708,13 @@ nouveau_display_create(struct drm_device *dev)
}
if (ret)
goto disp_create_err;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ goto vblank_err;
if (dev->mode_config.num_crtc) {
ret = drm_vblank_init(dev, dev->mode_config.num_crtc);
if (ret)
goto vblank_err;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 21/64] drm/nouveau: Switch to drm_mode_config_create_initial_state
@ 2026-11-16 10:30 ` Maxime Ripard
0 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Danilo Krummrich, Lyude Paul, nouveau
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index d71dcfc6ee66..da07acea6a41 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -708,11 +708,13 @@ nouveau_display_create(struct drm_device *dev)
}
if (ret)
goto disp_create_err;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ goto vblank_err;
if (dev->mode_config.num_crtc) {
ret = drm_vblank_init(dev, dev->mode_config.num_crtc);
if (ret)
goto vblank_err;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread
* [PATCH v2 22/64] drm/omap: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (21 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Tomi Valkeinen
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 89a6d3b4aa6f..db216c888a8f 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -533,11 +533,13 @@ static int omap_modeset_init(struct drm_device *dev)
dev->mode_config.normalize_zpos = true;
dev->mode_config.funcs = &omap_mode_config_funcs;
dev->mode_config.helper_private = &omap_mode_config_helper_funcs;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
omap_drm_irq_install(dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 23/64] drm/qxl: Destroy the monitors object on the modeset init error path
2026-11-16 10:30 ` Maxime Ripard
` (22 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
qxl_modeset_init() calls qxl_create_monitors_object() early on: it
allocates, pins and vmaps the monitors_config_bo buffer object, and
points qdev->ram_header->monitors_config to its physical address.
If drm_vblank_init() fails later on, qxl_modeset_init() returns an
error and qxl_pci_probe() jumps to the unload label, which calls
qxl_device_fini(). qxl_gem_fini() then force-frees the still pinned
and mapped monitors_config_bo, and iounmap() unmaps the RAM header.
The devres cleanup of the DRM device later calls qxl_drm_release(),
which in turn calls qxl_modeset_fini() and
qxl_destroy_monitors_object(). Those write to the unmapped RAM header,
and unmap and unreference the freed buffer object.
Destroy the monitors object on the error path, so that
qxl_destroy_monitors_object() has nothing left to do when it runs
again during the device release.
It will also be needed when drm_mode_config_reset() gets replaced by
drm_mode_config_create_initial_state(), whose state allocation can
fail.
Fixes: e485883c815ee ("drm/qxl: Use vblank timer")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-199921@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/qxl/qxl_display.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 204c47d61373..77fbf3c864cc 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1308,14 +1308,18 @@ int qxl_modeset_init(struct qxl_device *qdev)
qxl_display_read_client_monitors_config(qdev);
ret = drm_vblank_init(&qdev->ddev, qxl_num_crtc);
if (ret)
- return ret;
+ goto destroy_monitors_object;
drm_mode_config_reset(&qdev->ddev);
return 0;
+
+destroy_monitors_object:
+ qxl_destroy_monitors_object(qdev);
+ return ret;
}
void qxl_modeset_fini(struct qxl_device *qdev)
{
if (qdev->dumb_shadow_bo) {
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 24/64] drm/qxl: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (23 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 10:52 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann, spice-devel,
virtualization
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/qxl/qxl_display.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 77fbf3c864cc..361265a0d620 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1310,11 +1310,14 @@ int qxl_modeset_init(struct qxl_device *qdev)
ret = drm_vblank_init(&qdev->ddev, qxl_num_crtc);
if (ret)
goto destroy_monitors_object;
- drm_mode_config_reset(&qdev->ddev);
+ ret = drm_mode_config_create_initial_state(&qdev->ddev);
+ if (ret)
+ goto destroy_monitors_object;
+
return 0;
destroy_monitors_object:
qxl_destroy_monitors_object(qdev);
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 25/64] drm/rcar-du: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (24 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-17 23:53 ` Laurent Pinchart
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Geert Uytterhoeven, Kieran Bingham,
Laurent Pinchart, Magnus Damm, Tomi Valkeinen, linux-renesas-soc
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org
---
drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
index 9228a7ad0dfa..7fddde804dc6 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
@@ -1000,11 +1000,13 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
* DPAD0.
*/
dpad0_sources = rcdu->info->routes[RCAR_DU_OUTPUT_DPAD0].possible_crtcs;
rcdu->dpad0_source = ffs(dpad0_sources) - 1;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 25/64] drm/rcar-du: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 25/64] drm/rcar-du: " Maxime Ripard
@ 2026-11-17 23:53 ` Laurent Pinchart
0 siblings, 0 replies; 87+ messages in thread
From: Laurent Pinchart @ 2026-11-17 23:53 UTC (permalink / raw)
To: Maxime Ripard
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, Geert Uytterhoeven, Kieran Bingham, Magnus Damm,
Tomi Valkeinen, linux-renesas-soc
Hi Maxime,
Thank you for the patch.
On Mon, Nov 16, 2026 at 11:30:41AM +0100, Maxime Ripard wrote:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
>
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
>
> Switch to drm_mode_config_create_initial_state().
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> index 9228a7ad0dfa..7fddde804dc6 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> @@ -1000,11 +1000,13 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
> * DPAD0.
> */
> dpad0_sources = rcdu->info->routes[RCAR_DU_OUTPUT_DPAD0].possible_crtcs;
> rcdu->dpad0_source = ffs(dpad0_sources) - 1;
>
> - drm_mode_config_reset(dev);
> + ret = drm_mode_config_create_initial_state(dev);
> + if (ret)
> + return ret;
>
> drm_kms_helper_poll_init(dev);
>
> return 0;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 26/64] drm/rz-du: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (25 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Biju Das, linux-renesas-soc
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: linux-renesas-soc@vger.kernel.org
---
drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
index 87f171145a23..07171f2f3052 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
@@ -469,11 +469,13 @@ int rzg2l_du_modeset_init(struct rzg2l_du_device *rcdu)
encoder->possible_crtcs = route->possible_outputs;
encoder->possible_clones = (1 << num_encoders) - 1;
}
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 27/64] drm/shmobile: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (26 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Geert Uytterhoeven, linux-renesas-soc
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org
---
drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c
index fd9460da1789..4d3a714e255d 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c
@@ -173,11 +173,13 @@ int shmob_drm_modeset_init(struct shmob_drm_device *sdev)
ret = shmob_drm_connector_create(sdev, &sdev->encoder);
if (ret < 0)
return ret;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(dev);
sdev->ddev.mode_config.min_width = 0;
sdev->ddev.mode_config.min_height = 0;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 28/64] drm/st7571: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (27 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Marcus Folkesson
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/gpu/drm/sitronix/st7571.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sitronix/st7571.c b/drivers/gpu/drm/sitronix/st7571.c
index 608d38eab0fc..2d82fb78587d 100644
--- a/drivers/gpu/drm/sitronix/st7571.c
+++ b/drivers/gpu/drm/sitronix/st7571.c
@@ -865,11 +865,13 @@ struct st7571_device *st7571_probe(struct device *dev,
if (ret < 0) {
dev_err(st7571->dev, "Failed to initialize connector\n");
return ERR_PTR(ret);
}
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
ret = drm_dev_register(drm, 0);
if (ret) {
dev_err(st7571->dev, "Failed to register DRM device\n");
return ERR_PTR(ret);
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 29/64] drm/st7586: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (28 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-17 14:03 ` David Lechner
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, David Lechner
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: David Lechner <david@lechnology.com>
---
drivers/gpu/drm/sitronix/st7586.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sitronix/st7586.c b/drivers/gpu/drm/sitronix/st7586.c
index 28b2245f6b79..50b2e4c901ce 100644
--- a/drivers/gpu/drm/sitronix/st7586.c
+++ b/drivers/gpu/drm/sitronix/st7586.c
@@ -453,11 +453,13 @@ static int st7586_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 30/64] drm/st7735r: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (29 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-17 14:03 ` David Lechner
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, David Lechner
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: David Lechner <david@lechnology.com>
---
drivers/gpu/drm/sitronix/st7735r.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sitronix/st7735r.c b/drivers/gpu/drm/sitronix/st7735r.c
index bd763871dca0..e6c77b01dd38 100644
--- a/drivers/gpu/drm/sitronix/st7735r.c
+++ b/drivers/gpu/drm/sitronix/st7735r.c
@@ -333,11 +333,13 @@ static int st7735r_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 31/64] drm/st7920: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (30 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Iker Pedrosa
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Iker Pedrosa <ikerpedrosam@gmail.com>
---
drivers/gpu/drm/sitronix/st7920.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sitronix/st7920.c b/drivers/gpu/drm/sitronix/st7920.c
index 2f2c808e783b..616d83387d31 100644
--- a/drivers/gpu/drm/sitronix/st7920.c
+++ b/drivers/gpu/drm/sitronix/st7920.c
@@ -782,13 +782,11 @@ static int st7920_init_modeset(struct st7920_device *st7920)
if (ret) {
drm_err(drm, "DRM attach connector to encoder failed: %d\n", ret);
return ret;
}
- drm_mode_config_reset(drm);
-
- return 0;
+ return drm_mode_config_create_initial_state(drm);
}
static int st7920_probe(struct spi_device *spi)
{
struct st7920_device *st7920;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 32/64] drm/sprd: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (31 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Baolin Wang, Chunyan Zhang, Orson Zhai
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Orson Zhai <orsonzhai@gmail.com>
---
drivers/gpu/drm/sprd/sprd_drm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sprd_drm.c
index c2fd5380a834..cef022f54912 100644
--- a/drivers/gpu/drm/sprd/sprd_drm.c
+++ b/drivers/gpu/drm/sprd/sprd_drm.c
@@ -93,12 +93,14 @@ static int sprd_drm_bind(struct device *dev)
if (ret) {
drm_err(drm, "failed to initialize vblank.\n");
goto err_unbind_all;
}
- /* reset all the states of crtc/plane/encoder/connector */
- drm_mode_config_reset(drm);
+ /* Create the states of crtc/plane/encoder/connector */
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_unbind_all;
/* init kms poll for handling hpd */
drm_kms_helper_poll_init(drm);
ret = drm_dev_register(drm, 0);
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 33/64] drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
2026-11-16 10:30 ` Maxime Ripard
` (32 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
sti_cleanup() is shared between sti_unbind() and the sti_bind()
error paths, and calls drm_atomic_helper_shutdown().
However, on the error paths the initial state may not have been
created yet: when component_bind_all() or drm_dev_register() fails,
drm_mode_config_reset() hasn't run and the CRTC state is still NULL.
drm_atomic_helper_shutdown() will then go through
drm_atomic_helper_disable_all() and drm_atomic_get_crtc_state() to
drm_atomic_helper_crtc_duplicate_state(), which trips its
WARN_ON(!crtc->state) and returns an error.
Move drm_atomic_helper_shutdown() out of sti_cleanup() and into
sti_unbind(), so that it's only ever called on a fully initialized
device. It still runs after drm_dev_unregister() and before
drm_mode_config_cleanup(), as it did before.
It will also be needed when drm_mode_config_reset() gets replaced by
drm_mode_config_create_initial_state(), whose state allocation can
fail.
Fixes: a2b50babc7439 ("drm/sti: Use drm_atomic_helper_shutdown")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-200075@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/sti/sti_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 0ca6c6b41f18..794badf199c9 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -171,11 +171,10 @@ static int sti_init(struct drm_device *ddev)
static void sti_cleanup(struct drm_device *ddev)
{
struct sti_private *private = ddev->dev_private;
drm_kms_helper_poll_fini(ddev);
- drm_atomic_helper_shutdown(ddev);
drm_mode_config_cleanup(ddev);
component_unbind_all(ddev->dev, ddev);
dev_set_drvdata(ddev->dev, NULL);
kfree(private);
ddev->dev_private = NULL;
@@ -222,10 +221,11 @@ static int sti_bind(struct device *dev)
static void sti_unbind(struct device *dev)
{
struct drm_device *ddev = dev_get_drvdata(dev);
drm_dev_unregister(ddev);
+ drm_atomic_helper_shutdown(ddev);
sti_cleanup(ddev);
drm_dev_put(ddev);
}
static const struct component_master_ops sti_ops = {
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 34/64] drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
2026-11-16 10:30 ` Maxime Ripard
` (33 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, sashiko-bot
sti_bind() calls drm_dev_register() before
drm_mode_config_create_initial_state(), so the device is exposed to
userspace, through its device node and its connectors sysfs attributes,
while the plane, CRTC and connector states are still NULL. A process
opening the device in that window could then hit a NULL pointer
dereference.
Move drm_mode_config_create_initial_state() before drm_dev_register().
Fixes: 84601dbdea366 ("drm: sti: rework init sequence")
Reported-by: sashiko-bot@kernel.org
Link: https://lore.kernel.org/r/sashiko-outbox-200075@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/sti/sti_drv.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 794badf199c9..7db8de8744a4 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -195,24 +195,22 @@ static int sti_bind(struct device *dev)
ret = component_bind_all(ddev->dev, ddev);
if (ret)
goto err_cleanup;
- ret = drm_dev_register(ddev, 0);
+ ret = drm_mode_config_create_initial_state(ddev);
if (ret)
goto err_cleanup;
- ret = drm_mode_config_create_initial_state(ddev);
+ ret = drm_dev_register(ddev, 0);
if (ret)
- goto err_unregister;
+ goto err_cleanup;
drm_client_setup(ddev, NULL);
return 0;
-err_unregister:
- drm_dev_unregister(ddev);
err_cleanup:
sti_cleanup(ddev);
err_drm_dev_put:
drm_dev_put(ddev);
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 35/64] drm/stm: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (34 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 14:50 ` Raphael Gallais-Pou
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alexandre Torgue, Maxime Coquelin,
Philippe Cornu, Raphael Gallais-Pou, Yannick Fertre
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Philippe Cornu <philippe.cornu@foss.st.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Yannick Fertre <yannick.fertre@foss.st.com>
---
drivers/gpu/drm/stm/drv.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
index 0967b9b3451d..d1caa55e54e3 100644
--- a/drivers/gpu/drm/stm/drv.c
+++ b/drivers/gpu/drm/stm/drv.c
@@ -102,11 +102,15 @@ static int drv_load(struct drm_device *ddev)
ret = ltdc_load(ddev);
if (ret)
return ret;
- drm_mode_config_reset(ddev);
+ ret = drm_mode_config_create_initial_state(ddev);
+ if (ret) {
+ ltdc_unload(ddev);
+ return ret;
+ }
drm_kms_helper_poll_init(ddev);
platform_set_drvdata(pdev, ddev);
return 0;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 35/64] drm/stm: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 35/64] drm/stm: Switch to drm_mode_config_create_initial_state Maxime Ripard
@ 2026-11-16 14:50 ` Raphael Gallais-Pou
0 siblings, 0 replies; 87+ messages in thread
From: Raphael Gallais-Pou @ 2026-11-16 14:50 UTC (permalink / raw)
To: Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: dri-devel, Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
Yannick Fertre
On 11/16/26 11:30, Maxime Ripard wrote:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
>
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
>
> Switch to drm_mode_config_create_initial_state().
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
Hi Maxime,
Acked-by: Raphaël Gallais-Pou <raphael.gallais-pou@foss.st.com>
Thanks,
Best regards,
Raphaël
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 36/64] drm/sun4i: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (35 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Chen-Yu Tsai, Samuel Holland,
linux-sunxi
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Acked-by: Chen-Yu Tsai <wens@kernel.org>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Chen-Yu Tsai <wens@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-sunxi@lists.linux.dev
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +++-
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 6 +++---
drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index f8bbca6eb49c..248be5ff4f36 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -102,11 +102,13 @@ static int sun4i_drv_bind(struct device *dev)
/* Remove early framebuffers (ie. simplefb) */
ret = aperture_remove_all_conflicting_devices(sun4i_drv_driver.name);
if (ret)
goto unbind_all;
- sun4i_framebuffer_init(drm);
+ ret = sun4i_framebuffer_init(drm);
+ if (ret)
+ goto unbind_all;
/* Enable connectors polling */
drm_kms_helper_poll_init(drm);
ret = drm_dev_register(drm, 0);
diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
index fc822bc2c62b..d7e5cdf76c16 100644
--- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
@@ -22,16 +22,16 @@ static const struct drm_mode_config_funcs sun4i_de_mode_config_funcs = {
static const struct drm_mode_config_helper_funcs sun4i_de_mode_config_helpers = {
.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
};
-void sun4i_framebuffer_init(struct drm_device *drm)
+int sun4i_framebuffer_init(struct drm_device *drm)
{
- drm_mode_config_reset(drm);
-
drm->mode_config.max_width = 8192;
drm->mode_config.max_height = 8192;
drm->mode_config.normalize_zpos = true;
drm->mode_config.funcs = &sun4i_de_mode_config_funcs;
drm->mode_config.helper_private = &sun4i_de_mode_config_helpers;
+
+ return drm_mode_config_create_initial_state(drm);
}
diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.h b/drivers/gpu/drm/sun4i/sun4i_framebuffer.h
index 06901fb3a186..378f0de343d7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.h
+++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.h
@@ -7,8 +7,8 @@
*/
#ifndef _SUN4I_FRAMEBUFFER_H_
#define _SUN4I_FRAMEBUFFER_H_
-void sun4i_framebuffer_init(struct drm_device *drm);
+int sun4i_framebuffer_init(struct drm_device *drm);
#endif /* _SUN4I_FRAMEBUFFER_H_ */
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 37/64] drm/tegra: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (36 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Jonathan Hunter, Mikko Perttunen,
Thierry Reding, linux-tegra
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Thierry Reding <thierry.reding@kernel.org>
Cc: linux-tegra@vger.kernel.org
---
drivers/gpu/drm/tegra/drm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 324480c87fb1..9fdb9e70eb0a 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -1243,11 +1243,13 @@ static int host1x_drm_probe(struct host1x_device *dev)
err = drm_vblank_init(drm, drm->mode_config.num_crtc);
if (err < 0)
goto hub;
- drm_mode_config_reset(drm);
+ err = drm_mode_config_create_initial_state(drm);
+ if (err)
+ goto hub;
/*
* Only take over from a potential firmware framebuffer if any CRTCs
* have been registered. This must not be a fatal error because there
* are other accelerators that are exposed via this driver.
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 38/64] drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (37 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 10:55 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tests/drm_atomic_commit_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_atomic_commit_test.c b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
index 6ccb001f6264..97f60ce68b3e 100644
--- a/drivers/gpu/drm/tests/drm_atomic_commit_test.c
+++ b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
@@ -132,11 +132,13 @@ drm_atomic_test_init_drm_components(struct kunit *test, bool has_connectors)
drm_connector_attach_encoder(conn, &priv->encoders[i]);
}
done:
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
return priv;
}
static int set_up_atomic_state(struct kunit *test,
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 38/64] drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 38/64] drm/tests: drm_atomic_state_test: " Maxime Ripard
@ 2026-11-16 10:55 ` sashiko-bot
0 siblings, 0 replies; 87+ messages in thread
From: sashiko-bot @ 2026-11-16 10:55 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/tests: ERR_PTR dereference after
drm_atomic_test_init_drm_components()
- [Low] drm/tests: commit subject uses stale drm_atomic_state_test
prefix
--
commit 764d6a07d978e1acc8e6005af10238d412ddeb08
Author: Maxime Ripard <mripard@kernel.org>
drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
This commit switches drm_atomic_test_init_drm_components() from
drm_mode_config_reset() to drm_mode_config_create_initial_state() for
initial KMS state creation.
> drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
[Severity: Low]
This isn't a bug, but 5164f7e7ff8e ("drm: Rename struct drm_atomic_state
to drm_atomic_commit") renamed this test file to
drm_atomic_commit_test.c, so the subject prefix still refers to the old
name.
> diff --git a/drivers/gpu/drm/tests/drm_atomic_commit_test.c b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> index 6ccb001f6264b..97f60ce68b3e4 100644
> --- a/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> +++ b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> @@ -134,7 +134,9 @@ drm_atomic_test_init_drm_components(struct kunit *test, bool has_connectors)
> }
>
> done:
> - drm_mode_config_reset(drm);
> + ret = drm_mode_config_create_initial_state(drm);
> + if (ret)
> + return ERR_PTR(ret);
>
> return priv;
> }
[Severity: Medium]
Can returning ERR_PTR(ret) here lead to an error pointer dereference in
the callers?
Every earlier step in drm_atomic_test_init_drm_components() aborts via
KUNIT_ASSERT_*, and the callers only check KUNIT_ASSERT_NOT_NULL(test,
priv) before passing priv to set_up_atomic_state(), which dereferences
priv->crtc:
drivers/gpu/drm/tests/drm_atomic_commit_test.c:drm_test_check_connector_changed_modeset() {
...
priv = drm_atomic_test_init_drm_components(test, true);
KUNIT_ASSERT_NOT_NULL(test, priv);
/* First, do a modeset to set the connector */
ret = set_up_atomic_state(test, priv, &priv->connectors[0], &ctx);
...
}
Using KUNIT_ASSERT_EQ(test, ret, 0) here matches the rest of the helper,
and it looks like that change was accidentally squashed into the
following commit "drm/tests: drm_atomic_test: Switch to
drm_mode_config_create_initial_state".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=38
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 39/64] drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (38 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 10:53 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tests/drm_atomic_commit_test.c | 3 +--
drivers/gpu/drm/tests/drm_atomic_test.c | 4 +++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tests/drm_atomic_commit_test.c b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
index 97f60ce68b3e..a02859a0d8bf 100644
--- a/drivers/gpu/drm/tests/drm_atomic_commit_test.c
+++ b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
@@ -133,12 +133,11 @@ drm_atomic_test_init_drm_components(struct kunit *test, bool has_connectors)
drm_connector_attach_encoder(conn, &priv->encoders[i]);
}
done:
ret = drm_mode_config_create_initial_state(drm);
- if (ret)
- return ERR_PTR(ret);
+ KUNIT_ASSERT_EQ(test, ret, 0);
return priv;
}
static int set_up_atomic_state(struct kunit *test,
diff --git a/drivers/gpu/drm/tests/drm_atomic_test.c b/drivers/gpu/drm/tests/drm_atomic_test.c
index 541a0062f143..5e156d09e56f 100644
--- a/drivers/gpu/drm/tests/drm_atomic_test.c
+++ b/drivers/gpu/drm/tests/drm_atomic_test.c
@@ -84,11 +84,13 @@ static struct drm_atomic_test_priv *create_device(struct kunit *test)
drm_connector_helper_add(connector, &drm_atomic_init_connector_helper_funcs);
drm_connector_attach_encoder(connector, enc);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
return priv;
}
static void drm_test_drm_atomic_get_connector_for_encoder(struct kunit *test)
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 39/64] drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 39/64] drm/tests: drm_atomic_test: " Maxime Ripard
@ 2026-11-16 10:53 ` sashiko-bot
0 siblings, 0 replies; 87+ messages in thread
From: sashiko-bot @ 2026-11-16 10:53 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/tests: misplaced fixup hunk in
drm_atomic_test_init_drm_components()
--
commit 4a8e39a2143161f4693081f0e4cf620a298d8f3a
Author: Maxime Ripard <mripard@kernel.org>
drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
This commit switches create_device() in drm_atomic_test.c from
drm_mode_config_reset() to drm_mode_config_create_initial_state(), and
updates error handling in drm_atomic_test_init_drm_components() in
drm_atomic_commit_test.c.
> diff --git a/drivers/gpu/drm/tests/drm_atomic_commit_test.c b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> index 97f60ce68b3e4..a02859a0d8bf3 100644
> --- a/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> +++ b/drivers/gpu/drm/tests/drm_atomic_commit_test.c
> @@ -135,8 +135,7 @@ drm_atomic_test_init_drm_components(struct kunit *test, bool has_connectors)
>
> done:
> ret = drm_mode_config_create_initial_state(drm);
> - if (ret)
> - return ERR_PTR(ret);
> + KUNIT_ASSERT_EQ(test, ret, 0);
>
> return priv;
> }
[Severity: Low]
Should this hunk be squashed into the earlier commit "drm/tests:
drm_atomic_state_test: Switch to drm_mode_config_create_initial_state"?
That commit converted drm_atomic_test_init_drm_components() to return
ERR_PTR(ret), even though callers such as
drm_test_check_connector_changed_modeset() only check
KUNIT_ASSERT_NOT_NULL(test, priv) and would dereference an error pointer
at that point in the series.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=39
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 40/64] drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (39 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tests/drm_bridge_test.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tests/drm_bridge_test.c b/drivers/gpu/drm/tests/drm_bridge_test.c
index 15583ade8494..f56209c0ab1c 100644
--- a/drivers/gpu/drm/tests/drm_bridge_test.c
+++ b/drivers/gpu/drm/tests/drm_bridge_test.c
@@ -420,11 +420,13 @@ drm_test_bridge_init(struct kunit *test, const struct drm_bridge_funcs *funcs)
priv->connector = drm_bridge_connector_init(drm, enc);
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
return priv;
}
static struct drm_bridge_chain_priv *
@@ -518,11 +520,13 @@ drm_test_bridge_chain_init(struct kunit *test, unsigned int num_bridges,
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
drm_connector_attach_encoder(priv->connector, enc);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
if (!has_hdmi)
return priv;
scoped_guard(mutex, &drm->mode_config.mutex) {
@@ -610,11 +614,13 @@ drm_test_bridge_hdmi_init(struct kunit *test, const struct drm_bridge_funcs *fun
if (IS_ERR(priv->connector))
return ERR_CAST(priv->connector);
drm_connector_attach_encoder(priv->connector, enc);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ERR_PTR(ret);
return priv;
}
/*
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 41/64] drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (40 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
index 336bb644cb7c..35c551b4a35d 100644
--- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
@@ -295,11 +295,12 @@ __connector_hdmi_init(struct kunit *test,
KUNIT_ASSERT_EQ(test, ret, 0);
drm_connector_helper_add(conn, &dummy_connector_helper_funcs);
drm_connector_attach_encoder(conn, enc);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ KUNIT_ASSERT_EQ(test, ret, 0);
if (edid_data && edid_len) {
ret = set_connector_edid(test, &priv->connector, edid_data, edid_len);
KUNIT_ASSERT_GT(test, ret, 0);
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 42/64] drm/tidss: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (41 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Jyri Sarha, Tomi Valkeinen
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/tidss/tidss_drv.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 44b0b009c29a..e258f656cf03 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -164,11 +164,15 @@ static int tidss_probe(struct platform_device *pdev)
goto err_runtime_suspend;
}
drm_kms_helper_poll_init(ddev);
- drm_mode_config_reset(ddev);
+ ret = drm_mode_config_create_initial_state(ddev);
+ if (ret) {
+ dev_err(dev, "failed to create initial state: %d\n", ret);
+ goto err_irq_uninstall;
+ }
ret = drm_dev_register(ddev, 0);
if (ret) {
dev_err(dev, "failed to register DRM device\n");
goto err_irq_uninstall;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 43/64] drm/tilcdc: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (42 preceding siblings ...)
(?)
@ 2026-11-16 10:30 ` Maxime Ripard
2026-11-16 11:10 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Jyri Sarha, Tomi Valkeinen
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 1d6c9a423a41..da718d9cb1d6 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -420,11 +420,13 @@ static int tilcdc_pdev_probe(struct platform_device *pdev)
if (ret < 0) {
drm_err(ddev, "failed to install IRQ handler\n");
goto unregister_cpufreq_notif;
}
- drm_mode_config_reset(ddev);
+ ret = drm_mode_config_create_initial_state(ddev);
+ if (ret)
+ goto stop_poll;
drm_kms_helper_poll_init(ddev);
ret = drm_dev_register(ddev, 0);
if (ret)
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 43/64] drm/tilcdc: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` [PATCH v2 43/64] drm/tilcdc: " Maxime Ripard
@ 2026-11-16 11:10 ` sashiko-bot
0 siblings, 0 replies; 87+ messages in thread
From: sashiko-bot @ 2026-11-16 11:10 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/tilcdc: tilcdc_pdev_probe() skips tilcdc_crtc_hw_reset()
--
commit ae76397fb05d05122d64d74fa8d16d0b22b1c809
Author: Maxime Ripard <mripard@kernel.org>
drm/tilcdc: Switch to drm_mode_config_create_initial_state
This commit replaces drm_mode_config_reset() with
drm_mode_config_create_initial_state() in tilcdc_pdev_probe() to initialize
the KMS state at probe time.
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 1d6c9a423a410..da718d9cb1d69 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -422,7 +422,9 @@ static int tilcdc_pdev_probe(struct platform_device *pdev)
> goto unregister_cpufreq_notif;
> }
>
> - drm_mode_config_reset(ddev);
> + ret = drm_mode_config_create_initial_state(ddev);
> + if (ret)
> + goto stop_poll;
[Severity: High]
Does replacing drm_mode_config_reset() with
drm_mode_config_create_initial_state() skip tilcdc_crtc_hw_reset() during
probe?
tilcdc_crtc_hw_reset() is wired to drm_crtc_helper_funcs.hw_reset to turn off
LCDC_RASTER_ENABLE and wait for LCDC_FRAME_DONE when the bootloader leaves
the display controller active at boot, as introduced in 46a956ab3c5b
("drm/tilcdc: Turn raster off in crtc reset, if it was on in the HW") and
6e531fda1d6b ("drm/tilcdc: Move hardware reset to hw_reset hook").
Because drm_mode_config_create_initial_state() calls
drm_mode_config_crtc_create_state() without invoking helper_funcs->hw_reset,
hardware scanout stays enabled while the initial CRTC state is marked
disabled, causing the first modeset in tilcdc_crtc_enable() to reprogram
timings and DMA addresses while the raster is still running and time out
loading the palette.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=43
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 44/64] drm/arcpgu: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (43 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alexey Brodkin
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alexey Brodkin <abrodkin@synopsys.com>
---
drivers/gpu/drm/tiny/arcpgu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index 32f6e98ba9c5..08747a98ff3b 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -414,11 +414,13 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
}
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(drm);
platform_set_drvdata(pdev, drm);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 45/64] drm/bochs: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (44 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
2026-11-16 10:55 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Gerd Hoffmann, virtualization
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/tiny/bochs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 771d59b92f67..c24adbcb77a3 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -681,13 +681,11 @@ static int bochs_kms_init(struct bochs_device *bochs)
ret = drm_vblank_init(dev, 1);
if (ret)
return ret;
- drm_mode_config_reset(dev);
-
- return 0;
+ return drm_mode_config_create_initial_state(dev);
}
/* ---------------------------------------------------------------------- */
/* drm interface */
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 46/64] drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (45 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
2026-11-16 10:54 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann,
virtualization
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/tiny/cirrus-qemu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/cirrus-qemu.c b/drivers/gpu/drm/tiny/cirrus-qemu.c
index 9e3051b9c3f7..98664f573ff8 100644
--- a/drivers/gpu/drm/tiny/cirrus-qemu.c
+++ b/drivers/gpu/drm/tiny/cirrus-qemu.c
@@ -621,11 +621,13 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
ret = cirrus_pipe_init(cirrus);
if (ret < 0)
return ret;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
pci_set_drvdata(pdev, dev);
ret = drm_dev_register(dev, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 47/64] drm/gm12u320: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (46 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Hans de Goede
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Hans de Goede <hansg@kernel.org>
---
drivers/gpu/drm/tiny/gm12u320.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
index 5c4004346ff8..527b830e4465 100644
--- a/drivers/gpu/drm/tiny/gm12u320.c
+++ b/drivers/gpu/drm/tiny/gm12u320.c
@@ -770,11 +770,13 @@ static int gm12u320_usb_probe(struct usb_interface *interface,
ret = drm_connector_attach_encoder(&gm12u320->conn, &gm12u320->encoder);
if (ret)
return ret;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
usb_set_intfdata(interface, dev);
ret = drm_dev_register(dev, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 48/64] drm/hx8357d: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (47 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tiny/hx8357d.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c
index f942a8d09ff2..fe2fc76e2b3f 100644
--- a/drivers/gpu/drm/tiny/hx8357d.c
+++ b/drivers/gpu/drm/tiny/hx8357d.c
@@ -358,11 +358,13 @@ static int hx8357d_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 49/64] drm/ili9163: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (48 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tiny/ili9163.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ili9163.c b/drivers/gpu/drm/tiny/ili9163.c
index 8842424504e3..5b94626c2177 100644
--- a/drivers/gpu/drm/tiny/ili9163.c
+++ b/drivers/gpu/drm/tiny/ili9163.c
@@ -289,11 +289,13 @@ static int ili9163_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 50/64] drm/ili9225: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (49 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
2026-11-17 14:03 ` David Lechner
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, David Lechner
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: David Lechner <david@lechnology.com>
---
drivers/gpu/drm/tiny/ili9225.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index 5bf52a8fd75b..3b1f3b9a0abe 100644
--- a/drivers/gpu/drm/tiny/ili9225.c
+++ b/drivers/gpu/drm/tiny/ili9225.c
@@ -516,11 +516,13 @@ static int ili9225_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 51/64] drm/ili9341: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (50 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tiny/ili9341.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c
index 003381aa22ea..def7696362ff 100644
--- a/drivers/gpu/drm/tiny/ili9341.c
+++ b/drivers/gpu/drm/tiny/ili9341.c
@@ -320,11 +320,13 @@ static int ili9341_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 52/64] drm/ili9486: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (51 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Kamlesh Gurudasani
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
---
drivers/gpu/drm/tiny/ili9486.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index c945a9144315..755aac1f749b 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -348,11 +348,13 @@ static int ili9486_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 53/64] drm/mi0283qt: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (52 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alex Lanzano
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alex Lanzano <lanzano.alex@gmail.com>
---
drivers/gpu/drm/tiny/mi0283qt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
index b0121e89e2dc..cf53509044d1 100644
--- a/drivers/gpu/drm/tiny/mi0283qt.c
+++ b/drivers/gpu/drm/tiny/mi0283qt.c
@@ -328,11 +328,13 @@ static int mi0283qt_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 54/64] drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (53 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/tiny/panel-mipi-dbi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
index 3f462d79a6d3..6835c7d0f208 100644
--- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c
+++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
@@ -488,11 +488,13 @@ static int panel_mipi_dbi_spi_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 55/64] drm/pixpaper: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (54 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, LiangCheng Wang
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: LiangCheng Wang <zaq14760@gmail.com>
---
drivers/gpu/drm/tiny/pixpaper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/pixpaper.c b/drivers/gpu/drm/tiny/pixpaper.c
index 2a92a28b40f6..f8a633d0fbd8 100644
--- a/drivers/gpu/drm/tiny/pixpaper.c
+++ b/drivers/gpu/drm/tiny/pixpaper.c
@@ -1116,11 +1116,13 @@ static int pixpaper_probe(struct spi_device *spi)
drm_connector_helper_add(&panel->connector,
&pixpaper_connector_helper_funcs);
drm_connector_attach_encoder(&panel->connector, &panel->encoder);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 56/64] drm/repaper: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (55 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alex Lanzano
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alex Lanzano <lanzano.alex@gmail.com>
---
drivers/gpu/drm/tiny/repaper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index 25e6a7a4affc..4a0f55e3a9ee 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -1188,11 +1188,13 @@ static int repaper_probe(struct spi_device *spi)
ret = drm_connector_attach_encoder(&epd->connector, &epd->encoder);
if (ret)
return ret;
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 57/64] drm/sharp-memory: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (56 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Alex Lanzano
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Alex Lanzano <lanzano.alex@gmail.com>
---
drivers/gpu/drm/tiny/sharp-memory.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/sharp-memory.c b/drivers/gpu/drm/tiny/sharp-memory.c
index b948e44544d6..579782940cf4 100644
--- a/drivers/gpu/drm/tiny/sharp-memory.c
+++ b/drivers/gpu/drm/tiny/sharp-memory.c
@@ -618,11 +618,13 @@ static int sharp_memory_probe(struct spi_device *spi)
NULL);
if (ret)
return dev_err_probe(dev, ret, "Failed to initialize display pipeline.\n");
drm_plane_enable_fb_damage_clips(&smd->plane);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ return ret;
ret = drm_dev_register(drm, 0);
if (ret)
return dev_err_probe(dev, ret, "Failed to register drm device.\n");
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 58/64] drm/udl: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (57 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Sean Paul
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Sean Paul <sean@poorly.run>
---
drivers/gpu/drm/udl/udl_modeset.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index d8a617e2d2ea..02138457a97b 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -538,10 +538,12 @@ int udl_modeset_init(struct udl_device *udl)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret)
return ret;
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drmm_kms_helper_poll_init(dev);
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 59/64] drm/vboxvideo: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (58 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Hans de Goede
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Hans de Goede <hansg@kernel.org>
---
drivers/gpu/drm/vboxvideo/vbox_mode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c
index d66dc1cbbd82..414f2af1e821 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_mode.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c
@@ -875,11 +875,14 @@ int vbox_mode_init(struct vbox_private *vbox)
ret = vbox_connector_init(dev, vbox_crtc, encoder);
if (ret)
goto err_drm_mode_cleanup;
}
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ goto err_drm_mode_cleanup;
+
return 0;
err_drm_mode_cleanup:
drm_mode_config_cleanup(dev);
return ret;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 60/64] drm/verisilicon: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (59 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Icenowy Zheng
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
drivers/gpu/drm/verisilicon/vs_drm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/verisilicon/vs_drm.c b/drivers/gpu/drm/verisilicon/vs_drm.c
index fd259d53f49f..3f93cd43c623 100644
--- a/drivers/gpu/drm/verisilicon/vs_drm.c
+++ b/drivers/gpu/drm/verisilicon/vs_drm.c
@@ -128,11 +128,13 @@ int vs_drm_initialize(struct vs_dc *dc, struct platform_device *pdev)
vs_mode_config_init(drm);
/* Enable connectors polling */
drm_kms_helper_poll_init(drm);
- drm_mode_config_reset(drm);
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_fini_poll;
ret = drm_dev_register(drm, 0);
if (ret)
goto err_fini_poll;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 61/64] drm/virtio: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (60 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
2026-11-16 11:01 ` sashiko-bot
-1 siblings, 1 reply; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Chia-I Wu, David Airlie,
Dmitry Osipenko, Gerd Hoffmann, Gurchetan Singh, virtualization
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Chia-I Wu <olvaffe@gmail.com>
Cc: David Airlie <airlied@redhat.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index f0ed9bd27a91..dfc3aed03b8e 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -394,12 +394,11 @@ int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev)
ret = drm_vblank_init(vgdev->ddev, vgdev->num_scanouts);
if (ret)
return ret;
- drm_mode_config_reset(vgdev->ddev);
- return 0;
+ return drm_mode_config_create_initial_state(vgdev->ddev);
}
void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)
{
int i;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 62/64] drm/vmwgfx: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (61 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
2026-11-16 11:08 ` sashiko-bot
2026-11-17 6:52 ` Zack Rusin
-1 siblings, 2 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Broadcom internal kernel review list,
Zack Rusin
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: Zack Rusin <zack.rusin@broadcom.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +++++++++++++-
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 ---
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 ---
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 ---
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 90ab9380d883..4924649033bb 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1173,15 +1173,27 @@ int vmw_kms_init(struct vmw_private *dev_priv)
if (ret) {
ret = vmw_kms_sou_init_display(dev_priv);
if (ret) /* Fallback */
ret = vmw_kms_ldu_init_display(dev_priv);
}
+ if (ret)
+ return ret;
+
BUILD_BUG_ON(ARRAY_SIZE(display_unit_names) != (vmw_du_max + 1));
drm_info(&dev_priv->drm, "%s display unit initialized\n",
display_unit_names[dev_priv->active_display_unit]);
- return ret;
+ /*
+ * Create the initial state once, after the display unit that will
+ * be used has been settled on: a failure in one of the display
+ * unit initialization functions is used as a fallback condition to
+ * try the next one, and creating the state on a partially
+ * initialized device would both leave the KMS objects of the two
+ * backends on the same drm_device and trip WARN_ON() on the objects
+ * that don't have a state.
+ */
+ return drm_mode_config_create_initial_state(dev);
}
int vmw_kms_close(struct vmw_private *dev_priv)
{
int ret = 0;
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
index 0dea09cc29a7..dd5ca4dc75e8 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
@@ -537,11 +537,10 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
return ret;
}
int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
{
- struct drm_device *dev = &dev_priv->drm;
int i, ret;
int num_display_units = (dev_priv->capabilities & SVGA_CAP_MULTIMON) ?
VMWGFX_NUM_DISPLAY_UNITS : 1;
if (unlikely(dev_priv->ldu_priv)) {
@@ -565,12 +564,10 @@ int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
goto err_free;
}
dev_priv->active_display_unit = vmw_du_legacy;
- drm_mode_config_reset(dev);
-
return 0;
err_free:
kfree(dev_priv->ldu_priv);
dev_priv->ldu_priv = NULL;
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
index 39d58fc392bf..291e24456d06 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
@@ -921,11 +921,10 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit)
return ret;
}
int vmw_kms_sou_init_display(struct vmw_private *dev_priv)
{
- struct drm_device *dev = &dev_priv->drm;
int i;
/* Screen objects won't work if GMR's aren't available */
if (!dev_priv->has_gmr)
return -ENOSYS;
@@ -937,12 +936,10 @@ int vmw_kms_sou_init_display(struct vmw_private *dev_priv)
for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i)
vmw_sou_init(dev_priv, i);
dev_priv->active_display_unit = vmw_du_screen_object;
- drm_mode_config_reset(dev);
-
return 0;
}
static int do_bo_define_gmrfb(struct vmw_private *dev_priv,
struct vmw_framebuffer *framebuffer)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
index b505f8ba3e83..7a3e6ee10932 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
@@ -1683,11 +1683,10 @@ static void vmw_stdu_destroy(struct vmw_screen_target_display_unit *stdu)
* RETURNS:
* 0 on success, error code otherwise
*/
int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
{
- struct drm_device *dev = &dev_priv->drm;
int i, ret;
/* Do nothing if there's no support for MOBs */
if (!dev_priv->has_mob)
@@ -1706,9 +1705,7 @@ int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
"Failed to initialize STDU %d", i);
return ret;
}
}
- drm_mode_config_reset(dev);
-
return 0;
}
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 62/64] drm/vmwgfx: Switch to drm_mode_config_create_initial_state
2026-11-16 10:31 ` [PATCH v2 62/64] drm/vmwgfx: " Maxime Ripard
@ 2026-11-16 11:08 ` sashiko-bot
2026-11-17 6:52 ` Zack Rusin
1 sibling, 0 replies; 87+ messages in thread
From: sashiko-bot @ 2026-11-16 11:08 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/vmwgfx: leak of ldu_priv in vmw_kms_init() on initial
state error
--
commit 5f937b8ad11b4bd1a6956c12405bef9b28767c1f
Author: Maxime Ripard <mripard@kernel.org>
drm/vmwgfx: Switch to drm_mode_config_create_initial_state
This commit replaces the drm_mode_config_reset() calls in the individual
display unit init functions with a single
drm_mode_config_create_initial_state() call in vmw_kms_init().
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 90ab9380d8830..4924649033bb7 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -1175,11 +1175,23 @@ int vmw_kms_init(struct vmw_private *dev_priv)
> if (ret) /* Fallback */
> ret = vmw_kms_ldu_init_display(dev_priv);
> }
> + if (ret)
> + return ret;
> +
> BUILD_BUG_ON(ARRAY_SIZE(display_unit_names) != (vmw_du_max + 1));
> drm_info(&dev_priv->drm, "%s display unit initialized\n",
> display_unit_names[dev_priv->active_display_unit]);
>
> - return ret;
> + /*
> + * Create the initial state once, after the display unit that will
> + * be used has been settled on: a failure in one of the display
> + * unit initialization functions is used as a fallback condition to
> + * try the next one, and creating the state on a partially
> + * initialized device would both leave the KMS objects of the two
> + * backends on the same drm_device and trip WARN_ON() on the objects
> + * that don't have a state.
> + */
> + return drm_mode_config_create_initial_state(dev);
> }
[Severity: Medium]
Does this leak dev_priv->ldu_priv if drm_mode_config_create_initial_state()
fails after falling back to vmw_kms_ldu_init_display()?
vmw_kms_ldu_init_display() allocates dev_priv->ldu_priv with kmalloc_obj(),
which is only freed by vmw_kms_close() -> vmw_kms_ldu_close_display(). When
vmw_kms_init() returns an error here, vmw_driver_load() jumps to out_no_kms
and skips vmw_kms_close().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=62
^ permalink raw reply [flat|nested] 87+ messages in thread
* Re: [PATCH v2 62/64] drm/vmwgfx: Switch to drm_mode_config_create_initial_state
2026-11-16 10:31 ` [PATCH v2 62/64] drm/vmwgfx: " Maxime Ripard
2026-11-16 11:08 ` sashiko-bot
@ 2026-11-17 6:52 ` Zack Rusin
1 sibling, 0 replies; 87+ messages in thread
From: Zack Rusin @ 2026-11-17 6:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, Broadcom internal kernel review list
[-- Attachment #1: Type: text/plain, Size: 6208 bytes --]
On Mon, Nov 16, 2026 at 5:34 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
>
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
>
> Switch to drm_mode_config_create_initial_state().
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
> Cc: Zack Rusin <zack.rusin@broadcom.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +++++++++++++-
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 ---
> 4 files changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 90ab9380d883..4924649033bb 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -1173,15 +1173,27 @@ int vmw_kms_init(struct vmw_private *dev_priv)
> if (ret) {
> ret = vmw_kms_sou_init_display(dev_priv);
> if (ret) /* Fallback */
> ret = vmw_kms_ldu_init_display(dev_priv);
> }
> + if (ret)
> + return ret;
> +
> BUILD_BUG_ON(ARRAY_SIZE(display_unit_names) != (vmw_du_max + 1));
> drm_info(&dev_priv->drm, "%s display unit initialized\n",
> display_unit_names[dev_priv->active_display_unit]);
>
> - return ret;
> + /*
> + * Create the initial state once, after the display unit that will
> + * be used has been settled on: a failure in one of the display
> + * unit initialization functions is used as a fallback condition to
> + * try the next one, and creating the state on a partially
> + * initialized device would both leave the KMS objects of the two
> + * backends on the same drm_device and trip WARN_ON() on the objects
> + * that don't have a state.
> + */
> + return drm_mode_config_create_initial_state(dev);
> }
>
> int vmw_kms_close(struct vmw_private *dev_priv)
> {
> int ret = 0;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> index 0dea09cc29a7..dd5ca4dc75e8 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
> @@ -537,11 +537,10 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
> return ret;
> }
>
> int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
> {
> - struct drm_device *dev = &dev_priv->drm;
> int i, ret;
> int num_display_units = (dev_priv->capabilities & SVGA_CAP_MULTIMON) ?
> VMWGFX_NUM_DISPLAY_UNITS : 1;
>
> if (unlikely(dev_priv->ldu_priv)) {
> @@ -565,12 +564,10 @@ int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
> goto err_free;
> }
>
> dev_priv->active_display_unit = vmw_du_legacy;
>
> - drm_mode_config_reset(dev);
> -
> return 0;
>
> err_free:
> kfree(dev_priv->ldu_priv);
> dev_priv->ldu_priv = NULL;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> index 39d58fc392bf..291e24456d06 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> @@ -921,11 +921,10 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit)
> return ret;
> }
>
> int vmw_kms_sou_init_display(struct vmw_private *dev_priv)
> {
> - struct drm_device *dev = &dev_priv->drm;
> int i;
>
> /* Screen objects won't work if GMR's aren't available */
> if (!dev_priv->has_gmr)
> return -ENOSYS;
> @@ -937,12 +936,10 @@ int vmw_kms_sou_init_display(struct vmw_private *dev_priv)
> for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i)
> vmw_sou_init(dev_priv, i);
>
> dev_priv->active_display_unit = vmw_du_screen_object;
>
> - drm_mode_config_reset(dev);
> -
> return 0;
> }
>
> static int do_bo_define_gmrfb(struct vmw_private *dev_priv,
> struct vmw_framebuffer *framebuffer)
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> index b505f8ba3e83..7a3e6ee10932 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> @@ -1683,11 +1683,10 @@ static void vmw_stdu_destroy(struct vmw_screen_target_display_unit *stdu)
> * RETURNS:
> * 0 on success, error code otherwise
> */
> int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
> {
> - struct drm_device *dev = &dev_priv->drm;
> int i, ret;
>
>
> /* Do nothing if there's no support for MOBs */
> if (!dev_priv->has_mob)
> @@ -1706,9 +1705,7 @@ int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
> "Failed to initialize STDU %d", i);
> return ret;
> }
> }
>
> - drm_mode_config_reset(dev);
> -
> return 0;
> }
>
> --
> 2.56.1
>
That's a lot nicer than the v1, thanks. Sashiko is right that it leaks
in case of failure and something like:
- return drm_mode_config_create_initial_state(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ vmw_kms_close(dev_priv);
+
+ return ret;
would fix it but given that the leak happens when the screen failed to
initialize and the user has to deal with blank screen and the
allocation is small I would likely call it a low priority and probably
would be ok submitting as is.
Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>
z
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5414 bytes --]
^ permalink raw reply [flat|nested] 87+ messages in thread
* [PATCH v2 63/64] drm/xen: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (62 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Oleksandr Andrushchenko
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
drivers/gpu/drm/xen/xen_drm_front_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
index d193f60fad22..a0287e583a1d 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
@@ -449,11 +449,13 @@ int xen_drm_front_kms_init(struct xen_drm_front_drm_info *drm_info)
drm_mode_config_cleanup(dev);
return ret;
}
}
- drm_mode_config_reset(dev);
+ ret = drm_mode_config_create_initial_state(dev);
+ if (ret)
+ return ret;
drm_kms_helper_poll_init(dev);
return 0;
}
void xen_drm_front_kms_fini(struct xen_drm_front_drm_info *drm_info)
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* [PATCH v2 64/64] drm/xlnx: Switch to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
` (63 preceding siblings ...)
(?)
@ 2026-11-16 10:31 ` Maxime Ripard
-1 siblings, 0 replies; 87+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Michal Simek, Tomi Valkeinen
drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.
Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.
Switch to drm_mode_config_create_initial_state().
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Michal Simek <michal.simek@amd.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/gpu/drm/xlnx/zynqmp_kms.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index 5274bd3f9078..c123ded46f4c 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -522,12 +522,14 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
if (ret < 0)
goto err_poll_fini;
drm_kms_helper_poll_init(drm);
- /* Reset all components and register the DRM device. */
- drm_mode_config_reset(drm);
+ /* Create the initial state and register the DRM device. */
+ ret = drm_mode_config_create_initial_state(drm);
+ if (ret)
+ goto err_poll_fini;
ret = drm_dev_register(drm, 0);
if (ret < 0)
goto err_poll_fini;
--
2.56.1
^ permalink raw reply related [flat|nested] 87+ messages in thread* Re: [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state
2026-11-16 10:30 ` Maxime Ripard
@ 2026-11-17 13:22 ` Thomas Zimmermann
-1 siblings, 0 replies; 87+ messages in thread
From: Thomas Zimmermann @ 2026-11-17 13:22 UTC (permalink / raw)
To: Maxime Ripard, Maarten Lankhorst, David Airlie, Simona Vetter
Cc: dri-devel, Janne Grunau, Sasha Finkelstein, asahi,
Christian König, Alex Deucher, amd-gfx, sashiko-bot,
Liviu Dudau, Russell King, Dave Airlie, Jocelyn Falempe,
Alim Akhtar, Inki Dae, Krzysztof Kozlowski, Kyungmin Park,
Peter Griffin, Seung-Woo Kim, linux-samsung-soc, Alison Wang,
Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi, Dexuan Cui,
Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam, Frank Li,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx,
Paul Cercueil, linux-mips, Anitha Chrisanthus, Paul Kocialkowski,
Huacai Chen, Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu,
Xi Ruoyao, AngeloGioacchino Del Regno, Chun-Kuang Hu,
Matthias Brugger, Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang,
Marijn Suijten, Rob Clark, Sean Paul, freedreno, linux-arm-msm,
Danilo Krummrich, Lyude Paul, nouveau, Tomi Valkeinen,
Gerd Hoffmann, spice-devel, virtualization, Geert Uytterhoeven,
Kieran Bingham, Laurent Pinchart, Magnus Damm, Tomi Valkeinen,
linux-renesas-soc, Biju Das, Marcus Folkesson, David Lechner,
Iker Pedrosa, Baolin Wang, Chunyan Zhang, Orson Zhai,
Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
Raphael Gallais-Pou, Yannick Fertre, Chen-Yu Tsai, Samuel Holland,
linux-sunxi, Jonathan Hunter, Mikko Perttunen, Thierry Reding,
linux-tegra, Jyri Sarha, Alexey Brodkin, Hans de Goede,
Kamlesh Gurudasani, Alex Lanzano, LiangCheng Wang, Chia-I Wu,
Dmitry Osipenko, Gurchetan Singh,
Broadcom internal kernel review list, Zack Rusin,
Oleksandr Andrushchenko, Michal Simek
Hi Maxime
Am 16.11.26 um 11:30 schrieb Maxime Ripard:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles. However, the two roles need different
> behaviors, notably for objects like drm_private_obj that must persist
> across suspend/resume and are excluded from drm_mode_config_reset()
> by design.
>
> Previous series introduced drm_mode_config_create_initial_state() to
> handle only the initial state creation at probe time, including
> drm_private_obj. Unlike drm_mode_config_reset(), it returns an error
> code, allowing drivers to properly handle allocation failures.
>
> This series switches all drivers calling drm_mode_config_reset() at
> probe time to drm_mode_config_create_initial_state(). The conversion
> was done using a Coccinelle semantic patch.
>
> This is part, and the final piece, of a larger transition to remove the
> overloaded reset semantics from the KMS subsystem, following similar
> series for planes, CRTCs, connectors, and bridges.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
For the entire series:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> Changes in v2:
> - Fix some sashiko issues
> - Link to v1: https://lore.kernel.org/r/20261105-drm-no-more-config-reset-v1-0-763560c2cc3f@kernel.org
>
> ---
> Maxime Ripard (64):
> drm/adp: Switch to drm_mode_config_create_initial_state
> drm/amdgpu: Switch to drm_mode_config_create_initial_state
> drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
> drm/hdlcd: Switch to drm_mode_config_create_initial_state
> drm/armada: Switch to drm_mode_config_create_initial_state
> drm/ast: Switch to drm_mode_config_create_initial_state
> drm/exynos: Switch to drm_mode_config_create_initial_state
> drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
> drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
> drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
> drm/hyperv: Switch to drm_mode_config_create_initial_state
> drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
> drm/ingenic: Move the private object creation before the reset
> drm/ingenic: Switch to drm_mode_config_create_initial_state
> drm/kmb: Switch to drm_mode_config_create_initial_state
> drm/logicvc: Switch to drm_mode_config_create_initial_state
> drm/loongson: Switch to drm_mode_config_create_initial_state
> drm/mediatek: Switch to drm_mode_config_create_initial_state
> drm/mgag200: Switch to drm_mode_config_create_initial_state
> drm/msm: Switch to drm_mode_config_create_initial_state
> drm/nouveau: Switch to drm_mode_config_create_initial_state
> drm/omap: Switch to drm_mode_config_create_initial_state
> drm/qxl: Destroy the monitors object on the modeset init error path
> drm/qxl: Switch to drm_mode_config_create_initial_state
> drm/rcar-du: Switch to drm_mode_config_create_initial_state
> drm/rz-du: Switch to drm_mode_config_create_initial_state
> drm/shmobile: Switch to drm_mode_config_create_initial_state
> drm/st7571: Switch to drm_mode_config_create_initial_state
> drm/st7586: Switch to drm_mode_config_create_initial_state
> drm/st7735r: Switch to drm_mode_config_create_initial_state
> drm/st7920: Switch to drm_mode_config_create_initial_state
> drm/sprd: Switch to drm_mode_config_create_initial_state
> drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
> drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
> drm/stm: Switch to drm_mode_config_create_initial_state
> drm/sun4i: Switch to drm_mode_config_create_initial_state
> drm/tegra: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
> drm/tidss: Switch to drm_mode_config_create_initial_state
> drm/tilcdc: Switch to drm_mode_config_create_initial_state
> drm/arcpgu: Switch to drm_mode_config_create_initial_state
> drm/bochs: Switch to drm_mode_config_create_initial_state
> drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
> drm/gm12u320: Switch to drm_mode_config_create_initial_state
> drm/hx8357d: Switch to drm_mode_config_create_initial_state
> drm/ili9163: Switch to drm_mode_config_create_initial_state
> drm/ili9225: Switch to drm_mode_config_create_initial_state
> drm/ili9341: Switch to drm_mode_config_create_initial_state
> drm/ili9486: Switch to drm_mode_config_create_initial_state
> drm/mi0283qt: Switch to drm_mode_config_create_initial_state
> drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
> drm/pixpaper: Switch to drm_mode_config_create_initial_state
> drm/repaper: Switch to drm_mode_config_create_initial_state
> drm/sharp-memory: Switch to drm_mode_config_create_initial_state
> drm/udl: Switch to drm_mode_config_create_initial_state
> drm/vboxvideo: Switch to drm_mode_config_create_initial_state
> drm/verisilicon: Switch to drm_mode_config_create_initial_state
> drm/virtio: Switch to drm_mode_config_create_initial_state
> drm/vmwgfx: Switch to drm_mode_config_create_initial_state
> drm/xen: Switch to drm_mode_config_create_initial_state
> drm/xlnx: Switch to drm_mode_config_create_initial_state
>
> drivers/gpu/drm/adp/adp_drv.c | 4 +---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 +++-
> .../amdgpu_dm/tests/amdgpu_dm_connector_test.c | 3 ++-
> .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 4 +++-
> drivers/gpu/drm/arm/hdlcd_drv.c | 9 +++++----
> drivers/gpu/drm/armada/armada_drv.c | 4 +++-
> drivers/gpu/drm/ast/ast_mode.c | 4 +++-
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +++-
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 +++-
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 7 ++++---
> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 +---
> drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++-
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 22 +++++++++++++---------
> drivers/gpu/drm/kmb/kmb_drv.c | 3 +--
> drivers/gpu/drm/logicvc/logicvc_mode.c | 4 +++-
> drivers/gpu/drm/loongson/lsdc_drv.c | 4 +++-
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++++++-
> drivers/gpu/drm/mgag200/mgag200_g200.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh5.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200er.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200ev.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200se.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200wb.c | 4 +++-
> drivers/gpu/drm/msm/msm_kms.c | 4 +++-
> drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++-
> drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++-
> drivers/gpu/drm/qxl/qxl_display.c | 11 +++++++++--
> drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +++-
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 4 +++-
> drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 4 +++-
> drivers/gpu/drm/sitronix/st7571.c | 4 +++-
> drivers/gpu/drm/sitronix/st7586.c | 4 +++-
> drivers/gpu/drm/sitronix/st7735r.c | 4 +++-
> drivers/gpu/drm/sitronix/st7920.c | 4 +---
> drivers/gpu/drm/sprd/sprd_drm.c | 6 ++++--
> drivers/gpu/drm/sti/sti_drv.c | 10 ++++------
> drivers/gpu/drm/stm/drv.c | 6 +++++-
> drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +++-
> drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 6 +++---
> drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 2 +-
> drivers/gpu/drm/tegra/drm.c | 4 +++-
> drivers/gpu/drm/tests/drm_atomic_commit_test.c | 3 ++-
> drivers/gpu/drm/tests/drm_atomic_test.c | 4 +++-
> drivers/gpu/drm/tests/drm_bridge_test.c | 12 +++++++++---
> drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 ++-
> drivers/gpu/drm/tidss/tidss_drv.c | 6 +++++-
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +++-
> drivers/gpu/drm/tiny/arcpgu.c | 4 +++-
> drivers/gpu/drm/tiny/bochs.c | 4 +---
> drivers/gpu/drm/tiny/cirrus-qemu.c | 4 +++-
> drivers/gpu/drm/tiny/gm12u320.c | 4 +++-
> drivers/gpu/drm/tiny/hx8357d.c | 4 +++-
> drivers/gpu/drm/tiny/ili9163.c | 4 +++-
> drivers/gpu/drm/tiny/ili9225.c | 4 +++-
> drivers/gpu/drm/tiny/ili9341.c | 4 +++-
> drivers/gpu/drm/tiny/ili9486.c | 4 +++-
> drivers/gpu/drm/tiny/mi0283qt.c | 4 +++-
> drivers/gpu/drm/tiny/panel-mipi-dbi.c | 4 +++-
> drivers/gpu/drm/tiny/pixpaper.c | 4 +++-
> drivers/gpu/drm/tiny/repaper.c | 4 +++-
> drivers/gpu/drm/tiny/sharp-memory.c | 4 +++-
> drivers/gpu/drm/udl/udl_modeset.c | 4 +++-
> drivers/gpu/drm/vboxvideo/vbox_mode.c | 5 ++++-
> drivers/gpu/drm/verisilicon/vs_drm.c | 4 +++-
> drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +++++++++++++-
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 4 +++-
> drivers/gpu/drm/xlnx/zynqmp_kms.c | 6 ++++--
> 74 files changed, 243 insertions(+), 115 deletions(-)
> ---
> base-commit: a8670a2ab1a81dc3fc30093e47c23b83244ca4d0
> change-id: 20260712-drm-no-more-config-reset-1ea89f56693d
>
> Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 87+ messages in thread
* Re: [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state
@ 2026-11-17 13:22 ` Thomas Zimmermann
0 siblings, 0 replies; 87+ messages in thread
From: Thomas Zimmermann @ 2026-11-17 13:22 UTC (permalink / raw)
To: Maxime Ripard, Maarten Lankhorst, David Airlie, Simona Vetter
Cc: dri-devel, Janne Grunau, Sasha Finkelstein, asahi,
Christian König, Alex Deucher, amd-gfx, sashiko-bot,
Liviu Dudau, Russell King, Dave Airlie, Jocelyn Falempe,
Alim Akhtar, Inki Dae, Krzysztof Kozlowski, Kyungmin Park,
Peter Griffin, Seung-Woo Kim, linux-samsung-soc, Alison Wang,
Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi, Dexuan Cui,
Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam, Frank Li,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx,
Paul Cercueil, linux-mips, Anitha Chrisanthus, Paul Kocialkowski,
Huacai Chen, Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu,
Xi Ruoyao, AngeloGioacchino Del Regno, Chun-Kuang Hu,
Matthias Brugger, Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang,
Marijn Suijten, Rob Clark, Sean Paul, freedreno, linux-arm-msm,
Danilo Krummrich, nouveau, Tomi Valkeinen, Gerd Hoffmann,
spice-devel, virtualization, Geert Uytterhoeven, Kieran Bingham,
Laurent Pinchart, Magnus Damm, Tomi Valkeinen, linux-renesas-soc,
Biju Das, Marcus Folkesson, David Lechner, Iker Pedrosa,
Baolin Wang, Chunyan Zhang, Orson Zhai, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Chen-Yu Tsai, Samuel Holland, linux-sunxi,
Mikko Perttunen, Thierry Reding, linux-tegra, Jyri Sarha,
Alexey Brodkin, Hans de Goede, Kamlesh Gurudasani, Alex Lanzano,
LiangCheng Wang, Chia-I Wu, Dmitry Osipenko, Gurchetan Singh,
Broadcom internal kernel review list, Zack Rusin,
Oleksandr Andrushchenko, Michal Simek
Hi Maxime
Am 16.11.26 um 11:30 schrieb Maxime Ripard:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles. However, the two roles need different
> behaviors, notably for objects like drm_private_obj that must persist
> across suspend/resume and are excluded from drm_mode_config_reset()
> by design.
>
> Previous series introduced drm_mode_config_create_initial_state() to
> handle only the initial state creation at probe time, including
> drm_private_obj. Unlike drm_mode_config_reset(), it returns an error
> code, allowing drivers to properly handle allocation failures.
>
> This series switches all drivers calling drm_mode_config_reset() at
> probe time to drm_mode_config_create_initial_state(). The conversion
> was done using a Coccinelle semantic patch.
>
> This is part, and the final piece, of a larger transition to remove the
> overloaded reset semantics from the KMS subsystem, following similar
> series for planes, CRTCs, connectors, and bridges.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
For the entire series:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> Changes in v2:
> - Fix some sashiko issues
> - Link to v1: https://lore.kernel.org/r/20261105-drm-no-more-config-reset-v1-0-763560c2cc3f@kernel.org
>
> ---
> Maxime Ripard (64):
> drm/adp: Switch to drm_mode_config_create_initial_state
> drm/amdgpu: Switch to drm_mode_config_create_initial_state
> drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
> drm/hdlcd: Switch to drm_mode_config_create_initial_state
> drm/armada: Switch to drm_mode_config_create_initial_state
> drm/ast: Switch to drm_mode_config_create_initial_state
> drm/exynos: Switch to drm_mode_config_create_initial_state
> drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
> drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
> drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
> drm/hyperv: Switch to drm_mode_config_create_initial_state
> drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
> drm/ingenic: Move the private object creation before the reset
> drm/ingenic: Switch to drm_mode_config_create_initial_state
> drm/kmb: Switch to drm_mode_config_create_initial_state
> drm/logicvc: Switch to drm_mode_config_create_initial_state
> drm/loongson: Switch to drm_mode_config_create_initial_state
> drm/mediatek: Switch to drm_mode_config_create_initial_state
> drm/mgag200: Switch to drm_mode_config_create_initial_state
> drm/msm: Switch to drm_mode_config_create_initial_state
> drm/nouveau: Switch to drm_mode_config_create_initial_state
> drm/omap: Switch to drm_mode_config_create_initial_state
> drm/qxl: Destroy the monitors object on the modeset init error path
> drm/qxl: Switch to drm_mode_config_create_initial_state
> drm/rcar-du: Switch to drm_mode_config_create_initial_state
> drm/rz-du: Switch to drm_mode_config_create_initial_state
> drm/shmobile: Switch to drm_mode_config_create_initial_state
> drm/st7571: Switch to drm_mode_config_create_initial_state
> drm/st7586: Switch to drm_mode_config_create_initial_state
> drm/st7735r: Switch to drm_mode_config_create_initial_state
> drm/st7920: Switch to drm_mode_config_create_initial_state
> drm/sprd: Switch to drm_mode_config_create_initial_state
> drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
> drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
> drm/stm: Switch to drm_mode_config_create_initial_state
> drm/sun4i: Switch to drm_mode_config_create_initial_state
> drm/tegra: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
> drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
> drm/tidss: Switch to drm_mode_config_create_initial_state
> drm/tilcdc: Switch to drm_mode_config_create_initial_state
> drm/arcpgu: Switch to drm_mode_config_create_initial_state
> drm/bochs: Switch to drm_mode_config_create_initial_state
> drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
> drm/gm12u320: Switch to drm_mode_config_create_initial_state
> drm/hx8357d: Switch to drm_mode_config_create_initial_state
> drm/ili9163: Switch to drm_mode_config_create_initial_state
> drm/ili9225: Switch to drm_mode_config_create_initial_state
> drm/ili9341: Switch to drm_mode_config_create_initial_state
> drm/ili9486: Switch to drm_mode_config_create_initial_state
> drm/mi0283qt: Switch to drm_mode_config_create_initial_state
> drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
> drm/pixpaper: Switch to drm_mode_config_create_initial_state
> drm/repaper: Switch to drm_mode_config_create_initial_state
> drm/sharp-memory: Switch to drm_mode_config_create_initial_state
> drm/udl: Switch to drm_mode_config_create_initial_state
> drm/vboxvideo: Switch to drm_mode_config_create_initial_state
> drm/verisilicon: Switch to drm_mode_config_create_initial_state
> drm/virtio: Switch to drm_mode_config_create_initial_state
> drm/vmwgfx: Switch to drm_mode_config_create_initial_state
> drm/xen: Switch to drm_mode_config_create_initial_state
> drm/xlnx: Switch to drm_mode_config_create_initial_state
>
> drivers/gpu/drm/adp/adp_drv.c | 4 +---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 +++-
> .../amdgpu_dm/tests/amdgpu_dm_connector_test.c | 3 ++-
> .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 4 +++-
> drivers/gpu/drm/arm/hdlcd_drv.c | 9 +++++----
> drivers/gpu/drm/armada/armada_drv.c | 4 +++-
> drivers/gpu/drm/ast/ast_mode.c | 4 +++-
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +++-
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 +++-
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 7 ++++---
> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 +---
> drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++-
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 22 +++++++++++++---------
> drivers/gpu/drm/kmb/kmb_drv.c | 3 +--
> drivers/gpu/drm/logicvc/logicvc_mode.c | 4 +++-
> drivers/gpu/drm/loongson/lsdc_drv.c | 4 +++-
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++++++-
> drivers/gpu/drm/mgag200/mgag200_g200.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200eh5.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200er.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200ev.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200se.c | 4 +++-
> drivers/gpu/drm/mgag200/mgag200_g200wb.c | 4 +++-
> drivers/gpu/drm/msm/msm_kms.c | 4 +++-
> drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++-
> drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++-
> drivers/gpu/drm/qxl/qxl_display.c | 11 +++++++++--
> drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +++-
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 4 +++-
> drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 4 +++-
> drivers/gpu/drm/sitronix/st7571.c | 4 +++-
> drivers/gpu/drm/sitronix/st7586.c | 4 +++-
> drivers/gpu/drm/sitronix/st7735r.c | 4 +++-
> drivers/gpu/drm/sitronix/st7920.c | 4 +---
> drivers/gpu/drm/sprd/sprd_drm.c | 6 ++++--
> drivers/gpu/drm/sti/sti_drv.c | 10 ++++------
> drivers/gpu/drm/stm/drv.c | 6 +++++-
> drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +++-
> drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 6 +++---
> drivers/gpu/drm/sun4i/sun4i_framebuffer.h | 2 +-
> drivers/gpu/drm/tegra/drm.c | 4 +++-
> drivers/gpu/drm/tests/drm_atomic_commit_test.c | 3 ++-
> drivers/gpu/drm/tests/drm_atomic_test.c | 4 +++-
> drivers/gpu/drm/tests/drm_bridge_test.c | 12 +++++++++---
> drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 ++-
> drivers/gpu/drm/tidss/tidss_drv.c | 6 +++++-
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +++-
> drivers/gpu/drm/tiny/arcpgu.c | 4 +++-
> drivers/gpu/drm/tiny/bochs.c | 4 +---
> drivers/gpu/drm/tiny/cirrus-qemu.c | 4 +++-
> drivers/gpu/drm/tiny/gm12u320.c | 4 +++-
> drivers/gpu/drm/tiny/hx8357d.c | 4 +++-
> drivers/gpu/drm/tiny/ili9163.c | 4 +++-
> drivers/gpu/drm/tiny/ili9225.c | 4 +++-
> drivers/gpu/drm/tiny/ili9341.c | 4 +++-
> drivers/gpu/drm/tiny/ili9486.c | 4 +++-
> drivers/gpu/drm/tiny/mi0283qt.c | 4 +++-
> drivers/gpu/drm/tiny/panel-mipi-dbi.c | 4 +++-
> drivers/gpu/drm/tiny/pixpaper.c | 4 +++-
> drivers/gpu/drm/tiny/repaper.c | 4 +++-
> drivers/gpu/drm/tiny/sharp-memory.c | 4 +++-
> drivers/gpu/drm/udl/udl_modeset.c | 4 +++-
> drivers/gpu/drm/vboxvideo/vbox_mode.c | 5 ++++-
> drivers/gpu/drm/verisilicon/vs_drm.c | 4 +++-
> drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +++++++++++++-
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 3 ---
> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 4 +++-
> drivers/gpu/drm/xlnx/zynqmp_kms.c | 6 ++++--
> 74 files changed, 243 insertions(+), 115 deletions(-)
> ---
> base-commit: a8670a2ab1a81dc3fc30093e47c23b83244ca4d0
> change-id: 20260712-drm-no-more-config-reset-1ea89f56693d
>
> Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 87+ messages in thread