All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <masneyb@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Andreas Kemnade" <andreas@kemnade.info>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney+clk@redhat.com>,
	"Jerome Brunet" <jbrunet+clk@baylibre.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>, "Andy Yan" <andyshrk@163.com>,
	"Ulf Hansson" <ulfh@kernel.org>,
	linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/6] clk: Remove unused clk.dev
Date: Fri, 20 Nov 2026 11:56:53 -0500	[thread overview]
Message-ID: <awB71ckHyTRIfy0p@x1g10> (raw)
In-Reply-To: <CAMuHMdWJ8zK+kzcznM7FJ3JCo1xWzjRZ5MQz9jhSUcYQfO5rBA@mail.gmail.com>

On Fri, Nov 20, 2026 at 08:44:29AM +0100, Geert Uytterhoeven wrote:
> On Fri, 20 Nov 2026 at 02:40, Brian Masney <masneyb@kernel.org> wrote:
> > > This basically reverts commit efa850487a6b6742 ("clk: Inform the core
> > > about consumer devices").
> > >
> > > This commit added a struct device pointer member to struct clk and a
> > > parameter to clk_hw_create_clk(), but the new member was never used
> > > beyond setting.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > > --- a/drivers/clk/clk.h
> > > +++ b/drivers/clk/clk.h
> > > @@ -5,8 +5,6 @@
> > >   */
> > >
> > >  struct clk_hw;
> > > -struct device;
> > > -struct of_phandle_args;
> >
> > Did you mean to remove of_phandle_args?
> 
> Yes, it was added by efa850487a6b6742, too (although it was
> used in that header file before). Currently it's not used.

OK, I see that.

Reviewed-by: Brian Masney <masneyb@kernel.org>


WARNING: multiple messages have this Message-ID (diff)
From: Brian Masney <masneyb@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Andreas Kemnade" <andreas@kemnade.info>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney+clk@redhat.com>,
	"Jerome Brunet" <jbrunet+clk@baylibre.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>, "Andy Yan" <andyshrk@163.com>,
	"Ulf Hansson" <ulfh@kernel.org>,
	linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/6] clk: Remove unused clk.dev
Date: Fri, 20 Nov 2026 11:56:53 -0500	[thread overview]
Message-ID: <awB71ckHyTRIfy0p@x1g10> (raw)
In-Reply-To: <CAMuHMdWJ8zK+kzcznM7FJ3JCo1xWzjRZ5MQz9jhSUcYQfO5rBA@mail.gmail.com>

On Fri, Nov 20, 2026 at 08:44:29AM +0100, Geert Uytterhoeven wrote:
> On Fri, 20 Nov 2026 at 02:40, Brian Masney <masneyb@kernel.org> wrote:
> > > This basically reverts commit efa850487a6b6742 ("clk: Inform the core
> > > about consumer devices").
> > >
> > > This commit added a struct device pointer member to struct clk and a
> > > parameter to clk_hw_create_clk(), but the new member was never used
> > > beyond setting.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > > --- a/drivers/clk/clk.h
> > > +++ b/drivers/clk/clk.h
> > > @@ -5,8 +5,6 @@
> > >   */
> > >
> > >  struct clk_hw;
> > > -struct device;
> > > -struct of_phandle_args;
> >
> > Did you mean to remove of_phandle_args?
> 
> Yes, it was added by efa850487a6b6742, too (although it was
> used in that header file before). Currently it's not used.

OK, I see that.

Reviewed-by: Brian Masney <masneyb@kernel.org>


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-11-20 16:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:40 [PATCH 0/6] clk: Improve consumer field in debugfs clk_summary Geert Uytterhoeven
2026-11-19 13:40 ` Geert Uytterhoeven
2026-11-19 13:40 ` [PATCH 1/6] clk: Remove unused clk.dev Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven
2026-11-20  1:40   ` Brian Masney
2026-11-20  1:40     ` Brian Masney
2026-11-20  7:44     ` Geert Uytterhoeven
2026-11-20  7:44       ` Geert Uytterhoeven
2026-11-20 16:56       ` Brian Masney [this message]
2026-11-20 16:56         ` Brian Masney
2026-11-19 13:40 ` [PATCH 2/6] clk: Add dev_clk_get_from_provider() Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven
2026-11-20  1:40   ` Brian Masney
2026-11-20  1:40     ` Brian Masney
2026-11-19 13:40 ` [PATCH 3/6] clk: renesas: Convert to dev_clk_get_from_provider() Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven
2026-11-20  1:40   ` Brian Masney
2026-11-20  1:40     ` Brian Masney
2026-11-19 13:40 ` [PATCH 4/6] [RFT] drm/rockchip: dw_hdmi: " Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven
2026-11-20  1:40   ` Brian Masney
2026-11-20  1:40     ` Brian Masney
2026-11-19 13:40 ` [PATCH 5/6] [RFT] ARM: OMAP2+: " Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven
2026-11-19 21:50   ` Andreas Kemnade
2026-11-19 21:50     ` Andreas Kemnade
2026-11-20  7:49     ` Geert Uytterhoeven
2026-11-20  7:49       ` Geert Uytterhoeven
2026-11-20  8:43       ` Andreas Kemnade
2026-11-20  8:43         ` Andreas Kemnade
2026-11-20  8:49         ` Geert Uytterhoeven
2026-11-20  8:49           ` Geert Uytterhoeven
2026-11-20  9:53           ` Andreas Kemnade
2026-11-20  9:53             ` Andreas Kemnade
2026-11-20  1:40   ` Brian Masney
2026-11-20  1:40     ` Brian Masney
2026-11-19 13:40 ` [PATCH 6/6] [RFC] pmdomain: renesas: r8a78000: " Geert Uytterhoeven
2026-11-19 13:40   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awB71ckHyTRIfy0p@x1g10 \
    --to=masneyb@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=andyshrk@163.com \
    --cc=bmasney+clk@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=rogerq@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.