All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] usb: musb: fix use-after-free in musb_remove()
@ 2026-11-20 14:23 Joshua Crofts
  2026-11-20 14:37 ` sashiko-bot
  2026-11-20 14:51 ` Johan Hovold
  0 siblings, 2 replies; 5+ messages in thread
From: Joshua Crofts @ 2026-11-20 14:23 UTC (permalink / raw)
  To: Bin Liu, Greg Kroah-Hartman, Uwe Kleine-König, Felipe Balbi
  Cc: linux-usb, linux-kernel, Sashiko, stable, Joshua Crofts

Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
before usb_phy_shutdown() is called, causing a use-after-free bug.

Reorder the function so that usb_phy_shutdown() is called before
musb_platform_exit(), the same way as musb_init_controller() does in the
error path.

Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/bug/linux-d180c2b9-0006-4638-a22b-13df8c201235
Fixes: 39cee200c23e ("usb: musb: core: call init and shutdown for the usb phy")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
Changes in v2:
- Rebased on usb-linus branch
- Link to v1: https://lore.kernel.org/linux-usb/20261107-usb-uaf-fix-v1-1-ba33689d0ca3@kernel.org
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index eb29ae47697c..1715ff1dd424 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2651,6 +2651,7 @@ static void musb_remove(struct platform_device *pdev)
 	cancel_delayed_work_sync(&musb->finish_resume_work);
 	cancel_delayed_work_sync(&musb->deassert_reset_work);
 
+	usb_phy_shutdown(musb->xceiv);
 	musb_platform_exit(musb);
 
 	pm_runtime_dont_use_autosuspend(musb->controller);
@@ -2659,7 +2660,6 @@ static void musb_remove(struct platform_device *pdev)
 	musb_phy_callback = NULL;
 	if (musb->dma_controller)
 		musb_dma_controller_destroy(musb->dma_controller);
-	usb_phy_shutdown(musb->xceiv);
 	musb_free(musb);
 	device_init_wakeup(dev, 0);
 }

---
base-commit: 81fbc49e54cd8a8d10677878cc98a76d44797ea8
change-id: 20261120-usb-uaf-fix-ff4cbe6c4105

Best regards,
--  
Joshua Crofts <crofts@kernel.org>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
  2026-11-20 14:23 [PATCH v2] usb: musb: fix use-after-free in musb_remove() Joshua Crofts
@ 2026-11-20 14:37 ` sashiko-bot
  2026-11-20 14:51 ` Johan Hovold
  1 sibling, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-20 14:37 UTC (permalink / raw)
  To: Joshua Crofts; +Cc: linux-usb

> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
> before usb_phy_shutdown() is called, causing a use-after-free bug.
> 
> Reorder the function so that usb_phy_shutdown() is called before
> musb_platform_exit(), the same way as musb_init_controller() does in the
> error path.
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/bug/linux-d180c2b9-0006-4638-a22b-13df8c201235
> Fixes: 39cee200c23e ("usb: musb: core: call init and shutdown for the usb phy")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joshua Crofts <crofts@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-usb-uaf-fix-v2-1-cc3cb2a38ad5@kernel.org?part=1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
  2026-11-20 14:23 [PATCH v2] usb: musb: fix use-after-free in musb_remove() Joshua Crofts
  2026-11-20 14:37 ` sashiko-bot
@ 2026-11-20 14:51 ` Johan Hovold
  2026-11-20 14:56   ` Joshua Crofts
  1 sibling, 1 reply; 5+ messages in thread
From: Johan Hovold @ 2026-11-20 14:51 UTC (permalink / raw)
  To: Joshua Crofts
  Cc: Bin Liu, Greg Kroah-Hartman, Uwe Kleine-König, Felipe Balbi,
	linux-usb, linux-kernel, Sashiko, stable

On Fri, Nov 20, 2026 at 03:23:14PM +0100, Joshua Crofts wrote:
> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
> before usb_phy_shutdown() is called, causing a use-after-free bug.

This is too strongly worded. There is a potential for a use-after-free
here but it's extremely unlikely to ever be an issue in practice as the
phy driver would need to be unloaded by root while they are already
unbinding the host controller.

Why would root want to do that to themselves?

Johan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
  2026-11-20 14:51 ` Johan Hovold
@ 2026-11-20 14:56   ` Joshua Crofts
  2026-11-20 14:58     ` Johan Hovold
  0 siblings, 1 reply; 5+ messages in thread
From: Joshua Crofts @ 2026-11-20 14:56 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Bin Liu, Greg Kroah-Hartman, Uwe Kleine-König, Felipe Balbi,
	linux-usb, linux-kernel, Sashiko, stable

On 20-Nov-26 15:51, Johan Hovold wrote:
> On Fri, Nov 20, 2026 at 03:23:14PM +0100, Joshua Crofts wrote:
>> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
>> before usb_phy_shutdown() is called, causing a use-after-free bug.
> 
> This is too strongly worded. There is a potential for a use-after-free
> here but it's extremely unlikely to ever be an issue in practice as the
> phy driver would need to be unloaded by root while they are already
> unbinding the host controller.
> 
> Why would root want to do that to themselves?
Okay, if I add the word potentially then it's not too strong.

-- 
Kind regards,
Joshua Crofts


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
  2026-11-20 14:56   ` Joshua Crofts
@ 2026-11-20 14:58     ` Johan Hovold
  0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2026-11-20 14:58 UTC (permalink / raw)
  To: Joshua Crofts
  Cc: Bin Liu, Greg Kroah-Hartman, Uwe Kleine-König, Felipe Balbi,
	linux-usb, linux-kernel, Sashiko, stable

On Fri, Nov 20, 2026 at 03:56:19PM +0100, Joshua Crofts wrote:
> On 20-Nov-26 15:51, Johan Hovold wrote:
> > On Fri, Nov 20, 2026 at 03:23:14PM +0100, Joshua Crofts wrote:
> >> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
> >> before usb_phy_shutdown() is called, causing a use-after-free bug.
> > 
> > This is too strongly worded. There is a potential for a use-after-free
> > here but it's extremely unlikely to ever be an issue in practice as the
> > phy driver would need to be unloaded by root while they are already
> > unbinding the host controller.
> > 
> > Why would root want to do that to themselves?

> Okay, if I add the word potentially then it's not too strong.

It's a start, but you also should mention that this is not a real issue.

Johan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-20 14:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 14:23 [PATCH v2] usb: musb: fix use-after-free in musb_remove() Joshua Crofts
2026-11-20 14:37 ` sashiko-bot
2026-11-20 14:51 ` Johan Hovold
2026-11-20 14:56   ` Joshua Crofts
2026-11-20 14:58     ` Johan Hovold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.