All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guo Samin <samin.guo@starfivetech.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v5 08/12] net: stmmac: starfive_dmac: Add phy interface settings
Date: Tue, 7 Mar 2023 09:50:46 +0800	[thread overview]
Message-ID: <b02466fa-9c9d-3d8a-9112-2b52f14460d7@starfivetech.com> (raw)
In-Reply-To: <52822ce5-0712-48e5-81e0-c6ac09d6a6ee@lunn.ch>



在 2023/3/6 21:06:20, Andrew Lunn 写道:
>> Ugh, you're right. Both the syscon block, the register offset and the
>> bit position in those registers are different from gmac0 to gmac1, and
>> since we need a phandle to the syscon block anyway passing those two
>> other parameters as arguments is probably the nicest solution. For the
>> next version I'd change the 2nd argument from mask to the bit position
>> though. It seems the field is always 3 bits wide and this makes it a
>> little clearer that we're not just putting register values in the
>> device tree.
> 
> I prefer bit position over mask.
> 
> But please fully document this in the device tree. This is something a
> board developer is going to get wrong, because they assume MAC blocks
> are identical, and normally need identical configuration.
> 
> I assume this is also a hardware 'bug', and the next generation of the
> silicon will have this fixed? So this will go away?
> 
> 	Andrew


Hi Andrew, Yes, the hardware design does not take into account the feasibility of the software.
The next version will be fixed. Thank you. 
I will use bit position instead of mask, which is described in detail in the document.

Best regards,
Samin

-- 
Best regards,
Samin

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Guo Samin <samin.guo@starfivetech.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v5 08/12] net: stmmac: starfive_dmac: Add phy interface settings
Date: Tue, 7 Mar 2023 09:50:46 +0800	[thread overview]
Message-ID: <b02466fa-9c9d-3d8a-9112-2b52f14460d7@starfivetech.com> (raw)
In-Reply-To: <52822ce5-0712-48e5-81e0-c6ac09d6a6ee@lunn.ch>



在 2023/3/6 21:06:20, Andrew Lunn 写道:
>> Ugh, you're right. Both the syscon block, the register offset and the
>> bit position in those registers are different from gmac0 to gmac1, and
>> since we need a phandle to the syscon block anyway passing those two
>> other parameters as arguments is probably the nicest solution. For the
>> next version I'd change the 2nd argument from mask to the bit position
>> though. It seems the field is always 3 bits wide and this makes it a
>> little clearer that we're not just putting register values in the
>> device tree.
> 
> I prefer bit position over mask.
> 
> But please fully document this in the device tree. This is something a
> board developer is going to get wrong, because they assume MAC blocks
> are identical, and normally need identical configuration.
> 
> I assume this is also a hardware 'bug', and the next generation of the
> silicon will have this fixed? So this will go away?
> 
> 	Andrew


Hi Andrew, Yes, the hardware design does not take into account the feasibility of the software.
The next version will be fixed. Thank you. 
I will use bit position instead of mask, which is described in detail in the document.

Best regards,
Samin

-- 
Best regards,
Samin

  reply	other threads:[~2023-03-07  1:51 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  8:59 [PATCH v5 00/12] Add Ethernet driver for StarFive JH7110 SoC Samin Guo
2023-03-03  8:59 ` Samin Guo
2023-03-03  8:59 ` [PATCH v5 01/12] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03  8:59 ` [PATCH v5 02/12] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03  8:59 ` [PATCH v5 03/12] dt-bindings: net: snps,dwmac: Add an optional resets single 'ahb' Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-08 21:57   ` Rob Herring
2023-03-08 21:57     ` Rob Herring
2023-03-09  3:10     ` Guo Samin
2023-03-09  3:10       ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 04/12] dt-bindings: net: Add support StarFive dwmac Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-08 21:59   ` Rob Herring
2023-03-08 21:59     ` Rob Herring
2023-03-09  1:26     ` Guo Samin
2023-03-09  1:26       ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 05/12] riscv: dts: starfive: jh7110: Add ethernet device nodes Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03 13:45   ` Andrew Lunn
2023-03-03 13:45     ` Andrew Lunn
2023-03-06  2:19     ` Guo Samin
2023-03-06  2:19       ` Guo Samin
2023-03-04 22:57   ` Emil Renner Berthing
2023-03-04 22:57     ` Emil Renner Berthing
2023-03-07  7:50     ` Guo Samin
2023-03-07  7:50       ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 06/12] net: stmmac: Add glue layer for StarFive JH7110 SoC Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03 16:18   ` Emil Renner Berthing
2023-03-03 16:18     ` Emil Renner Berthing
2023-03-06  7:15     ` Guo Samin
2023-03-06  7:15       ` Guo Samin
2023-03-06 12:21       ` Emil Renner Berthing
2023-03-06 12:21         ` Emil Renner Berthing
2023-03-07  7:57         ` Guo Samin
2023-03-07  7:57           ` Guo Samin
2023-03-10  0:02   ` Emil Renner Berthing
2023-03-10  0:02     ` Emil Renner Berthing
2023-03-10  0:39     ` Emil Renner Berthing
2023-03-10  0:39       ` Emil Renner Berthing
2023-03-10  1:55       ` Guo Samin
2023-03-10  1:55         ` Guo Samin
2023-03-10  9:03         ` Emil Renner Berthing
2023-03-10  9:03           ` Emil Renner Berthing
2023-03-10 11:13           ` Guo Samin
2023-03-10 11:13             ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 07/12] dt-bindings: net: starfive,jh7110-dwmac: Add starfive,syscon Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-08 22:03   ` Rob Herring
2023-03-08 22:03     ` Rob Herring
2023-03-09  1:16     ` Guo Samin
2023-03-09  1:16       ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 08/12] net: stmmac: starfive_dmac: Add phy interface settings Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03 13:36   ` Andrew Lunn
2023-03-03 13:36     ` Andrew Lunn
2023-03-03 16:50   ` Emil Renner Berthing
2023-03-03 16:50     ` Emil Renner Berthing
2023-03-06  3:06     ` Guo Samin
2023-03-06  3:06       ` Guo Samin
2023-03-06 12:49       ` Emil Renner Berthing
2023-03-06 12:49         ` Emil Renner Berthing
2023-03-06 13:06         ` Andrew Lunn
2023-03-06 13:06           ` Andrew Lunn
2023-03-07  1:50           ` Guo Samin [this message]
2023-03-07  1:50             ` Guo Samin
2023-03-07  2:16         ` Guo Samin
2023-03-07  2:16           ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 09/12] riscv: dts: starfive: jh7110: Add syscon to support " Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03  8:59 ` [PATCH v5 10/12] riscv: dts: starfive: visionfive-2-v1.3b: Add gmac+phy's delay configuration Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-03  8:59 ` [PATCH v5 11/12] riscv: dts: starfive: visionfive-2-v1.2a: " Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-06 13:00   ` Emil Renner Berthing
2023-03-06 13:00     ` Emil Renner Berthing
2023-03-07  1:43     ` Guo Samin
2023-03-07  1:43       ` Guo Samin
2023-03-07 12:40       ` Emil Renner Berthing
2023-03-07 12:40         ` Emil Renner Berthing
2023-03-08  3:01         ` Guo Samin
2023-03-08  3:01           ` Guo Samin
2023-03-03  8:59 ` [PATCH v5 12/12] riscv: dts: starfive: visionfive 2: Enable gmac device tree node Samin Guo
2023-03-03  8:59   ` Samin Guo
2023-03-06 13:04   ` Emil Renner Berthing
2023-03-06 13:04     ` Emil Renner Berthing
2023-03-07  1:21     ` Guo Samin
2023-03-07  1:21       ` Guo Samin
2023-03-07 12:23       ` Emil Renner Berthing
2023-03-07 12:23         ` Emil Renner Berthing
2023-03-10  8:09 ` [PATCH v5 00/12] Add Ethernet driver for StarFive JH7110 SoC Tommaso Merciai
2023-03-10  8:09   ` Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b02466fa-9c9d-3d8a-9112-2b52f14460d7@starfivetech.com \
    --to=samin.guo@starfivetech.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.