* [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
@ 2023-02-17 19:18 Jonathan Cavitt
2023-02-17 21:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Jonathan Cavitt @ 2023-02-17 19:18 UTC (permalink / raw)
To: intel-gfx; +Cc: jonathan.cavitt, matthew.auld
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
MTL reports as not supporting 64K pages, or more accurately, the system that reports
whether a platform has 64K pages reports false for MTL. This is only half correct,
as the 64K page support reporting system only cares about 64K page support for LMEM,
which MTL doesn't have.
MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
using that manager doesn't resolve the issue because MTL is expecting the virtual
address space for the page table to be flushed after initialization, so we must also
add a flush statement there.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
index 4daaa6f55668..9c571185395f 100644
--- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
@@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
}
} while (rem >= page_size && index < max);
+ drm_clflush_virt_range(vaddr, PAGE_SIZE);
vma_res->page_sizes_gtt |= page_size;
} while (iter->sg && sg_dma_len(iter->sg));
}
@@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
struct sgt_dma iter = sgt_dma(vma_res);
if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
- if (HAS_64K_PAGES(vm->i915))
+ if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
else
gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for gen8_ppgtt: Use correct huge page manager for MTL
2023-02-17 19:18 [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL Jonathan Cavitt
@ 2023-02-17 21:00 ` Patchwork
2023-02-17 21:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-17 21:00 UTC (permalink / raw)
To: Jonathan Cavitt; +Cc: intel-gfx
== Series Details ==
Series: gen8_ppgtt: Use correct huge page manager for MTL
URL : https://patchwork.freedesktop.org/series/114161/
State : warning
== Summary ==
Error: dim checkpatch failed
f8a7b0058b4b gen8_ppgtt: Use correct huge page manager for MTL
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6:
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
total: 0 errors, 1 warnings, 0 checks, 15 lines checked
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for gen8_ppgtt: Use correct huge page manager for MTL
2023-02-17 19:18 [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL Jonathan Cavitt
2023-02-17 21:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-02-17 21:22 ` Patchwork
2023-02-18 11:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-02-21 16:06 ` [Intel-gfx] [PATCH] " Matthew Auld
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-17 21:22 UTC (permalink / raw)
To: Jonathan Cavitt; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4021 bytes --]
== Series Details ==
Series: gen8_ppgtt: Use correct huge page manager for MTL
URL : https://patchwork.freedesktop.org/series/114161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12758 -> Patchwork_114161v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/index.html
Participating hosts (39 -> 38)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114161v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334] / [i915#7872])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/fi-kbl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/fi-kbl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][3] -> [ABORT][4] ([i915#4983])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/bat-rpls-1/igt@i915_selftest@live@reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@workarounds:
- bat-rpls-1: [PASS][5] -> [DMESG-FAIL][6] ([i915#6763])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/bat-rpls-1/igt@i915_selftest@live@workarounds.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/bat-rpls-1/igt@i915_selftest@live@workarounds.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-n3050: [PASS][7] -> [FAIL][8] ([i915#6298])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][9] ([i915#3546]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][10] ([i915#6367] / [i915#7996]) -> [DMESG-FAIL][11] ([i915#6997])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/bat-rpls-2/igt@i915_selftest@live@slpc.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12758 -> Patchwork_114161v1
CI-20190529: 20190529
CI_DRM_12758: 207db44a791c337b64ed1df2715b00d2602eaed5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7165: 509e7e63c6377d0fe77d1bd209857fb191f4a84c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114161v1: 207db44a791c337b64ed1df2715b00d2602eaed5 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ee09d6a7f28c gen8_ppgtt: Use correct huge page manager for MTL
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/index.html
[-- Attachment #2: Type: text/html, Size: 4753 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for gen8_ppgtt: Use correct huge page manager for MTL
2023-02-17 19:18 [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL Jonathan Cavitt
2023-02-17 21:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-02-17 21:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-02-18 11:02 ` Patchwork
2023-02-21 16:06 ` [Intel-gfx] [PATCH] " Matthew Auld
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-18 11:02 UTC (permalink / raw)
To: Jonathan Cavitt; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 43186 bytes --]
== Series Details ==
Series: gen8_ppgtt: Use correct huge page manager for MTL
URL : https://patchwork.freedesktop.org/series/114161/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12758_full -> Patchwork_114161v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_114161v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_114161v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/index.html
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114161v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock@hugepages:
- shard-apl: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl1/igt@i915_selftest@mock@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl4/igt@i915_selftest@mock@hugepages.html
- shard-snb: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-snb7/igt@i915_selftest@mock@hugepages.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-snb7/igt@i915_selftest@mock@hugepages.html
- shard-glk: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk2/igt@i915_selftest@mock@hugepages.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk3/igt@i915_selftest@mock@hugepages.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][7] -> [ABORT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl6/igt@i915_suspend@forcewake.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl3/igt@i915_suspend@forcewake.html
* {igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-edp-1} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-edp-1.html
#### Warnings ####
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][10] -> [DMESG-FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-snb1/igt@i915_pm_rps@reset.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-snb7/igt@i915_pm_rps@reset.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_barrier_race@remote-request@rcs0}:
- {shard-rkl}: [INCOMPLETE][12] -> [ABORT][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-3/igt@gem_barrier_race@remote-request@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-2/igt@gem_barrier_race@remote-request@rcs0.html
* igt@i915_selftest@mock@hugepages:
- {shard-rkl}: [PASS][14] -> [DMESG-WARN][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-5/igt@i915_selftest@mock@hugepages.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-1/igt@i915_selftest@mock@hugepages.html
* {igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-edp-1}:
- {shard-rkl}: NOTRUN -> [SKIP][16] +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-a-edp-1.html
* {igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling}:
- shard-tglu-9: NOTRUN -> [SKIP][17] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling.html
* {igt@v3d/v3d_submit_csd@bad-extension}:
- {shard-dg1}: NOTRUN -> [SKIP][18] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-dg1-14/igt@v3d/v3d_submit_csd@bad-extension.html
New tests
---------
New tests have been introduced between CI_DRM_12758_full and Patchwork_114161v1_full:
### New IGT tests (1) ###
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-edp-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_114161v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@crc32:
- shard-tglu-9: NOTRUN -> [SKIP][19] ([i915#6230])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@api_intel_bb@crc32.html
* igt@drm_buddy@all-tests:
- shard-tglu-10: NOTRUN -> [SKIP][20] ([i915#6433])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@drm_buddy@all-tests.html
* igt@drm_mm@all-tests:
- shard-tglu-9: NOTRUN -> [SKIP][21] ([i915#6433])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@drm_mm@all-tests.html
* igt@fbdev@pan:
- shard-tglu-9: NOTRUN -> [SKIP][22] ([i915#2582])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@fbdev@pan.html
* igt@gem_ccs@ctrl-surf-copy-new-ctx:
- shard-tglu-10: NOTRUN -> [SKIP][23] ([i915#5325])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_ccs@ctrl-surf-copy-new-ctx.html
* igt@gem_ctx_sseu@mmap-args:
- shard-tglu-9: NOTRUN -> [SKIP][24] ([i915#280])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-tglu-9: NOTRUN -> [SKIP][25] ([i915#6334])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-tglu-10: NOTRUN -> [FAIL][26] ([i915#2842])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-tglu-9: NOTRUN -> [SKIP][27] ([fdo#109313])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_schedule@wide@rcs0:
- shard-glk: [PASS][28] -> [FAIL][29] ([i915#6659])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk8/igt@gem_exec_schedule@wide@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk4/igt@gem_exec_schedule@wide@rcs0.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk9/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-tglu-9: NOTRUN -> [SKIP][31] ([i915#4613]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_lmem_swapping@random:
- shard-tglu-10: NOTRUN -> [SKIP][32] ([i915#4613]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_lmem_swapping@random.html
* igt@gem_pwrite@basic-exhaustion:
- shard-tglu-9: NOTRUN -> [WARN][33] ([i915#2658])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pxp@create-regular-context-1:
- shard-tglu-9: NOTRUN -> [SKIP][34] ([i915#4270]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_pxp@create-regular-context-1.html
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-tglu-10: NOTRUN -> [SKIP][35] ([i915#4270]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_pxp@reject-modify-context-protection-on.html
* igt@gem_softpin@evict-snoop:
- shard-tglu-10: NOTRUN -> [SKIP][36] ([fdo#109312])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-tglu-9: NOTRUN -> [SKIP][37] ([i915#3297])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gem_userptr_blits@coherency-unsync.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-tglu-10: NOTRUN -> [SKIP][38] ([i915#3297])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen3_render_tiledx_blits:
- shard-tglu-9: NOTRUN -> [SKIP][39] ([fdo#109289]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gen3_render_tiledx_blits.html
* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglu-10: NOTRUN -> [SKIP][40] ([i915#2527] / [i915#2856]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@gen9_exec_parse@bb-start-cmd.html
* igt@gen9_exec_parse@unaligned-access:
- shard-tglu-9: NOTRUN -> [SKIP][41] ([i915#2527] / [i915#2856]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_hwmon@hwmon-write:
- shard-tglu-9: NOTRUN -> [SKIP][42] ([i915#7707])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@i915_hwmon@hwmon-write.html
* igt@i915_module_load@load:
- shard-tglu-9: NOTRUN -> [SKIP][43] ([i915#6227])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@i915_module_load@load.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu-10: NOTRUN -> [FAIL][44] ([i915#3989] / [i915#454])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-tglu-9: NOTRUN -> [SKIP][45] ([i915#1397])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@i915_pm_rpm@modeset-lpsp.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglu-10: NOTRUN -> [SKIP][46] ([i915#404])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglu-10: NOTRUN -> [SKIP][47] ([i915#5286]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-tglu-10: NOTRUN -> [SKIP][48] ([fdo#111614]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-tglu-9: NOTRUN -> [SKIP][49] ([fdo#111615] / [i915#1845] / [i915#7651]) +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglu-10: NOTRUN -> [SKIP][50] ([fdo#111615]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][51] ([i915#3689] / [i915#3886])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk5/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][53] ([i915#3689] / [i915#6095])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_ccs@pipe-b-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][54] ([i915#6095]) +4 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglu-9: NOTRUN -> [SKIP][55] ([i915#1845] / [i915#7651]) +72 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][56] ([i915#3689]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][57] ([fdo#111615] / [i915#3689]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglu-10: NOTRUN -> [SKIP][58] ([i915#3742])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium_color@ctm-0-50:
- shard-tglu-10: NOTRUN -> [SKIP][59] ([fdo#111827])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_chamelium_color@ctm-0-50.html
* igt@kms_chamelium_color@ctm-limited-range:
- shard-tglu-9: NOTRUN -> [SKIP][60] ([fdo#111827]) +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_chamelium_color@ctm-limited-range.html
* igt@kms_chamelium_edid@hdmi-mode-timings:
- shard-tglu-9: NOTRUN -> [SKIP][61] ([i915#7828]) +6 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_chamelium_edid@hdmi-mode-timings.html
* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-tglu-10: NOTRUN -> [SKIP][62] ([i915#7828]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_chamelium_hpd@hdmi-hpd.html
* igt@kms_cursor_crc@cursor-random-64x64:
- shard-tglu-9: NOTRUN -> [SKIP][63] ([i915#1845]) +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_cursor_crc@cursor-random-64x64.html
* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-tglu-10: NOTRUN -> [SKIP][64] ([i915#3359]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_cursor_crc@cursor-sliding-512x170.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [PASS][65] -> [FAIL][66] ([i915#2346])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_display_modes@extended-mode-basic:
- shard-tglu-10: NOTRUN -> [SKIP][67] ([fdo#109274]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][68] -> [FAIL][69] ([i915#4767])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- shard-tglu-10: NOTRUN -> [SKIP][70] ([fdo#109274] / [i915#3637]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#79])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-tglu-9: NOTRUN -> [SKIP][73] ([fdo#109274] / [i915#3637]) +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271]) +22 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-snb2/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#2122])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [PASS][77] -> [FAIL][78] ([i915#79]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-panning-vs-hang:
- shard-tglu-9: NOTRUN -> [SKIP][79] ([i915#3637]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_flip@flip-vs-panning-vs-hang.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling:
- shard-tglu-9: NOTRUN -> [SKIP][80] ([i915#3555]) +8 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-tglu-10: NOTRUN -> [SKIP][81] ([i915#2587] / [i915#2672]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-tglu-9: NOTRUN -> [SKIP][82] ([i915#1849]) +55 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear:
- shard-tglu-10: NOTRUN -> [SKIP][83] ([fdo#110189]) +11 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271]) +62 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt:
- shard-tglu-10: NOTRUN -> [SKIP][85] ([fdo#109280]) +15 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt.html
* igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
- shard-tglu-10: NOTRUN -> [SKIP][86] ([fdo#109289]) +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
* igt@kms_plane_alpha_blend@constant-alpha-min:
- shard-tglu-9: NOTRUN -> [SKIP][87] ([i915#7128] / [i915#7294])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_plane_alpha_blend@constant-alpha-min.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][88] ([i915#5235]) +3 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5:
- shard-tglu-9: NOTRUN -> [SKIP][89] ([i915#3555] / [i915#6953])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5.html
* igt@kms_prime@d3hot:
- shard-tglu-9: NOTRUN -> [SKIP][90] ([i915#6524]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_prime@d3hot.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglu-10: NOTRUN -> [SKIP][91] ([fdo#111068] / [i915#658]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-tglu-9: NOTRUN -> [SKIP][92] ([fdo#111068] / [i915#658])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-tglu-9: NOTRUN -> [SKIP][93] ([fdo#109642] / [fdo#111068] / [i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-tglu-9: NOTRUN -> [SKIP][94] ([fdo#110189]) +5 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglu-10: NOTRUN -> [SKIP][95] ([i915#5461])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-tglu-10: NOTRUN -> [SKIP][96] ([fdo#111615] / [i915#5289])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][97] ([i915#5465]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
* igt@kms_vrr@flip-suspend:
- shard-tglu-10: NOTRUN -> [SKIP][98] ([i915#3555]) +3 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@kms_vrr@flip-suspend.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglu-9: NOTRUN -> [SKIP][99] ([i915#2437])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@kms_writeback@writeback-invalid-parameters.html
* igt@perf_pmu@event-wait@rcs0:
- shard-tglu-9: NOTRUN -> [SKIP][100] ([fdo#112283])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@perf_pmu@event-wait@rcs0.html
* igt@v3d/v3d_get_param@get-bad-param:
- shard-tglu-10: NOTRUN -> [SKIP][101] ([fdo#109315] / [i915#2575]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@v3d/v3d_get_param@get-bad-param.html
* igt@v3d/v3d_perfmon@create-perfmon-0:
- shard-tglu-9: NOTRUN -> [SKIP][102] ([fdo#109315] / [i915#2575]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@v3d/v3d_perfmon@create-perfmon-0.html
* igt@vc4/vc4_tiling@set-bad-flags:
- shard-tglu-10: NOTRUN -> [SKIP][103] ([i915#2575]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-10/igt@vc4/vc4_tiling@set-bad-flags.html
* igt@vc4/vc4_wait_bo@used-bo-0ns:
- shard-tglu-9: NOTRUN -> [SKIP][104] ([i915#2575]) +6 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-tglu-9/igt@vc4/vc4_wait_bo@used-bo-0ns.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][105] ([i915#7742]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* {igt@gem_barrier_race@remote-request@rcs0}:
- shard-glk: [ABORT][107] -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk2/igt@gem_barrier_race@remote-request@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk9/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][109] ([i915#6259]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-5/igt@gem_exec_balancer@fairslice.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-1/igt@gem_exec_balancer@fairslice.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- {shard-rkl}: [FAIL][111] ([i915#2842]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-6/igt@gem_exec_fair@basic-none-solo@rcs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][113] ([i915#2842]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][115] ([i915#3281]) -> [PASS][116] +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-3/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][117] ([i915#3282]) -> [PASS][118] +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-1/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][119] ([i915#5566]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-glk4/igt@gen9_exec_parse@allowed-single.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-glk5/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- {shard-rkl}: [SKIP][121] ([i915#4098]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-2/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_dc@dc5-dpms:
- {shard-rkl}: [FAIL][123] ([i915#7330]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-1/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-dg1}: [SKIP][125] ([i915#1397]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-dg1-18/igt@i915_pm_rpm@dpms-lpsp.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-dg1-14/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][127] ([i915#6537]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-apl3/igt@i915_pm_rps@engine-order.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-apl7/igt@i915_pm_rps@engine-order.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- {shard-rkl}: [SKIP][129] ([i915#1849] / [i915#4098]) -> [PASS][130] +12 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_properties@crtc-properties-legacy:
- {shard-rkl}: [SKIP][131] ([i915#1849]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-2/igt@kms_properties@crtc-properties-legacy.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_properties@crtc-properties-legacy.html
* igt@kms_psr@suspend:
- {shard-rkl}: [SKIP][133] ([i915#1072]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-2/igt@kms_psr@suspend.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-idle:
- {shard-rkl}: [SKIP][135] ([i915#1845] / [i915#4098]) -> [PASS][136] +17 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12758/shard-rkl-2/igt@kms_vblank@pipe-a-ts-continuation-idle.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-idle.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6659]: https://gitlab.freedesktop.org/drm/intel/issues/6659
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7811]: https://gitlab.freedesktop.org/drm/intel/issues/7811
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
Build changes
-------------
* Linux: CI_DRM_12758 -> Patchwork_114161v1
CI-20190529: 20190529
CI_DRM_12758: 207db44a791c337b64ed1df2715b00d2602eaed5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7165: 509e7e63c6377d0fe77d1bd209857fb191f4a84c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114161v1: 207db44a791c337b64ed1df2715b00d2602eaed5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114161v1/index.html
[-- Attachment #2: Type: text/html, Size: 44132 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-17 19:18 [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL Jonathan Cavitt
` (2 preceding siblings ...)
2023-02-18 11:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2023-02-21 16:06 ` Matthew Auld
2023-02-21 16:07 ` Matthew Auld
2023-02-21 16:28 ` Cavitt, Jonathan
3 siblings, 2 replies; 12+ messages in thread
From: Matthew Auld @ 2023-02-21 16:06 UTC (permalink / raw)
To: Jonathan Cavitt, intel-gfx
On 17/02/2023 19:18, Jonathan Cavitt wrote:
> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
> MTL reports as not supporting 64K pages, or more accurately, the system that reports
> whether a platform has 64K pages reports false for MTL. This is only half correct,
> as the 64K page support reporting system only cares about 64K page support for LMEM,
> which MTL doesn't have.
>
> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
> using that manager doesn't resolve the issue because MTL is expecting the virtual
> address space for the page table to be flushed after initialization, so we must also
> add a flush statement there.
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Although it looks like the hugepage mock tests are failing with this. I
assume the mock device just uses some "max" gen version or so, which now
triggers this path. Any ideas for that?
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> index 4daaa6f55668..9c571185395f 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
> }
> } while (rem >= page_size && index < max);
>
> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
> vma_res->page_sizes_gtt |= page_size;
> } while (iter->sg && sg_dma_len(iter->sg));
> }
> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
> struct sgt_dma iter = sgt_dma(vma_res);
>
> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
> - if (HAS_64K_PAGES(vm->i915))
> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> else
> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 16:06 ` [Intel-gfx] [PATCH] " Matthew Auld
@ 2023-02-21 16:07 ` Matthew Auld
2023-02-21 16:28 ` Cavitt, Jonathan
1 sibling, 0 replies; 12+ messages in thread
From: Matthew Auld @ 2023-02-21 16:07 UTC (permalink / raw)
To: Jonathan Cavitt, intel-gfx
On 21/02/2023 16:06, Matthew Auld wrote:
> On 17/02/2023 19:18, Jonathan Cavitt wrote:
>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages.
>> This is because
>> MTL reports as not supporting 64K pages, or more accurately, the
>> system that reports
>> whether a platform has 64K pages reports false for MTL. This is only
>> half correct,
>> as the 64K page support reporting system only cares about 64K page
>> support for LMEM,
>> which MTL doesn't have.
>>
>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply
>> changing over to
>> using that manager doesn't resolve the issue because MTL is expecting
>> the virtual
>> address space for the page table to be flushed after initialization,
>> so we must also
>> add a flush statement there.
>>
>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Also make sure we use "drm/i915:" prefix for commit title.
>
> Although it looks like the hugepage mock tests are failing with this. I
> assume the mock device just uses some "max" gen version or so, which now
> triggers this path. Any ideas for that?
>
>> ---
>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> index 4daaa6f55668..9c571185395f 100644
>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct
>> i915_address_space *vm,
>> }
>> } while (rem >= page_size && index < max);
>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
>> vma_res->page_sizes_gtt |= page_size;
>> } while (iter->sg && sg_dma_len(iter->sg));
>> }
>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct
>> i915_address_space *vm,
>> struct sgt_dma iter = sgt_dma(vma_res);
>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
>> - if (HAS_64K_PAGES(vm->i915))
>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter,
>> cache_level, flags);
>> else
>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level,
>> flags);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 16:06 ` [Intel-gfx] [PATCH] " Matthew Auld
2023-02-21 16:07 ` Matthew Auld
@ 2023-02-21 16:28 ` Cavitt, Jonathan
2023-02-21 16:32 ` Matthew Auld
1 sibling, 1 reply; 12+ messages in thread
From: Cavitt, Jonathan @ 2023-02-21 16:28 UTC (permalink / raw)
To: Auld, Matthew; +Cc: intel-gfx@lists.freedesktop.org
-----Original Message-----
From: Auld, Matthew <matthew.auld@intel.com>
Sent: Tuesday, February 21, 2023 8:06 AM
To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>
> On 17/02/2023 19:18, Jonathan Cavitt wrote:
> > MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
> > MTL reports as not supporting 64K pages, or more accurately, the system that reports
> > whether a platform has 64K pages reports false for MTL. This is only half correct,
> > as the 64K page support reporting system only cares about 64K page support for LMEM,
> > which MTL doesn't have.
> >
> > MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
> > using that manager doesn't resolve the issue because MTL is expecting the virtual
> > address space for the page table to be flushed after initialization, so we must also
> > add a flush statement there.
> >
> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Although it looks like the hugepage mock tests are failing with this. I
> assume the mock device just uses some "max" gen version or so, which now
> triggers this path. Any ideas for that?
With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
If the mock tests are run immediately after the live ones, that would explain this behavior.
I was informed when this was initially debugged that the error was a known IOMMU issue
rather than some novel regression, though it's hard to tell if that was just hopeful optimism
or not at this point.
-Jonathan Cavitt
>
> > ---
> > drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> > index 4daaa6f55668..9c571185395f 100644
> > --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> > +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> > @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
> > }
> > } while (rem >= page_size && index < max);
> >
> > + drm_clflush_virt_range(vaddr, PAGE_SIZE);
> > vma_res->page_sizes_gtt |= page_size;
> > } while (iter->sg && sg_dma_len(iter->sg));
> > }
> > @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
> > struct sgt_dma iter = sgt_dma(vma_res);
> >
> > if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
> > - if (HAS_64K_PAGES(vm->i915))
> > + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
> > xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> > else
> > gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 16:28 ` Cavitt, Jonathan
@ 2023-02-21 16:32 ` Matthew Auld
2023-02-21 17:14 ` Cavitt, Jonathan
0 siblings, 1 reply; 12+ messages in thread
From: Matthew Auld @ 2023-02-21 16:32 UTC (permalink / raw)
To: Cavitt, Jonathan; +Cc: intel-gfx@lists.freedesktop.org
On 21/02/2023 16:28, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Auld, Matthew <matthew.auld@intel.com>
> Sent: Tuesday, February 21, 2023 8:06 AM
> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>
>> On 17/02/2023 19:18, Jonathan Cavitt wrote:
>>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
>>> MTL reports as not supporting 64K pages, or more accurately, the system that reports
>>> whether a platform has 64K pages reports false for MTL. This is only half correct,
>>> as the 64K page support reporting system only cares about 64K page support for LMEM,
>>> which MTL doesn't have.
>>>
>>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
>>> using that manager doesn't resolve the issue because MTL is expecting the virtual
>>> address space for the page table to be flushed after initialization, so we must also
>>> add a flush statement there.
>>>
>>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>
>> Although it looks like the hugepage mock tests are failing with this. I
>> assume the mock device just uses some "max" gen version or so, which now
>> triggers this path. Any ideas for that?
>
> With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
> If the mock tests are run immediately after the live ones, that would explain this behavior.
> I was informed when this was initially debugged that the error was a known IOMMU issue
> rather than some novel regression, though it's hard to tell if that was just hopeful optimism
> or not at this point.
In the test results we now get:
6> [183.420316] i915: Running
i915_gem_huge_page_mock_selftests/igt_mock_exhaust_device_supported_pages
<6> [183.436978] i915: Running
i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
<6> [183.445777] i915: Running
i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_misaligned_dma
<6> [183.904531] i915: Running
i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_huge_fill
<3> [183.912658] gtt=69632, expected=4096, size=69632, single=yes
<3> [183.912784] i915/i915_gem_huge_page_mock_selftests:
igt_mock_ppgtt_huge_fill failed with error -22
I didn't look any deeper than that though. Note that this a just a
mock/fake device. I don't think its IOMMU related.
> -Jonathan Cavitt
>
>>
>>> ---
>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>> index 4daaa6f55668..9c571185395f 100644
>>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
>>> }
>>> } while (rem >= page_size && index < max);
>>>
>>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
>>> vma_res->page_sizes_gtt |= page_size;
>>> } while (iter->sg && sg_dma_len(iter->sg));
>>> }
>>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
>>> struct sgt_dma iter = sgt_dma(vma_res);
>>>
>>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
>>> - if (HAS_64K_PAGES(vm->i915))
>>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
>>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>> else
>>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 16:32 ` Matthew Auld
@ 2023-02-21 17:14 ` Cavitt, Jonathan
2023-02-21 17:46 ` Matthew Auld
0 siblings, 1 reply; 12+ messages in thread
From: Cavitt, Jonathan @ 2023-02-21 17:14 UTC (permalink / raw)
To: Auld, Matthew; +Cc: intel-gfx@lists.freedesktop.org
-----Original Message-----
From: Auld, Matthew <matthew.auld@intel.com>
Sent: Tuesday, February 21, 2023 8:33 AM
To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>
> On 21/02/2023 16:28, Cavitt, Jonathan wrote:
> > -----Original Message-----
> > From: Auld, Matthew <matthew.auld@intel.com>
> > Sent: Tuesday, February 21, 2023 8:06 AM
> > To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
> > Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> > Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
> >>
> >> On 17/02/2023 19:18, Jonathan Cavitt wrote:
> >>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
> >>> MTL reports as not supporting 64K pages, or more accurately, the system that reports
> >>> whether a platform has 64K pages reports false for MTL. This is only half correct,
> >>> as the 64K page support reporting system only cares about 64K page support for LMEM,
> >>> which MTL doesn't have.
> >>>
> >>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
> >>> using that manager doesn't resolve the issue because MTL is expecting the virtual
> >>> address space for the page table to be flushed after initialization, so we must also
> >>> add a flush statement there.
> >>>
> >>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> >> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> >>
> >> Although it looks like the hugepage mock tests are failing with this. I
> >> assume the mock device just uses some "max" gen version or so, which now
> >> triggers this path. Any ideas for that?
> >
> > With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
> > If the mock tests are run immediately after the live ones, that would explain this behavior.
> > I was informed when this was initially debugged that the error was a known IOMMU issue
> > rather than some novel regression, though it's hard to tell if that was just hopeful optimism
> > or not at this point.
>
> In the test results we now get:
>
> 6> [183.420316] i915: Running
> i915_gem_huge_page_mock_selftests/igt_mock_exhaust_device_supported_pages
> <6> [183.436978] i915: Running
> i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
> <6> [183.445777] i915: Running
> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_misaligned_dma
> <6> [183.904531] i915: Running
> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_huge_fill
> <3> [183.912658] gtt=69632, expected=4096, size=69632, single=yes
> <3> [183.912784] i915/i915_gem_huge_page_mock_selftests:
> igt_mock_ppgtt_huge_fill failed with error -22
if (expected_gtt & I915_GTT_PAGE_SIZE_4K)
expected_gtt &= ~I915_GTT_PAGE_SIZE_64K;
I don't know why we're doing that to expected_gtt, but that seems to be the cause of the
problem in this case.
-Jonathan Cavitt
>
> I didn't look any deeper than that though. Note that this a just a
> mock/fake device. I don't think its IOMMU related.
>
> > -Jonathan Cavitt
> >
> >>
> >>> ---
> >>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>> index 4daaa6f55668..9c571185395f 100644
> >>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
> >>> }
> >>> } while (rem >= page_size && index < max);
> >>>
> >>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
> >>> vma_res->page_sizes_gtt |= page_size;
> >>> } while (iter->sg && sg_dma_len(iter->sg));
> >>> }
> >>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
> >>> struct sgt_dma iter = sgt_dma(vma_res);
> >>>
> >>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
> >>> - if (HAS_64K_PAGES(vm->i915))
> >>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
> >>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> >>> else
> >>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> >>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 17:14 ` Cavitt, Jonathan
@ 2023-02-21 17:46 ` Matthew Auld
2023-02-21 18:34 ` Cavitt, Jonathan
0 siblings, 1 reply; 12+ messages in thread
From: Matthew Auld @ 2023-02-21 17:46 UTC (permalink / raw)
To: Cavitt, Jonathan; +Cc: intel-gfx@lists.freedesktop.org
On 21/02/2023 17:14, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Auld, Matthew <matthew.auld@intel.com>
> Sent: Tuesday, February 21, 2023 8:33 AM
> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>
>> On 21/02/2023 16:28, Cavitt, Jonathan wrote:
>>> -----Original Message-----
>>> From: Auld, Matthew <matthew.auld@intel.com>
>>> Sent: Tuesday, February 21, 2023 8:06 AM
>>> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
>>> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
>>> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>>>
>>>> On 17/02/2023 19:18, Jonathan Cavitt wrote:
>>>>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
>>>>> MTL reports as not supporting 64K pages, or more accurately, the system that reports
>>>>> whether a platform has 64K pages reports false for MTL. This is only half correct,
>>>>> as the 64K page support reporting system only cares about 64K page support for LMEM,
>>>>> which MTL doesn't have.
>>>>>
>>>>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
>>>>> using that manager doesn't resolve the issue because MTL is expecting the virtual
>>>>> address space for the page table to be flushed after initialization, so we must also
>>>>> add a flush statement there.
>>>>>
>>>>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>>> Although it looks like the hugepage mock tests are failing with this. I
>>>> assume the mock device just uses some "max" gen version or so, which now
>>>> triggers this path. Any ideas for that?
>>>
>>> With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
>>> If the mock tests are run immediately after the live ones, that would explain this behavior.
>>> I was informed when this was initially debugged that the error was a known IOMMU issue
>>> rather than some novel regression, though it's hard to tell if that was just hopeful optimism
>>> or not at this point.
>>
>> In the test results we now get:
>>
>> 6> [183.420316] i915: Running
>> i915_gem_huge_page_mock_selftests/igt_mock_exhaust_device_supported_pages
>> <6> [183.436978] i915: Running
>> i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
>> <6> [183.445777] i915: Running
>> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_misaligned_dma
>> <6> [183.904531] i915: Running
>> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_huge_fill
>> <3> [183.912658] gtt=69632, expected=4096, size=69632, single=yes
>> <3> [183.912784] i915/i915_gem_huge_page_mock_selftests:
>> igt_mock_ppgtt_huge_fill failed with error -22
>
> if (expected_gtt & I915_GTT_PAGE_SIZE_4K)
> expected_gtt &= ~I915_GTT_PAGE_SIZE_64K;
>
> I don't know why we're doing that to expected_gtt, but that seems to be the cause of the
> problem in this case.
I think it's due to the older huge page model, where 64K requires the
entire page-table to all use 64K pages underneath (pde level hint), so
if we see 4K in there somewhere then we don't expect to get back 64K
GTT. But on newer HW we now have have pte level hint, so I think the
above can just be removed with this patch, since that's what the mock
device now uses.
> -Jonathan Cavitt
>
>>
>> I didn't look any deeper than that though. Note that this a just a
>> mock/fake device. I don't think its IOMMU related.
>>
>>> -Jonathan Cavitt
>>>
>>>>
>>>>> ---
>>>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>> index 4daaa6f55668..9c571185395f 100644
>>>>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
>>>>> }
>>>>> } while (rem >= page_size && index < max);
>>>>>
>>>>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
>>>>> vma_res->page_sizes_gtt |= page_size;
>>>>> } while (iter->sg && sg_dma_len(iter->sg));
>>>>> }
>>>>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
>>>>> struct sgt_dma iter = sgt_dma(vma_res);
>>>>>
>>>>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
>>>>> - if (HAS_64K_PAGES(vm->i915))
>>>>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
>>>>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>>>> else
>>>>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>>>
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 17:46 ` Matthew Auld
@ 2023-02-21 18:34 ` Cavitt, Jonathan
2023-02-22 9:35 ` Matthew Auld
0 siblings, 1 reply; 12+ messages in thread
From: Cavitt, Jonathan @ 2023-02-21 18:34 UTC (permalink / raw)
To: Auld, Matthew; +Cc: intel-gfx@lists.freedesktop.org
-----Original Message-----
From: Auld, Matthew <matthew.auld@intel.com>
Sent: Tuesday, February 21, 2023 9:46 AM
To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>
> On 21/02/2023 17:14, Cavitt, Jonathan wrote:
> > -----Original Message-----
> > From: Auld, Matthew <matthew.auld@intel.com>
> > Sent: Tuesday, February 21, 2023 8:33 AM
> > To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
> > Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
> > Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
> >>
> >> On 21/02/2023 16:28, Cavitt, Jonathan wrote:
> >>> -----Original Message-----
> >>> From: Auld, Matthew <matthew.auld@intel.com>
> >>> Sent: Tuesday, February 21, 2023 8:06 AM
> >>> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
> >>> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
> >>> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
> >>>>
> >>>> On 17/02/2023 19:18, Jonathan Cavitt wrote:
> >>>>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
> >>>>> MTL reports as not supporting 64K pages, or more accurately, the system that reports
> >>>>> whether a platform has 64K pages reports false for MTL. This is only half correct,
> >>>>> as the 64K page support reporting system only cares about 64K page support for LMEM,
> >>>>> which MTL doesn't have.
> >>>>>
> >>>>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
> >>>>> using that manager doesn't resolve the issue because MTL is expecting the virtual
> >>>>> address space for the page table to be flushed after initialization, so we must also
> >>>>> add a flush statement there.
> >>>>>
> >>>>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> >>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> >>>>
> >>>> Although it looks like the hugepage mock tests are failing with this. I
> >>>> assume the mock device just uses some "max" gen version or so, which now
> >>>> triggers this path. Any ideas for that?
> >>>
> >>> With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
> >>> If the mock tests are run immediately after the live ones, that would explain this behavior.
> >>> I was informed when this was initially debugged that the error was a known IOMMU issue
> >>> rather than some novel regression, though it's hard to tell if that was just hopeful optimism
> >>> or not at this point.
> >>
> >> In the test results we now get:
> >>
> >> 6> [183.420316] i915: Running
> >> i915_gem_huge_page_mock_selftests/igt_mock_exhaust_device_supported_pages
> >> <6> [183.436978] i915: Running
> >> i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
> >> <6> [183.445777] i915: Running
> >> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_misaligned_dma
> >> <6> [183.904531] i915: Running
> >> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_huge_fill
> >> <3> [183.912658] gtt=69632, expected=4096, size=69632, single=yes
> >> <3> [183.912784] i915/i915_gem_huge_page_mock_selftests:
> >> igt_mock_ppgtt_huge_fill failed with error -22
> >
> > if (expected_gtt & I915_GTT_PAGE_SIZE_4K)
> > expected_gtt &= ~I915_GTT_PAGE_SIZE_64K;
> >
> > I don't know why we're doing that to expected_gtt, but that seems to be the cause of the
> > problem in this case.
>
> I think it's due to the older huge page model, where 64K requires the
> entire page-table to all use 64K pages underneath (pde level hint), so
> if we see 4K in there somewhere then we don't expect to get back 64K
> GTT. But on newer HW we now have have pte level hint, so I think the
> above can just be removed with this patch, since that's what the mock
> device now uses.
Seems right. I guess that would be... what? Is it:
A. Platform specific? I.E. we need s generation check in the selftest to proceed, such as the following:
if (expected_gtt & I915_GTT_PAGE_SIZE_4K && GRAPHICS_VER(i915) >= 12)
B. Systems specific? I.E. we have a special check for this functionality such as:
if (expected_gtt & I915_GTT_PAGE_SIZE_4K && has_pte_level_hint(i915))
C. The new norm. I.E. we can just remove this line from the test and everything will work out fine.
-Jonathan Cavitt
>
> > -Jonathan Cavitt
> >
> >>
> >> I didn't look any deeper than that though. Note that this a just a
> >> mock/fake device. I don't think its IOMMU related.
> >>
> >>> -Jonathan Cavitt
> >>>
> >>>>
> >>>>> ---
> >>>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
> >>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>>>> index 4daaa6f55668..9c571185395f 100644
> >>>>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>>>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> >>>>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
> >>>>> }
> >>>>> } while (rem >= page_size && index < max);
> >>>>>
> >>>>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
> >>>>> vma_res->page_sizes_gtt |= page_size;
> >>>>> } while (iter->sg && sg_dma_len(iter->sg));
> >>>>> }
> >>>>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
> >>>>> struct sgt_dma iter = sgt_dma(vma_res);
> >>>>>
> >>>>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
> >>>>> - if (HAS_64K_PAGES(vm->i915))
> >>>>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
> >>>>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> >>>>> else
> >>>>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
> >>>>
> >>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
2023-02-21 18:34 ` Cavitt, Jonathan
@ 2023-02-22 9:35 ` Matthew Auld
0 siblings, 0 replies; 12+ messages in thread
From: Matthew Auld @ 2023-02-22 9:35 UTC (permalink / raw)
To: Cavitt, Jonathan; +Cc: intel-gfx@lists.freedesktop.org
On 21/02/2023 18:34, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Auld, Matthew <matthew.auld@intel.com>
> Sent: Tuesday, February 21, 2023 9:46 AM
> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>
>> On 21/02/2023 17:14, Cavitt, Jonathan wrote:
>>> -----Original Message-----
>>> From: Auld, Matthew <matthew.auld@intel.com>
>>> Sent: Tuesday, February 21, 2023 8:33 AM
>>> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
>>> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>; intel-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>>>
>>>> On 21/02/2023 16:28, Cavitt, Jonathan wrote:
>>>>> -----Original Message-----
>>>>> From: Auld, Matthew <matthew.auld@intel.com>
>>>>> Sent: Tuesday, February 21, 2023 8:06 AM
>>>>> To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org
>>>>> Cc: Dutt, Sudeep <sudeep.dutt@intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
>>>>> Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL
>>>>>>
>>>>>> On 17/02/2023 19:18, Jonathan Cavitt wrote:
>>>>>>> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because
>>>>>>> MTL reports as not supporting 64K pages, or more accurately, the system that reports
>>>>>>> whether a platform has 64K pages reports false for MTL. This is only half correct,
>>>>>>> as the 64K page support reporting system only cares about 64K page support for LMEM,
>>>>>>> which MTL doesn't have.
>>>>>>>
>>>>>>> MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing over to
>>>>>>> using that manager doesn't resolve the issue because MTL is expecting the virtual
>>>>>>> address space for the page table to be flushed after initialization, so we must also
>>>>>>> add a flush statement there.
>>>>>>>
>>>>>>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>>>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>>>
>>>>>> Although it looks like the hugepage mock tests are failing with this. I
>>>>>> assume the mock device just uses some "max" gen version or so, which now
>>>>>> triggers this path. Any ideas for that?
>>>>>
>>>>> With this patch applied, multiple calls to the hugepages live selftest result in a kernel panic.
>>>>> If the mock tests are run immediately after the live ones, that would explain this behavior.
>>>>> I was informed when this was initially debugged that the error was a known IOMMU issue
>>>>> rather than some novel regression, though it's hard to tell if that was just hopeful optimism
>>>>> or not at this point.
>>>>
>>>> In the test results we now get:
>>>>
>>>> 6> [183.420316] i915: Running
>>>> i915_gem_huge_page_mock_selftests/igt_mock_exhaust_device_supported_pages
>>>> <6> [183.436978] i915: Running
>>>> i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
>>>> <6> [183.445777] i915: Running
>>>> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_misaligned_dma
>>>> <6> [183.904531] i915: Running
>>>> i915_gem_huge_page_mock_selftests/igt_mock_ppgtt_huge_fill
>>>> <3> [183.912658] gtt=69632, expected=4096, size=69632, single=yes
>>>> <3> [183.912784] i915/i915_gem_huge_page_mock_selftests:
>>>> igt_mock_ppgtt_huge_fill failed with error -22
>>>
>>> if (expected_gtt & I915_GTT_PAGE_SIZE_4K)
>>> expected_gtt &= ~I915_GTT_PAGE_SIZE_64K;
>>>
>>> I don't know why we're doing that to expected_gtt, but that seems to be the cause of the
>>> problem in this case.
>>
>> I think it's due to the older huge page model, where 64K requires the
>> entire page-table to all use 64K pages underneath (pde level hint), so
>> if we see 4K in there somewhere then we don't expect to get back 64K
>> GTT. But on newer HW we now have have pte level hint, so I think the
>> above can just be removed with this patch, since that's what the mock
>> device now uses.
>
> Seems right. I guess that would be... what? Is it:
> A. Platform specific? I.E. we need s generation check in the selftest to proceed, such as the following:
>
> if (expected_gtt & I915_GTT_PAGE_SIZE_4K && GRAPHICS_VER(i915) >= 12)
>
> B. Systems specific? I.E. we have a special check for this functionality such as:
>
> if (expected_gtt & I915_GTT_PAGE_SIZE_4K && has_pte_level_hint(i915))
>
> C. The new norm. I.E. we can just remove this line from the test and everything will work out fine.
The mock device will always use the max graphics version:
RUNTIME_INFO(i915)->graphics.ip.ver = -1;
So I think option C.
>
> -Jonathan Cavitt
>
>>
>>> -Jonathan Cavitt
>>>
>>>>
>>>> I didn't look any deeper than that though. Note that this a just a
>>>> mock/fake device. I don't think its IOMMU related.
>>>>
>>>>> -Jonathan Cavitt
>>>>>
>>>>>>
>>>>>>> ---
>>>>>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ++-
>>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>>>> index 4daaa6f55668..9c571185395f 100644
>>>>>>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>>>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>>>>>>> @@ -570,6 +570,7 @@ xehpsdv_ppgtt_insert_huge(struct i915_address_space *vm,
>>>>>>> }
>>>>>>> } while (rem >= page_size && index < max);
>>>>>>>
>>>>>>> + drm_clflush_virt_range(vaddr, PAGE_SIZE);
>>>>>>> vma_res->page_sizes_gtt |= page_size;
>>>>>>> } while (iter->sg && sg_dma_len(iter->sg));
>>>>>>> }
>>>>>>> @@ -707,7 +708,7 @@ static void gen8_ppgtt_insert(struct i915_address_space *vm,
>>>>>>> struct sgt_dma iter = sgt_dma(vma_res);
>>>>>>>
>>>>>>> if (vma_res->bi.page_sizes.sg > I915_GTT_PAGE_SIZE) {
>>>>>>> - if (HAS_64K_PAGES(vm->i915))
>>>>>>> + if (GRAPHICS_VER_FULL(vm->i915) >= IP_VER(12, 50))
>>>>>>> xehpsdv_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>>>>>> else
>>>>>>> gen8_ppgtt_insert_huge(vm, vma_res, &iter, cache_level, flags);
>>>>>>
>>>>
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-22 9:36 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-17 19:18 [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL Jonathan Cavitt
2023-02-17 21:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-02-17 21:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-18 11:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-02-21 16:06 ` [Intel-gfx] [PATCH] " Matthew Auld
2023-02-21 16:07 ` Matthew Auld
2023-02-21 16:28 ` Cavitt, Jonathan
2023-02-21 16:32 ` Matthew Auld
2023-02-21 17:14 ` Cavitt, Jonathan
2023-02-21 17:46 ` Matthew Auld
2023-02-21 18:34 ` Cavitt, Jonathan
2023-02-22 9:35 ` Matthew Auld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.