All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [v2] drm/i915/display: Add an extra vblank wait before fbc activation
@ 2020-08-17 11:25 Uma Shankar
  2020-08-17 11:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add an extra vblank wait before fbc activation (rev2) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Uma Shankar @ 2020-08-17 11:25 UTC (permalink / raw)
  To: intel-gfx

Add an extra vblank before fbc is activated.
WA: 1409689360
Corruption with FBC around plane 1A enabling. In the Frame Buffer
Compression programming sequence "Display Plane Enabling with FBC"
add a wait for vblank between plane enabling step 1 and FBC enabling
step 2.

v2: Add wait only for active crtc

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 2ab32e6532ff..2a9d4796c4a8 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1085,10 +1085,13 @@ static void __intel_fbc_post_update(struct intel_crtc *crtc)
 	if (!intel_fbc_can_activate(crtc))
 		return;
 
-	if (!fbc->busy_bits)
+	if (!fbc->busy_bits) {
+		if (IS_TIGERLAKE(dev_priv))
+			intel_wait_for_vblank_if_active(dev_priv, crtc->pipe);
 		intel_fbc_hw_activate(dev_priv);
-	else
+	} else {
 		intel_fbc_deactivate(dev_priv, "frontbuffer write");
+	}
 }
 
 void intel_fbc_post_update(struct intel_atomic_state *state,
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-17 13:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-17 11:25 [Intel-gfx] [v2] drm/i915/display: Add an extra vblank wait before fbc activation Uma Shankar
2020-08-17 11:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add an extra vblank wait before fbc activation (rev2) Patchwork
2020-08-17 12:19 ` [Intel-gfx] [v2] drm/i915/display: Add an extra vblank wait before fbc activation Anshuman Gupta
2020-08-17 12:48   ` Shankar, Uma
2020-08-17 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Add an extra vblank wait before fbc activation (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.