From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
dhowells@redhat.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org
Cc: prsriva@linux.microsoft.com
Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update
Date: Thu, 31 Oct 2019 15:08:48 +0000 [thread overview]
Message-ID: <b83bd7ef-ce7f-e750-e30b-30d5a6469a28@linux.microsoft.com> (raw)
In-Reply-To: <1572523831.5028.43.camel@linux.ibm.com>
On 10/31/19 5:10 AM, Mimi Zohar wrote:
> On Wed, 2019-10-30 at 18:19 -0700, Lakshmi Ramasubramanian wrote:
>> Asymmetric keys used for verifying file signatures or certificates
>> are currently not included in the IMA measurement list.
>>
>> This patch defines a new IMA hook namely ima_post_key_create_or_update()
>> to measure asymmetric keys.
>
> It's not enough for the kernel to be able to compile the kernel after
> applying all the patches in a patch set. After applying each patch,
> the kernel should build properly, otherwise it is not bi-sect safe.
> Refer to "3) Separate your changes" of
> "Documentation/process/submitting-patches.rst.
I started with kernel version 5.3 for this patch set.
I applied Nayna's process_buffer_measurement() patch and then built my
changes on top of that.
This patch has no other dependency as far as I know.
Are you seeing a build break after applying this patch alone?
(PATCH v3 1/9) KEYS: Defined an IMA hook to measure keys on key create
or update
>
> This patch should also define the new "func".
>
Ok - I'll make that change.
thanks,
-lakshmi
WARNING: multiple messages have this Message-ID (diff)
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
dhowells@redhat.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org
Cc: prsriva@linux.microsoft.com
Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update
Date: Thu, 31 Oct 2019 08:08:48 -0700 [thread overview]
Message-ID: <b83bd7ef-ce7f-e750-e30b-30d5a6469a28@linux.microsoft.com> (raw)
In-Reply-To: <1572523831.5028.43.camel@linux.ibm.com>
On 10/31/19 5:10 AM, Mimi Zohar wrote:
> On Wed, 2019-10-30 at 18:19 -0700, Lakshmi Ramasubramanian wrote:
>> Asymmetric keys used for verifying file signatures or certificates
>> are currently not included in the IMA measurement list.
>>
>> This patch defines a new IMA hook namely ima_post_key_create_or_update()
>> to measure asymmetric keys.
>
> It's not enough for the kernel to be able to compile the kernel after
> applying all the patches in a patch set. After applying each patch,
> the kernel should build properly, otherwise it is not bi-sect safe.
> Refer to "3) Separate your changes" of
> "Documentation/process/submitting-patches.rst.
I started with kernel version 5.3 for this patch set.
I applied Nayna's process_buffer_measurement() patch and then built my
changes on top of that.
This patch has no other dependency as far as I know.
Are you seeing a build break after applying this patch alone?
(PATCH v3 1/9) KEYS: Defined an IMA hook to measure keys on key create
or update
>
> This patch should also define the new "func".
>
Ok - I'll make that change.
thanks,
-lakshmi
next prev parent reply other threads:[~2019-10-31 15:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 1:19 [PATCH v3 0/9] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 9:10 ` Sasha Levin
2019-10-31 9:10 ` Sasha Levin
2019-10-31 15:27 ` Lakshmi Ramasubramanian
2019-10-31 15:27 ` Lakshmi Ramasubramanian
2019-10-31 15:36 ` Sasha Levin
2019-10-31 15:36 ` Sasha Levin
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 15:08 ` Lakshmi Ramasubramanian [this message]
2019-10-31 15:08 ` Lakshmi Ramasubramanian
2019-10-31 15:27 ` Sasha Levin
2019-10-31 15:27 ` Sasha Levin
2019-10-31 15:37 ` Mimi Zohar
2019-10-31 15:37 ` Mimi Zohar
2019-10-31 15:42 ` Lakshmi Ramasubramanian
2019-10-31 15:42 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 2/9] KEYS: Defined functions to queue and dequeue keys for measurement Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 15:09 ` Lakshmi Ramasubramanian
2019-10-31 15:09 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 3/9] KEYS: Added KEYRING_CHECK policy for key measurement Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 1:19 ` [PATCH v3 4/9] KEYS: Updated IMA policy functions for handling " Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 12:10 ` Mimi Zohar
2019-10-31 1:19 ` [PATCH v3 5/9] KEYS: Updated ima_get_action() to return keyrings if specified in the policy Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 6/9] KEYS: Measure key if the IMA policy allows measurement for the given keyring Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 7/9] KEYS: Queue key for measurement if IMA is not yet initialized. Measure queued keys wh Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 7/9] KEYS: Queue key for measurement if IMA is not yet initialized. Measure queued keys when IMA initialization is completed Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 8/9] KEYS: Added a boolean flag for IMA initialization status Lakshmi Ramasubramanian
2019-10-31 1:19 ` Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 9/9] KEYS: Call the IMA hook to measure key when a new key is created or an existing key i Lakshmi Ramasubramanian
2019-10-31 1:19 ` [PATCH v3 9/9] KEYS: Call the IMA hook to measure key when a new key is created or an existing key is updated Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83bd7ef-ce7f-e750-e30b-30d5a6469a28@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=dhowells@redhat.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=prsriva@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.