Re: [PATCH 00/24] Optimize the hot path in the UFS driver

[John Garry <john.g.garry@oracle.com>]

On 03/04/2025 22:17, Bart Van Assche wrote:
> Hi Martin,
> 
> This patch series increases IOPS by 1% and reduces CPU per I/O by 10% on my
> UFS 4.0 test setup. Please consider this patch series for the next merge
> window.

That cover letter is a bit thin for something which now implements SCSI 
reserved command handling (in addition to any UFS optimisation).

> 
> Thanks,
> 
> Bart.
> 
> Bart Van Assche (23):
>    scsi: core: Make scsi_cmd_to_rq() accept const arguments
>    scsi: core: Make scsi_cmd_priv() accept const arguments
>    scsi: core: Use scsi_cmd_priv() instead of open-coding it
>    scsi: core: Introduce scsi_host_update_can_queue()
>    scsi: ufs: core: Change the type of one ufshcd_add_cmd_upiu_trace()
>      argument
>    scsi: ufs: core: Only call ufshcd_add_command_trace() for SCSI
>      commands
>    scsi: ufs: core: Change the type of one ufshcd_add_command_trace()
>      argument
>    scsi: ufs: core: Change the type of one ufshcd_send_command() argument
>    scsi: ufs: core: Only call ufshcd_should_inform_monitor() for SCSI
>      commands
>    scsi: ufs: core: Change the monitor function argument types
>    scsi: ufs: core: Rework ufshcd_mcq_compl_pending_transfer()
>    scsi: ufs: core: Rework ufshcd_eh_device_reset_handler()
>    scsi: ufs: core: Cache the DMA buffer sizes
>    scsi: ufs: core: Add an argument to ufshcd_mcq_decide_queue_depth()
>    scsi: ufs: core: Add an argument to ufshcd_alloc_mcq()
>    scsi: ufs: core: Call ufshcd_mcq_init() once
>    scsi: ufs: core: Allocate the SCSI host earlier
>    scsi: ufs: core: Call ufshcd_init_lrb() later
>    scsi: ufs: core: Use hba->reserved_slot
>    scsi: ufs: core: Allocate the reserved slot as a reserved request
>    scsi: ufs: core: Do not clear driver-private command data
>    scsi: ufs: core: Optimize the hot path
>    scsi: ufs: core: Remove the ufshcd_lrb task_tag member
> 
> Hannes Reinecke (1):
>    scsi: core: Implement reserved command handling
> 
>   drivers/scsi/hosts.c             |   3 +
>   drivers/scsi/scsi.c              |  26 ++
>   drivers/scsi/scsi_lib.c          |   6 +-
>   drivers/scsi/scsi_logging.c      |  10 +-
>   drivers/ufs/core/ufs-mcq.c       |  31 +-
>   drivers/ufs/core/ufshcd-crypto.h |  18 +-
>   drivers/ufs/core/ufshcd-priv.h   |  27 +-
>   drivers/ufs/core/ufshcd.c        | 660 +++++++++++++++++--------------
>   include/scsi/scsi_cmnd.h         |  17 +-
>   include/scsi/scsi_host.h         |  24 +-
>   include/ufs/ufshcd.h             |  11 +-
>   11 files changed, 487 insertions(+), 346 deletions(-)
> 
>