Re: [PATCH 12/24] scsi: ufs: core: Rework ufshcd_mcq_compl_pending_transfer()

[Bart Van Assche <bvanassche@acm.org>]

On 4/17/25 5:39 AM, Peter Wang (王信友) wrote:
> If blk_mq_rq_state(rq) state is MQ_RQ_COMPLETE, the code
> before modification would skip this tag.
> But the code after modification will execute the function(fn).
> This should cause issues, right?

Hi Peter,

My understanding is that the function modified by patch 12/24,
ufshcd_mcq_compl_pending_transfer(), is only called by the UFS error
handler. The UFS error handler is only activated after all pending
requests have completed (MQ_RQ_IDLE) or timed out (MQ_RQ_STARTED).
No requests should have the state MQ_RQ_COMPLETE when the error handler
is activated.

Thanks,

Bart.