All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev@kapio-technology.com
To: Ido Schimmel <idosch@nvidia.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Ivan Vecera <ivecera@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	bridge@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	Roopa Prabhu <roopa@nvidia.com>,
	kuba@kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Sean Wang <sean.wang@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Yuwei Wang <wangyuweihx@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
	davem@davemloft.net
Subject: Re: [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests
Date: Fri, 23 Sep 2022 14:21:25 +0200	[thread overview]
Message-ID: <bd690048460a519cd804d41be736ae40@kapio-technology.com> (raw)
In-Reply-To: <546f96aa592aec4d64bdfc45d4618c05@kapio-technology.com>

On 2022-09-23 13:34, netdev@kapio-technology.com wrote:
> On 2022-09-21 09:15, Ido Schimmel wrote:
> 
>> 	# Check blackhole entries can be replaced.
>> 	bridge fdb replace `mac_get $h2` dev $swp2 master static
>> 	bridge fdb get `mac_get $h2` br br0 | grep -q blackhole
>> 	check_fail $? "Blackhole entry found after replacement"
> 
> There seems to be a problem with replacing blackhole fdb entries as
> fdb_find_rcu() does not find the associated fdb entry (addr, vid) and
> I don't know why that is the case?

I realize that the reason why fdb_find_rcu() does not find the entry is 
surely that it is stored in the bridge device fdb and not 'master' fdb.

WARNING: multiple messages have this Message-ID (diff)
From: netdev@kapio-technology.com
To: Ido Schimmel <idosch@nvidia.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Shuah Khan <shuah@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Yuwei Wang <wangyuweihx@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	bridge@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests
Date: Fri, 23 Sep 2022 14:21:25 +0200	[thread overview]
Message-ID: <bd690048460a519cd804d41be736ae40@kapio-technology.com> (raw)
In-Reply-To: <546f96aa592aec4d64bdfc45d4618c05@kapio-technology.com>

On 2022-09-23 13:34, netdev@kapio-technology.com wrote:
> On 2022-09-21 09:15, Ido Schimmel wrote:
> 
>> 	# Check blackhole entries can be replaced.
>> 	bridge fdb replace `mac_get $h2` dev $swp2 master static
>> 	bridge fdb get `mac_get $h2` br br0 | grep -q blackhole
>> 	check_fail $? "Blackhole entry found after replacement"
> 
> There seems to be a problem with replacing blackhole fdb entries as
> fdb_find_rcu() does not find the associated fdb entry (addr, vid) and
> I don't know why that is the case?

I realize that the reason why fdb_find_rcu() does not find the entry is 
surely that it is stored in the bridge device fdb and not 'master' fdb.

WARNING: multiple messages have this Message-ID (diff)
From: netdev@kapio-technology.com
To: Ido Schimmel <idosch@nvidia.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Shuah Khan <shuah@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Yuwei Wang <wangyuweihx@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	bridge@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests
Date: Fri, 23 Sep 2022 14:21:25 +0200	[thread overview]
Message-ID: <bd690048460a519cd804d41be736ae40@kapio-technology.com> (raw)
In-Reply-To: <546f96aa592aec4d64bdfc45d4618c05@kapio-technology.com>

On 2022-09-23 13:34, netdev@kapio-technology.com wrote:
> On 2022-09-21 09:15, Ido Schimmel wrote:
> 
>> 	# Check blackhole entries can be replaced.
>> 	bridge fdb replace `mac_get $h2` dev $swp2 master static
>> 	bridge fdb get `mac_get $h2` br br0 | grep -q blackhole
>> 	check_fail $? "Blackhole entry found after replacement"
> 
> There seems to be a problem with replacing blackhole fdb entries as
> fdb_find_rcu() does not find the associated fdb entry (addr, vid) and
> I don't know why that is the case?

I realize that the reason why fdb_find_rcu() does not find the entry is 
surely that it is stored in the bridge device fdb and not 'master' fdb.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-23 12:21 UTC|newest]

Thread overview: 207+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 11:45 [Bridge] [PATCH v5 net-next 0/6] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Hans Schultz
2022-08-26 11:45 ` Hans Schultz
2022-08-26 11:45 ` Hans Schultz
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 1/6] net: bridge: add locked entry fdb flag to extend locked port feature Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-27 11:30   ` [Bridge] " Nikolay Aleksandrov
2022-08-27 11:30     ` Nikolay Aleksandrov
2022-08-27 11:30     ` Nikolay Aleksandrov
2022-08-27 13:17     ` [Bridge] " Ido Schimmel
2022-08-27 13:17       ` Ido Schimmel
2022-08-27 13:17       ` Ido Schimmel
2022-08-27 13:54       ` [Bridge] " Nikolay Aleksandrov
2022-08-27 13:54         ` Nikolay Aleksandrov
2022-08-27 13:54         ` Nikolay Aleksandrov
2022-08-28 11:24       ` [Bridge] " netdev
2022-08-28 11:24         ` netdev
2022-08-28 11:24         ` netdev
2022-08-28 11:21     ` [Bridge] " netdev
2022-08-28 11:21       ` netdev
2022-08-28 11:21       ` netdev
2022-08-29 11:09     ` [Bridge] " netdev
2022-08-29 11:09       ` netdev
2022-08-29 11:09       ` netdev
2022-08-29 11:43     ` [Bridge] " netdev
2022-08-29 11:43       ` netdev
2022-08-29 11:43       ` netdev
2022-08-29 14:02     ` [Bridge] " netdev
2022-08-29 14:02       ` netdev
2022-08-29 14:02       ` netdev
2022-08-29 16:12       ` [Bridge] " Ido Schimmel
2022-08-29 16:12         ` Ido Schimmel
2022-08-29 16:12         ` Ido Schimmel
2022-08-29 16:26         ` [Bridge] " netdev
2022-08-29 16:26           ` netdev
2022-08-29 16:26           ` netdev
2022-08-30 14:19         ` [Bridge] " netdev
2022-08-30 14:19           ` netdev
2022-08-30 14:19           ` netdev
2022-09-03 14:27           ` [Bridge] " Ido Schimmel
2022-09-03 14:27             ` Ido Schimmel
2022-09-03 14:27             ` Ido Schimmel
2022-08-27 15:19   ` [Bridge] " Ido Schimmel
2022-08-27 15:19     ` Ido Schimmel
2022-08-27 15:19     ` Ido Schimmel
2022-08-28 10:23     ` [Bridge] " netdev
2022-08-28 10:23       ` netdev
2022-08-28 10:23       ` netdev
2022-08-29  7:52       ` [Bridge] " Ido Schimmel
2022-08-29  7:52         ` Ido Schimmel
2022-08-29  7:52         ` Ido Schimmel
2022-08-29  8:04         ` [Bridge] " netdev
2022-08-29  8:04           ` netdev
2022-08-29  8:04           ` netdev
2022-08-29  9:51         ` [Bridge] " Nikolay Aleksandrov
2022-08-29  9:51           ` Nikolay Aleksandrov
2022-08-29  9:51           ` Nikolay Aleksandrov
2022-08-29  9:32     ` [Bridge] " netdev
2022-08-29  9:32       ` netdev
2022-08-29  9:32       ` netdev
2022-08-29 11:01     ` [Bridge] " netdev
2022-08-29 11:01       ` netdev
2022-08-29 11:01       ` netdev
2022-08-29 11:34     ` [Bridge] " netdev
2022-08-29 11:34       ` netdev
2022-08-29 11:34       ` netdev
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-27 15:46   ` [Bridge] " Ido Schimmel
2022-08-27 15:46     ` Ido Schimmel
2022-08-27 15:46     ` Ido Schimmel
2022-08-27 15:52     ` [Bridge] " Nikolay Aleksandrov
2022-08-27 15:52       ` Nikolay Aleksandrov
2022-08-27 15:52       ` Nikolay Aleksandrov
2022-08-28 11:27     ` [Bridge] " netdev
2022-08-28 11:27       ` netdev
2022-08-28 11:27       ` netdev
2022-08-27 18:34   ` [Bridge] " Ido Schimmel
2022-08-27 18:34     ` Ido Schimmel
2022-08-27 18:34     ` Ido Schimmel
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 4/6] net: dsa: mv88e6xxx: allow reading FID when handling ATU violations Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 5/6] net: dsa: mv88e6xxx: MacAuth/MAB implementation Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45 ` [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-26 11:45   ` Hans Schultz
2022-08-27 18:21   ` [Bridge] " Ido Schimmel
2022-08-27 18:21     ` Ido Schimmel
2022-08-27 18:21     ` Ido Schimmel
2022-08-28 12:00     ` [Bridge] " netdev
2022-08-28 12:00       ` netdev
2022-08-28 12:00       ` netdev
2022-08-29  7:40       ` [Bridge] " Ido Schimmel
2022-08-29  7:40         ` Ido Schimmel
2022-08-29  7:40         ` Ido Schimmel
2022-08-29  8:01         ` [Bridge] " netdev
2022-08-29  8:01           ` netdev
2022-08-29  8:01           ` netdev
2022-08-29 11:32           ` [Bridge] " Ido Schimmel
2022-08-29 11:32             ` Ido Schimmel
2022-08-29 11:32             ` Ido Schimmel
2022-08-29 12:04             ` [Bridge] " netdev
2022-08-29 12:04               ` netdev
2022-08-29 12:04               ` netdev
2022-08-29 14:37               ` [Bridge] " Ido Schimmel
2022-08-29 14:37                 ` Ido Schimmel
2022-08-29 14:37                 ` Ido Schimmel
2022-08-29 15:08                 ` [Bridge] " netdev
2022-08-29 15:08                   ` netdev
2022-08-29 15:08                   ` netdev
2022-08-29 16:03                   ` [Bridge] " Ido Schimmel
2022-08-29 16:03                     ` Ido Schimmel
2022-08-29 16:03                     ` Ido Schimmel
2022-08-29 16:13                     ` [Bridge] " netdev
2022-08-29 16:13                       ` netdev
2022-08-29 16:13                       ` netdev
2022-09-03 14:47                       ` [Bridge] " Ido Schimmel
2022-09-03 14:47                         ` Ido Schimmel
2022-09-03 14:47                         ` Ido Schimmel
2022-09-07 21:10                         ` [Bridge] " netdev
2022-09-07 21:10                           ` netdev
2022-09-07 21:10                           ` netdev
2022-09-08  7:59                           ` [Bridge] " Ido Schimmel
2022-09-08  7:59                             ` Ido Schimmel
2022-09-08  7:59                             ` Ido Schimmel
2022-09-08 11:14                             ` [Bridge] " netdev
2022-09-08 11:14                               ` netdev
2022-09-08 11:14                               ` netdev
2022-09-08 11:20                               ` [Bridge] " Vladimir Oltean
2022-09-08 11:20                                 ` Vladimir Oltean
2022-09-08 11:20                                 ` Vladimir Oltean
2022-09-09 13:11                                 ` [Bridge] " netdev
2022-09-09 13:11                                   ` netdev
2022-09-09 13:11                                   ` netdev
2022-09-11  0:13                                   ` [Bridge] " Vladimir Oltean
2022-09-11  0:13                                     ` Vladimir Oltean
2022-09-11  0:13                                     ` Vladimir Oltean
2022-09-11  9:23                                     ` [Bridge] " netdev
2022-09-11  9:23                                       ` netdev
2022-09-11  9:23                                       ` netdev
2022-09-12  9:08                                       ` [Bridge] " Ido Schimmel
2022-09-12  9:08                                         ` Ido Schimmel
2022-09-12  9:08                                         ` Ido Schimmel
2022-09-20 21:29                                         ` [Bridge] " netdev
2022-09-20 21:29                                           ` netdev
2022-09-20 21:29                                           ` netdev
2022-09-21  7:15                                           ` [Bridge] " Ido Schimmel
2022-09-21  7:15                                             ` Ido Schimmel
2022-09-21  7:15                                             ` Ido Schimmel
2022-09-22 20:35                                             ` [Bridge] " netdev
2022-09-22 20:35                                               ` netdev
2022-09-22 20:35                                               ` netdev
2022-09-27 15:19                                               ` [Bridge] " Petr Machata
2022-09-27 15:19                                                 ` Petr Machata
2022-09-27 15:19                                                 ` Petr Machata
2022-09-23 11:34                                             ` netdev
2022-09-23 11:34                                               ` netdev
2022-09-23 11:34                                               ` netdev
2022-09-23 12:21                                               ` netdev [this message]
2022-09-23 12:21                                                 ` netdev
2022-09-23 12:21                                                 ` netdev
2022-09-23 12:01                                             ` [Bridge] " netdev
2022-09-23 12:01                                               ` netdev
2022-09-23 12:01                                               ` netdev
2022-09-27  8:33                                             ` [Bridge] " netdev
2022-09-27  8:33                                               ` netdev
2022-09-27  8:33                                               ` netdev
2022-09-28  6:59                                               ` [Bridge] " Ido Schimmel
2022-09-28  6:59                                                 ` Ido Schimmel
2022-09-28  6:59                                                 ` Ido Schimmel
2022-09-28  7:29                                                 ` [Bridge] " netdev
2022-09-28  7:29                                                   ` netdev
2022-09-28  7:29                                                   ` netdev
2022-09-28  7:47                                                 ` [Bridge] " netdev
2022-09-28  7:47                                                   ` netdev
2022-09-28  7:47                                                   ` netdev
2022-09-28  8:46                                                   ` [Bridge] " Ido Schimmel
2022-09-28  8:46                                                     ` Ido Schimmel
2022-09-28  8:46                                                     ` Ido Schimmel
2022-09-28 10:16                                                     ` [Bridge] " netdev
2022-09-28 10:16                                                       ` netdev
2022-09-28 10:16                                                       ` netdev
2022-09-28 10:19                                                     ` [Bridge] " netdev
2022-09-28 10:19                                                       ` netdev
2022-09-28 10:19                                                       ` netdev
2022-09-29 22:26                                                     ` [Bridge] " netdev
2022-09-29 22:26                                                       ` netdev
2022-09-29 22:26                                                       ` netdev
2022-09-21 19:53                                         ` [Bridge] " netdev
2022-09-21 19:53                                           ` netdev
2022-09-21 19:53                                           ` netdev
2022-08-29  8:55         ` [Bridge] " netdev
2022-08-29  8:55           ` netdev
2022-08-29  8:55           ` netdev
2022-08-29 16:07     ` [Bridge] " netdev
2022-08-29 16:07       ` netdev
2022-08-29 16:07       ` netdev
2022-09-03 14:49       ` [Bridge] " Ido Schimmel
2022-09-03 14:49         ` Ido Schimmel
2022-09-03 14:49         ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd690048460a519cd804d41be736ae40@kapio-technology.com \
    --to=netdev@kapio-technology.com \
    --cc=Landen.Chao@mediatek.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=idosch@nvidia.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=sean.wang@mediatek.com \
    --cc=shuah@kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=wangyuweihx@gmail.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.