All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Baokun Li <libaokun1@huawei.com>, linux-erofs@lists.ozlabs.org
Cc: brauner@kernel.org, yangerkun@huawei.com,
	linux-kernel@vger.kernel.org, huyue2@coolpad.com,
	viro@zeniv.linux.org.uk
Subject: Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context
Date: Tue, 23 Apr 2024 18:37:42 +0800	[thread overview]
Message-ID: <be205197-91c8-4937-bfce-5ae5520128ea@linux.alibaba.com> (raw)
In-Reply-To: <20240419123611.947084-2-libaokun1@huawei.com>



On 2024/4/19 20:36, Baokun Li wrote:
> Instead of allocating the erofs_sb_info in fill_super() allocate it during
> erofs_init_fs_context() and ensure that erofs can always have the info
> available during erofs_kill_sb(). After this erofs_fs_context is no longer
> needed, replace ctx with sbi, no functional changes.
> 
> Suggested-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Thanks, it looks good to me, let's see how it behaves after applying
to -next.

Thanks,
Gao Xiang

WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Baokun Li <libaokun1@huawei.com>, linux-erofs@lists.ozlabs.org
Cc: xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com,
	jefflexu@linux.alibaba.com, viro@zeniv.linux.org.uk,
	brauner@kernel.org, linux-kernel@vger.kernel.org,
	yangerkun@huawei.com, houtao1@huawei.com
Subject: Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context
Date: Tue, 23 Apr 2024 18:37:42 +0800	[thread overview]
Message-ID: <be205197-91c8-4937-bfce-5ae5520128ea@linux.alibaba.com> (raw)
In-Reply-To: <20240419123611.947084-2-libaokun1@huawei.com>



On 2024/4/19 20:36, Baokun Li wrote:
> Instead of allocating the erofs_sb_info in fill_super() allocate it during
> erofs_init_fs_context() and ensure that erofs can always have the info
> available during erofs_kill_sb(). After this erofs_fs_context is no longer
> needed, replace ctx with sbi, no functional changes.
> 
> Suggested-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Thanks, it looks good to me, let's see how it behaves after applying
to -next.

Thanks,
Gao Xiang

  parent reply	other threads:[~2024-04-23 10:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 12:36 [PATCH -next v3 0/2] erofs: reliably distinguish block based and fscache mode Baokun Li via Linux-erofs
2024-04-19 12:36 ` Baokun Li
2024-04-19 12:36 ` [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context Baokun Li via Linux-erofs
2024-04-19 12:36   ` Baokun Li
2024-04-22 10:25   ` Jingbo Xu
2024-04-22 10:25     ` Jingbo Xu
2024-04-22 11:31     ` Baokun Li via Linux-erofs
2024-04-22 11:31       ` Baokun Li
2024-04-22 11:39       ` Jingbo Xu
2024-04-22 11:39         ` Jingbo Xu
2024-04-23 10:37   ` Gao Xiang [this message]
2024-04-23 10:37     ` Gao Xiang
2024-04-28  7:10   ` Gao Xiang
2024-04-28  7:10     ` Gao Xiang
2024-04-28 10:00   ` Chao Yu
2024-04-28 10:00     ` Chao Yu
2024-04-19 12:36 ` [PATCH -next v3 2/2] erofs: reliably distinguish block based and fscache mode Baokun Li via Linux-erofs
2024-04-19 12:36   ` Baokun Li
2024-04-22 11:52   ` Jingbo Xu
2024-04-22 11:52     ` Jingbo Xu
2024-04-28  7:17   ` Gao Xiang
2024-04-28  7:17     ` Gao Xiang
2024-04-28 10:03   ` Chao Yu
2024-04-28 10:03     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be205197-91c8-4937-bfce-5ae5520128ea@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=huyue2@coolpad.com \
    --cc=libaokun1@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yangerkun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.