From: Ping-Ke Shih <pkshih@realtek.com>
To: Arsenii Pashchenko <ulijg308@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v7 3/3] wifi: rtw88: rtw8822c: Replace custom DAC IQ sorting with kernel sort
Date: Fri, 28 Aug 2026 08:24:09 +0000 [thread overview]
Message-ID: <befda2079a1f4201b8f0ae3eeacb76bc@realtek.com> (raw)
In-Reply-To: <7d0ab2352317b81df10dca7ddb3e855a303b8be7.1787895379.git.ulijg308@gmail.com>
Arsenii Pashchenko <ulijg308@gmail.com> wrote:
> Replace the custom, nested bubble-sort logic in the calibration loop
> with direct calls to the kernel's optimized heapsort implementation
> inside rtw8822c_dac_cal_iq_search().
>
> Implement a safe, overflow-proof s32 comparator using the subtraction
> of relationals pattern. Since the input values are already properly
> sign-extended into signed arrays, the custom circular index sorting
> rules and helper functions completely disappear, reducing lines of code.
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>
I guess v7 has no change from v6. Please remember take my acked-by.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
prev parent reply other threads:[~2026-08-28 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 5:40 [PATCH rtw-next v7 0/3] wifi: rtw88: rtw8822c: refactor DAC IQ calibration to s32 Arsenii Pashchenko
2026-08-28 5:40 ` [PATCH rtw-next v7 1/3] wifi: rtw88: rtw8822c: Use bitfield macros for DAC IQ sampling Arsenii Pashchenko
2026-08-28 8:23 ` Ping-Ke Shih
2026-08-28 5:40 ` [PATCH rtw-next v7 2/3] wifi: rtw88: rtw8822c: Convert DAC IQ calibration path to signed math Arsenii Pashchenko
2026-08-28 8:29 ` Ping-Ke Shih
2026-08-28 5:40 ` [PATCH rtw-next v7 3/3] wifi: rtw88: rtw8822c: Replace custom DAC IQ sorting with kernel sort Arsenii Pashchenko
2026-08-28 8:24 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befda2079a1f4201b8f0ae3eeacb76bc@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulijg308@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.