All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Arsenii Pashchenko <ulijg308@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v7 1/3] wifi: rtw88: rtw8822c: Use bitfield macros for DAC IQ sampling
Date: Fri, 28 Aug 2026 08:23:01 +0000	[thread overview]
Message-ID: <d4ae3cda5aae435d97f5b5e3a27d446d@realtek.com> (raw)
In-Reply-To: <e4c9ff204ce4d6901da97a83b11dce1bd42f6b21.1787895379.git.ulijg308@gmail.com>

Arsenii Pashchenko <ulijg308@gmail.com> wrote:
> Define proper GENMASK constants for the In-phase (I) and Quadrature
> (Q) components of the DAC IQ data register in the header file.
> Replace manual bit shifting, masking, and rtw_read32_mask() with
> standard rtw_read32() and the FIELD_GET() macro to improve code
> readability.
> 
> Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>

I suppose you don't have change from v6 to v7, so just take
my acked-by?

Acked-by: Ping-Ke Shih <pkshih@realtek.com>





  reply	other threads:[~2026-08-28  8:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  5:40 [PATCH rtw-next v7 0/3] wifi: rtw88: rtw8822c: refactor DAC IQ calibration to s32 Arsenii Pashchenko
2026-08-28  5:40 ` [PATCH rtw-next v7 1/3] wifi: rtw88: rtw8822c: Use bitfield macros for DAC IQ sampling Arsenii Pashchenko
2026-08-28  8:23   ` Ping-Ke Shih [this message]
2026-08-28  5:40 ` [PATCH rtw-next v7 2/3] wifi: rtw88: rtw8822c: Convert DAC IQ calibration path to signed math Arsenii Pashchenko
2026-08-28  8:29   ` Ping-Ke Shih
2026-08-28  5:40 ` [PATCH rtw-next v7 3/3] wifi: rtw88: rtw8822c: Replace custom DAC IQ sorting with kernel sort Arsenii Pashchenko
2026-08-28  8:24   ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ae3cda5aae435d97f5b5e3a27d446d@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ulijg308@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.