[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2124 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

            Bug ID: 102014
           Summary: Mesa git build broken by commit
                    bc7f41e11d325280db12e7b9444501357bc13922
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: marko.skender@protonmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Hello,

Current git build is seemingly broken by:

[  511s] pipe_radeonsi.c: In function 'create_screen':
[  511s] pipe_radeonsi.c:15:34: error: 'flags' undeclared (first use in this
function); did you mean 'fabs'?
[  511s]     rw = amdgpu_winsys_create(fd, flags, radeonsi_screen_create);
[  511s]                                   ^~~~~
[  511s]                                   fabs
[  511s] pipe_radeonsi.c:15:34: note: each undeclared identifier is reported
only once for each function it appears in
[  511s] make[4]: *** [Makefile:996: pipe_radeonsi.lo] Error 1
[  511s] make[4]: *** Waiting for unfinished jobs....
[  511s] pipe_r600.c: In function 'create_screen':
[  511s] pipe_r600.c:12:38: error: 'flags' undeclared (first use in this
function); did you mean 'fabs'?
[  511s]     rw = radeon_drm_winsys_create(fd, flags, r600_screen_create);
[  511s]                                       ^~~~~
[  511s]                                       fabs
[  511s] pipe_r600.c:12:38: note: each undeclared identifier is reported only
once for each function it appears in
[  511s] pipe_r300.c: In function 'create_screen':
[  511s] pipe_r300.c:12:39: error: 'flags' undeclared (first use in this
function); did you mean 'fabs'?
[  511s]     sws = radeon_drm_winsys_create(fd, flags, r300_screen_create);
[  511s]                                        ^~~~~
[  511s]                                        fabs

Regards,
Marko

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3500 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #1 from Marko <marko.skender@protonmail.com> ---
Created attachment 133196
  --> https://bugs.freedesktop.org/attachment.cgi?id=133196&action=edit
Patch #1 to fix build

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #2 from Marko <marko.skender@protonmail.com> ---
Created attachment 133197
  --> https://bugs.freedesktop.org/attachment.cgi?id=133197&action=edit
Patch #2 to fix build

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #3 from Marko <marko.skender@protonmail.com> ---
Created attachment 133198
  --> https://bugs.freedesktop.org/attachment.cgi?id=133198&action=edit
Patch #3 to fix build

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #4 from Emil Velikov <emil.l.velikov@gmail.com> ---
Thanks for the report Marko.

Can you please squash these three patches (analogous to the offending commit)
and send the patch to the list - see
https://www.mesa3d.org/submittingpatches.html for details.

One small correction - one should get the flags from config->flags.

Please include the following in the commit message:

Cc: Nicolai Hähnle <nicolai.haehnle@amd.com>
Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create
functions")

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1632 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #5 from Nicolai Hähnle <nhaehnle@gmail.com> ---
*sigh*

This has not been a good week for me.

Please see https://patchwork.freedesktop.org/patch/170007/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 384 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

Vinson Lee <vlee@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1116 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

Vinson Lee <vlee@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedretti.fabio@gmail.com

--- Comment #6 from Vinson Lee <vlee@freedesktop.org> ---
*** Bug 102016 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2137 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 983 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

Marko <marko.skender@protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133196|0                           |1
        is obsolete|                            |
 Attachment #133197|0                           |1
        is obsolete|                            |
 Attachment #133198|0                           |1
        is obsolete|                            |

--- Comment #7 from Marko <marko.skender@protonmail.com> ---
Created attachment 133223
  --> https://bugs.freedesktop.org/attachment.cgi?id=133223&action=edit
Fixes build for current Mesa-git

Hi guys,

I've generated a single patch which currently builds successfully on commit    
d5ba75f8881f0869dc16f71f7395514c0a35b6e2


Ragards,

Marko

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2804 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 363 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

--- Comment #8 from Andy Furniss <adf.lists@gmail.com> ---
Also see this thread = there are more fixes needed to avoid issues after the
build is fixed.

https://lists.freedesktop.org/archives/mesa-dev/2017-August/165195.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1278 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102014] Mesa git build broken by commit bc7f41e11d325280db12e7b9444501357bc13922

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102014

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Nicolai Hähnle <nhaehnle@gmail.com> ---
The build should be fixed again with commit
33f7d71d5358337f08ce0bb94f5e915bda77748c, so closing this bug. (Note additional
patches are on their way which are required if you build only OpenCL.)

FYI, there are also segfaults, which should be fixed by this series:
https://patchwork.freedesktop.org/series/28311/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2449 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel