From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition
Date: Mon, 21 Aug 2017 16:56:02 +0000 [thread overview]
Message-ID: <bug-102342-502@http.bugs.freedesktop.org/> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=102342
Bug ID: 102342
Summary: mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.
c:169]: (style) Suspicious condition
Product: Mesa
Version: 17.1
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/radeonsi
Assignee: dri-devel@lists.freedesktop.org
Reporter: dcb314@hotmail.com
QA Contact: dri-devel@lists.freedesktop.org
mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style)
Suspicious condition (assignment + comparison); Clarify expression with
parentheses.
Source code is
if (!entry && (ret = pb_cache_is_buffer_compat(cur_entry, size,
alignment, usage) > 0))
maybe better code
if (!entry && ((ret = pb_cache_is_buffer_compat(cur_entry, size,
alignment, usage)) > 0))
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2590 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-08-21 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 16:56 bugzilla-daemon [this message]
2018-04-03 6:09 ` [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-102342-502@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.