* [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition
@ 2017-08-21 16:56 bugzilla-daemon
2018-04-03 6:09 ` bugzilla-daemon
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon @ 2017-08-21 16:56 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=102342
Bug ID: 102342
Summary: mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.
c:169]: (style) Suspicious condition
Product: Mesa
Version: 17.1
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/radeonsi
Assignee: dri-devel@lists.freedesktop.org
Reporter: dcb314@hotmail.com
QA Contact: dri-devel@lists.freedesktop.org
mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style)
Suspicious condition (assignment + comparison); Clarify expression with
parentheses.
Source code is
if (!entry && (ret = pb_cache_is_buffer_compat(cur_entry, size,
alignment, usage) > 0))
maybe better code
if (!entry && ((ret = pb_cache_is_buffer_compat(cur_entry, size,
alignment, usage)) > 0))
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2590 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread* [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition 2017-08-21 16:56 [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition bugzilla-daemon @ 2018-04-03 6:09 ` bugzilla-daemon 0 siblings, 0 replies; 2+ messages in thread From: bugzilla-daemon @ 2018-04-03 6:09 UTC (permalink / raw) To: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 1133 bytes --] https://bugs.freedesktop.org/show_bug.cgi?id=102342 Timothy Arceri <t_arceri@yahoo.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Timothy Arceri <t_arceri@yahoo.com.au> --- Thanks for reporting this. Fixed by: commit 7e9b7ec094500f1245eed518592f99244e54a753 (HEAD -> master, origin/master, origin/HEAD) Author: Timothy Arceri <tarceri@itsqueeze.com> Date: Sun Apr 1 09:32:28 2018 +1000 gallium/pipebuffer: fix parenthesis location Without this the return value will never get set to -1. This was first added in 49866c8f3457 and copied in 2b396eeed983. Fixes: 2b396eeed983 "gallium/pb_cache: add a copy of cache bufmgr independent of pb_manager" Reviewed-by: Marek Olšák <marek.olsak@amd.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102342 -- You are receiving this mail because: You are the assignee for the bug. [-- Attachment #1.2: Type: text/html, Size: 3112 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-03 6:09 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-08-21 16:56 [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition bugzilla-daemon 2018-04-03 6:09 ` bugzilla-daemon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.