[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

            Bug ID: 107012
           Summary: [PATCH] Radeon SI driver not architecture safe,
                    crashes on ppc64[el]
           Product: Mesa
           Version: git
          Hardware: PowerPC
                OS: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: tpearson@raptorengineering.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 140294
  --> https://bugs.freedesktop.org/attachment.cgi?id=140294&action=edit
Fix crashes

color_interp_vgpr_index was declared as a generic char value.  Because signed
values are used in this variable, the result was not safe across architectures
and crashed on ppc64[el] and arm systems.

The atttached patch declares color_interp_vgpr_index as a signed type, and has
been verified to work with alien-arena, glxgears, and Flightgear, all of which
were crashing before the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2747 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 715 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #1 from Simon McVittie <smcv@collabora.com> ---
Comment on attachment 140294
  --> https://bugs.freedesktop.org/attachment.cgi?id=140294
Fix crashes

Review of attachment 140294:
-----------------------------------------------------------------

::: src/gallium/drivers/radeonsi/si_shader.h
@@ +507,4 @@
>  		unsigned	ancillary_vgpr_index:5;
>  		unsigned	wqm:1;
>  		char		color_attr_index[2];
> +		signed		color_interp_vgpr_index[2]; /* -1 == constant */

Shouldn't this be a signed char, to make the size of the struct the same on all
architectures?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2078 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #2 from Simon McVittie <smcv@collabora.com> ---
(In reply to Simon McVittie from comment #1)
> Shouldn't this be a signed char, to make the size of the struct the same on
> all architectures?

I should have said: to make the size of this field the same as it used to be,
and make the effective type on all architectures the same as it always was on
x86. (char with no signedness qualifier is the same as signed char on most
architectures, but is the same as unsigned char on at least the powerpc
family.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1556 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 514 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #3 from Timothy Pearson <tpearson@raptorengineering.com> ---
Comment on attachment 140294
  --> https://bugs.freedesktop.org/attachment.cgi?id=140294
Fix crashes

Review of attachment 140294:
-----------------------------------------------------------------

I wasn't sure how you guys wanted it done; I can resubmit as signed char if
desired no problem. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1834 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

Timothy Pearson <tpearson@raptorengineering.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140294|0                           |1
        is obsolete|                            |

--- Comment #4 from Timothy Pearson <tpearson@raptorengineering.com> ---
Created attachment 140295
  --> https://bugs.freedesktop.org/attachment.cgi?id=140295&action=edit
Fix crashes

Re-upload with signed char used.  Not yet tested.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 260 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #5 from Timothy Pearson <tpearson@raptorengineering.com> ---
Confirm that latest patch works on a Radeon RX 470.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1095 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 275 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
Please send patches like this directly to the mesa-dev mailing list for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1097 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 484 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #7 from Timothy Pearson <tpearson@raptorengineering.com> ---
(In reply to Michel Dänzer from comment #6)
> Please send patches like this directly to the mesa-dev mailing list for
> review.

Patch has been sent.  I don't monitor mesa-dev, so please address any concerns
directly to the Email address the patch came from.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1393 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 565 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

Emil Velikov <emil.l.velikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Emil Velikov <emil.l.velikov@gmail.com> ---
The fix was merged as e1621fda84d92f154b19c5bf9562ee6963414399

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel