[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2281 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

            Bug ID: 107990
           Summary: Got Dying Light working in Arch by changing Mesa's
                    compile steps, how to get it working Out Of the Box?
           Product: Mesa
           Version: 18.2
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: john.ettedgui@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Hello,

I've been looking for a while on how to get DL running on Arch and I finally
found it.

Now I'd like this to be possible by default, but I don't know if the issue lies
in Arch or Mesa and I'm hopeful someone here will be able to help.

Arch's default compiler flags are:

CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
-fno-plt"
CXXFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
-fno-plt"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"

"-fno-plt" in C/CXXFLAGS and ",-z,now" in LDFLAGS need to be unset when
compiling Mesa to get DL to not crash.

The other change required is to not use glvnd, with "-D glvnd=false". I tried
building libglvnd with the same flags as Mesa, or none at all, but it didn't
help.

Here's the original 18.2.0 PKGBUILD in case it helps:
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa

The behavior is the same with Mesa 18.2.0 or master, with LLVM 6.0 or master.
I haven't tried with autoconf though, only Meson, but I can try if you think
it'd be helpful.

I don't have any helpful log, as the game segfaults without these, a backtrace
in gdb doesn't show me anything useful, and there's nothing in dmesg.

I'm using a 280X but people with 5xx seem to have the same behavior, so I don't
think it depends on the model. We're all on amdgpu.

I'd be happy to try / provide whatever would help.

Current versions: Linux 4.18.8, GCC 8.2.1, glibc 2.28, but it failed in
previous ones too.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3846 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 261 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #1 from John <john.ettedgui@gmail.com> ---
I had someone else try this, and it worked for him as well with a 580.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1148 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 475 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #2 from Timothy Arceri <t_arceri@yahoo.com.au> ---
When you say working I assume you mean it no longer crashes at start up?

Have you reported this to the packages of Mesa on Arch?

fno-plt is a gcc optimisation flag that is not applied to Mesa by default,
issues with this option should be reported to distro maintainers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1370 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1021 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #3 from John <john.ettedgui@gmail.com> ---
> When you say working I assume you mean it no longer crashes at start up?

Correct, sorry about the lack of clarity.
It still takes quite a while on the black screen with the white line, but it
eventually passes it and goes in game.

> Have you reported this to the packages of Mesa on Arch?

> fno-plt is a gcc optimisation flag that is not applied to Mesa by default, issues with this option should be reported to distro maintainers.

I have not yet, because I am not convinced about the distribution reverting
compile flags when a single proprietary game does not run with them; but if you
think I should, I'll do it right now (https://bugs.archlinux.org/task/60130).

That leaves the the glvnd issue, which of course might be because of the same
flags applied to I don't know which other package.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2053 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 602 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #4 from Thomas Crider <gloriouseggroll@gmail.com> ---
Just an update on this, you don't need to change Arch's compiler flags.
I compiled mesa with the default flags and used glvnd=false, then used
LD_PRELOAD for just libGL.so.1.2.0 and libglapi.so.0.0.0 and the game ran. I
was able to copy just those two alone to the Dying Light install directory and
LD_PRELOAD them from the directory. The problem is definitely an issue with
glvnd and mesa-libgl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1500 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 756 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #5 from Timothy Arceri <t_arceri@yahoo.com.au> ---
(In reply to Thomas Crider from comment #4)
> Just an update on this, you don't need to change Arch's compiler flags.
> I compiled mesa with the default flags and used glvnd=false, then used
> LD_PRELOAD for just libGL.so.1.2.0 and libglapi.so.0.0.0 and the game ran. I
> was able to copy just those two alone to the Dying Light install directory
> and LD_PRELOAD them from the directory. The problem is definitely an issue
> with glvnd and mesa-libgl

Still seem like some kind of distro issue as Fedora uses glvnd and I don't have
any issue here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1737 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 522 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

Timothy Arceri <t_arceri@yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |henrik.holst2@gmail.com

--- Comment #6 from Timothy Arceri <t_arceri@yahoo.com.au> ---
*** Bug 106287 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2692 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #7 from Aurryon Schwartz <social@staraurryon.com> ---
Good evening everyone,

I'm having the same problem as mentioned and disabling glvnd in the build
process prevented the segfault during the loading time of DL.

Here are my specs:
- Radeon WX 3100
- Vega 64 (used with DRI_PRIME env)
- Ubuntu 18.10

Glxinfo:

OpenGL renderer string: Radeon RX Vega (VEGA10, DRM 3.27.0,
4.19.4-041904-lowlatency, LLVM 8.0.0)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 19.0.0-devel -
padoka PPA
OpenGL core profile shading language version string: 4.50

Default Ubuntu 18.10 compile flags:
staraurryon@Aurryon-Desktop:~$ dpkg-buildflags 
CFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=. -fstack-protector-strong
-Wformat -Werror=format-security
CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2
CXXFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=. -fstack-protector-strong
-Wformat -Werror=format-security
FCFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=. -fstack-protector-strong
FFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=. -fstack-protector-strong
GCJFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=. -fstack-protector-strong
LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro
OBJCFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=.
-fstack-protector-strong -Wformat -Werror=format-security
OBJCXXFLAGS=-g -O2 -fdebug-prefix-map=/home/staraurryon=.
-fstack-protector-strong -Wformat -Werror=format-security

Additional build flags in debian/rules:
ifeq (,$(filter $(DEB_HOST_ARCH), armhf sh3 sh4))
buildflags = \
        $(shell DEB_CFLAGS_MAINT_APPEND=-Wall DEB_CXXFLAGS_MAINT_APPEND=-Wall
dpkg-buildflags --export=configure)
else
  ifneq (,$(filter $(DEB_HOST_ARCH), armhf))
  # Workaround for a variant of LP: #725126
  buildflags = \
        $(shell DEB_CFLAGS_MAINT_APPEND="-Wall -fno-optimize-sibling-calls"
DEB_CXXFLAGS_MAINT_APPEND="-Wall -fno-optimize-sibling-calls" dpkg-buildflags
--export=configure)
  else
  # Workaround for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83143
  buildflags = \
        $(shell DEB_CFLAGS_MAINT_APPEND="-Wall -O1"
DEB_CXXFLAGS_MAINT_APPEND="-Wall -O1" dpkg-buildflags --export=configure)
  endif
endif

I also tried to disable -Wl,-Bsymbolic-functions but without success as it was
not mentioned in RedHat build documentation.

If you have any comment on my infos, please don't hesitate.
I have started to investigate Fedora build flags as @Timothy Arceri mentioned
that there was no issue in Fedora.

GL HF

Regards,
Aurryon

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3703 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 3517 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

John Brooks <bugs.freedesktop@fastquake.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.freedesktop@fastquake.
                   |                            |com

--- Comment #8 from John Brooks <bugs.freedesktop@fastquake.com> ---
Created attachment 143165
  --> https://bugs.freedesktop.org/attachment.cgi?id=143165&action=edit
LD_PRELOAD shim

I have investigated the issue and found the cause of the problem.

First, some background. The game uses __GLEW_EXT_direct_state_access to detect
whether the EXT_direct_state_access OpenGL extension is available. In
experimental mode (glewExperimental=GL_TRUE), GLEW implements those macros by
calling glXGetProcAddress() for every function that an extension is supposed to
provide. If the driver returns non-NULL for every function in that set, then
the macro evaluates to true. And if the macro evaluates to true, then the game
will use EXT_direct_state_access functions such as glMapNamedBufferRangeEXT.

Mesa does not implement EXT_direct_state_access, and returns NULL when its
functions are queried with GetProcAddress(). GLVND, however, provides stubs for
all OpenGL functions, and returns the stub in glXGetProcAddress(). The stub
will eventually end up calling out to the vendor's (Mesa's) implementation of
the function when a context is created and the vendor becomes known. The upshot
of this is that glvnd will return a stub for every function in
EXT_direct_state_access, leading the GLEW macro to return true, and the game
will attempt to use those extension functions.

The trouble begins when the game tries to use glMapNamedBufferRangeEXT(). This
function is supposed to return a pointer to a memory area that maps to an
OpenGL buffer. Since Mesa does not implement EXT_direct_state_access, the GLVND
stub for glMapNamedBufferRangeEXT remains a no-op, and the return value is
undefined. The game tries to write to the pointer that is returned (which of
course is not valid as the function was a no-op), and it segfaults.

I brought this up in #dri-devel, and imirkin pointed me to this page
(https://dri.freedesktop.org/wiki/glXGetProcAddressNeverReturnsNULL/) which
explains that checking for NULL from glXGetProcAddress is not a reliable way to
determine if a function is supported. GLEW's experimental mode is doing this
and reporting that extensions are supported when they are not. The reason this
happens with GLVND and not Mesa alone is because Mesa alone returns NULL for
these functions. With Mesa alone, the game calls glMapNamedBufferRange instead
of glMapNamedBufferRangeEXT, which is just fine because Mesa implements the
former.

I'm not sure what to do to fix this at the driver level without being too
hacky. I've attached code for an LD_PRELOAD shim, it should be very simple to
compile (see comments in the file). This isn't ideal as it requires end users
to find and compile this, but it's something for now. The game's developers
could fix it by setting glewExperimental to GL_FALSE or improving their logic
for deciding when to use EXT_direct_state_access. Or maybe not using it at all,
since I'm not really sure what the point of using that extension is anyway,
even if it is available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 5181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #9 from Timothy Arceri <t_arceri@yahoo.com.au> ---
Thanks for investigating. The brute force fix is to finish implementing
EXT_direct_state_access. I have a partial implementation here which is able to
run Doom and Wolfenstein with this extension enabled[1].

Implementing the feature in Mesa shouldn't be all that difficult. The hardest
part will be writing all the piglit tests before this will be accepted in Mesa.
Currently I don't see myself working on this anytime in the near future, so
anyone is free to try pick this up. 

[1] https://gitlab.freedesktop.org/tarceri/mesa/commits/EXT_direct_state_access

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1753 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #10 from John <john.ettedgui@gmail.com> ---
Hey Timothy,

is this something fairly easy to get into for someone with no knowledge of
OpenGL or Mesa (I've had a patch 5 years ago, so pretty much the same as no
knowledge)? If so, unless John wants to do it, I would be willing to try.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1322 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1002 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #11 from Timothy Arceri <t_arceri@yahoo.com.au> ---
(In reply to John from comment #10)
> Hey Timothy,
> 
> is this something fairly easy to get into for someone with no knowledge of
> OpenGL or Mesa (I've had a patch 5 years ago, so pretty much the same as no
> knowledge)? If so, unless John wants to do it, I would be willing to try.

It will mean a lot of reading/learning but I think much of the extension could
be implemented by someone with no previous OpenGL knowledge. A bunch of the
support already exists due to ARB_direct_state_access being supported in Mesa,
things just need to be adjusted to the differences in the specs. Again the
harder part is probably writing all tests.

The extension is quite large as it touches a load of different features so it's
definitely something that could be shared across multiple developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1982 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

--- Comment #12 from Timothy Arceri <t_arceri@yahoo.com.au> ---
A bunch of EXT_direct_state_access function have now been implemented in mesa
master, it's likely that Dying Light now works. Would be good if someone can
give it a test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1268 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107990

John <john.ettedgui@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from John <john.ettedgui@gmail.com> ---
Yup that worked, thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2168 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel