[Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

[Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1457 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109060

            Bug ID: 109060
           Summary: android-x86 64bit builds crashes due to
                    android/gralloc_handle.h
           Product: DRI
           Version: DRI git
          Hardware: x86-64 (AMD64)
                OS: other
            Status: NEW
          Severity: blocker
          Priority: medium
         Component: libdrm
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: issor.oruam@gmail.com

Created attachment 142809
  --> https://bugs.freedesktop.org/attachment.cgi?id=142809&action=edit
draft patch that solves the crashes

Hi,
there is a series of Android apps using 32bit libs on 64bit Android that are
crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark
benchmarks and many others)

The cause is the difference in size of gralloc handle structs created by 32bit
libraries and 64bit architetures libraries.

The problem was observed and patched in gbm_gralloc in the past by Chih-Wei
Huang, but it was not taken into account in later evolution,
now with android/gralloc_handle.h in libdrm the problem is again present,
because the handle sizes in 32bit and 64bit are again different.

The attached draft patch solves the issue, tested on all apps that were
crashing
Please review and provide feedback

Mauro

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2996 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

[Robert Foss]

Hey Chih-Wei & Mauro,

This fix looks good to me.
Cleaned up patch name and pushed to repo.


Rob.

On 2018-12-14 01:05, bugzilla-daemon@freedesktop.org wrote:
> Bug ID 	109060 <https://bugs.freedesktop.org/show_bug.cgi?id=109060>
> Summary 	android-x86 64bit builds crashes due to android/gralloc_handle.h
> Product 	DRI
> Version 	DRI git
> Hardware 	x86-64 (AMD64)
> OS 	other
> Status 	NEW
> Severity 	blocker
> Priority 	medium
> Component 	libdrm
> Assignee 	dri-devel@lists.freedesktop.org
> Reporter 	issor.oruam@gmail.com
> 
> Createdattachment 142809 <attachment.cgi?id=142809> [details] 
> <attachment.cgi?id=142809&action=edit>  [review]  <page.cgi?id=splinter.html&bug=109060&attachment=142809>
> draft patch that solves the crashes
> 
> Hi,
> there is a series of Android apps using 32bit libs on 64bit Android that are
> crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark
> benchmarks and many others)
> 
> The cause is the difference in size of gralloc handle structs created by 32bit
> libraries and 64bit architetures libraries.
> 
> The problem was observed and patched in gbm_gralloc in the past by Chih-Wei
> Huang, but it was not taken into account in later evolution,
> now with android/gralloc_handle.h in libdrm the problem is again present,
> because the handle sizes in 32bit and 64bit are again different.
> 
> The attached draft patch solves the issue, tested on all apps that were
> crashing
> Please review and provide feedback
> 
> Mauro
> 
> --------------------------------------------------------------------------------
> You are receiving this mail because:
> 
>   * You are the assignee for the bug.
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109060

Emil Velikov <emil.l.velikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Emil Velikov <emil.l.velikov@gmail.com> ---
Seems like Rob pushed the patch, but forgot to update the bugreport - oops ;-)
Thanks for the fix gents.

commit 597725e9511f8c0405fdd8d92d749bce58c0bce3
Author: Mauro Rossi <issor.oruam@gmail.com>
Date:   Tue Dec 11 23:22:35 2018 +0100

    android: Fix 32-bit app crashing in 64-bit Android

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2414 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel