[Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]

* [Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]
@ 2019-08-14 19:04 bugzilla-daemon
  2019-10-02 17:30 ` bugzilla-daemon
  2019-10-02 17:31 ` bugzilla-daemon
  0 siblings, 2 replies; 3+ messages in thread
From: bugzilla-daemon @ 2019-08-14 19:04 UTC (permalink / raw)
  To: dri-devel

[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=111402

            Bug ID: 111402
           Summary: amdgpu-pro-install fails to install on openSUSE Leap
                    15.1 due to insufficient checks of $ID [PATCH
                    included]
           Product: DRI
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu-pro
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: public_timo.s@silentcreek.de

Created attachment 145064
  --> https://bugs.freedesktop.org/attachment.cgi?id=145064&action=edit
Simple fix that allows installing on openSUSE Leap 15.1

Hi,

I downloaded the latest amdgpu-pro-19.30-844693-sle-15.tar.xz package from
amd.com and tried to install it on openSUSE Leap 15.1 following the docs [1].

The command
  $ ./amdgpu-pro-install --opencl=legacy --headless
failed with the following error:
  tee: /etc/yum.repos.d/amdgpu-pro-local.repo: No such file or directory

So, the installer seems to mistake my system for a RHEL/CentOS-based OS.

Looking at the code, I noticed the script gets the $ID from /etc/os-release
which in my case looks like this:
NAME="openSUSE Leap"
VERSION="15.1 "
ID="opensuse-leap"
[...]

The function yum_repo() in the script does not properly check the $ID, however.
It only matches against the strings 'sles', 'sled' and 'opensuse', but not
'opensuse-leap'. This is contrary to the function os_release() which matches
opensuse-leap as well (with a wildcard).

So, the solution to the issue is a simple wildcard. I'm attaching a patch that
allowed me to run the installer on openSUSE Leap 15.1.

Regards,

Timo

[1] https://amdgpu-install.readthedocs.io/en/latest/install-installing.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3671 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread