* Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
@ 2023-11-20 15:36 ` Hamza Mahfooz
2023-11-21 16:41 ` Felix Kuehling
2023-11-20 15:36 ` [Bug 218168] " bugzilla-daemon
` (5 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Hamza Mahfooz @ 2023-11-20 15:36 UTC (permalink / raw)
To: bugzilla-daemon, dri-devel; +Cc: Felix Kuehling, amd-gfx
+ amd-gfx
+ Felix
On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>
> Bug ID: 218168
> Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
> bytes is larger than 1024 bytes
> Product: Drivers
> Version: 2.5
> Hardware: All
> OS: Linux
> Status: NEW
> Severity: normal
> Priority: P3
> Component: Video(DRI - non Intel)
> Assignee: drivers_video-dri@kernel-bugs.osdl.org
> Reporter: bluesun654@gmail.com
> Regression: No
>
> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>
> [...]
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
> 'kfd_topology_add_device':
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame
> size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 2082 | }
> | ^
> cc1: all warnings being treated as errors
> [...]
>
--
Hamza
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:36 ` Hamza Mahfooz
@ 2023-11-21 16:41 ` Felix Kuehling
0 siblings, 0 replies; 9+ messages in thread
From: Felix Kuehling @ 2023-11-21 16:41 UTC (permalink / raw)
To: Hamza Mahfooz, bugzilla-daemon, dri-devel; +Cc: amd-gfx
There are two patches that didn't make it into Linux 6.6 that reduce the
stack size in kfd_topology_add_device. Can you check if those fix the
problem?
commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Tue Sep 26 12:00:23 2023 -0400
drm/amdkfd: drop struct kfd_cu_info
I think this was an abstraction back from when
kfd supported both radeon and amdgpu. Since we just
support amdgpu now, there is no more need for this and
we can use the amdgpu structures directly.
This also avoids having the kfd_cu_info structures on
the stack when inlining which can blow up the stack.
Cc: Arnd Bergmann <arnd@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
commit 1f3b515578a1d73926993629a06a7f3b60535b59
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Thu Sep 21 10:32:09 2023 -0400
drm/amdkfd: reduce stack size in kfd_topology_add_device()
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than 1024 bytes
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
Cc: Arnd Bergmann <arnd@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Regards,
Felix
On 2023-11-20 10:36, Hamza Mahfooz wrote:
> + amd-gfx
> + Felix
>
> On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>>
>> Bug ID: 218168
>> Summary: amdgpu: kfd_topology.c warning: the frame size
>> of 1408
>> bytes is larger than 1024 bytes
>> Product: Drivers
>> Version: 2.5
>> Hardware: All
>> OS: Linux
>> Status: NEW
>> Severity: normal
>> Priority: P3
>> Component: Video(DRI - non Intel)
>> Assignee: drivers_video-dri@kernel-bugs.osdl.org
>> Reporter: bluesun654@gmail.com
>> Regression: No
>>
>> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>>
>> [...]
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
>> 'kfd_topology_add_device':
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error:
>> the frame
>> size of 1408 bytes is larger than 1024 bytes
>> [-Werror=frame-larger-than=]
>> 2082 | }
>> | ^
>> cc1: all warnings being treated as errors
>> [...]
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
2023-11-20 15:36 ` Hamza Mahfooz
@ 2023-11-20 15:36 ` bugzilla-daemon
2023-11-20 18:01 ` bugzilla-daemon
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-20 15:36 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
--- Comment #1 from hamza.mahfooz@amd.com ---
+ amd-gfx
+ Felix
On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>
> Bug ID: 218168
> Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
> bytes is larger than 1024 bytes
> Product: Drivers
> Version: 2.5
> Hardware: All
> OS: Linux
> Status: NEW
> Severity: normal
> Priority: P3
> Component: Video(DRI - non Intel)
> Assignee: drivers_video-dri@kernel-bugs.osdl.org
> Reporter: bluesun654@gmail.com
> Regression: No
>
> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>
> [...]
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
> 'kfd_topology_add_device':
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame
> size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 2082 | }
> | ^
> cc1: all warnings being treated as errors
> [...]
>
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
2023-11-20 15:36 ` Hamza Mahfooz
2023-11-20 15:36 ` [Bug 218168] " bugzilla-daemon
@ 2023-11-20 18:01 ` bugzilla-daemon
2023-11-20 19:50 ` bugzilla-daemon
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-20 18:01 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
Artem S. Tashkinov (aros@gmx.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |ANSWERED
--- Comment #2 from Artem S. Tashkinov (aros@gmx.com) ---
Please report here:
https://gitlab.freedesktop.org/drm/amd/-/issues
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
` (2 preceding siblings ...)
2023-11-20 18:01 ` bugzilla-daemon
@ 2023-11-20 19:50 ` bugzilla-daemon
2023-11-21 13:50 ` bugzilla-daemon
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-20 19:50 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
--- Comment #3 from Scall (scall-ebr@prosemail.net) ---
Done. For reference: https://gitlab.freedesktop.org/drm/amd/-/issues/3000
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
` (3 preceding siblings ...)
2023-11-20 19:50 ` bugzilla-daemon
@ 2023-11-21 13:50 ` bugzilla-daemon
2023-11-21 13:50 ` bugzilla-daemon
2023-11-21 16:41 ` bugzilla-daemon
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-21 13:50 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
--- Comment #4 from Artem S. Tashkinov (aros@gmx.com) ---
Fixed by
https://gitlab.freedesktop.org/drm/amd/uploads/26580b07cb9c763a0b840b9d705e0338/0001-drm-amdkfd-reduce-stack-size-in-kfd_topology_add_dev.patch
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
` (4 preceding siblings ...)
2023-11-21 13:50 ` bugzilla-daemon
@ 2023-11-21 13:50 ` bugzilla-daemon
2023-11-21 16:41 ` bugzilla-daemon
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-21 13:50 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
Artem S. Tashkinov (aros@gmx.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://gitlab.freedesktop.
| |org/drm/amd/-/issues/2866
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes
2023-11-20 15:16 [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes bugzilla-daemon
` (5 preceding siblings ...)
2023-11-21 13:50 ` bugzilla-daemon
@ 2023-11-21 16:41 ` bugzilla-daemon
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2023-11-21 16:41 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=218168
--- Comment #5 from Felix Kuehling (felix.kuehling@amd.com) ---
There are two patches that didn't make it into Linux 6.6 that reduce the
stack size in kfd_topology_add_device. Can you check if those fix the
problem?
commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Tue Sep 26 12:00:23 2023 -0400
drm/amdkfd: drop struct kfd_cu_info
I think this was an abstraction back from when
kfd supported both radeon and amdgpu. Since we just
support amdgpu now, there is no more need for this and
we can use the amdgpu structures directly.
This also avoids having the kfd_cu_info structures on
the stack when inlining which can blow up the stack.
Cc: Arnd Bergmann <arnd@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
commit 1f3b515578a1d73926993629a06a7f3b60535b59
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Thu Sep 21 10:32:09 2023 -0400
drm/amdkfd: reduce stack size in kfd_topology_add_device()
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger
than 1024 bytes
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
Cc: Arnd Bergmann <arnd@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Regards,
Felix
On 2023-11-20 10:36, Hamza Mahfooz wrote:
> + amd-gfx
> + Felix
>
> On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>>
>> Bug ID: 218168
>> Summary: amdgpu: kfd_topology.c warning: the frame size
>> of 1408
>> bytes is larger than 1024 bytes
>> Product: Drivers
>> Version: 2.5
>> Hardware: All
>> OS: Linux
>> Status: NEW
>> Severity: normal
>> Priority: P3
>> Component: Video(DRI - non Intel)
>> Assignee: drivers_video-dri@kernel-bugs.osdl.org
>> Reporter: bluesun654@gmail.com
>> Regression: No
>>
>> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>>
>> [...]
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
>> 'kfd_topology_add_device':
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error:
>> the frame
>> size of 1408 bytes is larger than 1024 bytes
>> [-Werror=frame-larger-than=]
>> 2082 | }
>> | ^
>> cc1: all warnings being treated as errors
>> [...]
>>
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread