[Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

            Bug ID: 218168
           Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
                    bytes is larger than 1024 bytes
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: bluesun654@gmail.com
        Regression: No

Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:

[...]
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
'kfd_topology_add_device':
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame
size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
 2082 | }
      | ^
cc1: all warnings being treated as errors
[...]

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[Hamza Mahfooz]

+ amd-gfx
+ Felix

On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218168
> 
>              Bug ID: 218168
>             Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
>                      bytes is larger than 1024 bytes
>             Product: Drivers
>             Version: 2.5
>            Hardware: All
>                  OS: Linux
>              Status: NEW
>            Severity: normal
>            Priority: P3
>           Component: Video(DRI - non Intel)
>            Assignee: drivers_video-dri@kernel-bugs.osdl.org
>            Reporter: bluesun654@gmail.com
>          Regression: No
> 
> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
> 
> [...]
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
> 'kfd_topology_add_device':
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame
> size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>   2082 | }
>        | ^
> cc1: all warnings being treated as errors
> [...]
> 
-- 
Hamza

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

--- Comment #1 from hamza.mahfooz@amd.com ---
+ amd-gfx
+ Felix

On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218168
> 
>              Bug ID: 218168
>             Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
>                      bytes is larger than 1024 bytes
>             Product: Drivers
>             Version: 2.5
>            Hardware: All
>                  OS: Linux
>              Status: NEW
>            Severity: normal
>            Priority: P3
>           Component: Video(DRI - non Intel)
>            Assignee: drivers_video-dri@kernel-bugs.osdl.org
>            Reporter: bluesun654@gmail.com
>          Regression: No
> 
> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
> 
> [...]
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
> 'kfd_topology_add_device':
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame
> size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>   2082 | }
>        | ^
> cc1: all warnings being treated as errors
> [...]
>

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |ANSWERED

--- Comment #2 from Artem S. Tashkinov (aros@gmx.com) ---
Please report here:

https://gitlab.freedesktop.org/drm/amd/-/issues

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

--- Comment #3 from Scall (scall-ebr@prosemail.net) ---
Done. For reference: https://gitlab.freedesktop.org/drm/amd/-/issues/3000

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

--- Comment #4 from Artem S. Tashkinov (aros@gmx.com) ---
Fixed by 

https://gitlab.freedesktop.org/drm/amd/uploads/26580b07cb9c763a0b840b9d705e0338/0001-drm-amdkfd-reduce-stack-size-in-kfd_topology_add_dev.patch

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.freedesktop.
                   |                            |org/drm/amd/-/issues/2866

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[Felix Kuehling]

There are two patches that didn't make it into Linux 6.6 that reduce the 
stack size in kfd_topology_add_device. Can you check if those fix the 
problem?

commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Tue Sep 26 12:00:23 2023 -0400

     drm/amdkfd: drop struct kfd_cu_info
     
     I think this was an abstraction back from when
     kfd supported both radeon and amdgpu.  Since we just
     support amdgpu now, there is no more need for this and
     we can use the amdgpu structures directly.
     
     This also avoids having the kfd_cu_info structures on
     the stack when inlining which can blow up the stack.
     
     Cc: Arnd Bergmann <arnd@kernel.org>
     Acked-by: Arnd Bergmann <arnd@arndb.de>
     Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
     Acked-by: Christian König <christian.koenig@amd.com>
     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 1f3b515578a1d73926993629a06a7f3b60535b59
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Thu Sep 21 10:32:09 2023 -0400

     drm/amdkfd: reduce stack size in kfd_topology_add_device()
     
     kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than 1024 bytes
     
     Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
     Cc: Arnd Bergmann <arnd@kernel.org>
     Acked-by: Arnd Bergmann <arnd@arndb.de>
     Acked-by: Christian König <christian.koenig@amd.com>
     Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
   Felix


On 2023-11-20 10:36, Hamza Mahfooz wrote:
> + amd-gfx
> + Felix
>
> On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>>
>>              Bug ID: 218168
>>             Summary: amdgpu: kfd_topology.c warning: the frame size 
>> of 1408
>>                      bytes is larger than 1024 bytes
>>             Product: Drivers
>>             Version: 2.5
>>            Hardware: All
>>                  OS: Linux
>>              Status: NEW
>>            Severity: normal
>>            Priority: P3
>>           Component: Video(DRI - non Intel)
>>            Assignee: drivers_video-dri@kernel-bugs.osdl.org
>>            Reporter: bluesun654@gmail.com
>>          Regression: No
>>
>> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>>
>> [...]
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
>> 'kfd_topology_add_device':
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: 
>> the frame
>> size of 1408 bytes is larger than 1024 bytes 
>> [-Werror=frame-larger-than=]
>>   2082 | }
>>        | ^
>> cc1: all warnings being treated as errors
>> [...]
>>

[Bug 218168] amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218168

--- Comment #5 from Felix Kuehling (felix.kuehling@amd.com) ---
There are two patches that didn't make it into Linux 6.6 that reduce the 
stack size in kfd_topology_add_device. Can you check if those fix the 
problem?

commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Tue Sep 26 12:00:23 2023 -0400

     drm/amdkfd: drop struct kfd_cu_info

     I think this was an abstraction back from when
     kfd supported both radeon and amdgpu.  Since we just
     support amdgpu now, there is no more need for this and
     we can use the amdgpu structures directly.

     This also avoids having the kfd_cu_info structures on
     the stack when inlining which can blow up the stack.

     Cc: Arnd Bergmann <arnd@kernel.org>
     Acked-by: Arnd Bergmann <arnd@arndb.de>
     Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
     Acked-by: Christian König <christian.koenig@amd.com>
     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 1f3b515578a1d73926993629a06a7f3b60535b59
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Thu Sep 21 10:32:09 2023 -0400

     drm/amdkfd: reduce stack size in kfd_topology_add_device()

     kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger
than 1024 bytes

     Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
     Cc: Arnd Bergmann <arnd@kernel.org>
     Acked-by: Arnd Bergmann <arnd@arndb.de>
     Acked-by: Christian König <christian.koenig@amd.com>
     Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
   Felix


On 2023-11-20 10:36, Hamza Mahfooz wrote:
> + amd-gfx
> + Felix
>
> On 11/20/23 10:16, bugzilla-daemon@kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=218168
>>
>>              Bug ID: 218168
>>             Summary: amdgpu: kfd_topology.c warning: the frame size 
>> of 1408
>>                      bytes is larger than 1024 bytes
>>             Product: Drivers
>>             Version: 2.5
>>            Hardware: All
>>                  OS: Linux
>>              Status: NEW
>>            Severity: normal
>>            Priority: P3
>>           Component: Video(DRI - non Intel)
>>            Assignee: drivers_video-dri@kernel-bugs.osdl.org
>>            Reporter: bluesun654@gmail.com
>>          Regression: No
>>
>> Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:
>>
>> [...]
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
>> 'kfd_topology_add_device':
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: 
>> the frame
>> size of 1408 bytes is larger than 1024 bytes 
>> [-Werror=frame-larger-than=]
>>   2082 | }
>>        | ^
>> cc1: all warnings being treated as errors
>> [...]
>>

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.