[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|x86-64                      |Platform_x86
           Assignee|platform_x86_64@kernel-bugs |drivers_platform_x86@kernel
                   |.osdl.org                   |-bugs.osdl.org
            Product|Platform Specific/Hardware  |Drivers

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #9 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Can you please share a log with dynamic debug turned on for amd-pmf?  You can
rmmod/modprobe it if you want rather than a full boot.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #10 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #9)
> Can you please share a log with dynamic debug turned on for amd-pmf?  You
> can rmmod/modprobe it if you want rather than a full boot.

Can you tell me how to do that? And I'll upload it tomorrow cuz I'm going to
sleep now

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #11 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
sudo dmesg --clear
sudo rmmod amd-pmf
sudo modprobe amd-pmf dyndbg='+p'
sudo dmesg > dmesg.txt

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #12 from al0uette@outlook.com ---
Created attachment 306115
  --> https://bugzilla.kernel.org/attachment.cgi?id=306115&action=edit
log of amd-pmf

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #13 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
OK, from that log and your acpidump it looks to me that it supports these PMF
functions:

APMF_FUNC_GET_SYS_PARAMS
APMF_FUNC_SBIOS_REQUESTS
APMF_FUNC_OS_POWER_SLIDER_UPDATE


The one that is specifically causing the conflict the ASUS driver is
APMF_FUNC_OS_POWER_SLIDER_UPDATE.  This is what causes the ACPI power profile
to get registered:

[   71.242252] amd-pmf AMDI0102:00: SPS enabled and Platform Profiles
registered

When the profile is moved it calls APMF() with an arg of 8, which calls PMF8():

                    Case (0x08)
                    {
                        PMF8 (Arg1)
                    }

PMF8 outputs some debug using M460 but eventually calls APX8():

            Method (PMF8, 1, Serialized)
            {
                M460 ("FEA-ASL-\\_SB.PMF.APMF Function 8 call PMF8\n", Zero,
Zero, Zero, Zero, Zero, Zero)
                CreateByteField (Arg0, 0x02, M490)
                M460 ("  Slider Event Notification: 0x%x\n", M490, Zero, Zero,
Zero, Zero, Zero)
                If (CondRefOf (\_SB.APX8))
                {
                    M460 ("  Call OEM ACPI APX8\n", Zero, Zero, Zero, Zero,
Zero, Zero)
                    \_SB.APX8 (M490)
                }
            }

This updates a "PMTP" field:

        Method (APX8, 1, Serialized)
        {
            PMTP = (0xD6080000 | Arg0)
        }

That PTMP field is part of an Operation Region used for Port I/O:

        OperationRegion (TP80, SystemIO, 0x80, 0x04)
        Field (TP80, DWordAcc, NoLock, Preserve)
        {
            PMTP,   32
        }

To me this looks like the system should probably be responding to power slider
events from the amd-pmf driver.  Do you find that various CPU coefficients
don't get updated even when you've changed the power profile when amd-pmf is
bound?

If they do get updated, then I think the bug should be in asus-wmi.c that it
shouldn't be loading a platform profile because amd-pmf is taking this role. 
Perhaps the DSTS method has an unknown bit to indicate this?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #14 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #13)
> Do you find that various CPU
> coefficients don't get updated even when you've changed the power profile
> when amd-pmf is bound?

If you're talking about energy_performance_profile, then I do have such a
problem. You can see another issue opened by me:

https://bugzilla.kernel.org/show_bug.cgi?id=218686

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #15 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
No; not that.  I'm talking about things like sPPT and fPPT.
Try reading /sys/kernel/debug/amd_pmf/current_power_limits and then changing
the platform profile to power saver or performance.
See if any of those limits change.

For reference; this is what I see on a Framework 13 AMD:

(in balanced):
spl:35000 fppt:35000 sppt:33000 sppt_apu_only:41000 stt_min:28000 stt[APU]:0
stt[HS2]: 0

(in power saver):
spl:15000 fppt:15000 sppt:15000 sppt_apu_only:41000 stt_min:15000 stt[APU]:0
stt[HS2]: 0

(in performance):
spl:30000 fppt:30000 sppt:30000 sppt_apu_only:41000 stt_min:30000 stt[APU]:128
stt[HS2]: 0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #16 from al0uette@outlook.com ---
[root@Zephyrus:~]# cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance
performance

[root@Zephyrus:~]# cat /sys/kernel/debug/amd_pmf/current_power_limits
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

[root@Zephyrus:~]# echo "powersave" | tee
/sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
powersave

[root@Zephyrus:~]# cat /sys/kernel/debug/amd_pmf/current_power_limits
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

Seems that they don't change

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #17 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
OK - can you please do an experiment where you modify the PMF driver to not
register a platform profile but let the asus-wmi one do it?  Try reading that
same file in the different states when asus-wmi is controlling it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #18 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Wait; you're not changing the right thing.  You should be changing
/sys/firmware/acpi/platform_profile

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #19 from al0uette@outlook.com ---
Oh sorry for that, here's the new result(amd-pmf)

[low-power]
sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                    
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

[balanced]
sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                    
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

[performance]
sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                         
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #20 from al0uette@outlook.com ---
(with asus-nb-wmi)

[quiet](asus-nb-wmi don't have low-power profile)
spl:35000 fppt:65000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0
[balanced]
spl:35000 fppt:65000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0
[performance]
spl:35000 fppt:80000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #21 from al0uette@outlook.com ---
(In reply to al0uette from comment #20)
> (with asus-nb-wmi)
> 
> [quiet](asus-nb-wmi don't have low-power profile)
> spl:35000 fppt:65000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0
> [balanced]
> spl:35000 fppt:65000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0
> [performance]
> spl:35000 fppt:80000 sppt:44000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0

The above data is taken when I unplugged power cable, here's the value with
power cable connected:

[quiet]
spl:35000 fppt:65000 sppt:55000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0
[balanced]
spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0
[performance]
spl:80000 fppt:80000 sppt:80000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
stt[HS2]: 0

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #22 from al0uette@outlook.com ---
(In reply to al0uette from comment #19)
> Oh sorry for that, here's the new result(amd-pmf)
> 
> [low-power]
> sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                    
> spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0
> 
> [balanced]
> sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                    
> spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0
> 
> [performance]
> sudo cat /sys/kernel/debug/amd_pmf/current_power_limits                     
> 
> spl:45000 fppt:65000 sppt:65000 sppt_apu_only:54000 stt_min:0 stt[APU]:0
> stt[HS2]: 0

This result is also taken with power cable connected

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #23 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
It looks like the BIOS has a bug that it's advertisement of that bit even
though it doesn't work.
I guess in Windows this is a no-op.

Hans - there's a few ways to handle this I can think of.
1. Quirk against this system and BIOS to ignore that bit in AMD PMF.
2. Allow multiple drivers to register for platform profile.
3. Do nothing, let Asus fix in BIOS.

What do you want to do?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #24 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
And before we decide al0uette did you already update to the latest BIOS
available by Asus? Issue still exists?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #25 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #24)
> And before we decide al0uette did you already update to the latest BIOS
> available by Asus? Issue still exists?

Definitely, I've updated to the latest BIOS(version 303)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #26 from al0uette@outlook.com ---
And the issue still exists, which is why I'm reporting this issue

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #27 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Mario Limonciello (AMD) from comment #23)
> Hans - there's a few ways to handle this I can think of.
> 1. Quirk against this system and BIOS to ignore that bit in AMD PMF.
> 2. Allow multiple drivers to register for platform profile.
> 3. Do nothing, let Asus fix in BIOS.
> 
> What do you want to do?

I wish we could rely on 3. but I don't think it is very likely Asus is actually
going to fix this and al0uette has just confirmed this still happens with the
latest available BIOS :|

2. seems complicated and will likely be messy, so that leaves 1. I'm afraid.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #28 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #23)
> It looks like the BIOS has a bug that it's advertisement of that bit even
> though it doesn't work.
> I guess in Windows this is a no-op.
> 
> Hans - there's a few ways to handle this I can think of.
> 1. Quirk against this system and BIOS to ignore that bit in AMD PMF.
> 2. Allow multiple drivers to register for platform profile.
> 3. Do nothing, let Asus fix in BIOS.
> 
> What do you want to do?

I really doubt whether ASUS will fix this BIOS bug. I contacted ASUS consumer
support today for the CPPC problem and they seem unwilling to provide Linux
support

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #29 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
I did do something a few years ago to let multiple drivers react to profile
changes. This was in advance of amd pmf driver existing but I think the same
concepts can potentially apply.

https://lore.kernel.org/linux-acpi/20211026180535.9096-4-mario.limonciello@amd.com/T/

It "could" be dusted off to find the rough edges instead of quirking.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #30 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Mario Limonciello (AMD) from comment #29)
> I did do something a few years ago to let multiple drivers react to profile
> changes. This was in advance of amd pmf driver existing but I think the same
> concepts can potentially apply.
> 
> https://lore.kernel.org/linux-acpi/20211026180535.9096-4-mario.
> limonciello@amd.com/T/
> 
> It "could" be dusted off to find the rough edges instead of quirking.

So how would this work in a case like this where one platform-profile provider
supports "quiet" and the other "low-power" (and both support "balanced" +
"performance"  ?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #31 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
I'm actually unsure what the quiet profile means compared to low power. I would
think it's better for Asus driver to use low power.

That's what userspace power profiles daemon uses anyway.


But yes if there are different mapping for different drivers that could be
problematic the way it was done in that series. 

There could also be a problem of device ordering.

So I guess the way to solve it would be to make all drivers that want it
request it enabled with the profiles they support. 

To userspace the superset would be reported.

Individual driver callbacks if they're requested to switch to an unsupported
state would be a noop.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #32 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
I'm actually unsure what the quiet profile means compared to low power. I would
think it's better for Asus driver to use low power.

Note that the actual CPU power-limits between balanced and quiet do not change
on this laptop, so I guess quiet chooses a fan curve with less aggressive
ramping up of the fans on higher temps. IOW quiet != low-power.

Anyways this is exactly what I meant with how allowing multiple providers will
be messy. I really think just adding a DMI quirk for this hopefully single
broken model is best.

And if we see this more often maybe we need a way to prioritize one provider
over the other, e.g. pass a priority level when registering and if a higher
priority provider shows up unregister the previous one. Although with a complex
driver like amd-pmf getting an unregister-platform-profile callback for this
called from the core might be tricky to implement.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #33 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
OK, in that case let's see dmidecode output to pick the best string to use for
a quirk.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #34 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
I've posted a quirk based on what was in your dmesg attached to this bug.

https://lore.kernel.org/platform-driver-x86/20240410140956.385-1-mario.limonciello@amd.com/T/#me44972a836808229f63a8afa58aee837146f26ad

Please have a try with that. If it doesn't work, please get dmidecode attached
and share the dynamic debug output when amd-pmf is loaded.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #35 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #34)
> I've posted a quirk based on what was in your dmesg attached to this bug.
> 
> https://lore.kernel.org/platform-driver-x86/20240410140956.385-1-mario.
> limonciello@amd.com/T/#me44972a836808229f63a8afa58aee837146f26ad
> 
> Please have a try with that. If it doesn't work, please get dmidecode
> attached and share the dynamic debug output when amd-pmf is loaded.

OK, thank you, I'll try it. Should I dmidecode before or after applying this
patch?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #36 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Only need dmidecode if it doesn't work. Doesn't matter when you call it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #37 from al0uette@outlook.com ---
Got it. I'm compiling kernel now

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #38 from al0uette@outlook.com ---
On 6.9.0-rc1 it works perfectly fine now. Thank you Mario and Hans

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

al0uette@outlook.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #39 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Just to be crystal clear you mean 6.9-rc1 + ghY patch series right?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #40 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
*my

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #41 from al0uette@outlook.com ---
(In reply to Mario Limonciello (AMD) from comment #39)
> Just to be crystal clear you mean 6.9-rc1 + ghY patch series right?

To be accurate, it's 6.9.0-rc1 from tiwai's
branch(https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git, commit
f17dcc83a813d62cc249ade09167acdbb0c3d5e3), plus your patch series and a patch
to fix volume control for cirrus amps. The content of that patch is as follows:

From 28668199b2a6f7df30d9192fe23de48859a988e7 Mon Sep 17 00:00:00 2001
From: "Luke D. Jones" <luke@ljones.dev>
Date: Wed, 3 Apr 2024 12:05:16 +1300
Subject: [PATCH] Test patch for GA403U series

Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
 sound/pci/hda/patch_realtek.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cdcb28aa9d7b..1c08bf26b15e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7467,6 +7467,8 @@ enum {
        ALC285_FIXUP_CS35L56_I2C_2,
        ALC285_FIXUP_CS35L56_I2C_4,
        ALC285_FIXUP_ASUS_GA403U,
+       ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC,
+       ALC285_FIXUP_ASUS_GA403U_I2C_SPEAKER2_TO_DAC1,
 };

 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9690,6 +9692,22 @@ static const struct hda_fixup alc269_fixups[] = {
                .type = HDA_FIXUP_FUNC,
                .v.func = alc285_fixup_asus_ga403u,
        },
+       [ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC] = {
+               .type = HDA_FIXUP_PINS,
+               .v.pins = (const struct hda_pintbl[]) {
+                       { 0x19, 0x03a11050 },
+                       { 0x1b, 0x03a11c30 },
+                       { }
+               },
+               .chained = true,
+               .chain_id = ALC285_FIXUP_ASUS_GA403U_I2C_SPEAKER2_TO_DAC1
+       },
+       [ALC285_FIXUP_ASUS_GA403U_I2C_SPEAKER2_TO_DAC1] = {
+               .type = HDA_FIXUP_FUNC,
+               .v.func = alc285_fixup_speaker2_to_dac1,
+               .chained = true,
+               .chain_id = ALC285_FIXUP_ASUS_GA403U,
+       },
 };

 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -10143,7 +10161,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] =
{
        SND_PCI_QUIRK(0x1043, 0x1a83, "ASUS UM5302LA",
ALC294_FIXUP_CS35L41_I2C_2),
        SND_PCI_QUIRK(0x1043, 0x1a8f, "ASUS UX582ZS",
ALC245_FIXUP_CS35L41_SPI_2),
        SND_PCI_QUIRK(0x1043, 0x1b11, "ASUS UX431DA",
ALC294_FIXUP_ASUS_COEF_1B),
-       SND_PCI_QUIRK(0x1043, 0x1b13, "ASUS U41SV/GA403U",
ALC285_FIXUP_ASUS_GA403U),
+       SND_PCI_QUIRK(0x1043, 0x1b13, "ASUS U41SV/GA403U",
ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC),
        SND_PCI_QUIRK(0x1043, 0x1b93, "ASUS G614JVR/JIR",
ALC245_FIXUP_CS35L41_SPI_2),
        SND_PCI_QUIRK(0x1043, 0x1bbd, "ASUS Z550MA",
ALC255_FIXUP_ASUS_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x1043, 0x1c03, "ASUS UM3406HA",
ALC287_FIXUP_CS35L41_I2C_2),
-- 
2.44.0

I guess other parts doesn't really matters, since the major differences are in
audio part.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.