[Bug 82586] New: UBO matrix in std140 struct does not work

[Bug 82586] New: UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1304 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

          Priority: medium
            Bug ID: 82586
          Assignee: dri-devel@lists.freedesktop.org
           Summary: UBO matrix in std140 struct does not work
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: pavol@klacansky.com
          Hardware: Other
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

I am not sure if the problem is actually in my code, but I tested it on nVidia
driver and it worked (but their compiler might have a fix for it internally).

Here is vertex shader:

#version 330

layout(location = 0) in vec4 position;

layout(std140) uniform Matrices {
    mat4 model;
    mat4 view;
    mat4 projection;
} matrices;

out gl_PerVertex {
    vec4 gl_Position;
};

/* interpolate to compute normal in fragment shader */
out vec3 v_position;

void main(void)
{
    v_position = vec3(matrices.view * matrices.model * position);
    gl_Position = matrices.projection * matrices.view * matrices.model *
position;
}


If I use only one matrix from the uniform it works. I have printed UBOs values
and they are just identity matrices.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2601 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

Ian Romanick <idr@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Ian Romanick <idr@freedesktop.org> ---
What is the failure mode?  A bunch of changes recently occurred in the GLSL
compiler (especially in the linker) for UBO matrices.  What version of Mesa are
you on?  Can you try a build of master?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1914 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 407 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #2 from pavol@klacansky.com ---
"What is the failure mode?"
Don't follow

"What version of Mesa are you on?"
https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers
Seem couple days old.

"Can you try a build of master?"
Can't I just wait for new build in PPA?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #3 from Ian Romanick <idr@freedesktop.org> ---
(In reply to comment #2)
> "What is the failure mode?"
> Don't follow

You say it doesn't work.  That's pretty vague.  If it fails in some way, what
is the mode of the failure?  (See also
http://en.wikipedia.org/wiki/Failure_causes#Component_failure)

Are the member locations incorrect (query through the API)?  Is the row-major /
column-major orientation of the matrices incorrect (query through the API)?  Is
the generated code reading the wrong locations?  Does it crash in the driver? 
Does your computer catch on fire?

Without any information about how it actually fails, it's pretty much
impossible to fix.

> "What version of Mesa are you on?"
> https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers
> Seem couple days old.

When I check it now, it should have everything.  The other question: does this
work on older Mesa?  Say... a 10.2 stable release?

> "Can you try a build of master?"
> Can't I just wait for new build in PPA?

You can... at some point there will probably be a patch for you to test, and
that won't be in PPA.  You can probably wait to worry about it until such a
patch exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2408 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1626 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #4 from pavol@klacansky.com ---
(In reply to comment #3)
> You say it doesn't work.  That's pretty vague.  If it fails in some way,
> what is the mode of the failure?  (See also
> http://en.wikipedia.org/wiki/Failure_causes#Component_failure)
It just does not display anything, hence either whole pipeline crashes (and
OpenGL KHR_debug does not print it out) or the transform moves vertices outside
clipping region (I might try transform feedback over weekend).

> Are the member locations incorrect (query through the API)?  Is the
> row-major / column-major orientation of the matrices incorrect (query
> through the API)?  Is the generated code reading the wrong locations?  Does
> it crash in the driver?  Does your computer catch on fire?
Locations are correct (at least if gl query returns them properly). I do not
know, I do not read anything (or I do not follow). How do I know if it crashes
in driver? No, though DPM is really bad.

> Without any information about how it actually fails, it's pretty much
> impossible to fix.

If I apply one of the matrices, it works, if I multiply two of them, it does
not.

> When I check it now, it should have everything.  The other question: does
> this work on older Mesa?  Say... a 10.2 stable release?
Yes, it works on 10.2.5

> You can... at some point there will probably be a patch for you to test, and
> that won't be in PPA.  You can probably wait to worry about it until such a
> patch exists.

Ok, hope the process is seamless.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2680 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #5 from pavol@klacansky.com ---
I have got new mesa from PPA and problem seems to be gone. How can I find exact
commit fixing this, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1037 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 403 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #6 from Roland Scheidegger <sroland@vmware.com> ---
(In reply to comment #5)
> I have got new mesa from PPA and problem seems to be gone. How can I find
> exact commit fixing this, please?

Just use git bisect. That of course requires you to build mesa yourself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1258 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 384 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #7 from Ilia Mirkin <imirkin@alum.mit.edu> ---
Probably one of

http://cgit.freedesktop.org/mesa/mesa/commit/?id=d52202141ebe28cd9f8d305827552fafccb279fd
http://cgit.freedesktop.org/mesa/mesa/commit/?id=da9c3ed304be5d08ff989d61c6e2d1be8a845767

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 432 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #8 from pavol@klacansky.com ---
I have tried to compile mesa, but all I get is GL 2.1

OpenGL version string: 2.1 Mesa 10.3.0-devel (git-9d9879a)

I just build master without any non-default flags. Can you help, please?
(I would like to bisect, and I reported other bug which I want to test)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 210 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #9 from Ilia Mirkin <imirkin@alum.mit.edu> ---
--enable-texture-float

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 987 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 686 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

pavol@klacansky.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from pavol@klacansky.com ---
Thanks, I am not sure if I done it correctly, but bisect gave me this as first
bad commit (if I understand it means the bug was introduced in it)

http://cgit.freedesktop.org/mesa/mesa/commit/?id=01bf8bb87565ed3677e43c6b6deeb90378d88647

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2193 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 82586] UBO matrix in std140 struct does not work

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=82586

--- Comment #11 from pavol@klacansky.com ---
Fixed here, thanks.

http://cgit.freedesktop.org/mesa/mesa/commit/?id=da9c3ed304be5d08ff989d61c6e2d1be8a845767

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1170 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel