[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1334 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

            Bug ID: 94595
           Summary: [Mesa AMD&swrast] Texture views attached as
                    framebuffers return their viewed tecture's color
                    encoding and render incorrectly
           Product: Mesa
           Version: git
          Hardware: Other
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: esmith@feralinteractive.com
        QA Contact: dri-devel@lists.freedesktop.org

As seen in the example given, when attaching an SRGB/RGB texture view is
created from an alternate RGB/SRGB texture, then attached as a framebuffer,
rendering will gamma correct wrongly and querying
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING will return GL_LINEAR for an SRGB
backed frame buffer.

This is causing AA renders to be too dark as in our unreleased project, among
many other subtle colour issues.

Tested on latest 11.3 (git-9d9965c from oibaf) and seen on older drivers as
well.
$ g++ TextureViewFramebufferSRGBTest.cpp.cpp $( sdl2-config --cflags --libs )
-lGL
This reproduces on Mesa AMD and swrast.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2678 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #1 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thanks for the report - did you forget to attach a source file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1175 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #2 from Edwin Smith <esmith@feralinteractive.com> ---
Created attachment 122407
  --> https://bugs.freedesktop.org/attachment.cgi?id=122407&action=edit
TextureViewFramebufferSRGB Test Sample Code

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1444 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 312 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #3 from Edwin Smith <esmith@feralinteractive.com> ---
Created attachment 122408
  --> https://bugs.freedesktop.org/attachment.cgi?id=122408&action=edit
AMD Mesa Test Output

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1375 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 324 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #4 from Edwin Smith <esmith@feralinteractive.com> ---
Created attachment 122409
  --> https://bugs.freedesktop.org/attachment.cgi?id=122409&action=edit
Intel Output (Correct Behaviour)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1411 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #5 from Edwin Smith <esmith@feralinteractive.com> ---
Created attachment 122410
  --> https://bugs.freedesktop.org/attachment.cgi?id=122410&action=edit
Nvidia Output (Correct Behaviour)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1414 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #6 from Edwin Smith <esmith@feralinteractive.com> ---
Created attachment 122411
  --> https://bugs.freedesktop.org/attachment.cgi?id=122411&action=edit
Swrast Output (Incorrect Behaviour)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1420 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 447 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

Edwin Smith <esmith@feralinteractive.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122408|AMD Mesa Test Output        |AMD Mesa Output (Incorrect
        description|                            |Behaviour)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 268 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #7 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Hi Edwin, thanks for following up with the details. I'm going to look into
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1192 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 417 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

--- Comment #8 from Nicolai Hähnle <nhaehnle@gmail.com> ---
There is a patch at https://patchwork.freedesktop.org/patch/77510/ which fixes
your test case (and should fix format casting with render-to-texture more
generally).

Let us know if this fixes your SRGB-related rendering problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1402 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 549 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Fixed in Mesa master, commit a8b315b8271e867db30650dedb52e53d8dd9667c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2251 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 550 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94595

Edwin Smith <esmith@feralinteractive.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #10 from Edwin Smith <esmith@feralinteractive.com> ---
The test case submitted now works as expected using the latest mesa git
drivers. Thank you for such a quick fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2164 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel