All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 97305] Gallium: TBOs and images set the offset in elements, not bytes
Date: Mon, 29 Aug 2016 17:42:22 +0000	[thread overview]
Message-ID: <bug-97305-502-AkAAUWBFeR@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-97305-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97305

Matias N. Goldberg <dark_sylinc@yahoo.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #18 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
You're awesome!

I can confirm it works on both the sample repro I provided and my actual real
case.

Small note: We discovered there was a potential for a crash because at certain
points we assume SIMD alignment; so we're now enforcing 16-byte alignment as
minimum in our code. I'm doing this remark because Mesa is the only (or among
the very few) implementations that return alignments <16; which can reveal
hidden bugs in program code that runs fine everywhere else. If you ever see a
bug report of these sorts (e.g. crashing in movaps, movntdqa), this is
something to keep in mind.

I appreciate the 4 byte alignment as 256 reported by others is excessively
wasteful. Thanks.

For the record it was fixed in
https://cgit.freedesktop.org/mesa/mesa/commit/?id=7cd256ce7e4bad680bb77d033cf5dd662abab2dd
and
https://cgit.freedesktop.org/mesa/mesa/commit/?id=325379096f54dde39171d1b8804e29a8003bb3c7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3208 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2016-08-29 17:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 19:53 [Bug 97305] Wrong values returned by GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT & GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT randomly breaks stuff bugzilla-daemon
2016-08-11 20:06 ` bugzilla-daemon
2016-08-11 20:17 ` bugzilla-daemon
2016-08-11 20:30 ` bugzilla-daemon
2016-08-11 20:31 ` bugzilla-daemon
2016-08-11 22:12 ` bugzilla-daemon
2016-08-11 22:18 ` bugzilla-daemon
2016-08-11 22:22 ` bugzilla-daemon
2016-08-11 22:28 ` bugzilla-daemon
2016-08-11 22:39 ` bugzilla-daemon
2016-08-11 22:42 ` bugzilla-daemon
2016-08-11 22:50 ` bugzilla-daemon
2016-08-11 22:54 ` bugzilla-daemon
2016-08-11 23:08 ` bugzilla-daemon
2016-08-11 23:48 ` [Bug 97305] Gallium: TBOs and images set the offset in elements, not bytes bugzilla-daemon
2016-08-12  0:01 ` bugzilla-daemon
2016-08-29 15:05 ` bugzilla-daemon
2016-08-29 15:15 ` bugzilla-daemon
2016-08-29 17:42 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97305-502-AkAAUWBFeR@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.