All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 97305] Wrong values returned by GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT & GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT randomly breaks stuff
Date: Thu, 11 Aug 2016 22:50:41 +0000	[thread overview]
Message-ID: <bug-97305-502-RlxfWBQen9@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-97305-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1170 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97305

--- Comment #11 from Ilia Mirkin <imirkin@alum.mit.edu> ---
(In reply to Marek Olšák from comment #10)
> (In reply to Ilia Mirkin from comment #9)
> > (In reply to Marek Olšák from comment #5)
> > > Pre-GCN cards require an alignment of 256 bytes for uniform buffers. GCN
> > > cards only require 4 byte alignment there.
> > > 
> > > All other buffer binding points require 1, 2, or 4 bytes depending on the
> > > texel size. It's really min(texel_size, 4).
> > 
> > That means that you have to return max(texel_size) for the
> > GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT. You only get one cap, and a texture
> > buffer can be any offset.
> 
> That's what we already do.

You return 4. However that's not enough if I set the format to GL_RGBA32I.
There's no provision in the spec to disallow someone feeding you a aligned-to-4
buffer with GL_RGBA32I format if you return "4" as the value.

Oh, unless I totally misunderstood what you were saying, and that situation
should work. In which case, apologies for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2394 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-08-11 22:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 19:53 [Bug 97305] Wrong values returned by GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT & GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT randomly breaks stuff bugzilla-daemon
2016-08-11 20:06 ` bugzilla-daemon
2016-08-11 20:17 ` bugzilla-daemon
2016-08-11 20:30 ` bugzilla-daemon
2016-08-11 20:31 ` bugzilla-daemon
2016-08-11 22:12 ` bugzilla-daemon
2016-08-11 22:18 ` bugzilla-daemon
2016-08-11 22:22 ` bugzilla-daemon
2016-08-11 22:28 ` bugzilla-daemon
2016-08-11 22:39 ` bugzilla-daemon
2016-08-11 22:42 ` bugzilla-daemon
2016-08-11 22:50 ` bugzilla-daemon [this message]
2016-08-11 22:54 ` bugzilla-daemon
2016-08-11 23:08 ` bugzilla-daemon
2016-08-11 23:48 ` [Bug 97305] Gallium: TBOs and images set the offset in elements, not bytes bugzilla-daemon
2016-08-12  0:01 ` bugzilla-daemon
2016-08-29 15:05 ` bugzilla-daemon
2016-08-29 15:15 ` bugzilla-daemon
2016-08-29 17:42 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97305-502-RlxfWBQen9@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.