From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Shawn Guo <shawn.guo@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
David Yang <mmyangfl@gmail.com>
Subject: Re: [PATCH v5 0/5] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy
Date: Tue, 5 Mar 2024 15:13:23 +0100 [thread overview]
Message-ID: <c010c46b-25b1-418f-8e92-e5c1683ce88b@linaro.org> (raw)
In-Reply-To: <20240305-inno-phy-v5-0-dc1cb130ea08@outlook.com>
On 05/03/2024 14:32, Yang Xiwen via B4 Relay wrote:
> This should be considered a hack. The proper solution would be
> extracting write_reg logic to a separate regmap driver. Leaving only
> "write BIT(2) to address 0x6" to the PHY driver.
>
> A proper fix should be implemented later.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> ---
> Changes in v5:
> - commit msg: bulk->array. (Philipp)
> - use devm_reset_control_array_exclusive() instead. (Philipp)
> - Link to v4: https://lore.kernel.org/r/20240305-inno-phy-v4-0-a03204c9cf1c@outlook.com
One patchset per 24h. Allow people to actually review your code, before
posting new version.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Shawn Guo <shawn.guo@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
David Yang <mmyangfl@gmail.com>
Subject: Re: [PATCH v5 0/5] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy
Date: Tue, 5 Mar 2024 15:13:23 +0100 [thread overview]
Message-ID: <c010c46b-25b1-418f-8e92-e5c1683ce88b@linaro.org> (raw)
In-Reply-To: <20240305-inno-phy-v5-0-dc1cb130ea08@outlook.com>
On 05/03/2024 14:32, Yang Xiwen via B4 Relay wrote:
> This should be considered a hack. The proper solution would be
> extracting write_reg logic to a separate regmap driver. Leaving only
> "write BIT(2) to address 0x6" to the PHY driver.
>
> A proper fix should be implemented later.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> ---
> Changes in v5:
> - commit msg: bulk->array. (Philipp)
> - use devm_reset_control_array_exclusive() instead. (Philipp)
> - Link to v4: https://lore.kernel.org/r/20240305-inno-phy-v4-0-a03204c9cf1c@outlook.com
One patchset per 24h. Allow people to actually review your code, before
posting new version.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-05 14:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 13:32 [PATCH v5 0/5] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` [PATCH v5 1/5] phy: hisilicon: hisi-inno-phy: enable clocks for every ports Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` [PATCH v5 2/5] dt-bindings: phy: hisi-inno-usb2: convert to YAML Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` [PATCH v5 3/5] dt-bindings: phy: hisilicon,inno-usb2-phy: add support for Hi3798MV100 INNO PHY Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` [PATCH v5 4/5] dt-bindings: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` [PATCH v5 5/5] phy: hisilicon: hisi-inno-phy: add support for Hi3798MV200 INNO PHY Yang Xiwen
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-03-05 13:32 ` Yang Xiwen via B4 Relay
2024-04-05 16:52 ` Vinod Koul
2024-04-05 16:52 ` Vinod Koul
2024-04-05 17:53 ` Yang Xiwen
2024-04-05 17:53 ` Yang Xiwen
2024-04-06 6:19 ` Vinod Koul
2024-04-06 6:19 ` Vinod Koul
2024-03-05 14:13 ` Krzysztof Kozlowski [this message]
2024-03-05 14:13 ` [PATCH v5 0/5] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c010c46b-25b1-418f-8e92-e5c1683ce88b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=kishon@kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mmyangfl@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.