Re: [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes

[Sibi Sankar <sibis@codeaurora.org>]

Hey Jonathan,

Thanks for the patch! Please use the
suggested register space definitions
instead.

On 2020-07-13 21:11, Jonathan Marek wrote:
> Add the interconnect dts nodes for sm8150.
> 
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 82 ++++++++++++++++++++++++++++
>  1 file changed, 82 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 33ff99132f4f..fa9cd9d60093 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/clock/qcom,gcc-sm8150.h>
>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
> +#include <dt-bindings/interconnect/qcom,sm8150.h>
>  #include <dt-bindings/thermal/thermal.h>
> 
>  / {
> @@ -440,6 +441,69 @@ uart2: serial@a90000 {
>  			};
>  		};
> 
> +		dc_noc: interconnect@14e0000 {
> +			compatible = "qcom,sm8150-dc-noc";
> +			reg = <0 0x014e0000 0 0x1000>;

0x09160000 0x3200

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		config_noc: interconnect@1500000 {
> +			compatible = "qcom,sm8150-config-noc";
> +			reg = <0 0x01500000 0 0x1000>;

0x01500000 0x7400

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		camnoc_virt: interconnect@1620000 {
> +			compatible = "qcom,sm8150-camnoc-virt";
> +			reg = <0 0x01620000 0 0x1000>;

0x0ac00000 0x1000

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		ipa_virt: interconnect-ipa@1620000 {
> +			compatible = "qcom,sm8150-ipa-virt";
> +			reg = <0 0x01620000 0 0x1000>;

0x01e00000 0x1000

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		system_noc: interconnect@1629000 {
> +			compatible = "qcom,sm8150-system-noc";
> +			reg = <0 0x01500000 0 0x1000>;

0x01620000 0x19400

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		aggre1_noc: interconnect@16e4000 {
> +			compatible = "qcom,sm8150-aggre1-noc";
> +			reg = <0 0x016e4000 0 0x1000>;

0x016e0000 0xd080

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		aggre2_noc: interconnect@1706000 {
> +			compatible = "qcom,sm8150-aggre2-noc";
> +			reg = <0 0x01706000 0 0x1000>;

0x01700000 0x3b100

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		compute_noc: interconnect@1720000 {
> +			compatible = "qcom,sm8150-compute-noc";
> +			reg = <0 0x01720000 0 0x1000>;

0x01720000 0x7000

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		mmss_noc: interconnect@1749000 {
> +			compatible = "qcom,sm8150-mmss-noc";
> +			reg = <0 0x01749000 0 0x1000>;

0x01740000 0x1c100

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
>  		ufs_mem_hc: ufshc@1d84000 {
>  			compatible = "qcom,sm8150-ufshc", "qcom,ufshc",
>  				     "jedec,ufs-2.0";
> @@ -860,6 +924,20 @@ usb_2_ssphy: lane@88eb200 {
>  			};
>  		};
> 
> +		mc_virt: interconnect@9680000 {
> +			compatible = "qcom,sm8150-mc-virt";
> +			reg = <0 0x09680000 0 0x1000>;

0x0163a000 0x1000

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
> +		gem_noc: interconnect@96ab000 {
> +			compatible = "qcom,sm8150-gem-noc";
> +			reg = <0 0x096ab000 0 0x1000>;

0x09680000 0x3e200

> +			#interconnect-cells = <1>;
> +			qcom,bcm-voters = <&apps_bcm_voter>;
> +		};
> +
>  		usb_1: usb@a6f8800 {
>  			compatible = "qcom,sm8150-dwc3", "qcom,dwc3";
>  			reg = <0 0x0a6f8800 0 0x400>;
> @@ -1280,6 +1358,10 @@ rpmhpd_opp_turbo_l1: opp11 {
>  					};
>  				};
>  			};
> +
> +			apps_bcm_voter: bcm_voter {
> +				compatible = "qcom,bcm-voter";
> +			};
>  		};
> 
>  		cpufreq_hw: cpufreq@18323000 {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.