[PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Borys Turko]

The customizable Lenovo hotkey ("Star with S") on the Lenovo 82EY is
currently mapped to KEY_FAVORITES. However, KEY_FAVORITES is primarily
handled as a browser-specific action (Add to Favorites) and is not
consistently recognized as a system-wide hotkey by modern desktop
environments.

Testing on the Cinnamon desktop environment shows that KEY_FAVORITES
is not captured for system mapping, and it fails to trigger any action
in modern web browsers.

Remapping this key to KEY_DASHBOARD allows it to be treated as a
system-level event. This change enables users to map the key to
system functions (such as a dashboard or launcher) through their
desktop environment's keyboard settings.

Tested on Lenovo 82EY with evtest and Cinnamon DE.

Signed-off-by: Borys Turko <turkoborys@gmail.com>
---
 drivers/platform/x86/lenovo/ideapad-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
index 4fbc904f1..3a5b5a478 100644
--- a/drivers/platform/x86/lenovo/ideapad-laptop.c
+++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
@@ -1333,7 +1333,7 @@ static const struct key_entry ideapad_keymap[] = {
 	/* Esc (handled by the firmware) */
 	{ KE_IGNORE,	0x03 | IDEAPAD_WMI_KEY },
 	/* Customizable Lenovo Hotkey ("star" with 'S' inside) */
-	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_FAVORITES } },
+	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_DASHBOARD } },
 	{ KE_KEY,	0x04 | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
 	/* Lenovo Support */
 	{ KE_KEY,	0x07 | IDEAPAD_WMI_KEY, { KEY_HELP } },
-- 
2.54.0

Re: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Mark Pearson]

Hi Borys,

On Wed, Apr 22, 2026, at 6:42 AM, Borys Turko wrote:
> The customizable Lenovo hotkey ("Star with S") on the Lenovo 82EY is
> currently mapped to KEY_FAVORITES. However, KEY_FAVORITES is primarily
> handled as a browser-specific action (Add to Favorites) and is not
> consistently recognized as a system-wide hotkey by modern desktop
> environments.
>
> Testing on the Cinnamon desktop environment shows that KEY_FAVORITES
> is not captured for system mapping, and it fails to trigger any action
> in modern web browsers.
>
> Remapping this key to KEY_DASHBOARD allows it to be treated as a
> system-level event. This change enables users to map the key to
> system functions (such as a dashboard or launcher) through their
> desktop environment's keyboard settings.
>
> Tested on Lenovo 82EY with evtest and Cinnamon DE.
>
> Signed-off-by: Borys Turko <turkoborys@gmail.com>
> ---
>  drivers/platform/x86/lenovo/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c 
> b/drivers/platform/x86/lenovo/ideapad-laptop.c
> index 4fbc904f1..3a5b5a478 100644
> --- a/drivers/platform/x86/lenovo/ideapad-laptop.c
> +++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
> @@ -1333,7 +1333,7 @@ static const struct key_entry ideapad_keymap[] = {
>  	/* Esc (handled by the firmware) */
>  	{ KE_IGNORE,	0x03 | IDEAPAD_WMI_KEY },
>  	/* Customizable Lenovo Hotkey ("star" with 'S' inside) */
> -	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_FAVORITES } },
> +	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_DASHBOARD } },
>  	{ KE_KEY,	0x04 | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
>  	/* Lenovo Support */
>  	{ KE_KEY,	0x07 | IDEAPAD_WMI_KEY, { KEY_HELP } },
> -- 
> 2.54.0

Interestingly thinkpad_acpi uses KEY_BOOKMARKS for the star key.

The Thinkpad user guide entry for the star key says "Customize the function of this key on the Vantage app"....so it's pretty much open season on the intention of the key (I assume Ideapad says similar).

KEY_DASHBOARD seems to intend to do an application overview (as far as I can tell it's an Apple thing)

I did try over-riding KEY_BOOKMARKS in gnome as a keyboard shortcut on my Thinkpad, and I was able to set that to whatever I wanted and it worked. Afraid I don't have any Ideapads handy.

Afraid I would lean towards not changing it. 
It's been this way since 2022 and is a valid use. If we change it there's a chance it will muck it up for someone, and at least currently it does something rather than nothing (unless configured)

If KEY_BOOKMARKS is configurable in Cinnamon then that might be a better choice - but I still lean towards no change (and seeing if Cinnamon can be fixed to let you change it)

I don't feel strongly about this - so see what other maintainers suggest.

Mark

Re: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Borys]

Hi Mark,

Thanks for the detailed feedback and for testing this on your
ThinkPad. I’ve done some further testing on the IdeaPad Gaming 3
(Cinnamon) to address your points and cross-referenced several IdeaPad
manuals.

On this specific hardware, I found that KEY_FAVORITES currently
results in no action at all. It acts as a dead key in the desktop
environment, so the risk of a regression for existing users seems
minimal compared to the benefit of making the key functional.

While the ThinkPad intent might be more flexible, the IdeaPad manuals
(for the Gaming and 5 series, for example) specifically state the key
is intended to "Open an app" or "Open Lenovo Vantage/PC Manager." I
tested KEY_BOOKMARKS as you suggested, but found that browsers like
Firefox "hijack" this key to open a sidebar, which prevents the user
from mapping it to a system tool as the manual intends. Additionally,
in my environment, the system labels this key as "Favorites," which
might be confusing for a "PC Manager" launcher.

In my testing, KEY_CONFIG seems to avoid these conflicts. The system
identifies it as "Tools," which is a perfect semantic match for the
Vantage tools mentioned in the documentation. It isn't intercepted by
browsers and remains fully mappable by the user. Using a neutral key
like KEY_PROG4 would also achieve this same goal of giving the user
full control without default interference.

I’m curious to hear your thoughts on these findings and how we can
best align the driver with the "user-defined" intent described in the
manuals.

Best regards,

Borys

Re: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Borys]

Hi,

Any chance you've had a look at my response below?

Best regards,
Borys

Op do 23 apr 2026 om 09:59 schreef Borys <turkoborys@gmail.com>:
>
> Hi Mark,
>
> Thanks for the detailed feedback and for testing this on your
> ThinkPad. I’ve done some further testing on the IdeaPad Gaming 3
> (Cinnamon) to address your points and cross-referenced several IdeaPad
> manuals.
>
> On this specific hardware, I found that KEY_FAVORITES currently
> results in no action at all. It acts as a dead key in the desktop
> environment, so the risk of a regression for existing users seems
> minimal compared to the benefit of making the key functional.
>
> While the ThinkPad intent might be more flexible, the IdeaPad manuals
> (for the Gaming and 5 series, for example) specifically state the key
> is intended to "Open an app" or "Open Lenovo Vantage/PC Manager." I
> tested KEY_BOOKMARKS as you suggested, but found that browsers like
> Firefox "hijack" this key to open a sidebar, which prevents the user
> from mapping it to a system tool as the manual intends. Additionally,
> in my environment, the system labels this key as "Favorites," which
> might be confusing for a "PC Manager" launcher.
>
> In my testing, KEY_CONFIG seems to avoid these conflicts. The system
> identifies it as "Tools," which is a perfect semantic match for the
> Vantage tools mentioned in the documentation. It isn't intercepted by
> browsers and remains fully mappable by the user. Using a neutral key
> like KEY_PROG4 would also achieve this same goal of giving the user
> full control without default interference.
>
> I’m curious to hear your thoughts on these findings and how we can
> best align the driver with the "user-defined" intent described in the
> manuals.
>
> Best regards,
>
> Borys

Re: [PATCH] platform/x86: ideapad-laptop: remap "Star with S" key to KEY_DASHBOARD

[Mark Pearson]

Hi Borys,

On Fri, May 15, 2026, at 1:38 PM, Borys wrote:
> Hi,
>
> Any chance you've had a look at my response below?

Sorry - it got lost in my email swamp :)

I don't feel strongly about it - I'll happily defer to the experienced maintainers perspective. Just wanted to highlight that potentially you might break somebodies carefully crafted key mappings
(but realistically, I think the odds on that are towards the low side)

Mark

>
> Best regards,
> Borys
>
> Op do 23 apr 2026 om 09:59 schreef Borys <turkoborys@gmail.com>:
>>
>> Hi Mark,
>>
>> Thanks for the detailed feedback and for testing this on your
>> ThinkPad. I’ve done some further testing on the IdeaPad Gaming 3
>> (Cinnamon) to address your points and cross-referenced several IdeaPad
>> manuals.
>>
>> On this specific hardware, I found that KEY_FAVORITES currently
>> results in no action at all. It acts as a dead key in the desktop
>> environment, so the risk of a regression for existing users seems
>> minimal compared to the benefit of making the key functional.
>>
>> While the ThinkPad intent might be more flexible, the IdeaPad manuals
>> (for the Gaming and 5 series, for example) specifically state the key
>> is intended to "Open an app" or "Open Lenovo Vantage/PC Manager." I
>> tested KEY_BOOKMARKS as you suggested, but found that browsers like
>> Firefox "hijack" this key to open a sidebar, which prevents the user
>> from mapping it to a system tool as the manual intends. Additionally,
>> in my environment, the system labels this key as "Favorites," which
>> might be confusing for a "PC Manager" launcher.
>>
>> In my testing, KEY_CONFIG seems to avoid these conflicts. The system
>> identifies it as "Tools," which is a perfect semantic match for the
>> Vantage tools mentioned in the documentation. It isn't intercepted by
>> browsers and remains fully mappable by the user. Using a neutral key
>> like KEY_PROG4 would also achieve this same goal of giving the user
>> full control without default interference.
>>
>> I’m curious to hear your thoughts on these findings and how we can
>> best align the driver with the "user-defined" intent described in the
>> manuals.
>>
>> Best regards,
>>
>> Borys