From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
catalin.marinas@arm.com, will@kernel.org, maz@kernel.org,
dbrazdil@google.com
Subject: Re: [PATCH][for-stable-v5.11]] arm64: Unconditionally set virtual cpu id registers
Date: Tue, 16 Mar 2021 11:41:26 +0000 [thread overview]
Message-ID: <c89f1434-e4e5-325d-e68d-ece76e8d3315@arm.com> (raw)
In-Reply-To: <YFCXCbKefWH8smpB@kroah.com>
On 3/16/21 11:31 AM, Greg KH wrote:
> On Tue, Mar 16, 2021 at 11:25:00AM +0000, Vladimir Murzin wrote:
>> Commit 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> reorganized el2 setup in such way that virtual cpu id registers set
>> only in nVHE, yet they used (and need) to be set irrespective VHE
>> support. Lack of setup causes 32-bit guest stop booting due to MIDR
>> stay undefined.
>>
>> Fixes: 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>>
>> There is no upstream fix since issue went away due to code there has
>> been reworked in 5.12: nVHE comes first, so virtual cpu id register
>> are always set.
>>
>> Maintainers, please, Ack.
>
> Why not just use the "rework" patch instead that fixes this issue?>
>
> that's always preferred instead of one-off patches.
That's moderate size patch series [1] which brings new functionality, but
more importantly move boot flow upside down, where we first boot nVHE and
then switch to VHE if supported. I think that a lot of change to carry in
stable compare to proposed fix.
[1] https://lore.kernel.org/kvmarm/20210208095732.3267263-2-maz@kernel.org/
Cheers
Vladimir
>
> thanks,
>
> greg k-h
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
catalin.marinas@arm.com, will@kernel.org, maz@kernel.org,
dbrazdil@google.com
Subject: Re: [PATCH][for-stable-v5.11]] arm64: Unconditionally set virtual cpu id registers
Date: Tue, 16 Mar 2021 11:41:26 +0000 [thread overview]
Message-ID: <c89f1434-e4e5-325d-e68d-ece76e8d3315@arm.com> (raw)
In-Reply-To: <YFCXCbKefWH8smpB@kroah.com>
On 3/16/21 11:31 AM, Greg KH wrote:
> On Tue, Mar 16, 2021 at 11:25:00AM +0000, Vladimir Murzin wrote:
>> Commit 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> reorganized el2 setup in such way that virtual cpu id registers set
>> only in nVHE, yet they used (and need) to be set irrespective VHE
>> support. Lack of setup causes 32-bit guest stop booting due to MIDR
>> stay undefined.
>>
>> Fixes: 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>>
>> There is no upstream fix since issue went away due to code there has
>> been reworked in 5.12: nVHE comes first, so virtual cpu id register
>> are always set.
>>
>> Maintainers, please, Ack.
>
> Why not just use the "rework" patch instead that fixes this issue?>
>
> that's always preferred instead of one-off patches.
That's moderate size patch series [1] which brings new functionality, but
more importantly move boot flow upside down, where we first boot nVHE and
then switch to VHE if supported. I think that a lot of change to carry in
stable compare to proposed fix.
[1] https://lore.kernel.org/kvmarm/20210208095732.3267263-2-maz@kernel.org/
Cheers
Vladimir
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2021-03-16 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 11:25 [PATCH][for-stable-v5.11]] arm64: Unconditionally set virtual cpu id registers Vladimir Murzin
2021-03-16 11:25 ` Vladimir Murzin
2021-03-16 11:31 ` Greg KH
2021-03-16 11:31 ` Greg KH
2021-03-16 11:41 ` Vladimir Murzin [this message]
2021-03-16 11:41 ` Vladimir Murzin
2021-03-16 11:41 ` Marc Zyngier
2021-03-16 11:41 ` Marc Zyngier
2021-03-16 13:22 ` Marc Zyngier
2021-03-16 13:22 ` Marc Zyngier
2021-03-16 13:37 ` Vladimir Murzin
2021-03-16 13:37 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89f1434-e4e5-325d-e68d-ece76e8d3315@arm.com \
--to=vladimir.murzin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.