All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915/display: Add command line param for DC balance
@ 2026-09-15  4:00 Mitul Golani
  2026-09-15  4:15 ` ✗ CI.checkpatch: warning for drm/i915/display: Add command line param for DC balance (rev2) Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Mitul Golani @ 2026-09-15  4:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: intel-xe, ankit.k.nautiyal

Add an 'enable_dc_balance' display module parameter, disabled by
default, so the feature can be explicitly opted in at driver
initialization on configurations where it is known to be beneficial,
while preserving existing behaviour everywhere else.
intel_vrr_dc_balance_compute_config() honours the parameter, so no
recompilation is needed to try the feature.

--v2:
- Make enable_dc_balance a bool and keep it disabled by default; fix the
  parameter type/value mismatch and correct the description (Chaitanya
  Kumar Borah, Jani Nikula)
- Explain in the commit message why the feature is gated and why a
  module parameter is used (Jani Nikula)

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_params.c | 4 ++++
 drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
 drivers/gpu/drm/i915/display/intel_vrr.c            | 4 +++-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 2aed110c5b090..ca0ef466bb103 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -120,6 +120,10 @@ intel_display_param_named_unsafe(enable_psr, int, 0400,
 	"(0=disabled, 1=enable up to PSR1, 2=enable up to PSR2) "
 	"Default: -1 (use per-chip default)");
 
+intel_display_param_named_unsafe(enable_dc_balance, bool, 0400,
+	"Enable VRR DC balance (0=disabled, 1=enabled). "
+	"Default: 0 (disabled)");
+
 intel_display_param_named_unsafe(enable_panel_replay, int, 0400,
 	"Enable Panel Replay (0=disabled, 1=enabled). Default: -1 (use per-chip default)");
 
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index ba01aeaf89440..5c5a1a1358c32 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -46,6 +46,7 @@ struct drm_printer;
 	param(bool, enable_dp_mst, true, 0600) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
+	param(bool, enable_dc_balance, false, 0600) \
 	param(int, enable_panel_replay, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
 	param(bool, enable_psr2_sel_fetch, true, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index e36db11744405..1698c54e258b4 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -439,10 +439,12 @@ static bool intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_st
 static void
 intel_vrr_dc_balance_compute_config(struct intel_crtc_state *crtc_state)
 {
+	struct intel_display *display = to_intel_display(crtc_state);
 	int guardband_usec, adjustment_usec;
 	struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
 
-	if (!intel_vrr_dc_balance_possible(crtc_state) || !crtc_state->vrr.enable)
+	if (!intel_vrr_dc_balance_possible(crtc_state) ||
+	    !crtc_state->vrr.enable || !display->params.enable_dc_balance)
 		return;
 
 	crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax;
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2026-09-17  5:25 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-15  4:00 [PATCH v2] drm/i915/display: Add command line param for DC balance Mitul Golani
2026-09-15  4:15 ` ✗ CI.checkpatch: warning for drm/i915/display: Add command line param for DC balance (rev2) Patchwork
2026-09-15  4:17 ` ✓ CI.KUnit: success " Patchwork
2026-09-15  5:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-15  6:02 ` ✓ i915.CI.BAT: " Patchwork
2026-09-15  7:05 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-15  8:53 ` ✗ i915.CI.Full: " Patchwork
2026-09-16  6:38 ` [PATCH v2] drm/i915/display: Add command line param for DC balance Nautiyal, Ankit K
2026-09-16  7:26 ` Jani Nikula
2026-09-16  9:20   ` Golani, Mitulkumar Ajitkumar
2026-09-16 10:11     ` Jani Nikula
2026-09-17  5:25       ` Golani, Mitulkumar Ajitkumar
2026-09-16  9:48 ` ✓ i915.CI.Full: success for drm/i915/display: Add command line param for DC balance (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.