From: Faiz Abbas <faiz_abbas@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v2 12/13] davinci: omapl138-lcdk: enable driver-model in SPL
Date: Mon, 11 Nov 2019 15:48:21 +0530 [thread overview]
Message-ID: <ccbe50d0-697c-10f7-472f-696acd58a1ec@ti.com> (raw)
In-Reply-To: <CAMpxmJUZH56_gYXRqG_48VJY_ANv9egnyfCT5gcX51PX=yQiFA@mail.gmail.com>
Hi Bartosz,
On 08/11/19 9:20 PM, Bartosz Golaszewski wrote:
> pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>>
>> czw., 26 wrz 2019 o 01:21 Faiz Abbas <faiz_abbas@ti.com> napisał(a):
>>>
>>> Hi,
>>>
>>> On 29/07/19 12:28 PM, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>>
>>>> Enable CONFIG_SPL_DM and enable the driver model for serial by defining
>>>> an appropriate device in the board file for da850-lcdk.
>>>>
>>>
>>> This breaks booting from MMC on omapl138_lcdk. You didn't add a
>>> U_BOOT_DEVICE for the mmc node.
>>>
>>> Thanks,
>>> Faiz
>>
>> Just letting you know I haven't forgotten about this. I finally got
>> some time to work on it this week, but it turned out to be
>> non-trivial, as for some reason the set_cmd mmc callback is not being
>> properly assigned in SPL with driver-model and I couldn't find out why
>> so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm
>> not sure if you want to revert the offending patch for now or this can
>> wait for another week?
>>
>> Best regards,
>> Bartosz Golaszewski
>
> I've been working on this some more this week and noticed that in SPL
> for some reason the bind function of the mmc driver is not called
> (despite the driver being probed fine), but so far I've been unable to
> figure out why exactly.
I suspect you need to set DM_FLAG_PRE_RELOC for the bind to be called.
Can you try setting this flag?
Thanks,
Faiz
next prev parent reply other threads:[~2019-11-11 10:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 6:57 [U-Boot] [RESEND PATCH v2 00/13] ARM: davinci: driver-model improvements Bartosz Golaszewski
2019-07-29 6:57 ` [U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs Bartosz Golaszewski
2019-07-29 16:14 ` Tom Rini
2019-07-29 16:24 ` Adam Ford
2019-07-30 1:21 ` Tom Rini
2019-07-29 6:57 ` [U-Boot] [RESEND PATCH v2 02/13] sandbox: " Bartosz Golaszewski
2019-07-30 1:21 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 03/13] i2c: remove i2c driver-model compatibility layer Bartosz Golaszewski
2019-07-30 1:21 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 04/13] omapl138_lcdk_defconfig: don't build support for SPI Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 05/13] nand: davinci: make davinci_nand_init() static Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 06/13] nand: davinci: add support for driver model Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 07/13] davinci: omapl138-lcdk: enable driver model for NAND Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 08/13] davinci: da850-evm: " Bartosz Golaszewski
2019-07-29 18:14 ` Adam Ford
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 09/13] davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 10/13] davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 11/13] davinci: omapl138-lcdk: remove unneeded includes Bartosz Golaszewski
2019-07-30 1:22 ` Tom Rini
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 12/13] davinci: omapl138-lcdk: enable driver-model in SPL Bartosz Golaszewski
2019-07-30 1:23 ` Tom Rini
2019-09-25 13:34 ` Faiz Abbas
2019-10-25 16:10 ` Bartosz Golaszewski
2019-10-25 17:25 ` Rizvi, Mohammad Faiz Abbas
2019-10-27 18:05 ` Bartosz Golaszewski
2019-11-08 15:50 ` Bartosz Golaszewski
2019-11-08 16:14 ` Adam Ford
2019-11-08 17:33 ` Bartosz Golaszewski
2019-11-08 17:59 ` Bartosz Golaszewski
2019-11-11 12:57 ` Adam Ford
2019-11-13 10:52 ` Bartosz Golaszewski
2019-11-13 10:55 ` Bartosz Golaszewski
2019-11-11 10:18 ` Faiz Abbas [this message]
2019-07-29 6:58 ` [U-Boot] [RESEND PATCH v2 13/13] configs: omapl138_lcdk: enable NAND self-init " Bartosz Golaszewski
2019-07-30 1:23 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccbe50d0-697c-10f7-472f-696acd58a1ec@ti.com \
--to=faiz_abbas@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.