* [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
@ 2026-06-27 10:01 ` Nabige Aala
2026-06-28 12:35 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
` (4 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Nabige Aala @ 2026-06-27 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor,
Nabige Aala
Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper,
DPU display controller, DSI host controller, and 14nm DSI PHY.
Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific
compatible strings are used as the primary match with QCM2290 fallbacks
to reuse the existing driver support.
The dispcc clock inputs for the DSI byte and pixel PLLs are wired
from mdss_dsi0_phy.
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra.dtsi | 203 ++++++++++++++++++++++++++++++++++-
1 file changed, 201 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
index e67fe047a683..3c8eda0a518b 100644
--- a/arch/arm64/boot/dts/qcom/shikra.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
@@ -4,6 +4,7 @@
*/
#include <dt-bindings/clock/qcom,dispcc-qcm2290.h>
+#include <dt-bindings/clock/qcom,dsi-phy-28nm.h>
#include <dt-bindings/clock/qcom,qcm2290-gpucc.h>
#include <dt-bindings/clock/qcom,rpmcc.h>
#include <dt-bindings/clock/qcom,shikra-gcc.h>
@@ -1990,6 +1991,204 @@ gpucc: clock-controller@5990000 {
#power-domain-cells = <1>;
};
+ mdss: display-subsystem@5e00000 {
+ compatible = "qcom,shikra-mdss", "qcom,qcm2290-mdss";
+ reg = <0x0 0x05e00000 0x0 0x1000>;
+ reg-names = "mdss";
+ interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH 0>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ clocks = <&gcc GCC_DISP_AHB_CLK>,
+ <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_CLK>;
+ clock-names = "iface",
+ "bus",
+ "core";
+
+ resets = <&dispcc DISP_CC_MDSS_CORE_BCR>;
+
+ power-domains = <&dispcc MDSS_GDSC>;
+
+ iommus = <&apps_smmu 0x420 0x2>;
+ interconnects = <&mmrt_virt MASTER_MDP_PORT0 RPM_ALWAYS_TAG
+ &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>,
+ <&mem_noc MASTER_AMPSS_M0 RPM_ALWAYS_TAG
+ &config_noc SLAVE_DISPLAY_CFG RPM_ALWAYS_TAG>;
+ interconnect-names = "mdp0-mem",
+ "cpu-cfg";
+
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ status = "disabled";
+
+ mdp: display-controller@5e01000 {
+ compatible = "qcom,shikra-dpu", "qcom,qcm2290-dpu";
+ reg = <0x0 0x05e01000 0x0 0x8f000>,
+ <0x0 0x05eb0000 0x0 0x3000>;
+ reg-names = "mdp",
+ "vbif";
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "bus",
+ "iface",
+ "core",
+ "lut",
+ "vsync";
+
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmpd QCM2290_VDDCX>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dpu_intf1_out: endpoint {
+ remote-endpoint = <&mdss_dsi0_in>;
+ };
+ };
+ };
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-19200000 {
+ opp-hz = /bits/ 64 <19200000>;
+ required-opps = <&rpmpd_opp_min_svs>;
+ };
+
+ opp-192000000 {
+ opp-hz = /bits/ 64 <192000000>;
+ required-opps = <&rpmpd_opp_low_svs>;
+ };
+
+ opp-256000000 {
+ opp-hz = /bits/ 64 <256000000>;
+ required-opps = <&rpmpd_opp_svs>;
+ };
+
+ opp-307200000 {
+ opp-hz = /bits/ 64 <307200000>;
+ required-opps = <&rpmpd_opp_svs_plus>;
+ };
+
+ opp-384000000 {
+ opp-hz = /bits/ 64 <384000000>;
+ required-opps = <&rpmpd_opp_nom>;
+ };
+ };
+ };
+
+ mdss_dsi0: dsi@5e94000 {
+ compatible = "qcom,shikra-dsi-ctrl",
+ "qcom,qcm2290-dsi-ctrl",
+ "qcom,mdss-dsi-ctrl";
+ reg = <0x0 0x05e94000 0x0 0x400>;
+ reg-names = "dsi_ctrl";
+
+ interrupt-parent = <&mdss>;
+ interrupts = <4>;
+
+ clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>,
+ <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>,
+ <&dispcc DISP_CC_MDSS_PCLK0_CLK>,
+ <&dispcc DISP_CC_MDSS_ESC0_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&gcc GCC_DISP_HF_AXI_CLK>;
+ clock-names = "byte",
+ "byte_intf",
+ "pixel",
+ "core",
+ "iface",
+ "bus";
+
+ assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK_SRC>,
+ <&dispcc DISP_CC_MDSS_PCLK0_CLK_SRC>;
+ assigned-clock-parents = <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
+ <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>;
+
+ operating-points-v2 = <&dsi_opp_table>;
+ power-domains = <&rpmpd QCM2290_VDDCX>;
+ phys = <&mdss_dsi0_phy>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ dsi_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-19200000 {
+ opp-hz = /bits/ 64 <19200000>;
+ required-opps = <&rpmpd_opp_min_svs>;
+ };
+
+ opp-164000000 {
+ opp-hz = /bits/ 64 <164000000>;
+ required-opps = <&rpmpd_opp_low_svs>;
+ };
+
+ opp-187500000 {
+ opp-hz = /bits/ 64 <187500000>;
+ required-opps = <&rpmpd_opp_svs>;
+ };
+ };
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ mdss_dsi0_in: endpoint {
+ remote-endpoint = <&dpu_intf1_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ mdss_dsi0_out: endpoint {
+ };
+ };
+ };
+ };
+
+ mdss_dsi0_phy: phy@5e94400 {
+ compatible = "qcom,dsi-phy-14nm-2290";
+ reg = <0x0 0x05e94400 0x0 0x100>,
+ <0x0 0x05e94500 0x0 0x300>,
+ <0x0 0x05e94800 0x0 0x188>;
+ reg-names = "dsi_phy",
+ "dsi_phy_lane",
+ "dsi_pll";
+
+ clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&rpmcc RPM_SMD_XO_CLK_SRC>;
+ clock-names = "iface",
+ "ref";
+
+ power-domains = <&rpmpd QCM2290_VDDMX>;
+ required-opps = <&rpmpd_opp_nom>;
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ status = "disabled";
+ };
+ };
+
dispcc: clock-controller@5f00000 {
compatible = "qcom,shikra-dispcc", "qcom,qcm2290-dispcc";
reg = <0x0 0x05f00000 0x0 0x20000>;
@@ -1997,8 +2196,8 @@ dispcc: clock-controller@5f00000 {
<&rpmcc RPM_SMD_XO_A_CLK_SRC>,
<&gcc GCC_DISP_GPLL0_CLK_SRC>,
<&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>,
- <0>,
- <0>,
+ <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
+ <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>,
<0>,
<0>,
<&sleep_clk>;
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem
2026-06-27 10:01 ` [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
@ 2026-06-28 12:35 ` Dmitry Baryshkov
0 siblings, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:35 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:35PM +0530, Nabige Aala wrote:
> Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper,
> DPU display controller, DSI host controller, and 14nm DSI PHY.
>
> Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific
> compatible strings are used as the primary match with QCM2290 fallbacks
> to reuse the existing driver support.
>
> The dispcc clock inputs for the DSI byte and pixel PLLs are wired
> from mdss_dsi0_phy.
>
> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra.dtsi | 203 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 201 insertions(+), 2 deletions(-)
>
> +
> + clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> + <&dispcc DISP_CC_MDSS_MDP_CLK>,
> + <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> + <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> + clock-names = "bus",
> + "iface",
> + "core",
> + "lut",
> + "vsync";
> +
> + operating-points-v2 = <&mdp_opp_table>;
> + power-domains = <&rpmpd QCM2290_VDDCX>;
Don't blindly copy bits and pieces from other platforms. No, its' not
QCM2290.
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
[...]
> +
> + assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK_SRC>,
> + <&dispcc DISP_CC_MDSS_PCLK0_CLK_SRC>;
> + assigned-clock-parents = <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
> + <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>;
> +
> + operating-points-v2 = <&dsi_opp_table>;
> + power-domains = <&rpmpd QCM2290_VDDCX>;
The same.
> + phys = <&mdss_dsi0_phy>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> +
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
2026-06-27 10:01 ` [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
@ 2026-06-27 10:01 ` Nabige Aala
2026-06-28 12:30 ` Dmitry Baryshkov
2026-06-28 12:30 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
` (3 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Nabige Aala @ 2026-06-27 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor,
Nabige Aala
From: Arpit Saini <arpit.saini@oss.qualcomm.com>
Enable the Shikra MDSS display subsystem on the Shikra CQM EVK
board and add the DLC0697 MIPI DSI display panel node.
Pin pm4125_l5 to 1.232V with regulator-allow-set-load
for DSI PHY PLL stability.
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 104 ++++++++++++++++++++++++++++
1 file changed, 104 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
index 683b5245923b..c9ea093cd8ca 100644
--- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
@@ -23,6 +23,18 @@ chosen {
stdout-path = "serial0:115200n8";
};
+ lcd_bias: regulator-lcd-bias {
+ compatible = "regulator-fixed";
+ regulator-name = "lcd_bias";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&pm4125_l17>;
+ gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ pinctrl-0 = <&lcd_bias_en>;
+ pinctrl-names = "default";
+ };
+
wcn3988-pmu {
compatible = "qcom,wcn3988-pmu";
@@ -60,6 +72,52 @@ vreg_pmu_ch1: ldo4 {
};
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&pm4125_l5>;
+ status = "okay";
+
+ panel@0 {
+ compatible = "dlc,dlc0697", "ilitek,ili7807s";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+
+ vddi-supply = <&pm4125_l15>;
+ avdd-supply = <&lcd_bias>;
+ avee-supply = <&lcd_bias>;
+
+ pinctrl-0 = <&panel_bl_en &panel_rst_n &panel_te_pin>;
+ pinctrl-1 = <&panel_bl_en_suspend &panel_rst_n_suspend>;
+ pinctrl-names = "default", "sleep";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+ data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+ status = "okay";
+};
+
+&pm4125_l5 {
+ /* DSI VDDA - must be at NOM voltage for PHY PLL lock */
+ regulator-min-microvolt = <1232000>;
+ regulator-max-microvolt = <1232000>;
+ regulator-allow-set-load;
+};
+
&remoteproc_cdsp {
firmware-name = "qcom/shikra/cdsp.mbn";
@@ -116,3 +174,49 @@ &wifi {
status = "okay";
};
+
+&tlmm {
+ lcd_bias_en: lcd-bias-en-state {
+ pins = "gpio151";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ panel_bl_en: panel-bl-en-state {
+ pins = "gpio91";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-high;
+ };
+
+ panel_bl_en_suspend: panel-bl-en-suspend-state {
+ pins = "gpio91";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ output-low;
+ };
+
+ panel_rst_n: panel-rst-n-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ panel_rst_n_suspend: panel-rst-n-suspend-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ panel_te_pin: panel-te-pin-state {
+ pins = "gpio86";
+ function = "mdp_vsync_p";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
@ 2026-06-28 12:30 ` Dmitry Baryshkov
2026-06-28 12:30 ` Dmitry Baryshkov
1 sibling, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:30 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:36PM +0530, Nabige Aala wrote:
> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>
> Enable the Shikra MDSS display subsystem on the Shikra CQM EVK
> board and add the DLC0697 MIPI DSI display panel node.
> Pin pm4125_l5 to 1.232V with regulator-allow-set-load
> for DSI PHY PLL stability.
>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 104 ++++++++++++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> index 683b5245923b..c9ea093cd8ca 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> @@ -23,6 +23,18 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + lcd_bias: regulator-lcd-bias {
> + compatible = "regulator-fixed";
> + regulator-name = "lcd_bias";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&pm4125_l17>;
> + gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + pinctrl-0 = <&lcd_bias_en>;
> + pinctrl-names = "default";
> + };
> +
> wcn3988-pmu {
> compatible = "qcom,wcn3988-pmu";
>
> @@ -60,6 +72,52 @@ vreg_pmu_ch1: ldo4 {
> };
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + vdda-supply = <&pm4125_l5>;
> + status = "okay";
Empty lines before the status property, please.
> +
> + panel@0 {
> + compatible = "dlc,dlc0697", "ilitek,ili7807s";
> + reg = <0>;
> +
> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +
> + vddi-supply = <&pm4125_l15>;
> + avdd-supply = <&lcd_bias>;
> + avee-supply = <&lcd_bias>;
AVEE is typically the negative / ground supply. How can it be supplied
by the same regulator as AVDD?
> +
> + pinctrl-0 = <&panel_bl_en &panel_rst_n &panel_te_pin>;
> + pinctrl-1 = <&panel_bl_en_suspend &panel_rst_n_suspend>;
> + pinctrl-names = "default", "sleep";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> +&mdss_dsi0_out {
> + remote-endpoint = <&panel_in>;
> + data-lanes = <0 1 2 3>;
> +};
> +
> +&mdss_dsi0_phy {
> + status = "okay";
> +};
> +
> +&pm4125_l5 {
> + /* DSI VDDA - must be at NOM voltage for PHY PLL lock */
> + regulator-min-microvolt = <1232000>;
> + regulator-max-microvolt = <1232000>;
> + regulator-allow-set-load;
> +};
> +
> &remoteproc_cdsp {
> firmware-name = "qcom/shikra/cdsp.mbn";
>
> @@ -116,3 +174,49 @@ &wifi {
>
> status = "okay";
> };
> +
> +&tlmm {
> + lcd_bias_en: lcd-bias-en-state {
> + pins = "gpio151";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + panel_bl_en: panel-bl-en-state {
> + pins = "gpio91";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
I think, recent recommendation is to sort these entries by the pin
number.
> + };
> +
> + panel_bl_en_suspend: panel-bl-en-suspend-state {
> + pins = "gpio91";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + output-low;
> + };
> +
> + panel_rst_n: panel-rst-n-state {
> + pins = "gpio3";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-disable;
> + };
> +
> + panel_rst_n_suspend: panel-rst-n-suspend-state {
> + pins = "gpio3";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + panel_te_pin: panel-te-pin-state {
> + pins = "gpio86";
> + function = "mdp_vsync_p";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +};
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-06-28 12:30 ` Dmitry Baryshkov
@ 2026-06-28 12:30 ` Dmitry Baryshkov
1 sibling, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:30 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:36PM +0530, Nabige Aala wrote:
> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>
> Enable the Shikra MDSS display subsystem on the Shikra CQM EVK
> board and add the DLC0697 MIPI DSI display panel node.
> Pin pm4125_l5 to 1.232V with regulator-allow-set-load
> for DSI PHY PLL stability.
>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Oh, and I nearly forgot. You are resending a patch written by somebody
else. What is missing here and why?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
2026-06-27 10:01 ` [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
@ 2026-06-27 10:01 ` Nabige Aala
2026-06-28 8:44 ` Krzysztof Kozlowski
2026-06-27 10:01 ` [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
` (2 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Nabige Aala @ 2026-06-27 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor,
Nabige Aala
From: Arpit Saini <arpit.saini@oss.qualcomm.com>
Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
used on the Shikra board.
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f2e6ae93e533..0395873ec03f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1009,6 +1009,7 @@ CONFIG_DRM_MXSFB=m
CONFIG_DRM_IMX_LCDIF=m
CONFIG_DRM_NOUVEAU=m
CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=m
+CONFIG_DRM_PANEL_ILITEK_ILI7807S=m
CONFIG_DRM_PANEL_LVDS=m
CONFIG_DRM_PANEL_HIMAX_HX8279=m
CONFIG_DRM_PANEL_HIMAX_HX83112A=m
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-27 10:01 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
@ 2026-06-28 8:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-28 8:44 UTC (permalink / raw)
To: Nabige Aala, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor
On 27/06/2026 12:01, Nabige Aala wrote:
> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>
> Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
> used on the Shikra board.
So that's a v4, no changelog, tags ignored, comments not responded and
also ignored.
You got yourself one NAK, now second:
NAK
Address the comments before you send the next version.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
` (2 preceding siblings ...)
2026-06-27 10:01 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
@ 2026-06-27 10:01 ` Nabige Aala
2026-06-28 12:36 ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
2026-06-28 12:24 ` [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Dmitry Baryshkov
5 siblings, 1 reply; 16+ messages in thread
From: Nabige Aala @ 2026-06-27 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor,
Nabige Aala
From: Arpit Saini <arpit.saini@oss.qualcomm.com>
Enable the Shikra MDSS display subsystem on the Shikra CQS EVK
board and add the DLC0697 MIPI DSI display panel node.
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 104 ++++++++++++++++++++++++++++
1 file changed, 104 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
index 26ff8007a819..4ae47d72d4d4 100644
--- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
@@ -23,6 +23,18 @@ chosen {
stdout-path = "serial0:115200n8";
};
+ lcd_bias: regulator-lcd-bias {
+ compatible = "regulator-fixed";
+ regulator-name = "lcd_bias";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&pm4125_l17>;
+ gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ pinctrl-0 = <&lcd_bias_en>;
+ pinctrl-names = "default";
+ };
+
wcn3988-pmu {
compatible = "qcom,wcn3988-pmu";
@@ -60,6 +72,52 @@ vreg_pmu_ch1: ldo4 {
};
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&pm4125_l5>;
+ status = "okay";
+
+ panel@0 {
+ compatible = "dlc,dlc0697", "ilitek,ili7807s";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+
+ vddi-supply = <&pm4125_l15>;
+ avdd-supply = <&lcd_bias>;
+ avee-supply = <&lcd_bias>;
+
+ pinctrl-0 = <&panel_bl_en &panel_rst_n &panel_te_pin>;
+ pinctrl-1 = <&panel_bl_en_suspend &panel_rst_n_suspend>;
+ pinctrl-names = "default", "sleep";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+ data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+ status = "okay";
+};
+
+&pm4125_l5 {
+ /* DSI VDDA - must be at NOM voltage for PHY PLL lock */
+ regulator-min-microvolt = <1232000>;
+ regulator-max-microvolt = <1232000>;
+ regulator-allow-set-load;
+};
+
&remoteproc_cdsp {
firmware-name = "qcom/shikra/cdsp.mbn";
@@ -116,3 +174,49 @@ &wifi {
status = "okay";
};
+
+&tlmm {
+ lcd_bias_en: lcd-bias-en-state {
+ pins = "gpio151";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ panel_bl_en: panel-bl-en-state {
+ pins = "gpio91";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-high;
+ };
+
+ panel_bl_en_suspend: panel-bl-en-suspend-state {
+ pins = "gpio91";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ output-low;
+ };
+
+ panel_rst_n: panel-rst-n-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ panel_rst_n_suspend: panel-rst-n-suspend-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ panel_te_pin: panel-te-pin-state {
+ pins = "gpio86";
+ function = "mdp_vsync_p";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
2026-06-27 10:01 ` [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
@ 2026-06-28 12:36 ` Dmitry Baryshkov
0 siblings, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:36 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:38PM +0530, Nabige Aala wrote:
> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>
> Enable the Shikra MDSS display subsystem on the Shikra CQS EVK
> board and add the DLC0697 MIPI DSI display panel node.
>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Missing SoB.
> ---
> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 104 ++++++++++++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> +&mdss_dsi0 {
> + vdda-supply = <&pm4125_l5>;
> + status = "okay";
> +
> + panel@0 {
> + compatible = "dlc,dlc0697", "ilitek,ili7807s";
> + reg = <0>;
> +
> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +
> + vddi-supply = <&pm4125_l15>;
> + avdd-supply = <&lcd_bias>;
> + avee-supply = <&lcd_bias>;
The same question regardin AVEE supply.
> +
> + pinctrl-0 = <&panel_bl_en &panel_rst_n &panel_te_pin>;
> + pinctrl-1 = <&panel_bl_en_suspend &panel_rst_n_suspend>;
> + pinctrl-names = "default", "sleep";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> @@ -116,3 +174,49 @@ &wifi {
>
> status = "okay";
> };
> +
> +&tlmm {
> + lcd_bias_en: lcd-bias-en-state {
> + pins = "gpio151";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
Order by the pin number.
> +
> + panel_bl_en: panel-bl-en-state {
> + pins = "gpio91";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
> + };
> +
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
` (3 preceding siblings ...)
2026-06-27 10:01 ` [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
@ 2026-06-27 10:01 ` Nabige Aala
2026-06-28 8:45 ` Krzysztof Kozlowski
2026-06-28 12:38 ` Dmitry Baryshkov
2026-06-28 12:24 ` [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Dmitry Baryshkov
5 siblings, 2 replies; 16+ messages in thread
From: Nabige Aala @ 2026-06-27 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor,
Nabige Aala
From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Device tree changes to support lt9611uxd hdmi-dsi driver.
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 122 ++++++++++++++++++++++++++++
1 file changed, 122 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
index fd691d53a0fa..9cc4a1c6e4ed 100644
--- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
@@ -23,6 +23,36 @@ chosen {
stdout-path = "serial0:115200n8";
};
+ hdmi-connector {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con: endpoint {
+ remote-endpoint = <<9611_out>;
+ };
+ };
+ };
+
+ vreg_lt9611_vcc: regulator-lt9611-vcc {
+ compatible = "regulator-fixed";
+ regulator-name = "lt9611_vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&pm8150_gpios 4 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hdmi_reg_en>;
+ };
+
+ vreg_lt9611_vdd: regulator-lt9611-vdd {
+ compatible = "regulator-fixed";
+ regulator-name = "lt9611_vdd";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
vreg_wcn_3p3: regulator-wcn-3p3 {
compatible = "regulator-fixed";
regulator-name = "wcn_3p3";
@@ -68,6 +98,78 @@ vreg_pmu_ch1: ldo4 {
};
};
+&i2c4 {
+ status = "okay";
+
+ lt9611uxd: lt9611uxd@41 {
+ compatible = "lontium,lt9611uxd";
+ reg = <0x41>;
+ interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
+ reset-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>;
+ vcc-supply = <&vreg_lt9611_vcc>;
+ vdd-supply = <&vreg_lt9611_vdd>;
+ lontium,port-select = <1>; /* PORT_SELECT_B */
+
+ pinctrl-names = "default";
+ pinctrl-0 = <<9611_irq_pin <9611_rst_pin>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ lt9611_a: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ lt9611_out: endpoint {
+ remote-endpoint = <&hdmi_con>;
+ };
+ };
+ };
+ };
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&pm8150_l11>;
+ status = "okay";
+
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <<9611_a>;
+ data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+ status = "okay";
+};
+
+&pm8150_gpios {
+ hdmi_reg_en: hdmi-reg-en-state {
+ pins = "gpio4";
+ function = PMIC_GPIO_FUNC_NORMAL;
+ bias-disable;
+ };
+};
+
+&pm8150_l11 {
+ /* DSI VDDA - must be at NOM voltage for PHY PLL lock */
+ regulator-min-microvolt = <1232000>;
+ regulator-max-microvolt = <1232000>;
+ regulator-allow-set-load;
+};
+
&remoteproc_cdsp {
firmware-name = "qcom/shikra/cdsp.mbn";
@@ -103,6 +205,26 @@ &sdhc_1 {
status = "okay";
};
+&tlmm {
+ lt9611_irq_pin: lt9611-irq-state {
+ pins = "gpio85";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ lt9611_rst_pin: lt9611-rst-state {
+ pins = "gpio76";
+ function = "gpio";
+ drive-strength = <8>;
+ output-high;
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
+
&uart8 {
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
@ 2026-06-28 8:45 ` Krzysztof Kozlowski
2026-06-28 12:38 ` Dmitry Baryshkov
1 sibling, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-28 8:45 UTC (permalink / raw)
To: Nabige Aala, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, arpit.saini, mohit.dsor
On 27/06/2026 12:01, Nabige Aala wrote:
> From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>
> Device tree changes to support lt9611uxd hdmi-dsi driver.
>
> Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Incomplete DCO
...
> +
> vreg_wcn_3p3: regulator-wcn-3p3 {
> compatible = "regulator-fixed";
> regulator-name = "wcn_3p3";
> @@ -68,6 +98,78 @@ vreg_pmu_ch1: ldo4 {
> };
> };
>
> +&i2c4 {
> + status = "okay";
> +
> + lt9611uxd: lt9611uxd@41 {
No. Nice try. Instead of fixing broken driver (I reported this), you
send broken workaround which is in clear violations of coding style and
DT spec.
That's a poor way to upstream things. Just throwing the code over the wall.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
2026-06-28 8:45 ` Krzysztof Kozlowski
@ 2026-06-28 12:38 ` Dmitry Baryshkov
1 sibling, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:38 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:39PM +0530, Nabige Aala wrote:
> From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>
> Device tree changes to support lt9611uxd hdmi-dsi driver.
>
> Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 122 ++++++++++++++++++++++++++++
> 1 file changed, 122 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> index fd691d53a0fa..9cc4a1c6e4ed 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> @@ -23,6 +23,36 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + hdmi-connector {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi_con: endpoint {
> + remote-endpoint = <<9611_out>;
> + };
> + };
> + };
> +
> + vreg_lt9611_vcc: regulator-lt9611-vcc {
> + compatible = "regulator-fixed";
> + regulator-name = "lt9611_vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&pm8150_gpios 4 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hdmi_reg_en>;
> + };
> +
> + vreg_lt9611_vdd: regulator-lt9611-vdd {
> + compatible = "regulator-fixed";
> + regulator-name = "lt9611_vdd";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> vreg_wcn_3p3: regulator-wcn-3p3 {
> compatible = "regulator-fixed";
> regulator-name = "wcn_3p3";
> @@ -68,6 +98,78 @@ vreg_pmu_ch1: ldo4 {
> };
> };
>
> +&i2c4 {
> + status = "okay";
> +
> + lt9611uxd: lt9611uxd@41 {
> + compatible = "lontium,lt9611uxd";
> + reg = <0x41>;
> + interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>;
> + vcc-supply = <&vreg_lt9611_vcc>;
> + vdd-supply = <&vreg_lt9611_vdd>;
> + lontium,port-select = <1>; /* PORT_SELECT_B */
Nope, NAK.
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <<9611_irq_pin <9611_rst_pin>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
port@1 { reg = <1>; };
> +
> + lt9611_a: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + lt9611_out: endpoint {
> + remote-endpoint = <&hdmi_con>;
> + };
> + };
> + };
> + };
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + vdda-supply = <&pm8150_l11>;
> + status = "okay";
> +
> +};
> +
> +&mdss_dsi0_out {
> + remote-endpoint = <<9611_a>;
> + data-lanes = <0 1 2 3>;
> +};
> +
> +&mdss_dsi0_phy {
> + status = "okay";
> +};
> +
> +&pm8150_gpios {
> + hdmi_reg_en: hdmi-reg-en-state {
> + pins = "gpio4";
> + function = PMIC_GPIO_FUNC_NORMAL;
> + bias-disable;
> + };
> +};
> +
> +&pm8150_l11 {
> + /* DSI VDDA - must be at NOM voltage for PHY PLL lock */
I see this being set for all EVK boards. Why is not a part of the base
DTSI?
> + regulator-min-microvolt = <1232000>;
> + regulator-max-microvolt = <1232000>;
> + regulator-allow-set-load;
> +};
> +
> &remoteproc_cdsp {
> firmware-name = "qcom/shikra/cdsp.mbn";
>
> @@ -103,6 +205,26 @@ &sdhc_1 {
> status = "okay";
> };
>
> +&tlmm {
> + lt9611_irq_pin: lt9611-irq-state {
> + pins = "gpio85";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + lt9611_rst_pin: lt9611-rst-state {
> + pins = "gpio76";
> + function = "gpio";
> + drive-strength = <8>;
> + output-high;
> + };
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> &uart8 {
> status = "okay";
>
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
` (4 preceding siblings ...)
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
@ 2026-06-28 12:24 ` Dmitry Baryshkov
5 siblings, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2026-06-28 12:24 UTC (permalink / raw)
To: Nabige Aala
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
arpit.saini, mohit.dsor
On Sat, Jun 27, 2026 at 03:31:34PM +0530, Nabige Aala wrote:
> This series adds display support for the Qualcomm Shikra platform.
>
> It introduces the Shikra MDSS display subsystem support at the SoC
> level, and enables display on the Shikra CQS EVK, CQM EVK and IQS
> EVK boards with the required DSI panel nodes. It also adds LT9611UXD
> support for HDMI output.
>
> Nabige Aala (5):
> arm64: dts: qcom: shikra: Add MDSS display subsystem
> arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
> arm64: defconfig: Enable ILI7807S DSI panel driver
> arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
> arm64: dts: qcom: Shikra LT9611UXD support
>
> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/shikra.dtsi | 203 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> arch/arm64/configs/defconfig | 1 +
> 5 files changed, 534 insertions(+), 2 deletions(-)
>
>
> Signed-off-by: arpit.saini@oss.qualcomm.com
> Signed-off-by: mohit.dsor@oss.qualcomm.com
Unnamed people? This is not a valid SoB tag, FWIW.
> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
> ---
> Arpit Saini (3):
> arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
> arm64: defconfig: Enable ILI7807S DSI panel driver
> arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
>
> Mohit Dsor (1):
> arm64: dts: qcom: Shikra LT9611UXD support
>
> Nabige Aala (1):
> arm64: dts: qcom: shikra: Add MDSS display subsystem
Huh? Suddently a different set of authors for the patches. Please clean
up your cover letter.
>
> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 104 ++++++++++++++
> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 104 ++++++++++++++
> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 122 +++++++++++++++++
> arch/arm64/boot/dts/qcom/shikra.dtsi | 203 +++++++++++++++++++++++++++-
> arch/arm64/configs/defconfig | 1 +
> 5 files changed, 532 insertions(+), 2 deletions(-)
> ---
> base-commit: f28fb4ff0d25819c58341fec6e3953f1ebb1fc2e
> change-id: 20260626-shikra-dt-changes-8d127be951d5
>
> Best regards,
> --
> Nabige Aala <nabige.aala@oss.qualcomm.com>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 16+ messages in thread