From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Carsten Otte <cotte@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Shirley Ma <xma@us.ibm.com>,
lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, Krishna Kumar <krkumar2@in.ibm.com>,
Tom Lendacky <tahm@linux.vnet.ibm.com>,
steved@us.ibm.com, habanero@linux.vnet.ibm.com
Subject: [PATCHv2 RFC 0/4] virtio and vhost-net capacity handling
Date: Thu, 2 Jun 2011 18:42:35 +0300 [thread overview]
Message-ID: <cover.1307029008.git.mst@redhat.com> (raw)
OK, here's a new attempt to use the new capacity api. I also added more
comments to clarify the logic. Hope this is more readable. Let me know
pls.
This is on top of the patches applied by Rusty.
Warning: untested. Posting now to give people chance to
comment on the API.
Changes from v1:
- fix comment in patch 2 to correct confusion noted by Rusty
- rewrite patch 3 along the lines suggested by Rusty
note: it's not exactly the same but I hope it's close
enough, the main difference is that mine does limited
polling even in the unlikely xmit failure case.
- added a patch to not return capacity from add_buf
it always looked like a weird hack
Michael S. Tsirkin (4):
virtio_ring: add capacity check API
virtio_net: fix tx capacity checks using new API
virtio_net: limit xmit polling
Revert "virtio: make add_buf return capacity remaining:
drivers/net/virtio_net.c | 111 ++++++++++++++++++++++++++----------------
drivers/virtio/virtio_ring.c | 10 +++-
include/linux/virtio.h | 7 ++-
3 files changed, 84 insertions(+), 44 deletions(-)
--
1.7.5.53.gc233e
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Krishna Kumar <krkumar2-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>,
Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Shirley Ma <xma-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
habanero-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
Heiko Carstens
<heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
steved-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
Christian Borntraeger
<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
Tom Lendacky
<tahm-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Martin Schwidefsky
<schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
linux390-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Subject: [PATCHv2 RFC 0/4] virtio and vhost-net capacity handling
Date: Thu, 2 Jun 2011 18:42:35 +0300 [thread overview]
Message-ID: <cover.1307029008.git.mst@redhat.com> (raw)
OK, here's a new attempt to use the new capacity api. I also added more
comments to clarify the logic. Hope this is more readable. Let me know
pls.
This is on top of the patches applied by Rusty.
Warning: untested. Posting now to give people chance to
comment on the API.
Changes from v1:
- fix comment in patch 2 to correct confusion noted by Rusty
- rewrite patch 3 along the lines suggested by Rusty
note: it's not exactly the same but I hope it's close
enough, the main difference is that mine does limited
polling even in the unlikely xmit failure case.
- added a patch to not return capacity from add_buf
it always looked like a weird hack
Michael S. Tsirkin (4):
virtio_ring: add capacity check API
virtio_net: fix tx capacity checks using new API
virtio_net: limit xmit polling
Revert "virtio: make add_buf return capacity remaining:
drivers/net/virtio_net.c | 111 ++++++++++++++++++++++++++----------------
drivers/virtio/virtio_ring.c | 10 +++-
include/linux/virtio.h | 7 ++-
3 files changed, 84 insertions(+), 44 deletions(-)
--
1.7.5.53.gc233e
next reply other threads:[~2011-06-02 15:43 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 15:42 Michael S. Tsirkin [this message]
2011-06-02 15:42 ` [PATCHv2 RFC 0/4] virtio and vhost-net capacity handling Michael S. Tsirkin
2011-06-02 15:42 ` [PATCHv2 RFC 1/4] virtio_ring: add capacity check API Michael S. Tsirkin
2011-06-02 15:42 ` Michael S. Tsirkin
2011-06-02 15:42 ` Michael S. Tsirkin
2011-06-02 15:43 ` [PATCHv2 RFC 2/4] virtio_net: fix tx capacity checks using new API Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-02 15:43 ` [PATCHv2 RFC 3/4] virtio_net: limit xmit polling Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-02 18:09 ` Sridhar Samudrala
2011-06-02 18:09 ` Sridhar Samudrala
2011-06-02 19:23 ` Michael S. Tsirkin
2011-06-02 19:23 ` Michael S. Tsirkin
2011-06-02 19:23 ` Michael S. Tsirkin
2011-06-07 15:59 ` Michael S. Tsirkin
2011-06-07 15:59 ` Michael S. Tsirkin
2011-06-07 15:59 ` Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-02 15:43 ` [PATCHv2 RFC 4/4] Revert "virtio: make add_buf return capacity remaining: Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-02 15:43 ` Michael S. Tsirkin
2011-06-07 15:54 ` Michael S. Tsirkin
2011-06-07 15:54 ` Michael S. Tsirkin
2011-06-08 0:19 ` Rusty Russell
2011-06-08 0:19 ` Rusty Russell
2011-06-07 15:54 ` Michael S. Tsirkin
2011-06-02 17:17 ` [PATCHv2 RFC 0/4] virtio and vhost-net capacity handling Michael S. Tsirkin
2011-06-02 17:17 ` Michael S. Tsirkin
2011-06-06 3:39 ` Rusty Russell
2011-06-06 3:39 ` Rusty Russell
2011-06-06 3:39 ` Rusty Russell
2011-06-02 17:17 ` Michael S. Tsirkin
2011-06-07 16:08 ` Michael S. Tsirkin
2011-06-07 16:08 ` Michael S. Tsirkin
2011-06-07 16:08 ` Michael S. Tsirkin
2011-06-13 13:32 ` Krishna Kumar2
2011-06-13 13:35 ` Michael S. Tsirkin
2011-06-13 13:35 ` Michael S. Tsirkin
2011-06-13 13:44 ` Krishna Kumar2
2011-06-13 13:44 ` Krishna Kumar2
2011-06-13 13:44 ` Krishna Kumar2
2011-06-13 13:35 ` Michael S. Tsirkin
2011-06-13 13:38 ` Krishna Kumar2
2011-06-13 13:38 ` Krishna Kumar2
2011-06-13 13:38 ` Krishna Kumar2
2011-06-19 8:53 ` Michael S. Tsirkin
2011-06-19 8:53 ` Michael S. Tsirkin
2011-06-19 8:53 ` Michael S. Tsirkin
2011-06-13 13:32 ` Krishna Kumar2
-- strict thread matches above, loose matches on Subject: below --
2011-06-02 15:42 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1307029008.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=habanero@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=steved@us.ibm.com \
--cc=tahm@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.