[PATCH 0/1] siggen.py: fix clean_basepath()

[PATCH 0/1] siggen.py: fix clean_basepath()

[Robert Yang]

The following changes since commit 9f66aa1a11b5b45280aa41bf4517ec56ee5f2ab2:

  bitbake: toaster: start script warning text formatting small improvement (2015-09-23 22:44:56 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib rbt/sig
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/sig

Robert Yang (1):
  siggen.py: fix clean_basepath()

 bitbake/lib/bb/siggen.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.9.5

[PATCH 1/1] siggen.py: fix clean_basepath()

[Robert Yang]

Fixed:
$ bitbake-diffsigs tmp/stamps/x86_64-linux/quilt-native/0.64-r0.do_patch.sigdata.foo tmp/stamps/x86_64-linux/quilt-native/0.64-r0.do_fetch.sigdata.foo
[snip]
runtaskdeps changed from ['quiltquilt-native_0.64.bb.do_unpack'] to []

Note the "quiltquilt-native".

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/siggen.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index 2985272..46fd2fc 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -303,7 +303,7 @@ def dump_this_task(outfile, d):
     bb.parse.siggen.dump_sigtask(fn, task, outfile, "customfile")
 
 def clean_basepath(a):
-    b = a.rsplit("/", 2)[1] + a.rsplit("/", 2)[2]
+    b = a.rsplit("/", 2)[2]
     if a.startswith("virtual:"):
         b = b + ":" + a.rsplit(":", 1)[0]
     return b
-- 
1.7.9.5

Re: [PATCH 0/1] siggen.py: fix clean_basepath()

[Robert Yang]

Hi RP,

I'm not sure what patch causes this problem, this patch can fix it,
but I'm not sure whether it is a correct fix or not.

// Robert

On 09/24/2015 04:20 PM, Robert Yang wrote:
> The following changes since commit 9f66aa1a11b5b45280aa41bf4517ec56ee5f2ab2:
>
>    bitbake: toaster: start script warning text formatting small improvement (2015-09-23 22:44:56 +0100)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib rbt/sig
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/sig
>
> Robert Yang (1):
>    siggen.py: fix clean_basepath()
>
>   bitbake/lib/bb/siggen.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Re: [PATCH 0/1] siggen.py: fix clean_basepath()

[Richard Purdie]

On Thu, 2015-09-24 at 16:23 +0800, Robert Yang wrote:
> Hi RP,
> 
> I'm not sure what patch causes this problem, this patch can fix it,
> but I'm not sure whether it is a correct fix or not.

The code there is quite deliberately adding this in. The issue is around
shared workdir and shared stamps that we had for gcc in particular.
Without this, we used to get stamp mismatches reported for gcc
unpack/fetch/patch tasks.

That said, I think the shared stamps code was a bad idea, we've stopped
using it for gcc now (gcc-source is there instead) and we should
probably remove all remnants of stamp-base from bitbake as it turned out
to be a bad idea.

I'd probably leave fixing this until we do that.

Cheers,

Richard