[PATCH 0/2] Fix various issues

[PATCH 0/2] Fix various issues

[Shivani Bhardwaj]

This patch removes unused code and changes the variable type to more
effective one.
After applying this patch, code becomes better.

Shivani Bhardwaj (2):
  Staging: wilc1000: wilc_wfi_cfgoperations: Remove unused code
  Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

-- 
2.1.0

[PATCH 1/2] Staging: wilc1000: wilc_wfi_cfgoperations: Remove unused code

[Shivani Bhardwaj]

Remove a flag variable which is not used anywhere in the code.
Semantic patch used:

@@
type T;
identifier i;
constant C;
position p != e.p;
@@

- T i@p;
  <+... when != i
- i = C;
  ...+>

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 6472777..d2e6f55 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1764,7 +1764,6 @@ static int del_pmksa(struct wiphy *wiphy, struct net_device *netdev,
 {
 
 	u32 i;
-	u8 flag = 0;
 	s32 s32Error = 0;
 
 	struct wilc_priv *priv = wiphy_priv(wiphy);
@@ -1777,7 +1776,6 @@ static int del_pmksa(struct wiphy *wiphy, struct net_device *netdev,
 			/*If bssid is found, reset the values*/
 			PRINT_D(CFG80211_DBG, "Reseting PMKID values\n");
 			memset(&priv->pmkid_list.pmkidlist[i], 0, sizeof(struct host_if_pmkid));
-			flag = PMKID_FOUND;
 			break;
 		}
 	}
-- 
2.1.0

[PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

[Shivani Bhardwaj]

Change variable of the type u8 to bool as the only values acquired by it
are true or false.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index d2e6f55..e4c134a 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1714,7 +1714,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
 {
 	u32 i;
 	s32 s32Error = 0;
-	u8 flag = 0;
+	bool pmkid_found = false;
 
 	struct wilc_priv *priv = wiphy_priv(wiphy);
 
@@ -1725,7 +1725,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
 		if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid,
 				 ETH_ALEN)) {
 			/*If bssid already exists and pmkid value needs to reset*/
-			flag = PMKID_FOUND;
+			pmkid_found = true;
 			PRINT_D(CFG80211_DBG, "PMKID already exists\n");
 			break;
 		}
@@ -1736,7 +1736,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
 			    ETH_ALEN);
 		memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
 			    PMKID_LEN);
-		if (!(flag == PMKID_FOUND))
+		if (!pmkid_found)
 			priv->pmkid_list.numpmkid++;
 	} else {
 		PRINT_ER("Invalid PMKID index\n");
-- 
2.1.0

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

[Julia Lawall]

On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:

> Change variable of the type u8 to bool as the only values acquired by it
> are true or false.

This looks better, but now I think that PMKID_FOUND is not used anywhere,
so its definition can be removed.

julia

> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index d2e6f55..e4c134a 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1714,7 +1714,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>  {
>  	u32 i;
>  	s32 s32Error = 0;
> -	u8 flag = 0;
> +	bool pmkid_found = false;
>
>  	struct wilc_priv *priv = wiphy_priv(wiphy);
>
> @@ -1725,7 +1725,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>  		if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid,
>  				 ETH_ALEN)) {
>  			/*If bssid already exists and pmkid value needs to reset*/
> -			flag = PMKID_FOUND;
> +			pmkid_found = true;
>  			PRINT_D(CFG80211_DBG, "PMKID already exists\n");
>  			break;
>  		}
> @@ -1736,7 +1736,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>  			    ETH_ALEN);
>  		memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
>  			    PMKID_LEN);
> -		if (!(flag == PMKID_FOUND))
> +		if (!pmkid_found)
>  			priv->pmkid_list.numpmkid++;
>  	} else {
>  		PRINT_ER("Invalid PMKID index\n");
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20f17185a553556d1d6d806811bf068cd727a689.1444733999.git.shivanib134%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

[Shivani Bhardwaj]

On Tue, Oct 13, 2015 at 4:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:
>
>> Change variable of the type u8 to bool as the only values acquired by it
>> are true or false.
>
> This looks better, but now I think that PMKID_FOUND is not used anywhere,
> so its definition can be removed.
>
> julia
>
I've removed that from header, should I send a v3 with header file's
changes included? Or I can send it individually?
Thank you

>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> index d2e6f55..e4c134a 100644
>> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> @@ -1714,7 +1714,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>>  {
>>       u32 i;
>>       s32 s32Error = 0;
>> -     u8 flag = 0;
>> +     bool pmkid_found = false;
>>
>>       struct wilc_priv *priv = wiphy_priv(wiphy);
>>
>> @@ -1725,7 +1725,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>>               if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid,
>>                                ETH_ALEN)) {
>>                       /*If bssid already exists and pmkid value needs to reset*/
>> -                     flag = PMKID_FOUND;
>> +                     pmkid_found = true;
>>                       PRINT_D(CFG80211_DBG, "PMKID already exists\n");
>>                       break;
>>               }
>> @@ -1736,7 +1736,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>>                           ETH_ALEN);
>>               memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
>>                           PMKID_LEN);
>> -             if (!(flag == PMKID_FOUND))
>> +             if (!pmkid_found)
>>                       priv->pmkid_list.numpmkid++;
>>       } else {
>>               PRINT_ER("Invalid PMKID index\n");
>> --
>> 2.1.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20f17185a553556d1d6d806811bf068cd727a689.1444733999.git.shivanib134%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

[Julia Lawall]

On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:

> On Tue, Oct 13, 2015 at 4:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:
> >
> >> Change variable of the type u8 to bool as the only values acquired by it
> >> are true or false.
> >
> > This looks better, but now I think that PMKID_FOUND is not used anywhere,
> > so its definition can be removed.
> >
> > julia
> >
> I've removed that from header, should I send a v3 with header file's
> changes included? Or I can send it individually?

Removing that from the header is only valid if these other changes are
done, so to ensure the patches get applied in the right order, it could be
better to send a v3, with that being the third patch.

julia

> Thank you
>
> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >> ---
> >>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> >> index d2e6f55..e4c134a 100644
> >> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> >> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> >> @@ -1714,7 +1714,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
> >>  {
> >>       u32 i;
> >>       s32 s32Error = 0;
> >> -     u8 flag = 0;
> >> +     bool pmkid_found = false;
> >>
> >>       struct wilc_priv *priv = wiphy_priv(wiphy);
> >>
> >> @@ -1725,7 +1725,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
> >>               if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid,
> >>                                ETH_ALEN)) {
> >>                       /*If bssid already exists and pmkid value needs to reset*/
> >> -                     flag = PMKID_FOUND;
> >> +                     pmkid_found = true;
> >>                       PRINT_D(CFG80211_DBG, "PMKID already exists\n");
> >>                       break;
> >>               }
> >> @@ -1736,7 +1736,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
> >>                           ETH_ALEN);
> >>               memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
> >>                           PMKID_LEN);
> >> -             if (!(flag == PMKID_FOUND))
> >> +             if (!pmkid_found)
> >>                       priv->pmkid_list.numpmkid++;
> >>       } else {
> >>               PRINT_ER("Invalid PMKID index\n");
> >> --
> >> 2.1.0
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20f17185a553556d1d6d806811bf068cd727a689.1444733999.git.shivanib134%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQFMF%3DdEO2%3D1fZD%2Bg6HiwV9xfAqjSe8AD21AsOF6P5sbqA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool

[Shivani Bhardwaj]

On Tue, Oct 13, 2015 at 6:18 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:
>
>> On Tue, Oct 13, 2015 at 4:50 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> > On Tue, 13 Oct 2015, Shivani Bhardwaj wrote:
>> >
>> >> Change variable of the type u8 to bool as the only values acquired by it
>> >> are true or false.
>> >
>> > This looks better, but now I think that PMKID_FOUND is not used anywhere,
>> > so its definition can be removed.
>> >
>> > julia
>> >
>> I've removed that from header, should I send a v3 with header file's
>> changes included? Or I can send it individually?
>
> Removing that from the header is only valid if these other changes are
> done, so to ensure the patches get applied in the right order, it could be
> better to send a v3, with that being the third patch.
>
> julia
>

OK. Thank you! I'm sending new version.

>> Thank you
>>
>> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> >> ---
>> >>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
>> >>  1 file changed, 3 insertions(+), 3 deletions(-)
>> >>
>> >> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> >> index d2e6f55..e4c134a 100644
>> >> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> >> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
>> >> @@ -1714,7 +1714,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>> >>  {
>> >>       u32 i;
>> >>       s32 s32Error = 0;
>> >> -     u8 flag = 0;
>> >> +     bool pmkid_found = false;
>> >>
>> >>       struct wilc_priv *priv = wiphy_priv(wiphy);
>> >>
>> >> @@ -1725,7 +1725,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>> >>               if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid,
>> >>                                ETH_ALEN)) {
>> >>                       /*If bssid already exists and pmkid value needs to reset*/
>> >> -                     flag = PMKID_FOUND;
>> >> +                     pmkid_found = true;
>> >>                       PRINT_D(CFG80211_DBG, "PMKID already exists\n");
>> >>                       break;
>> >>               }
>> >> @@ -1736,7 +1736,7 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev,
>> >>                           ETH_ALEN);
>> >>               memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
>> >>                           PMKID_LEN);
>> >> -             if (!(flag == PMKID_FOUND))
>> >> +             if (!pmkid_found)
>> >>                       priv->pmkid_list.numpmkid++;
>> >>       } else {
>> >>               PRINT_ER("Invalid PMKID index\n");
>> >> --
>> >> 2.1.0
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20f17185a553556d1d6d806811bf068cd727a689.1444733999.git.shivanib134%40gmail.com.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQFMF%3DdEO2%3D1fZD%2Bg6HiwV9xfAqjSe8AD21AsOF6P5sbqA%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH 0/2] Fix various issues

[Greg KH]

On Tue, Oct 13, 2015 at 04:33:56PM +0530, Shivani Bhardwaj wrote:
> This patch removes unused code and changes the variable type to more
> effective one.
> After applying this patch, code becomes better.

Ok, not to pick on just this patch, but everyone's 0/X emails need a bit
more work please.

First off, they need 'staging' in them, and then need to be a bit more
descriptive as to what the patch series does (hint, this one is really
vague.)

Don't worry about this one, I'll take it, but in the future, if
_everyone_ could work on their 0/X emails, I would greatly appreciate
it.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH 0/2] Fix various issues

[Shivani Bhardwaj]

On Tue, Oct 13, 2015 at 7:54 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Oct 13, 2015 at 04:33:56PM +0530, Shivani Bhardwaj wrote:
>> This patch removes unused code and changes the variable type to more
>> effective one.
>> After applying this patch, code becomes better.
>
> Ok, not to pick on just this patch, but everyone's 0/X emails need a bit
> more work please.
>
> First off, they need 'staging' in them, and then need to be a bit more
> descriptive as to what the patch series does (hint, this one is really
> vague.)
>
> Don't worry about this one, I'll take it, but in the future, if
> _everyone_ could work on their 0/X emails, I would greatly appreciate
> it.
>
> thanks,
>
> greg k-h

I'll take care. Thanks, Greg.