* [PULL] *** Fix build issue with html5lib in bitbake *** @ 2018-03-27 21:15 ` Soemoe Aung 0 siblings, 0 replies; 11+ messages in thread From: Soemoe Aung @ 2018-03-26 20:51 UTC (permalink / raw) To: poky This fixes a build issue where bitbake won't run because of an issue with one of the libraries it depends on. The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) are available in the Git repository at: git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib Soemoe Aung (2): fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 2.17.0.rc0.231.g781580f067-goog ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** @ 2018-03-27 21:15 ` Soemoe Aung 0 siblings, 0 replies; 11+ messages in thread From: Soemoe Aung @ 2018-03-27 21:15 UTC (permalink / raw) To: bitbake-devel When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there. yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo. I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches? Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky. The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) are available in the Git repository at: git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib Soemoe Aung (2): fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 2.17.0.rc0.231.g781580f067-goog ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake *** 2018-03-27 21:15 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Soemoe Aung (?) @ 2018-03-26 20:55 ` Burton, Ross 2018-03-26 21:00 ` Soemoe Aung 2018-03-26 21:02 ` Ruica Cristina -1 siblings, 2 replies; 11+ messages in thread From: Burton, Ross @ 2018-03-26 20:55 UTC (permalink / raw) To: Soemoe Aung; +Cc: Poky Project What branch is this meant to be applied to? Also, as it's a bitbake change, this should go to the bitbake list. On 26 March 2018 at 21:51, Soemoe Aung <soemoe.a@gmail.com> wrote: > This fixes a build issue where bitbake won't run because of an issue with one of the libraries it depends on. > > The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: > > bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) > > are available in the Git repository at: > > git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib > > Soemoe Aung (2): > fix build error in included html5lib in bitbake > fix html5lib fix to be the same as in the krogoth branch > > bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > -- > 2.17.0.rc0.231.g781580f067-goog > > -- > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake *** 2018-03-26 20:55 ` [PULL] *** Fix build issue with html5lib in bitbake *** Burton, Ross @ 2018-03-26 21:00 ` Soemoe Aung 2018-03-27 9:28 ` Burton, Ross 2018-03-26 21:02 ` Ruica Cristina 1 sibling, 1 reply; 11+ messages in thread From: Soemoe Aung @ 2018-03-26 21:00 UTC (permalink / raw) To: Burton, Ross; +Cc: Poky Project [-- Attachment #1: Type: text/plain, Size: 1841 bytes --] Sorry if it wasn't clear. This is meant for fido (and also jethro). The context is that when doing a fresh checkout of yocto-poky for branches fido or jethro, I wasn't able to build with bitbake because of an error in one of its included libraries. This issue seems to be resolved starting in the krogoth branch. If I send this change to the bitbake list, would it also get applied to the yocto-poky repo in the fido and jethro branches? Also, apologies for the duplicate. I didn't see my message at https://lists.yoctoproject.org/pipermail/poky/2018-March/date.html so wasn't sure if it actually went through. On Mon, Mar 26, 2018 at 1:55 PM, Burton, Ross <ross.burton@intel.com> wrote: > What branch is this meant to be applied to? > > Also, as it's a bitbake change, this should go to the bitbake list. > > On 26 March 2018 at 21:51, Soemoe Aung <soemoe.a@gmail.com> wrote: > > This fixes a build issue where bitbake won't run because of an issue > with one of the libraries it depends on. > > > > The following changes since commit ea6d21066a7cce2fef08ad66287170 > c5995bb1e2: > > > > bitbake: bitbake-user-manual: Fixed porno hack for hello world example > (2018-01-17 22:32:46 +0000) > > > > are available in the Git repository at: > > > > git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib > > > > Soemoe Aung (2): > > fix build error in included html5lib in bitbake > > fix html5lib fix to be the same as in the krogoth branch > > > > bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > -- > > 2.17.0.rc0.231.g781580f067-goog > > > > -- > > _______________________________________________ > > poky mailing list > > poky@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/poky > [-- Attachment #2: Type: text/html, Size: 2815 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake *** 2018-03-26 21:00 ` Soemoe Aung @ 2018-03-27 9:28 ` Burton, Ross 2018-03-30 15:49 ` Soemoe Aung 0 siblings, 1 reply; 11+ messages in thread From: Burton, Ross @ 2018-03-27 9:28 UTC (permalink / raw) To: Soemoe Aung; +Cc: Poky Project On 26 March 2018 at 22:00, Soemoe Aung <soemoe.a@gmail.com> wrote: > Sorry if it wasn't clear. This is meant for fido (and also jethro). The > context is that when doing a fresh checkout of yocto-poky for branches fido > or jethro, I wasn't able to build with bitbake because of an error in one of > its included libraries. This issue seems to be resolved starting in the > krogoth branch. > > If I send this change to the bitbake list, would it also get applied to the > yocto-poky repo in the fido and jethro branches? Yes, send it to bitbake@ and the maintainer will ensure that it bubbles through to the Poky repos. Ross ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake *** 2018-03-27 9:28 ` Burton, Ross @ 2018-03-30 15:49 ` Soemoe Aung 0 siblings, 0 replies; 11+ messages in thread From: Soemoe Aung @ 2018-03-30 15:49 UTC (permalink / raw) To: Burton, Ross; +Cc: Poky Project [-- Attachment #1: Type: text/plain, Size: 1301 bytes --] Just closing the loop here. I reached out about this to the bitbake list and someone backported the original commit for newer versions of bitbake back to the versions used in yocto-poky fido <http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=fido&id=87631919819b6f85f23f57689cd1065c64d7fb03> and jethro <http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=jethro&id=331275422b2c3f326f605c23ae89eedb4e222eb5>. I did fresh checkouts of both these branches of poky and I can get past these build errors out of the box now. On Tue, Mar 27, 2018 at 2:28 AM, Burton, Ross <ross.burton@intel.com> wrote: > On 26 March 2018 at 22:00, Soemoe Aung <soemoe.a@gmail.com> wrote: > > Sorry if it wasn't clear. This is meant for fido (and also jethro). The > > context is that when doing a fresh checkout of yocto-poky for branches > fido > > or jethro, I wasn't able to build with bitbake because of an error in > one of > > its included libraries. This issue seems to be resolved starting in the > > krogoth branch. > > > > If I send this change to the bitbake list, would it also get applied to > the > > yocto-poky repo in the fido and jethro branches? > > Yes, send it to bitbake@ and the maintainer will ensure that it > bubbles through to the Poky repos. > > Ross > [-- Attachment #2: Type: text/html, Size: 1793 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake *** 2018-03-26 20:55 ` [PULL] *** Fix build issue with html5lib in bitbake *** Burton, Ross 2018-03-26 21:00 ` Soemoe Aung @ 2018-03-26 21:02 ` Ruica Cristina 1 sibling, 0 replies; 11+ messages in thread From: Ruica Cristina @ 2018-03-26 21:02 UTC (permalink / raw) To: Soemoe Aung, Burton, Ross; +Cc: Poky Project [-- Attachment #1: Type: text/plain, Size: 1486 bytes --] rocko..i tried to edit local.conf file and add package_Classes ?="package ipk"and it won't let me bitbake..i m kind of new in this and i don t know how to manage it.. On Monday, March 26, 2018, 11:56:22 PM GMT+3, Burton, Ross <ross.burton@intel.com> wrote: What branch is this meant to be applied to? Also, as it's a bitbake change, this should go to the bitbake list. On 26 March 2018 at 21:51, Soemoe Aung <soemoe.a@gmail.com> wrote: > This fixes a build issue where bitbake won't run because of an issue with one of the libraries it depends on. > > The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: > > bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) > > are available in the Git repository at: > > git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib > > Soemoe Aung (2): > fix build error in included html5lib in bitbake > fix html5lib fix to be the same as in the krogoth branch > > bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > -- > 2.17.0.rc0.231.g781580f067-goog > > -- > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky -- _______________________________________________ poky mailing list poky@yoctoproject.org https://lists.yoctoproject.org/listinfo/poky [-- Attachment #2: Type: text/html, Size: 3336 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** 2018-03-27 21:15 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Soemoe Aung (?) (?) @ 2018-03-28 9:41 ` Ola x Nilsson 2018-03-28 16:47 ` Soemoe Aung -1 siblings, 1 reply; 11+ messages in thread From: Ola x Nilsson @ 2018-03-28 9:41 UTC (permalink / raw) To: bitbake-devel@lists.openembedded.org This has already been fixed on a few branches with bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8 It might be better to backport that where needed. -- Ola Nilsson ________________________________________ From: bitbake-devel-bounces@lists.openembedded.org <bitbake-devel-bounces@lists.openembedded.org> on behalf of Soemoe Aung <soemoe.a@gmail.com> Sent: Tuesday, March 27, 2018 23:15 To: bitbake-devel@lists.openembedded.org Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there. yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo. I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches? Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky. The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) are available in the Git repository at: git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib Soemoe Aung (2): fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 2.17.0.rc0.231.g781580f067-goog -- _______________________________________________ bitbake-devel mailing list bitbake-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/bitbake-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** 2018-03-28 9:41 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Ola x Nilsson @ 2018-03-28 16:47 ` Soemoe Aung 2018-03-29 17:43 ` Peter Kjellerstedt 0 siblings, 1 reply; 11+ messages in thread From: Soemoe Aung @ 2018-03-28 16:47 UTC (permalink / raw) To: Ola x Nilsson; +Cc: bitbake-devel@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 3228 bytes --] Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as well. My change literally took the html5lib file from 1.30 and copied it to the file in 1.26 and submitted it as a patch. Apologies if this was the wrong way to go about this. What are the steps to backport this change to 1.26 and 1.28 (and also to send these changes upstream to yocto-poky)? Is there anything I need to do? On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <ola.x.nilsson@axis.com> wrote: > This has already been fixed on a few branches with > > bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8 > > It might be better to backport that where needed. > > -- > Ola Nilsson > ________________________________________ > From: bitbake-devel-bounces@lists.openembedded.org < > bitbake-devel-bounces@lists.openembedded.org> on behalf of Soemoe Aung < > soemoe.a@gmail.com> > Sent: Tuesday, March 27, 2018 23:15 > To: bitbake-devel@lists.openembedded.org > Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in > bitbake 1.26/1.28 *** > > When I was running yocto-poky on the fido and jethro branches, I was > getting build errors caused by the included html5lib in bitbake. It seems > like a class is being called incorrectly there. I noticed the issue is > resolved in the krogoth branch and the html5lib is indeed different there. > > yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake > version 1.28. Looking at the bitbake source repo for these versions > confirms that these files are the same. yocto-poky krogoth, which has the > issue fixed, uses bitbake 1.30, which also has the issue fixed in the > bitbake repo. > > I originally created this patch in the yocto-poky contrib repo and was > directed to send it to bitbake instead. Can someone here take a look at > this and accept the changes into the 1.26 and 1.28 branches? Can you also > send these changes upstream to the yocto-poky fido and jethro branches? > > Let me know if you need any changes here, like creating this patch from > the bitbake repo directly instead of indirectly through yocto-poky. > > The following changes since commit ea6d21066a7cce2fef08ad66287170 > c5995bb1e2: > > bitbake: bitbake-user-manual: Fixed porno hack for hello world example > (2018-01-17 22:32:46 +0000) > > are available in the Git repository at: > > git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib > > Soemoe Aung (2): > fix build error in included html5lib in bitbake > fix html5lib fix to be the same as in the krogoth branch > > bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > -- > 2.17.0.rc0.231.g781580f067-goog > > -- > _______________________________________________ > bitbake-devel mailing list > bitbake-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/bitbake-devel > -- > _______________________________________________ > bitbake-devel mailing list > bitbake-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/bitbake-devel > [-- Attachment #2: Type: text/html, Size: 4444 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** 2018-03-28 16:47 ` Soemoe Aung @ 2018-03-29 17:43 ` Peter Kjellerstedt 2018-03-30 15:46 ` Soemoe Aung 0 siblings, 1 reply; 11+ messages in thread From: Peter Kjellerstedt @ 2018-03-29 17:43 UTC (permalink / raw) To: Soemoe Aung, Ola x Nilsson; +Cc: bitbake-devel@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 4181 bytes --] One way to create and send the patch is: git cherry-pick 1679188f9c55c615cae780f2b5e6852dea9cf2ec # Assuming you are in the bitbake repository, not poky git commit --amend # To add your Signed-off-by footer git format-patch --subject-prefix='jethro][PATCH' 'HEAD^..HEAD' git send-email --to=openembedded-core@lists.openembedded.org --confirm=always --no-chain-reply-to --suppress-cc=all 000* //Peter From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Soemoe Aung Sent: den 28 mars 2018 18:47 To: Ola x Nilsson <Ola.x.Nilsson@axis.com> Cc: bitbake-devel@lists.openembedded.org Subject: Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as well. My change literally took the html5lib file from 1.30 and copied it to the file in 1.26 and submitted it as a patch. Apologies if this was the wrong way to go about this. What are the steps to backport this change to 1.26 and 1.28 (and also to send these changes upstream to yocto-poky)? Is there anything I need to do? On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <ola.x.nilsson@axis.com<mailto:ola.x.nilsson@axis.com>> wrote: This has already been fixed on a few branches with bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8 It might be better to backport that where needed. -- Ola Nilsson ________________________________________ From: bitbake-devel-bounces@lists.openembedded.org<mailto:bitbake-devel-bounces@lists.openembedded.org> <bitbake-devel-bounces@lists.openembedded.org<mailto:bitbake-devel-bounces@lists.openembedded.org>> on behalf of Soemoe Aung <soemoe.a@gmail.com<mailto:soemoe.a@gmail.com>> Sent: Tuesday, March 27, 2018 23:15 To: bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org> Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there. yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo. I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches? Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky. The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2: bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000) are available in the Git repository at: git://push.yoctoproject.org/poky-contrib<http://push.yoctoproject.org/poky-contrib> saung/bitbake-html5lib Soemoe Aung (2): fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 2.17.0.rc0.231.g781580f067-goog -- _______________________________________________ bitbake-devel mailing list bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org> http://lists.openembedded.org/mailman/listinfo/bitbake-devel -- _______________________________________________ bitbake-devel mailing list bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org> http://lists.openembedded.org/mailman/listinfo/bitbake-devel [-- Attachment #2: Type: text/html, Size: 9176 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** 2018-03-29 17:43 ` Peter Kjellerstedt @ 2018-03-30 15:46 ` Soemoe Aung 0 siblings, 0 replies; 11+ messages in thread From: Soemoe Aung @ 2018-03-30 15:46 UTC (permalink / raw) To: Peter Kjellerstedt; +Cc: bitbake-devel@lists.openembedded.org, Ola x Nilsson [-- Attachment #1: Type: text/plain, Size: 4817 bytes --] Just saw that Richard Purdie backported Daniel Lublin's original commit to 1.26 and 1.28 (edd90cd858da5da564e9849ebc0849a8a8173d4f <http://git.openembedded.org/bitbake/commit/?h=1.26&id=edd90cd858da5da564e9849ebc0849a8a8173d4f> and 0d80cacb2b84ee059cee3caf8a5968033b9ce3c5 <http://git.openembedded.org/bitbake/commit/?h=1.28&id=0d80cacb2b84ee059cee3caf8a5968033b9ce3c5>). I noticed it was pushed upstream to yocto-poky fido and jethro as well. I did a fresh checkout of yocto-poky fido and jethro and got both to build past that error out of the box. Thanks to Richard and Daniel and everyone else! On Thu, Mar 29, 2018 at 10:43 AM, Peter Kjellerstedt < peter.kjellerstedt@axis.com> wrote: > One way to create and send the patch is: > > > > git cherry-pick 1679188f9c55c615cae780f2b5e6852dea9cf2ec # Assuming you > are in the bitbake repository, not poky > > git commit --amend # To add your Signed-off-by footer > > git format-patch --subject-prefix='jethro][PATCH' 'HEAD^..HEAD' > > git send-email --to=openembedded-core@lists.openembedded.org > --confirm=always --no-chain-reply-to --suppress-cc=all 000* > > > > //Peter > > > > *From:* bitbake-devel-bounces@lists.openembedded.org [mailto: > bitbake-devel-bounces@lists.openembedded.org] *On Behalf Of *Soemoe Aung > *Sent:* den 28 mars 2018 18:47 > *To:* Ola x Nilsson <Ola.x.Nilsson@axis.com> > *Cc:* bitbake-devel@lists.openembedded.org > *Subject:* Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib > in bitbake 1.26/1.28 *** > > > > Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. > That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as > well. My change literally took the html5lib file from 1.30 and copied it to > the file in 1.26 and submitted it as a patch. Apologies if this was the > wrong way to go about this. > > > > What are the steps to backport this change to 1.26 and 1.28 (and also to > send these changes upstream to yocto-poky)? Is there anything I need to do? > > > > On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <ola.x.nilsson@axis.com> > wrote: > > This has already been fixed on a few branches with > > bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8 > > It might be better to backport that where needed. > > -- > Ola Nilsson > ________________________________________ > From: bitbake-devel-bounces@lists.openembedded.org < > bitbake-devel-bounces@lists.openembedded.org> on behalf of Soemoe Aung < > soemoe.a@gmail.com> > Sent: Tuesday, March 27, 2018 23:15 > To: bitbake-devel@lists.openembedded.org > Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in > bitbake 1.26/1.28 *** > > > When I was running yocto-poky on the fido and jethro branches, I was > getting build errors caused by the included html5lib in bitbake. It seems > like a class is being called incorrectly there. I noticed the issue is > resolved in the krogoth branch and the html5lib is indeed different there. > > yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake > version 1.28. Looking at the bitbake source repo for these versions > confirms that these files are the same. yocto-poky krogoth, which has the > issue fixed, uses bitbake 1.30, which also has the issue fixed in the > bitbake repo. > > I originally created this patch in the yocto-poky contrib repo and was > directed to send it to bitbake instead. Can someone here take a look at > this and accept the changes into the 1.26 and 1.28 branches? Can you also > send these changes upstream to the yocto-poky fido and jethro branches? > > Let me know if you need any changes here, like creating this patch from > the bitbake repo directly instead of indirectly through yocto-poky. > > The following changes since commit ea6d21066a7cce2fef08ad66287170 > c5995bb1e2: > > bitbake: bitbake-user-manual: Fixed porno hack for hello world example > (2018-01-17 22:32:46 +0000) > > are available in the Git repository at: > > git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib > > Soemoe Aung (2): > fix build error in included html5lib in bitbake > fix html5lib fix to be the same as in the krogoth branch > > bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > -- > 2.17.0.rc0.231.g781580f067-goog > > -- > _______________________________________________ > bitbake-devel mailing list > bitbake-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/bitbake-devel > -- > _______________________________________________ > bitbake-devel mailing list > bitbake-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/bitbake-devel > > > [-- Attachment #2: Type: text/html, Size: 8770 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-03-30 15:50 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-26 20:51 [PULL] *** Fix build issue with html5lib in bitbake *** Soemoe Aung 2018-03-27 21:15 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Soemoe Aung 2018-03-26 20:55 ` [PULL] *** Fix build issue with html5lib in bitbake *** Burton, Ross 2018-03-26 21:00 ` Soemoe Aung 2018-03-27 9:28 ` Burton, Ross 2018-03-30 15:49 ` Soemoe Aung 2018-03-26 21:02 ` Ruica Cristina 2018-03-28 9:41 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Ola x Nilsson 2018-03-28 16:47 ` Soemoe Aung 2018-03-29 17:43 ` Peter Kjellerstedt 2018-03-30 15:46 ` Soemoe Aung
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.